Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnOff cluster featuremap #15618

Merged
merged 3 commits into from
Mar 1, 2022
Merged

OnOff cluster featuremap #15618

merged 3 commits into from
Mar 1, 2022

Conversation

jmartinez-silabs
Copy link
Member

Problem

Fixes #15534
Fixes #15406

Change overview

Change OnOff cluster featuremap to 1 for all-cluster-app and lighting app
Gate some OnOff commands and behaviour depending of the feature map value
Set Level control OnLevel attribute default value to 0xFF (Null) [project-chip/zap/issues/354]

*commits can be reviewed separately regen is the last commit

Testing

Test suites and manual testing on efr32 +chip-tool

@github-actions
Copy link

github-actions bot commented Feb 27, 2022 •
edited
Loading

PR #15618: Size comparison from 2aab9b8 to f363a4a

Increases (23 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2aab9b86 f363a4a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599542 599686 144 0.0
.app_xip_area 504388 504532 144 0.0
lock cyw930739m2evb_01 (read/write) 557614 557710 96 0.0
.app_xip_area 463996 464092 96 0.0
efr32 lighting-app BRD4161A (read only) 916516 916676 160 0.0
.text 916508 916668 160 0.0
BRD4161A+rpc (read only) 946604 946764 160 0.0
.text 946596 946756 160 0.0
lock-app BRD4161A+wf200 (read only) 986436 986548 112 0.0
.text 986428 986540 112 0.0
esp32 all-clusters-app c3devkit (read only) 956534 956698 164 0.0
.flash.text 956534 956698 164 0.0
m5stack (read only) 1004671 1004803 132 0.0
.flash.text 999287 999419 132 0.0
k32w lock k32w061+release (read/write) 695176 695272 96 0.0
.text 609724 609820 96 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350140 2350204 64 0.0
.text 1312740 1312804 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038907 1039067 160 0.0
text 700036 700192 156 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1002119 1002279 160 0.0
text 686416 686564 148 0.0
nrf52840dk_nrf52840+rpc (read/write) 968447 968591 144 0.0
text 663644 663788 144 0.0
nrf52840dongle_nrf52840 (read/write) 1018207 1018351 144 0.0
text 691124 691268 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904946 905090 144 0.0
text 596128 596276 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 931223 931319 96 0.0
text 628904 629000 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834846 834942 96 0.0
text 539380 539476 96 0.0
pump-app nrf52840dk_nrf52840 (read/write) 929467 929579 112 0.0
text 628332 628432 100 0.0
p6 all-clusters-app default (read/write) 2488104 2488264 160 0.0
.text 1446368 1446528 160 0.0
light-app default (read/write) 2395304 2395464 160 0.0
.text 1353568 1353728 160 0.0
lock-app default (read/write) 2358880 2358992 112 0.0
.text 1317144 1317256 112 0.0
qpg lighting-app qpg6105+debug (read only) 601168 601312 144 0.0
.text 595848 595992 144 0.0
lock-app qpg6105+debug (read only) 566964 567060 96 0.0
.text 561644 561740 96 0.0
telink lighting-app tlsr9518adk80d (read/write) 883086 883246 160 0.0
text 623942 624106 164 0.0
Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2aab9b86 f363a4a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599542 599686 144 0.0
.app_xip_area 504388 504532 144 0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557614 557710 96 0.0
.app_xip_area 463996 464092 96 0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578138 578138 0 0.0
.app_xip_area 475088 475088 0 0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916516 916676 160 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916508 916668 160 0.0
BRD4161A+rpc (read only) 946604 946764 160 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946596 946756 160 0.0
lock-app BRD4161A+wf200 (read only) 986436 986548 112 0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986428 986540 112 0.0
window-app BRD4161A (read only) 850596 850596 0 0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850588 850588 0 0.0
esp32 all-clusters-app c3devkit (read only) 956534 956698 164 0.0
(read/write) 1392986 1392986 0 0.0
.dram0.bss 62592 62592 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197248 197248 0 0.0
.flash.text 956534 956698 164 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1004671 1004803 132 0.0
(read/write) 458264 458264 0 0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999287 999419 132 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691904 691904 0 0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606700 606700 0 0.0
lock k32w061+release (read/write) 695176 695272 96 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609724 609820 96 0.0
linux chip-tool-ipv6only arm64 (read only) 8757372 8757372 0 0.0
(read/write) 412049 412049 0 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296840 296840 0 0.0
.dynamic 560 560 0 0.0
.got 51512 51512 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456996 456996 0 0.0
.text 7435092 7435092 0 0.0
thermostat-no-ble arm64 (read only) 2162916 2162916 0 0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1811648 1811648 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350140 2350204 64 0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312740 1312804 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038907 1039067 160 0.0
bss 125756 125756 0 0.0
rodata 135900 135900 0 0.0
text 700036 700192 156 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1002119 1002279 160 0.0
bss 122064 122064 0 0.0
rodata 116144 116144 0 0.0
text 686416 686564 148 0.0
nrf52840dk_nrf52840+rpc (read/write) 968447 968591 144 0.0
bss 119148 119148 0 0.0
rodata 107520 107520 0 0.0
text 663644 663788 144 0.0
nrf52840dongle_nrf52840 (read/write) 1018207 1018351 144 0.0
bss 123112 123112 0 0.0
rodata 115828 115828 0 0.0
text 691124 691268 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904946 905090 144 0.0
bss 119352 119352 0 0.0
rodata 108256 108256 0 0.0
text 596128 596276 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 931223 931319 96 0.0
bss 120280 120280 0 0.0
rodata 104976 104976 0 0.0
text 628904 629000 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834846 834942 96 0.0
bss 117600 117600 0 0.0
rodata 97004 97004 0 0.0
text 539380 539476 96 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 501603 501603 0 0.0
bss 52584 52584 0 0.0
rodata 44500 44500 0 0.0
text 342712 342712 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 929467 929579 112 0.0
bss 120012 120012 0 0.0
rodata 103956 103956 0 0.0
text 628332 628432 100 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 925443 925443 0 0.0
bss 120016 120016 0 0.0
rodata 103652 103652 0 0.0
text 624588 624588 0 0.0
shell nrf52840dk_nrf52840 (read/write) 788811 788811 0 0.0
bss 112360 112360 0 0.0
rodata 74836 74836 0 0.0
text 525504 525504 0 0.0
p6 all-clusters-app default (read/write) 2488104 2488264 160 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446368 1446528 160 0.0
light-app default (read/write) 2395304 2395464 160 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353568 1353728 160 0.0
lock-app default (read/write) 2358880 2358992 112 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317144 1317256 112 0.0
qpg lighting-app qpg6105+debug (read only) 601168 601312 144 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595848 595992 144 0.0
lock-app qpg6105+debug (read only) 566964 567060 96 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561644 561740 96 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883086 883246 160 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623942 624106 164 0.0

@andy31415 andy31415 merged commit 18ab5f4 into project-chip:master Mar 1, 2022
@jmartinez-silabs jmartinez-silabs deleted the onoff_featuremap branch March 7, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
3 participants
@jmartinez-silabs @andy31415 @bzbarsky-apple