-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GN examples workflow not saving the outputs #1559
Fix GN examples workflow not saving the outputs #1559
Conversation
- name: Uploading Binaries | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: ${{ env.BUILD_TYPE }}-example-build-${{ steps.outsuffix.outputs.value }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The binary upload names will be used for bloat check. Could we make the BUILD_TYPE be something like 'gn_nrf' and such so that bloat check compares the right versions?
Alternatively we can remove the uploading of binaries from the autotools build. The binary upload is for bloat purpose only anyway. If we go this latter path, there will be a time where gn builds will be bloat checked against the autotools versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to gn_nrf and gn_linux.
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
* Fix GN examples workflow not saving the outputs * Change BUILD_TYPE for gn examples
* Fix GN examples workflow not saving the outputs * Change BUILD_TYPE for gn examples
* Fix GN examples workflow not saving the outputs * Change BUILD_TYPE for gn examples
* Fix GN examples workflow not saving the outputs * Change BUILD_TYPE for gn examples
* Fix GN examples workflow not saving the outputs * Change BUILD_TYPE for gn examples
Merge in WMN_TOOLS/matter from bugfix/fix_for_build_warnings to RC_2.3.0-1.3 Squashed commit of the following: commit 425eb2d2b304d3f1d6acfa86b3c7bf9a5dede95f Author: Arun Padakanti <[email protected]> Date: Fri Feb 9 11:49:24 2024 +0530 Fixed build warnings.
Merge in WMN_TOOLS/matter from bugfix/fix_for_build_warnings to RC_2.3.0-1.3 Squashed commit of the following: commit 425eb2d2b304d3f1d6acfa86b3c7bf9a5dede95f Author: Arun Padakanti <[email protected]> Date: Fri Feb 9 11:49:24 2024 +0530 Fixed build warnings.
Fix GN examples workflow not uploading artifacts.