Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GN examples workflow not saving the outputs #1559

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jul 10, 2020

Fix GN examples workflow not uploading artifacts.

- name: Uploading Binaries
uses: actions/upload-artifact@v2
with:
name: ${{ env.BUILD_TYPE }}-example-build-${{ steps.outsuffix.outputs.value }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary upload names will be used for bloat check. Could we make the BUILD_TYPE be something like 'gn_nrf' and such so that bloat check compares the right versions?

Alternatively we can remove the uploading of binaries from the autotools build. The binary upload is for bloat purpose only anyway. If we go this latter path, there will be a time where gn builds will be bloat checked against the autotools versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to gn_nrf and gn_linux.

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


@woody-apple woody-apple merged commit 21f9d09 into project-chip:master Jul 10, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
* Fix GN examples workflow not saving the outputs

* Change BUILD_TYPE for gn examples
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
* Fix GN examples workflow not saving the outputs

* Change BUILD_TYPE for gn examples
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
* Fix GN examples workflow not saving the outputs

* Change BUILD_TYPE for gn examples
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
* Fix GN examples workflow not saving the outputs

* Change BUILD_TYPE for gn examples
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
* Fix GN examples workflow not saving the outputs

* Change BUILD_TYPE for gn examples
@mspang mspang deleted the for-chip/output-binaries branch August 14, 2020 20:17
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Feb 15, 2024
Merge in WMN_TOOLS/matter from bugfix/fix_for_build_warnings to RC_2.3.0-1.3

Squashed commit of the following:

commit 425eb2d2b304d3f1d6acfa86b3c7bf9a5dede95f
Author: Arun Padakanti <[email protected]>
Date:   Fri Feb 9 11:49:24 2024 +0530

    Fixed build warnings.
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
Merge in WMN_TOOLS/matter from bugfix/fix_for_build_warnings to RC_2.3.0-1.3

Squashed commit of the following:

commit 425eb2d2b304d3f1d6acfa86b3c7bf9a5dede95f
Author: Arun Padakanti <[email protected]>
Date:   Fri Feb 9 11:49:24 2024 +0530

    Fixed build warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants