-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Rely on the readclient/writeclient/commandsender onDone c… #15571
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_WaitOnDoneForExiting
Feb 25, 2022
Merged
[chip-tool] Rely on the readclient/writeclient/commandsender onDone c… #15571
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_WaitOnDoneForExiting
Feb 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt and
harsha-rajendran
February 25, 2022 13:02
pullapprove
bot
requested review from
vijs,
lazarkov,
wbschiller,
woody-apple,
LuDuda,
xylophone21,
lzgrablic02,
yunhanw-google,
mlepage-google,
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
February 25, 2022 13:02
…allback to be called for returning any errors
vivien-apple
force-pushed
the
ChipTool_WaitOnDoneForExiting
branch
from
February 25, 2022 13:14
1161a71
to
44eab55
Compare
PR #15571: Size comparison from 980e177 to 44eab55 Decreases (2 builds for linux)
Full report (45 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jepenven-silabs
approved these changes
Feb 25, 2022
Damian-Nordic
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…allback to be called for returning any errors
Problem
chip-tool
exit on the first error when using a wildcard.See #14896
Change overview
onDone
delegates method before exitingTesting
It was manually tested doing:
./out/debug/standalone/chip-tool any read-by-id 0xFFFFFFFF 0xFFFFFFFF 0x12344321 3