Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move screen framework into component #1555

Merged

Conversation

mlepage-google
Copy link
Contributor

Problem

Screen framework is living in ESP32 wifi-echo demo, whereas it should be a separate component.

Summary of Changes

Move screen framework into components area.

@mlepage-google mlepage-google force-pushed the screen-framework-component branch from c325c85 to 7828089 Compare July 10, 2020 19:32
@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.text 120 120
chip-wifi-echo.elf .flash.rodata 8 8
chip-wifi-echo.elf .dram0.bss 0 -8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.debug_line,0,354
.flash.text,120,120
.debug_str,0,76
.xt.prop._ZN10ListScreenD5Ev,0,52
.xt.lit._ZN10ListScreenD5Ev,0,48
.xt.lit._ZNSt6vectorIP6ScreenSaIS1_EE17_M_realloc_insertIJRKS1_EEEvN9__gnu_cxx17__normal_iteratorIPS1_S3_EEDpOT_,0,48
.flash.rodata,8,8
.dram0.bss,-8,0
[Unmapped],0,-10
.xt.prop._ZNSt6vectorIP6ScreenSaIS1_EE17_M_realloc_insertIJRKS1_EEEvN9__gnu_cxx17__normal_iteratorIPS1_S3_EEDpOT_,0,-28
.xt.prop._ZN10ListScreenD2Ev,0,-80


@woody-apple woody-apple merged commit fcddc88 into project-chip:master Jul 10, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@mlepage-google mlepage-google deleted the screen-framework-component branch February 15, 2022 15:06
jmartinez-silabs added a commit to SiliconLabs/matter that referenced this pull request Feb 15, 2024
…w-app.

Merge in WMN_TOOLS/matter from revert_csl_on_window_app to RC_2.3.0-1.3

Squashed commit of the following:

commit 2177f2e8e72a65edcdf69b13711b139d0d82cf75
Author: Junior Martinez <[email protected]>
Date:   Thu Feb 8 12:47:30 2024 -0500

    disable csl/ssed on window-app. as it currently require ot rcp update to validate
jmartinez-silabs added a commit to SiliconLabs/matter that referenced this pull request May 8, 2024
…w-app.

Merge in WMN_TOOLS/matter from revert_csl_on_window_app to RC_2.3.0-1.3

Squashed commit of the following:

commit 2177f2e8e72a65edcdf69b13711b139d0d82cf75
Author: Junior Martinez <[email protected]>
Date:   Thu Feb 8 12:47:30 2024 -0500

    disable csl/ssed on window-app. as it currently require ot rcp update to validate
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
…w-app.

Merge in WMN_TOOLS/matter from revert_csl_on_window_app to RC_2.3.0-1.3

Squashed commit of the following:

commit 2177f2e8e72a65edcdf69b13711b139d0d82cf75
Author: Junior Martinez <[email protected]>
Date:   Thu Feb 8 12:47:30 2024 -0500

    disable csl/ssed on window-app. as it currently require ot rcp update to validate
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
…w-app.

Merge in WMN_TOOLS/matter from revert_csl_on_window_app to RC_2.3.0-1.3

Squashed commit of the following:

commit 2177f2e8e72a65edcdf69b13711b139d0d82cf75
Author: Junior Martinez <[email protected]>
Date:   Thu Feb 8 12:47:30 2024 -0500

    disable csl/ssed on window-app. as it currently require ot rcp update to validate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants