Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Objective C NS_ENUM/NS_OPTIONS for enums and bitmaps. #15493

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Generate Objective C NS_ENUM/NS_OPTIONS for enums and bitmaps. #15493

merged 1 commit into from
Mar 1, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

We are not generating Objective C reflections of spec enums and bitmaps.

Change overview

Do that.

Testing

Read the generated code.

@boring-cyborg boring-cyborg bot added the darwin label Feb 23, 2022
@github-actions
Copy link

github-actions bot commented Feb 23, 2022 •
edited
Loading

PR #15493: Size comparison from cb0e243 to 886eb81

Full report (26 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section cb0e243 886eb81 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599070 599070 0 0.0
.app_xip_area 503876 503876 0 0.0
.bss 77884 77884 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557138 557138 0 0.0
.app_xip_area 463488 463488 0 0.0
.bss 76380 76380 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577870 577870 0 0.0
.app_xip_area 474788 474788 0 0.0
.bss 85484 85484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916568 916568 0 0.0
(read/write) 128648 128648 0 0.0
.bss 126600 126600 0 0.0
.data 2048 2048 0 0.0
.text 916560 916560 0 0.0
BRD4161A+rpc (read only) 945276 945276 0 0.0
(read/write) 145564 145564 0 0.0
.bss 143376 143376 0 0.0
.data 2188 2188 0 0.0
.text 945268 945268 0 0.0
window-app BRD4161A (read only) 850932 850932 0 0.0
(read/write) 126548 126548 0 0.0
.bss 124632 124632 0 0.0
.data 1916 1916 0 0.0
.text 850924 850924 0 0.0
k32w light k32w061+release (read/write) 691656 691656 0 0.0
.bss 77520 77520 0 0.0
.data 1924 1924 0 0.0
.text 606412 606412 0 0.0
lock k32w061+release (read/write) 694744 694744 0 0.0
.bss 77720 77720 0 0.0
.data 1964 1964 0 0.0
.text 609260 609260 0 0.0
linux all-clusters-app debug (read only) 2395673 2395673 0 0.0
(read/write) 148592 148592 0 0.0
.bss 62944 62944 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206501 206501 0 0.0
.text 2025730 2025730 0 0.0
bridge-app debug+rpc (read only) 1718861 1718861 0 0.0
(read/write) 93856 93856 0 0.0
.bss 48480 48480 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38280 38280 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140628 140628 0 0.0
.text 1462069 1462069 0 0.0
chip-tool debug (read only) 9070797 9070797 0 0.0
(read/write) 321624 321624 0 0.0
.bss 41024 41024 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 273368 273368 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 480373 480373 0 0.0
.text 7928213 7928213 0 0.0
chip-tool-ipv6only arm64 (read only) 8823092 8823092 0 0.0
(read/write) 434721 434721 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 319040 319040 0 0.0
.dynamic 560 560 0 0.0
.got 51400 51400 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456796 456796 0 0.0
.text 7447892 7447892 0 0.0
door-lock-app debug (read only) 1934169 1934169 0 0.0
(read/write) 119992 119992 0 0.0
.bss 51168 51168 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62416 62416 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 172252 172252 0 0.0
.text 1613026 1613026 0 0.0
lighting-app debug+rpc (read only) 2063569 2063569 0 0.0
(read/write) 124904 124904 0 0.0
.bss 52128 52128 0 0.0
.data 1408 1408 0 0.0
.data.rel.ro 65904 65904 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 164753 164753 0 0.0
.text 1743794 1743794 0 0.0
ota-provider-app debug (read only) 1866281 1866281 0 0.0
(read/write) 115656 115656 0 0.0
.bss 51040 51040 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57688 57688 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 157171 157171 0 0.0
.text 1558162 1558162 0 0.0
ota-requestor-app debug (read only) 1877345 1877345 0 0.0
(read/write) 117424 117424 0 0.0
.bss 51872 51872 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58952 58952 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151172 151172 0 0.0
.text 1576930 1576930 0 0.0
shell debug (read only) 2363841 2363841 0 0.0
(read/write) 151136 151136 0 0.0
.bss 71296 71296 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73328 73328 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206482 206482 0 0.0
.text 2000130 2000130 0 0.0
thermostat-no-ble arm64 (read only) 2162188 2162188 0 0.0
(read/write) 149937 149937 0 0.0
.bss 66433 66433 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75272 75272 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132700 132700 0 0.0
.text 1810608 1810608 0 0.0
tv-app debug (read only) 2590057 2590057 0 0.0
(read/write) 152272 152272 0 0.0
.bss 69120 69120 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73960 73960 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 199901 199901 0 0.0
.text 2215362 2215362 0 0.0
p6 all-clusters-app default (read/write) 2491032 2491032 0 0.0
.bss 122400 122400 0 0.0
.data 2688 2688 0 0.0
.text 1449296 1449296 0 0.0
light-app default (read/write) 2395176 2395176 0 0.0
.bss 113648 113648 0 0.0
.data 2536 2536 0 0.0
.text 1353440 1353440 0 0.0
lock-app default (read/write) 2358744 2358744 0 0.0
.bss 113400 113400 0 0.0
.data 2496 2496 0 0.0
.text 1317008 1317008 0 0.0
qpg lighting-app qpg6105+debug (read only) 600768 600768 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1124 1124 0 0.0
.text 595448 595448 0 0.0
lock-app qpg6105+debug (read only) 566568 566568 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90944 90944 0 0.0
.data 1076 1076 0 0.0
.text 561248 561248 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 882202 882202 0 0.0
bss 86372 86372 0 0.0
noinit 37160 37160 0 0.0
text 623476 623476 0 0.0

@boring-cyborg boring-cyborg bot added the app label Feb 24, 2022
@github-actions
Copy link

github-actions bot commented Feb 24, 2022 •
edited
Loading

PR #15493: Size comparison from cb0e243 to 04d36f0

Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cb0e243 04d36f0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599070 599070 0 0.0
.app_xip_area 503876 503876 0 0.0
.bss 77884 77884 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557138 557138 0 0.0
.app_xip_area 463488 463488 0 0.0
.bss 76380 76380 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577870 577870 0 0.0
.app_xip_area 474788 474788 0 0.0
.bss 85484 85484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916568 916568 0 0.0
(read/write) 128648 128648 0 0.0
.bss 126600 126600 0 0.0
.data 2048 2048 0 0.0
.text 916560 916560 0 0.0
BRD4161A+rpc (read only) 945276 945276 0 0.0
(read/write) 145564 145564 0 0.0
.bss 143376 143376 0 0.0
.data 2188 2188 0 0.0
.text 945268 945268 0 0.0
window-app BRD4161A (read only) 850932 850932 0 0.0
(read/write) 126548 126548 0 0.0
.bss 124632 124632 0 0.0
.data 1916 1916 0 0.0
.text 850924 850924 0 0.0
esp32 all-clusters-app c3devkit (read only) 951708 951708 0 0.0
(read/write) 1399562 1399562 0 0.0
.dram0.bss 66680 66680 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 199808 199808 0 0.0
.flash.text 951708 951708 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1001719 1001719 0 0.0
(read/write) 464952 464952 0 0.0
.dram0.bss 71832 71832 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 226920 226920 0 0.0
.flash.text 996335 996335 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691656 691656 0 0.0
.bss 77520 77520 0 0.0
.data 1924 1924 0 0.0
.text 606412 606412 0 0.0
lock k32w061+release (read/write) 694744 694744 0 0.0
.bss 77720 77720 0 0.0
.data 1964 1964 0 0.0
.text 609260 609260 0 0.0
linux all-clusters-app debug (read only) 2395673 2395673 0 0.0
(read/write) 148592 148592 0 0.0
.bss 62944 62944 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206501 206501 0 0.0
.text 2025730 2025730 0 0.0
bridge-app debug+rpc (read only) 1718861 1718861 0 0.0
(read/write) 93856 93856 0 0.0
.bss 48480 48480 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38280 38280 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140628 140628 0 0.0
.text 1462069 1462069 0 0.0
chip-tool debug (read only) 9070797 9070797 0 0.0
(read/write) 321624 321624 0 0.0
.bss 41024 41024 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 273368 273368 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 480373 480373 0 0.0
.text 7928213 7928213 0 0.0
chip-tool-ipv6only arm64 (read only) 8823092 8823092 0 0.0
(read/write) 434721 434721 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 319040 319040 0 0.0
.dynamic 560 560 0 0.0
.got 51400 51400 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456796 456796 0 0.0
.text 7447892 7447892 0 0.0
door-lock-app debug (read only) 1934169 1934169 0 0.0
(read/write) 119992 119992 0 0.0
.bss 51168 51168 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62416 62416 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 172252 172252 0 0.0
.text 1613026 1613026 0 0.0
lighting-app debug+rpc (read only) 2063569 2063569 0 0.0
(read/write) 124904 124904 0 0.0
.bss 52128 52128 0 0.0
.data 1408 1408 0 0.0
.data.rel.ro 65904 65904 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 164753 164753 0 0.0
.text 1743794 1743794 0 0.0
ota-provider-app debug (read only) 1866281 1866281 0 0.0
(read/write) 115656 115656 0 0.0
.bss 51040 51040 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57688 57688 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 157171 157171 0 0.0
.text 1558162 1558162 0 0.0
ota-requestor-app debug (read only) 1877345 1877345 0 0.0
(read/write) 117424 117424 0 0.0
.bss 51872 51872 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58952 58952 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151172 151172 0 0.0
.text 1576930 1576930 0 0.0
shell debug (read only) 2363841 2363841 0 0.0
(read/write) 151136 151136 0 0.0
.bss 71296 71296 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73328 73328 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206482 206482 0 0.0
.text 2000130 2000130 0 0.0
thermostat-no-ble arm64 (read only) 2162188 2162188 0 0.0
(read/write) 149937 149937 0 0.0
.bss 66433 66433 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75272 75272 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132700 132700 0 0.0
.text 1810608 1810608 0 0.0
tv-app debug (read only) 2590057 2590057 0 0.0
(read/write) 152272 152272 0 0.0
.bss 69120 69120 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73960 73960 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 199901 199901 0 0.0
.text 2215362 2215362 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452456 2452456 0 0.0
.bss 194760 194760 0 0.0
.data 5512 5512 0 0.0
.text 1415028 1415028 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2413832 2413832 0 0.0
.bss 188860 188860 0 0.0
.data 5800 5800 0 0.0
.text 1376404 1376404 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349588 2349588 0 0.0
.bss 187764 187764 0 0.0
.data 5776 5776 0 0.0
.text 1312188 1312188 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1155428 1155428 0 0.0
.bss 11952 11952 0 0.0
.data 4512 4512 0 0.0
.text 118812 118812 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2339960 2339960 0 0.0
.bss 186400 186400 0 0.0
.data 5608 5608 0 0.0
.text 1302532 1302532 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1018955 1018955 0 0.0
bss 121476 121476 0 0.0
rodata 120704 120704 0 0.0
text 698852 698852 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 986479 986479 0 0.0
bss 118520 118520 0 0.0
rodata 112236 112236 0 0.0
text 677212 677212 0 0.0
nrf52840dongle_nrf52840 (read/write) 1035423 1035423 0 0.0
bss 122508 122508 0 0.0
rodata 120112 120112 0 0.0
text 704176 704176 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 925406 925406 0 0.0
bss 118260 118260 0 0.0
rodata 113960 113960 0 0.0
text 612392 612392 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 948219 948219 0 0.0
bss 119688 119688 0 0.0
rodata 109544 109544 0 0.0
text 641464 641464 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 855518 855518 0 0.0
bss 116504 116504 0 0.0
rodata 102712 102712 0 0.0
text 555784 555784 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 523115 523115 0 0.0
bss 52588 52588 0 0.0
rodata 49864 49864 0 0.0
text 358460 358460 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 946315 946315 0 0.0
bss 119408 119408 0 0.0
rodata 108496 108496 0 0.0
text 640844 640844 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 942291 942291 0 0.0
bss 119412 119412 0 0.0
rodata 108192 108192 0 0.0
text 637100 637100 0 0.0
shell nrf52840dk_nrf52840 (read/write) 808183 808183 0 0.0
bss 112160 112160 0 0.0
rodata 79676 79676 0 0.0
text 539868 539868 0 0.0
p6 all-clusters-app default (read/write) 2491032 2491032 0 0.0
.bss 122400 122400 0 0.0
.data 2688 2688 0 0.0
.text 1449296 1449296 0 0.0
light-app default (read/write) 2395176 2395176 0 0.0
.bss 113648 113648 0 0.0
.data 2536 2536 0 0.0
.text 1353440 1353440 0 0.0
lock-app default (read/write) 2358744 2358744 0 0.0
.bss 113400 113400 0 0.0
.data 2496 2496 0 0.0
.text 1317008 1317008 0 0.0
qpg lighting-app qpg6105+debug (read only) 600768 600768 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1124 1124 0 0.0
.text 595448 595448 0 0.0
lock-app qpg6105+debug (read only) 566568 566568 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90944 90944 0 0.0
.data 1076 1076 0 0.0
.text 561248 561248 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 882202 882202 0 0.0
bss 86372 86372 0 0.0
noinit 37160 37160 0 0.0
text 623476 623476 0 0.0

andy31415
andy31415 reviewed Feb 24, 2022
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 24, 2022 •
edited
Loading

PR #15493: Size comparison from 08d8b9b to effd0a5

Full report (44 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 08d8b9b effd0a5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599134 599134 0 0.0
.app_xip_area 503940 503940 0 0.0
.bss 77884 77884 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557186 557186 0 0.0
.app_xip_area 463536 463536 0 0.0
.bss 76380 76380 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577918 577918 0 0.0
.app_xip_area 474836 474836 0 0.0
.bss 85484 85484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916648 916648 0 0.0
(read/write) 128648 128648 0 0.0
.bss 126600 126600 0 0.0
.data 2048 2048 0 0.0
.text 916640 916640 0 0.0
BRD4161A+rpc (read only) 945356 945356 0 0.0
(read/write) 145564 145564 0 0.0
.bss 143376 143376 0 0.0
.data 2188 2188 0 0.0
.text 945348 945348 0 0.0
lock-app BRD4161A+wf200 (read only) 986400 986400 0 0.0
(read/write) 121028 121028 0 0.0
.bss 119100 119100 0 0.0
.data 1924 1924 0 0.0
.text 986392 986392 0 0.0
window-app BRD4161A (read only) 850912 850912 0 0.0
(read/write) 126552 126552 0 0.0
.bss 124632 124632 0 0.0
.data 1916 1916 0 0.0
.text 850904 850904 0 0.0
esp32 all-clusters-app c3devkit (read only) 952250 952250 0 0.0
(read/write) 1399650 1399650 0 0.0
.dram0.bss 66680 66680 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 199896 199896 0 0.0
.flash.text 952250 952250 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1002427 1002427 0 0.0
(read/write) 465160 465160 0 0.0
.dram0.bss 71832 71832 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 227128 227128 0 0.0
.flash.text 997043 997043 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691704 691704 0 0.0
.bss 77520 77520 0 0.0
.data 1924 1924 0 0.0
.text 606460 606460 0 0.0
lock k32w061+release (read/write) 694792 694792 0 0.0
.bss 77720 77720 0 0.0
.data 1964 1964 0 0.0
.text 609308 609308 0 0.0
linux all-clusters-app debug (read only) 2396265 2396265 0 0.0
(read/write) 148592 148592 0 0.0
.bss 62944 62944 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206501 206501 0 0.0
.text 2026322 2026322 0 0.0
bridge-app debug+rpc (read only) 1719117 1719117 0 0.0
(read/write) 93856 93856 0 0.0
.bss 48480 48480 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38280 38280 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140628 140628 0 0.0
.text 1462325 1462325 0 0.0
chip-tool debug (read only) 9070909 9070909 0 0.0
(read/write) 321624 321624 0 0.0
.bss 41024 41024 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 273368 273368 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 480373 480373 0 0.0
.text 7928325 7928325 0 0.0
chip-tool-ipv6only arm64 (read only) 8823156 8823156 0 0.0
(read/write) 434721 434721 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 319040 319040 0 0.0
.dynamic 560 560 0 0.0
.got 51400 51400 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456796 456796 0 0.0
.text 7447956 7447956 0 0.0
door-lock-app debug (read only) 1934441 1934441 0 0.0
(read/write) 119992 119992 0 0.0
.bss 51168 51168 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62416 62416 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 172252 172252 0 0.0
.text 1613298 1613298 0 0.0
lighting-app debug+rpc (read only) 2064065 2064065 0 0.0
(read/write) 124904 124904 0 0.0
.bss 52128 52128 0 0.0
.data 1408 1408 0 0.0
.data.rel.ro 65904 65904 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 164753 164753 0 0.0
.text 1744290 1744290 0 0.0
ota-provider-app debug (read only) 1866553 1866553 0 0.0
(read/write) 115656 115656 0 0.0
.bss 51040 51040 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57688 57688 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 157171 157171 0 0.0
.text 1558434 1558434 0 0.0
ota-requestor-app debug (read only) 1877729 1877729 0 0.0
(read/write) 117424 117424 0 0.0
.bss 51872 51872 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58952 58952 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151172 151172 0 0.0
.text 1577314 1577314 0 0.0
shell debug (read only) 2364433 2364433 0 0.0
(read/write) 151136 151136 0 0.0
.bss 71296 71296 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73328 73328 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206482 206482 0 0.0
.text 2000722 2000722 0 0.0
thermostat-no-ble arm64 (read only) 2162644 2162644 0 0.0
(read/write) 149937 149937 0 0.0
.bss 66433 66433 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75272 75272 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132708 132708 0 0.0
.text 1811056 1811056 0 0.0
tv-app debug (read only) 2590537 2590537 0 0.0
(read/write) 152272 152272 0 0.0
.bss 69120 69120 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73960 73960 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 199901 199901 0 0.0
.text 2215842 2215842 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452584 2452584 0 0.0
.bss 194760 194760 0 0.0
.data 5512 5512 0 0.0
.text 1415156 1415156 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2413960 2413960 0 0.0
.bss 188860 188860 0 0.0
.data 5800 5800 0 0.0
.text 1376532 1376532 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349652 2349652 0 0.0
.bss 187764 187764 0 0.0
.data 5776 5776 0 0.0
.text 1312252 1312252 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1155428 1155428 0 0.0
.bss 11952 11952 0 0.0
.data 4512 4512 0 0.0
.text 118812 118812 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340024 2340024 0 0.0
.bss 186400 186400 0 0.0
.data 5608 5608 0 0.0
.text 1302596 1302596 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1001571 1001571 0 0.0
bss 122100 122100 0 0.0
rodata 115788 115788 0 0.0
text 686180 686180 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967083 967083 0 0.0
bss 119184 119184 0 0.0
rodata 106892 106892 0 0.0
text 662896 662896 0 0.0
nrf52840dongle_nrf52840 (read/write) 1017555 1017555 0 0.0
bss 123148 123148 0 0.0
rodata 115432 115432 0 0.0
text 690832 690832 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904386 904386 0 0.0
bss 119388 119388 0 0.0
rodata 107904 107904 0 0.0
text 595892 595892 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930551 930551 0 0.0
bss 120316 120316 0 0.0
rodata 104576 104576 0 0.0
text 628612 628612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834226 834226 0 0.0
bss 117636 117636 0 0.0
rodata 96608 96608 0 0.0
text 539088 539088 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 501603 501603 0 0.0
bss 52584 52584 0 0.0
rodata 44500 44500 0 0.0
text 342712 342712 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 928811 928811 0 0.0
bss 120048 120048 0 0.0
rodata 103556 103556 0 0.0
text 628040 628040 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 924787 924787 0 0.0
bss 120052 120052 0 0.0
rodata 103252 103252 0 0.0
text 624296 624296 0 0.0
shell nrf52840dk_nrf52840 (read/write) 788671 788671 0 0.0
bss 112360 112360 0 0.0
rodata 74728 74728 0 0.0
text 525468 525468 0 0.0
p6 all-clusters-app default (read/write) 2491176 2491176 0 0.0
.bss 122400 122400 0 0.0
.data 2688 2688 0 0.0
.text 1449440 1449440 0 0.0
light-app default (read/write) 2395288 2395288 0 0.0
.bss 113648 113648 0 0.0
.data 2536 2536 0 0.0
.text 1353552 1353552 0 0.0
lock-app default (read/write) 2358840 2358840 0 0.0
.bss 113400 113400 0 0.0
.data 2496 2496 0 0.0
.text 1317104 1317104 0 0.0
qpg lighting-app qpg6105+debug (read only) 600832 600832 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1124 1124 0 0.0
.text 595512 595512 0 0.0
lock-app qpg6105+debug (read only) 566616 566616 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90944 90944 0 0.0
.data 1076 1076 0 0.0
.text 561296 561296 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 882290 882290 0 0.0
bss 86372 86372 0 0.0
noinit 37160 37160 0 0.0
text 623564 623564 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

/rebase

@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

PR #15493: Size comparison from 29db0f4 to d791f74

Increases above 0.2%:

platform target config section 29db0f4 d791f74 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038959 1075263 36304 3.5
bss 125756 127608 1852 1.5
rodata 135904 141808 5904 4.3
text 700088 728444 28356 4.1
Increases (1 build for nrfconnect)
platform target config section 29db0f4 d791f74 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038959 1075263 36304 3.5
bss 125756 127608 1852 1.5
rodata 135904 141808 5904 4.3
text 700088 728444 28356 4.1
Full report (20 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 29db0f4 d791f74 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599590 599590 0 0.0
.app_xip_area 504436 504436 0 0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557622 557622 0 0.0
.app_xip_area 464004 464004 0 0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578146 578146 0 0.0
.app_xip_area 475096 475096 0 0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916532 916532 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916524 916524 0 0.0
BRD4161A+rpc (read only) 946612 946612 0 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946604 946604 0 0.0
lock-app BRD4161A+wf200 (read only) 986444 986444 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986436 986436 0 0.0
window-app BRD4161A (read only) 850612 850612 0 0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850604 850604 0 0.0
k32w light k32w061+release (read/write) 691908 691908 0 0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606704 606704 0 0.0
lock k32w061+release (read/write) 695180 695180 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609728 609728 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8757580 8757580 0 0.0
(read/write) 412049 412049 0 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296848 296848 0 0.0
.dynamic 560 560 0 0.0
.got 51512 51512 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 457028 457028 0 0.0
.text 7435236 7435236 0 0.0
thermostat-no-ble arm64 (read only) 2163444 2163444 0 0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75088 75088 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132996 132996 0 0.0
.text 1812128 1812128 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350148 2350148 0 0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312748 1312748 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038959 1075263 36304 3.5
bss 125756 127608 1852 1.5
rodata 135904 141808 5904 4.3
text 700088 728444 28356 4.1
p6 all-clusters-app default (read/write) 2488224 2488224 0 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446488 1446488 0 0.0
light-app default (read/write) 2395440 2395440 0 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353704 1353704 0 0.0
lock-app default (read/write) 2359000 2359000 0 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317264 1317264 0 0.0
qpg lighting-app qpg6105+debug (read only) 601212 601212 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595892 595892 0 0.0
lock-app qpg6105+debug (read only) 566976 566976 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561656 561656 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883138 883138 0 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623992 623992 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited
Loading

PR #15493: Size comparison from 29db0f4 to 2e7c79f

Increases above 0.2%:

platform target config section 29db0f4 2e7c79f change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038959 1075263 36304 3.5
bss 125756 127608 1852 1.5
rodata 135904 141808 5904 4.3
text 700088 728444 28356 4.1
Increases (1 build for nrfconnect)
platform target config section 29db0f4 2e7c79f change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038959 1075263 36304 3.5
bss 125756 127608 1852 1.5
rodata 135904 141808 5904 4.3
text 700088 728444 28356 4.1
Full report (20 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 29db0f4 2e7c79f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599590 599590 0 0.0
.app_xip_area 504436 504436 0 0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557622 557622 0 0.0
.app_xip_area 464004 464004 0 0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578146 578146 0 0.0
.app_xip_area 475096 475096 0 0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916532 916532 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916524 916524 0 0.0
BRD4161A+rpc (read only) 946612 946612 0 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946604 946604 0 0.0
lock-app BRD4161A+wf200 (read only) 986444 986444 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986436 986436 0 0.0
window-app BRD4161A (read only) 850612 850612 0 0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850604 850604 0 0.0
k32w light k32w061+release (read/write) 691908 691908 0 0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606704 606704 0 0.0
lock k32w061+release (read/write) 695180 695180 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609728 609728 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8757580 8757580 0 0.0
(read/write) 412049 412049 0 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296848 296848 0 0.0
.dynamic 560 560 0 0.0
.got 51512 51512 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 457028 457028 0 0.0
.text 7435236 7435236 0 0.0
thermostat-no-ble arm64 (read only) 2163444 2163444 0 0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75088 75088 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132996 132996 0 0.0
.text 1812128 1812128 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350148 2350148 0 0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312748 1312748 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038959 1075263 36304 3.5
bss 125756 127608 1852 1.5
rodata 135904 141808 5904 4.3
text 700088 728444 28356 4.1
p6 all-clusters-app default (read/write) 2488224 2488224 0 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446488 1446488 0 0.0
light-app default (read/write) 2395440 2395440 0 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353704 1353704 0 0.0
lock-app default (read/write) 2359000 2359000 0 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317264 1317264 0 0.0
qpg lighting-app qpg6105+debug (read only) 601212 601212 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595892 595892 0 0.0
lock-app qpg6105+debug (read only) 566976 566976 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561656 561656 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883138 883138 0 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623992 623992 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 6adeb23 into project-chip:master Mar 1, 2022
@bzbarsky-apple bzbarsky-apple deleted the generate-objc-enums branch March 1, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@sagar-apple sagar-apple sagar-apple approved these changes

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @sagar-apple