Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang-tidy] Fix some bugprone-use-after-move errors #15476

Merged
merged 1 commit into from
Feb 24, 2022
Merged

[clang-tidy] Fix some bugprone-use-after-move errors #15476

merged 1 commit into from
Feb 24, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

clang-tidy with bugprone-use-after-move errors is complaining a little.

Change overview

  • Fix the different places where it complains

@vivien-apple vivien-apple self-assigned this Feb 23, 2022
@restyled-io restyled-io bot mentioned this pull request Feb 23, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 23, 2022 •
edited
Loading

PR #15476: Size comparison from 70ae428 to 3396312

Decreases (8 builds for linux)
platform target config section 70ae428 3396312 change % change
linux bridge-app debug+rpc (read only) 1718061 1718045 -16 -0.0
.text 1461285 1461269 -16 -0.0
chip-tool debug (read only) 9069245 9069229 -16 -0.0
.text 7927093 7927077 -16 -0.0
chip-tool-ipv6only arm64 (read only) 8822084 8822052 -32 -0.0
.text 7447076 7447044 -32 -0.0
lighting-app debug+rpc (read only) 2062785 2062769 -16 -0.0
.text 1743026 1743010 -16 -0.0
ota-provider-app debug (read only) 1865137 1865121 -16 -0.0
.text 1557186 1557170 -16 -0.0
ota-requestor-app debug (read only) 1876625 1876609 -16 -0.0
.text 1576162 1576146 -16 -0.0
thermostat-no-ble arm64 (read only) 2161644 2161612 -32 -0.0
.text 1810080 1810048 -32 -0.0
tv-app debug (read only) 2588465 2588449 -16 -0.0
.text 2214130 2214114 -16 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 70ae428 3396312 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598974 598974 0 0.0
.app_xip_area 503780 503780 0 0.0
.bss 77884 77884 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557042 557042 0 0.0
.app_xip_area 463392 463392 0 0.0
.bss 76380 76380 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577774 577774 0 0.0
.app_xip_area 474692 474692 0 0.0
.bss 85484 85484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916340 916340 0 0.0
(read/write) 128648 128648 0 0.0
.bss 126600 126600 0 0.0
.data 2048 2048 0 0.0
.text 916332 916332 0 0.0
BRD4161A+rpc (read only) 945064 945064 0 0.0
(read/write) 145568 145568 0 0.0
.bss 143376 143376 0 0.0
.data 2188 2188 0 0.0
.text 945056 945056 0 0.0
window-app BRD4161A (read only) 850704 850704 0 0.0
(read/write) 126552 126552 0 0.0
.bss 124632 124632 0 0.0
.data 1916 1916 0 0.0
.text 850696 850696 0 0.0
esp32 all-clusters-app c3devkit (read only) 951482 951482 0 0.0
(read/write) 1399610 1399610 0 0.0
.dram0.bss 66672 66672 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 199872 199872 0 0.0
.flash.text 951482 951482 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1001539 1001539 0 0.0
(read/write) 465008 465008 0 0.0
.dram0.bss 71824 71824 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 226984 226984 0 0.0
.flash.text 996155 996155 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691572 691572 0 0.0
.bss 77520 77520 0 0.0
.data 1924 1924 0 0.0
.text 606328 606328 0 0.0
lock k32w061+release (read/write) 694660 694660 0 0.0
.bss 77720 77720 0 0.0
.data 1964 1964 0 0.0
.text 609176 609176 0 0.0
linux all-clusters-app debug (read only) 2394905 2394905 0 0.0
(read/write) 148592 148592 0 0.0
.bss 62944 62944 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78584 78584 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206565 206565 0 0.0
.text 2024946 2024946 0 0.0
bridge-app debug+rpc (read only) 1718061 1718045 -16 -0.0
(read/write) 93856 93856 0 0.0
.bss 48480 48480 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38264 38264 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140660 140660 0 0.0
.text 1461285 1461269 -16 -0.0
chip-tool debug (read only) 9069245 9069229 -16 -0.0
(read/write) 321592 321592 0 0.0
.bss 41024 41024 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 273352 273352 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 479989 479989 0 0.0
.text 7927093 7927077 -16 -0.0
chip-tool-ipv6only arm64 (read only) 8822084 8822052 -32 -0.0
(read/write) 434705 434705 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 319024 319024 0 0.0
.dynamic 560 560 0 0.0
.got 51392 51392 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456684 456684 0 0.0
.text 7447076 7447044 -32 -0.0
door-lock-app debug (read only) 1933433 1933433 0 0.0
(read/write) 119992 119992 0 0.0
.bss 51168 51168 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62400 62400 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 172348 172348 0 0.0
.text 1612242 1612242 0 0.0
lighting-app debug+rpc (read only) 2062785 2062769 -16 -0.0
(read/write) 124872 124872 0 0.0
.bss 52128 52128 0 0.0
.data 1408 1408 0 0.0
.data.rel.ro 65888 65888 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 164785 164785 0 0.0
.text 1743026 1743010 -16 -0.0
ota-provider-app debug (read only) 1865137 1865121 -16 -0.0
(read/write) 115592 115592 0 0.0
.bss 51008 51008 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57672 57672 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 157075 157075 0 0.0
.text 1557186 1557170 -16 -0.0
ota-requestor-app debug (read only) 1876625 1876609 -16 -0.0
(read/write) 117392 117392 0 0.0
.bss 51872 51872 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58936 58936 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151268 151268 0 0.0
.text 1576162 1576146 -16 -0.0
shell debug (read only) 2363393 2363393 0 0.0
(read/write) 151104 151104 0 0.0
.bss 71296 71296 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73312 73312 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206866 206866 0 0.0
.text 1999346 1999346 0 0.0
thermostat-no-ble arm64 (read only) 2161644 2161612 -32 -0.0
(read/write) 149921 149921 0 0.0
.bss 66433 66433 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75256 75256 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132764 132764 0 0.0
.text 1810080 1810048 -32 -0.0
tv-app debug (read only) 2588465 2588449 -16 -0.0
(read/write) 152208 152208 0 0.0
.bss 69120 69120 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73896 73896 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 199805 199805 0 0.0
.text 2214130 2214114 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2440036 2440036 0 0.0
.bss 194612 194612 0 0.0
.data 5360 5360 0 0.0
.text 1402608 1402608 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2401348 2401348 0 0.0
.bss 188712 188712 0 0.0
.data 5656 5656 0 0.0
.text 1363920 1363920 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337168 2337168 0 0.0
.bss 187608 187608 0 0.0
.data 5632 5632 0 0.0
.text 1299768 1299768 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327540 2327540 0 0.0
.bss 186244 186244 0 0.0
.data 5464 5464 0 0.0
.text 1290112 1290112 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022607 1022607 0 0.0
bss 122664 122664 0 0.0
rodata 120852 120852 0 0.0
text 700092 700092 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 991883 991883 0 0.0
bss 119852 119852 0 0.0
rodata 112376 112376 0 0.0
text 679972 679972 0 0.0
nrf52840dongle_nrf52840 (read/write) 1037619 1037619 0 0.0
bss 123868 123868 0 0.0
rodata 119700 119700 0 0.0
text 704144 704144 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929254 929254 0 0.0
bss 119224 119224 0 0.0
rodata 114112 114112 0 0.0
text 615124 615124 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 951711 951711 0 0.0
bss 120876 120876 0 0.0
rodata 109692 109692 0 0.0
text 642548 642548 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859190 859190 0 0.0
bss 117468 117468 0 0.0
rodata 102864 102864 0 0.0
text 558352 558352 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527567 527567 0 0.0
bss 53632 53632 0 0.0
rodata 49948 49948 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949855 949855 0 0.0
bss 120596 120596 0 0.0
rodata 108644 108644 0 0.0
text 641936 641936 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945819 945819 0 0.0
bss 120600 120600 0 0.0
rodata 108344 108344 0 0.0
text 638176 638176 0 0.0
shell nrf52840dk_nrf52840 (read/write) 811715 811715 0 0.0
bss 113348 113348 0 0.0
rodata 79752 79752 0 0.0
text 540984 540984 0 0.0
p6 all-clusters-app default (read/write) 2490888 2490888 0 0.0
.bss 122400 122400 0 0.0
.data 2688 2688 0 0.0
.text 1449152 1449152 0 0.0
light-app default (read/write) 2395024 2395024 0 0.0
.bss 113648 113648 0 0.0
.data 2536 2536 0 0.0
.text 1353288 1353288 0 0.0
lock-app default (read/write) 2358584 2358584 0 0.0
.bss 113400 113400 0 0.0
.data 2496 2496 0 0.0
.text 1316848 1316848 0 0.0
qpg lighting-app qpg6105+debug (read only) 600684 600684 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1124 1124 0 0.0
.text 595364 595364 0 0.0
lock-app qpg6105+debug (read only) 566484 566484 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90944 90944 0 0.0
.data 1076 1076 0 0.0
.text 561164 561164 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 881938 881938 0 0.0
bss 86372 86372 0 0.0
noinit 37160 37160 0 0.0
text 623156 623156 0 0.0

@bzbarsky-apple
Copy link
Contributor

@vivien-apple restyle?

@vivien-apple vivien-apple force-pushed the ClangTidy_UseAfterMove branch from 3396312 to 5788b27 Compare February 24, 2022 10:43
@github-actions
Copy link

github-actions bot commented Feb 24, 2022 •
edited
Loading

PR #15476: Size comparison from 924c01c to 5788b27

Decreases (8 builds for linux)
platform target config section 924c01c 5788b27 change % change
linux all-clusters-app debug (read only) 2395457 2395441 -16 -0.0
.text 2025794 2025778 -16 -0.0
chip-tool debug (read only) 8992797 8992781 -16 -0.0
.text 7904133 7904117 -16 -0.0
chip-tool-ipv6only arm64 (read only) 8747532 8747500 -32 -0.0
.text 7426660 7426628 -32 -0.0
ota-provider-app debug (read only) 1865777 1865761 -16 -0.0
.text 1557906 1557890 -16 -0.0
ota-requestor-app debug (read only) 1876985 1876969 -16 -0.0
.text 1576786 1576770 -16 -0.0
shell debug (read only) 2363705 2363689 -16 -0.0
.text 2000210 2000194 -16 -0.0
thermostat-no-ble arm64 (read only) 2161588 2161556 -32 -0.0
.text 1810512 1810480 -32 -0.0
tv-app debug (read only) 2589617 2589601 -16 -0.0
.text 2215346 2215330 -16 -0.0
Full report (45 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 924c01c 5788b27 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599062 599062 0 0.0
.app_xip_area 503876 503876 0 0.0
.bss 77876 77876 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557114 557114 0 0.0
.app_xip_area 463472 463472 0 0.0
.bss 76372 76372 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577838 577838 0 0.0
.app_xip_area 474764 474764 0 0.0
.bss 85476 85476 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916024 916024 0 0.0
(read/write) 128640 128640 0 0.0
.bss 126592 126592 0 0.0
.data 2048 2048 0 0.0
.text 916016 916016 0 0.0
BRD4161A+rpc (read only) 944716 944716 0 0.0
(read/write) 145556 145556 0 0.0
.bss 143368 143368 0 0.0
.data 2188 2188 0 0.0
.text 944708 944708 0 0.0
lock-app BRD4161A+wf200 (read only) 985968 985968 0 0.0
(read/write) 121020 121020 0 0.0
.bss 119092 119092 0 0.0
.data 1924 1924 0 0.0
.text 985960 985960 0 0.0
window-app BRD4161A (read only) 850288 850288 0 0.0
(read/write) 126544 126544 0 0.0
.bss 124624 124624 0 0.0
.data 1916 1916 0 0.0
.text 850280 850280 0 0.0
esp32 all-clusters-app c3devkit (read only) 952148 952148 0 0.0
(read/write) 1399602 1399602 0 0.0
.dram0.bss 66672 66672 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 199864 199864 0 0.0
.flash.text 952148 952148 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1002271 1002271 0 0.0
(read/write) 465104 465104 0 0.0
.dram0.bss 71824 71824 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 227080 227080 0 0.0
.flash.text 996887 996887 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691628 691628 0 0.0
.bss 77512 77512 0 0.0
.data 1924 1924 0 0.0
.text 606392 606392 0 0.0
lock k32w061+release (read/write) 694716 694716 0 0.0
.bss 77712 77712 0 0.0
.data 1964 1964 0 0.0
.text 609240 609240 0 0.0
linux all-clusters-app debug (read only) 2395457 2395441 -16 -0.0
(read/write) 148400 148400 0 0.0
.bss 62944 62944 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206629 206629 0 0.0
.text 2025794 2025778 -16 -0.0
bridge-app debug+rpc (read only) 1718237 1718237 0 0.0
(read/write) 93664 93664 0 0.0
.bss 48480 48480 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140660 140660 0 0.0
.text 1461749 1461749 0 0.0
chip-tool debug (read only) 8992797 8992781 -16 -0.0
(read/write) 299128 299128 0 0.0
.bss 41024 41024 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 250872 250872 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 480213 480213 0 0.0
.text 7904133 7904117 -16 -0.0
chip-tool-ipv6only arm64 (read only) 8747532 8747500 -32 -0.0
(read/write) 412241 412241 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296568 296568 0 0.0
.dynamic 560 560 0 0.0
.got 51392 51392 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456468 456468 0 0.0
.text 7426660 7426628 -32 -0.0
door-lock-app debug (read only) 1933649 1933649 0 0.0
(read/write) 119800 119800 0 0.0
.bss 51168 51168 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 172412 172412 0 0.0
.text 1612754 1612754 0 0.0
lighting-app debug+rpc (read only) 2063305 2063305 0 0.0
(read/write) 124680 124680 0 0.0
.bss 52128 52128 0 0.0
.data 1408 1408 0 0.0
.data.rel.ro 65696 65696 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 164945 164945 0 0.0
.text 1743746 1743746 0 0.0
ota-provider-app debug (read only) 1865777 1865761 -16 -0.0
(read/write) 115464 115464 0 0.0
.bss 51040 51040 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 157331 157331 0 0.0
.text 1557906 1557890 -16 -0.0
ota-requestor-app debug (read only) 1876985 1876969 -16 -0.0
(read/write) 117200 117200 0 0.0
.bss 51872 51872 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151364 151364 0 0.0
.text 1576786 1576770 -16 -0.0
shell debug (read only) 2363705 2363689 -16 -0.0
(read/write) 150912 150912 0 0.0
.bss 71296 71296 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206674 206674 0 0.0
.text 2000210 2000194 -16 -0.0
thermostat-no-ble arm64 (read only) 2161588 2161556 -32 -0.0
(read/write) 149745 149745 0 0.0
.bss 66433 66433 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132708 132708 0 0.0
.text 1810512 1810480 -32 -0.0
tv-app debug (read only) 2589617 2589601 -16 -0.0
(read/write) 151920 151920 0 0.0
.bss 69120 69120 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 200221 200221 0 0.0
.text 2215346 2215330 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452552 2452552 0 0.0
.bss 194752 194752 0 0.0
.data 5512 5512 0 0.0
.text 1415124 1415124 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2413864 2413864 0 0.0
.bss 188852 188852 0 0.0
.data 5800 5800 0 0.0
.text 1376436 1376436 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349620 2349620 0 0.0
.bss 187756 187756 0 0.0
.data 5776 5776 0 0.0
.text 1312220 1312220 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1155428 1155428 0 0.0
.bss 11952 11952 0 0.0
.data 4512 4512 0 0.0
.text 118812 118812 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2339992 2339992 0 0.0
.bss 186392 186392 0 0.0
.data 5608 5608 0 0.0
.text 1302564 1302564 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1044331 1044331 0 0.0
bss 128856 128856 0 0.0
rodata 138540 138540 0 0.0
text 699724 699724 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1001503 1001503 0 0.0
bss 122092 122092 0 0.0
rodata 115752 115752 0 0.0
text 686156 686156 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967031 967031 0 0.0
bss 119176 119176 0 0.0
rodata 106856 106856 0 0.0
text 662872 662872 0 0.0
nrf52840dongle_nrf52840 (read/write) 1017503 1017503 0 0.0
bss 123140 123140 0 0.0
rodata 115396 115396 0 0.0
text 690808 690808 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904318 904318 0 0.0
bss 119380 119380 0 0.0
rodata 107868 107868 0 0.0
text 595868 595868 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930499 930499 0 0.0
bss 120308 120308 0 0.0
rodata 104540 104540 0 0.0
text 628588 628588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834126 834126 0 0.0
bss 117628 117628 0 0.0
rodata 96572 96572 0 0.0
text 539064 539064 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 501603 501603 0 0.0
bss 52584 52584 0 0.0
rodata 44500 44500 0 0.0
text 342712 342712 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 928759 928759 0 0.0
bss 120040 120040 0 0.0
rodata 103520 103520 0 0.0
text 628016 628016 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 924719 924719 0 0.0
bss 120044 120044 0 0.0
rodata 103216 103216 0 0.0
text 624272 624272 0 0.0
shell nrf52840dk_nrf52840 (read/write) 788643 788643 0 0.0
bss 112360 112360 0 0.0
rodata 74716 74716 0 0.0
text 525452 525452 0 0.0
p6 all-clusters-app default (read/write) 2490728 2490728 0 0.0
.bss 122392 122392 0 0.0
.data 2688 2688 0 0.0
.text 1448992 1448992 0 0.0
light-app default (read/write) 2394856 2394856 0 0.0
.bss 113640 113640 0 0.0
.data 2536 2536 0 0.0
.text 1353120 1353120 0 0.0
lock-app default (read/write) 2358392 2358392 0 0.0
.bss 113392 113392 0 0.0
.data 2496 2496 0 0.0
.text 1316656 1316656 0 0.0
qpg lighting-app qpg6105+debug (read only) 600752 600752 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1124 1124 0 0.0
.text 595432 595432 0 0.0
lock-app qpg6105+debug (read only) 566536 566536 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1076 1076 0 0.0
.text 561216 561216 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 882206 882206 0 0.0
bss 86364 86364 0 0.0
noinit 37160 37160 0 0.0
text 623528 623528 0 0.0

@vivien-apple vivien-apple merged commit e04be15 into project-chip:master Feb 24, 2022
andy31415
andy31415 reviewed Jun 24, 2022
View reviewed changes
src/ble/BtpEngine.cpp
@@ -385,7 +385,7 @@ CHIP_ERROR BtpEngine::HandleCharacteristicReceived(System::PacketBufferHandle &&
}
LogState();

if (!data.IsNull())
if (!data.IsNull()) // NOLINT(bugprone-use-after-move)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a real bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic left review comments

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees

@vivien-apple vivien-apple

Labels
ble lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @bzbarsky-apple @andy31415 @Damian-Nordic