-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --interface-id option to examples/platform/Linux #15411
Merged
andy31415
merged 2 commits into
project-chip:master
from
vivien-apple:Tests_OptionaInterfaceIdArgument
Feb 22, 2022
Merged
Add --interface-id option to examples/platform/Linux #15411
andy31415
merged 2 commits into
project-chip:master
from
vivien-apple:Tests_OptionaInterfaceIdArgument
Feb 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
kghost
February 22, 2022 14:20
pullapprove
bot
requested review from
lazarkov,
LuDuda,
lzgrablic02,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple and
xylophone21
February 22, 2022 14:20
PR #15411: Size comparison from 2b80c6a to bd28e2e Increases above 0.2%:
Increases (40 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
reviewed
Feb 22, 2022
jmeg-sfy
reviewed
Feb 22, 2022
jmeg-sfy
approved these changes
Feb 22, 2022
…oadcast onto the local machine on macos
vivien-apple
force-pushed
the
Tests_OptionaInterfaceIdArgument
branch
from
February 22, 2022 15:29
bd28e2e
to
5866a1a
Compare
PR #15411: Size comparison from 153a564 to 5866a1a Increases above 0.2%:
Increases (40 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is still hard to run tests that relies on mdns on CI, notably because Darwin tests does not run into a network namespace and there is some collisions from advertisement of the outside world.
This PR gives an other attempt at limiting the scope of these advertisements by asking the server to only broadcast onto the local machine.
Change overview
interface-id
argument