Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrfconnect] Fix examples' initialization order #15387

Merged
merged 2 commits into from
Feb 22, 2022
Merged

[nrfconnect] Fix examples' initialization order #15387

merged 2 commits into from
Feb 22, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

While investigating the root cause of #15295 we found out that the initialization code in a lot of examples may be racy as it starts the CHIP thread before initializing all other components.

Change overview

Make sure that all the initialization code in nRF Connect examples happens prior to the point in which the CHIP thread is started to guarantee no data races can occur in that phase.

Testing

I ran all nRF Connect examples on hardware and tried to commission them.

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR #15387: Size comparison from e71be1c to 2863a5d

Full report (14 builds for cyw30739, k32w, linux, p6, qpg, telink)
platform target config section e71be1c3 2863a5d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599502 599502 0 0.0
.app_xip_area 503436 503436 0 0.0
.bss 78764 78764 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557538 557538 0 0.0
.app_xip_area 463016 463016 0 0.0
.bss 77260 77260 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578774 578774 0 0.0
.app_xip_area 474828 474828 0 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 692692 692692 0 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 606596 606596 0 0.0
lock k32w061+release (read/write) 695256 695256 0 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 608904 608904 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8781772 8781772 0 0.0
(read/write) 432641 432641 0 0.0
.bss 58977 58977 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 317776 317776 0 0.0
.dynamic 560 560 0 0.0
.got 50880 50880 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 454596 454596 0 0.0
.text 7412804 7412804 0 0.0
thermostat-no-ble arm64 (read only) 2167740 2167740 0 0.0
(read/write) 151137 151137 0 0.0
.bss 67521 67521 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75384 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134060 0 0.0
.text 1814240 1814240 0 0.0
p6 all-clusters-app default (read/write) 2489048 2489048 0 0.0
.bss 122872 122872 0 0.0
.data 2672 2672 0 0.0
.text 1447312 1447312 0 0.0
light-app default (read/write) 2394600 2394600 0 0.0
.bss 113896 113896 0 0.0
.data 2528 2528 0 0.0
.text 1352864 1352864 0 0.0
lock-app default (read/write) 2358176 2358176 0 0.0
.bss 113648 113648 0 0.0
.data 2488 2488 0 0.0
.text 1316440 1316440 0 0.0
qpg lighting-app qpg6105+debug (read only) 600348 600348 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90944 90944 0 0.0
.data 1112 1112 0 0.0
.text 595028 595028 0 0.0
lock-app qpg6105+debug (read only) 566108 566108 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90952 0 0.0
.data 1064 1064 0 0.0
.text 560788 560788 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878766 878766 0 0.0
bss 87500 87500 0 0.0
noinit 37160 37160 0 0.0
text 618928 618928 0 0.0

woody-apple
woody-apple approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR #15387: Size comparison from e71be1c to 0ae7ec3

Decreases (8 builds for nrfconnect)
platform target config section e71be1c3 0ae7ec3 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023579 1023459 -120 -0.0
rodata 120984 120912 -72 -0.1
text 700044 700004 -40 -0.0
nrf52840dk_nrf52840+rpc (read/write) 992891 992767 -124 -0.0
rodata 112528 112468 -60 -0.1
text 679948 679880 -68 -0.0
nrf52840dongle_nrf52840 (read/write) 1038335 1038179 -156 -0.0
rodata 119816 119756 -60 -0.1
text 703856 703760 -96 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 930190 930070 -120 -0.0
rodata 114240 114168 -72 -0.1
text 615072 615032 -40 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 952343 952239 -104 -0.0
rodata 109820 109748 -72 -0.1
text 642160 642124 -36 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859822 859698 -124 -0.0
rodata 102992 102916 -76 -0.1
text 557964 557928 -36 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 950919 950815 -104 -0.0
rodata 108772 108700 -72 -0.1
text 641980 641944 -36 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946867 946759 -108 -0.0
rodata 108472 108396 -76 -0.1
text 638220 638184 -36 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e71be1c3 0ae7ec3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599502 599502 0 0.0
.app_xip_area 503436 503436 0 0.0
.bss 78764 78764 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557538 557538 0 0.0
.app_xip_area 463016 463016 0 0.0
.bss 77260 77260 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578774 578774 0 0.0
.app_xip_area 474828 474828 0 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916484 916484 0 0.0
(read/write) 129500 129500 0 0.0
.bss 127464 127464 0 0.0
.data 2036 2036 0 0.0
.text 916476 916476 0 0.0
BRD4161A+rpc (read only) 945192 945192 0 0.0
(read/write) 146416 146416 0 0.0
.bss 144240 144240 0 0.0
.data 2176 2176 0 0.0
.text 945184 945184 0 0.0
window-app BRD4161A (read only) 850304 850304 0 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 850296 850296 0 0.0
esp32 all-clusters-app c3devkit (read only) 950408 950408 0 0.0
(read/write) 1400290 1400290 0 0.0
.dram0.bss 67144 67144 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200088 200088 0 0.0
.flash.text 950408 950408 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999903 999903 0 0.0
(read/write) 465560 465560 0 0.0
.dram0.bss 72296 72296 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227072 227072 0 0.0
.flash.text 994519 994519 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692692 692692 0 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 606596 606596 0 0.0
lock k32w061+release (read/write) 695256 695256 0 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 608904 608904 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8781772 8781772 0 0.0
(read/write) 432641 432641 0 0.0
.bss 58977 58977 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 317776 317776 0 0.0
.dynamic 560 560 0 0.0
.got 50880 50880 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 454596 454596 0 0.0
.text 7412804 7412804 0 0.0
thermostat-no-ble arm64 (read only) 2167740 2167740 0 0.0
(read/write) 151137 151137 0 0.0
.bss 67521 67521 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75384 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134060 0 0.0
.text 1814240 1814240 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430660 2430660 0 0.0
.bss 194564 194564 0 0.0
.data 5328 5328 0 0.0
.text 1393232 1393232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392780 2392780 0 0.0
.bss 188432 188432 0 0.0
.data 5632 5632 0 0.0
.text 1355352 1355352 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328224 2328224 0 0.0
.bss 187432 187432 0 0.0
.data 5608 5608 0 0.0
.text 1290824 1290824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319124 2319124 0 0.0
.bss 185980 185980 0 0.0
.data 5440 5440 0 0.0
.text 1281696 1281696 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023579 1023459 -120 -0.0
bss 123528 123528 0 0.0
rodata 120984 120912 -72 -0.1
text 700044 700004 -40 -0.0
nrf52840dk_nrf52840+rpc (read/write) 992891 992767 -124 -0.0
bss 120716 120716 0 0.0
rodata 112528 112468 -60 -0.1
text 679948 679880 -68 -0.0
nrf52840dongle_nrf52840 (read/write) 1038335 1038179 -156 -0.0
bss 124748 124748 0 0.0
rodata 119816 119756 -60 -0.1
text 703856 703760 -96 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 930190 930070 -120 -0.0
bss 120088 120088 0 0.0
rodata 114240 114168 -72 -0.1
text 615072 615032 -40 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 952343 952239 -104 -0.0
bss 121756 121756 0 0.0
rodata 109820 109748 -72 -0.1
text 642160 642124 -36 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859822 859698 -124 -0.0
bss 118348 118348 0 0.0
rodata 102992 102916 -76 -0.1
text 557964 557928 -36 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950919 950815 -104 -0.0
bss 121476 121476 0 0.0
rodata 108772 108700 -72 -0.1
text 641980 641944 -36 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946867 946759 -108 -0.0
bss 121480 121480 0 0.0
rodata 108472 108396 -76 -0.1
text 638220 638184 -36 -0.0
shell nrf52840dk_nrf52840 (read/write) 811543 811543 0 0.0
bss 113324 113324 0 0.0
rodata 79756 79756 0 0.0
text 540812 540812 0 0.0
p6 all-clusters-app default (read/write) 2489048 2489048 0 0.0
.bss 122872 122872 0 0.0
.data 2672 2672 0 0.0
.text 1447312 1447312 0 0.0
light-app default (read/write) 2394600 2394600 0 0.0
.bss 113896 113896 0 0.0
.data 2528 2528 0 0.0
.text 1352864 1352864 0 0.0
lock-app default (read/write) 2358176 2358176 0 0.0
.bss 113648 113648 0 0.0
.data 2488 2488 0 0.0
.text 1316440 1316440 0 0.0
qpg lighting-app qpg6105+debug (read only) 600348 600348 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90944 90944 0 0.0
.data 1112 1112 0 0.0
.text 595028 595028 0 0.0
lock-app qpg6105+debug (read only) 566108 566108 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90952 0 0.0
.data 1064 1064 0 0.0
.text 560788 560788 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878766 878766 0 0.0
bss 87500 87500 0 0.0
noinit 37160 37160 0 0.0
text 618928 618928 0 0.0

@bzbarsky-apple
Copy link
Contributor

/rebase

@Damian-Nordic @bzbarsky-apple
[nrfconnect] Fix examples' initialization order
d046268 
Make sure that all the initialization code happens prior to
the point in which the CHIP thread is started to guarantee
no data races can occur in that phase.

Signed-off-by: Damian Krolik <[email protected]>
@Damian-Nordic @bzbarsky-apple
Fix build on the dongle
c3987a8
@github-actions
Copy link

github-actions bot commented Feb 22, 2022 •
edited
Loading

PR #15387: Size comparison from 3666c5b to c3987a8

Decreases (8 builds for nrfconnect)
platform target config section 3666c5b c3987a8 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1024007 1023883 -124 -0.0
rodata 120964 120888 -76 -0.1
text 700232 700192 -40 -0.0
nrf52840dk_nrf52840+rpc (read/write) 993283 993159 -124 -0.0
rodata 112472 112412 -60 -0.1
text 680136 680068 -68 -0.0
nrf52840dongle_nrf52840 (read/write) 1038747 1038591 -156 -0.0
rodata 119796 119736 -60 -0.1
text 704032 703936 -96 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 930618 930498 -120 -0.0
rodata 114220 114148 -72 -0.1
text 615260 615220 -40 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 952743 952635 -108 -0.0
rodata 109804 109728 -76 -0.1
text 642324 642288 -36 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 860218 860114 -104 -0.0
rodata 102972 102900 -72 -0.1
text 558128 558092 -36 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 951319 951211 -108 -0.0
rodata 108756 108680 -76 -0.1
text 642144 642108 -36 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 947279 947175 -104 -0.0
rodata 108452 108380 -72 -0.1
text 638384 638348 -36 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3666c5b c3987a8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599862 599862 0 0.0
.app_xip_area 503540 503540 0 0.0
.bss 79020 79020 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557906 557906 0 0.0
.app_xip_area 463128 463128 0 0.0
.bss 77516 77516 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 579142 579142 0 0.0
.app_xip_area 474940 474940 0 0.0
.bss 86612 86612 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916644 916644 0 0.0
(read/write) 129760 129760 0 0.0
.bss 127720 127720 0 0.0
.data 2040 2040 0 0.0
.text 916636 916636 0 0.0
BRD4161A+rpc (read only) 945352 945352 0 0.0
(read/write) 146680 146680 0 0.0
.bss 144496 144496 0 0.0
.data 2180 2180 0 0.0
.text 945344 945344 0 0.0
window-app BRD4161A (read only) 850480 850480 0 0.0
(read/write) 127680 127680 0 0.0
.bss 125768 125768 0 0.0
.data 1908 1908 0 0.0
.text 850472 850472 0 0.0
esp32 all-clusters-app c3devkit (read only) 951666 951666 0 0.0
(read/write) 1400210 1400210 0 0.0
.dram0.bss 67208 67208 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 199944 199944 0 0.0
.flash.text 951666 951666 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1001291 1001291 0 0.0
(read/write) 465496 465496 0 0.0
.dram0.bss 72360 72360 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226944 226944 0 0.0
.flash.text 995907 995907 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 693072 693072 0 0.0
.bss 78648 78648 0 0.0
.data 1916 1916 0 0.0
.text 606708 606708 0 0.0
lock k32w061+release (read/write) 695612 695612 0 0.0
.bss 78856 78856 0 0.0
.data 1956 1956 0 0.0
.text 609000 609000 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8863980 8863980 0 0.0
(read/write) 434705 434705 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 319024 319024 0 0.0
.dynamic 560 560 0 0.0
.got 51392 51392 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456468 456468 0 0.0
.text 7489188 7489188 0 0.0
thermostat-no-ble arm64 (read only) 2174844 2174844 0 0.0
(read/write) 151265 151265 0 0.0
.bss 67585 67585 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75408 75408 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133820 133820 0 0.0
.text 1821440 1821440 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2441028 2441028 0 0.0
.bss 195036 195036 0 0.0
.data 5352 5352 0 0.0
.text 1403600 1403600 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2402204 2402204 0 0.0
.bss 189136 189136 0 0.0
.data 5648 5648 0 0.0
.text 1364776 1364776 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337720 2337720 0 0.0
.bss 188136 188136 0 0.0
.data 5624 5624 0 0.0
.text 1300320 1300320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328612 2328612 0 0.0
.bss 186676 186676 0 0.0
.data 5456 5456 0 0.0
.text 1291184 1291184 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1024007 1023883 -124 -0.0
bss 123784 123784 0 0.0
rodata 120964 120888 -76 -0.1
text 700232 700192 -40 -0.0
nrf52840dk_nrf52840+rpc (read/write) 993283 993159 -124 -0.0
bss 120972 120972 0 0.0
rodata 112472 112412 -60 -0.1
text 680136 680068 -68 -0.0
nrf52840dongle_nrf52840 (read/write) 1038747 1038591 -156 -0.0
bss 125004 125004 0 0.0
rodata 119796 119736 -60 -0.1
text 704032 703936 -96 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 930618 930498 -120 -0.0
bss 120344 120344 0 0.0
rodata 114220 114148 -72 -0.1
text 615260 615220 -40 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 952743 952635 -108 -0.0
bss 122012 122012 0 0.0
rodata 109804 109728 -76 -0.1
text 642324 642288 -36 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 860218 860114 -104 -0.0
bss 118604 118604 0 0.0
rodata 102972 102900 -72 -0.1
text 558128 558092 -36 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527567 527567 0 0.0
bss 53632 53632 0 0.0
rodata 49948 49948 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 951319 951211 -108 -0.0
bss 121732 121732 0 0.0
rodata 108756 108680 -76 -0.1
text 642144 642108 -36 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 947279 947175 -104 -0.0
bss 121736 121736 0 0.0
rodata 108452 108380 -72 -0.1
text 638384 638348 -36 -0.0
shell nrf52840dk_nrf52840 (read/write) 811587 811587 0 0.0
bss 113324 113324 0 0.0
rodata 79752 79752 0 0.0
text 540852 540852 0 0.0
p6 all-clusters-app default (read/write) 2490928 2490928 0 0.0
.bss 122936 122936 0 0.0
.data 2680 2680 0 0.0
.text 1449192 1449192 0 0.0
light-app default (read/write) 2394888 2394888 0 0.0
.bss 114184 114184 0 0.0
.data 2528 2528 0 0.0
.text 1353152 1353152 0 0.0
lock-app default (read/write) 2358464 2358464 0 0.0
.bss 113936 113936 0 0.0
.data 2488 2488 0 0.0
.text 1316728 1316728 0 0.0
qpg lighting-app qpg6105+debug (read only) 600452 600452 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91200 91200 0 0.0
.data 1116 1116 0 0.0
.text 595132 595132 0 0.0
lock-app qpg6105+debug (read only) 566212 566212 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91208 91208 0 0.0
.data 1068 1068 0 0.0
.text 560892 560892 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883034 883034 0 0.0
bss 87532 87532 0 0.0
noinit 37160 37160 0 0.0
text 623066 623066 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 944425f into project-chip:master Feb 22, 2022
@Damian-Nordic Damian-Nordic deleted the init-order branch February 22, 2022 07:24
@Damian-Nordic Damian-Nordic mentioned this pull request Feb 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuDuda LuDuda LuDuda approved these changes

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Damian-Nordic @bzbarsky-apple @LuDuda @woody-apple