Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename channel cluster ErrorTypeEnum to StatusEnum #15382

Merged
merged 6 commits into from
Feb 21, 2022
Merged

Rename channel cluster ErrorTypeEnum to StatusEnum #15382

merged 6 commits into from
Feb 21, 2022

Conversation

lazarkov
Copy link
Contributor

@lazarkov lazarkov commented Feb 21, 2022 •
edited
Loading

Problem

  • Channel Cluster response command has a parameter errorTypeEnum, which needs to be renamed to statusEnum.
  • The spec. is also changed under this PR

Issues reported

This PR will resolve this reported issue related to MediaPlayback cluster:
#15089

Change overview

see above

Testing

Run ./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "

@restyled-io restyled-io bot mentioned this pull request Feb 21, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR #15382: Size comparison from e71be1c to eb34817

Decreases (1 build for linux)
platform target config section e71be1c3 eb34817 change % change
linux chip-tool-ipv6only arm64 (read only) 8781772 8781756 -16 -0.0
.rodata 454596 454580 -16 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e71be1c3 eb34817 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599502 599502 0 0.0
.app_xip_area 503436 503436 0 0.0
.bss 78764 78764 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557538 557538 0 0.0
.app_xip_area 463016 463016 0 0.0
.bss 77260 77260 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578774 578774 0 0.0
.app_xip_area 474828 474828 0 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916484 916484 0 0.0
(read/write) 129500 129500 0 0.0
.bss 127464 127464 0 0.0
.data 2036 2036 0 0.0
.text 916476 916476 0 0.0
BRD4161A+rpc (read only) 945192 945192 0 0.0
(read/write) 146416 146416 0 0.0
.bss 144240 144240 0 0.0
.data 2176 2176 0 0.0
.text 945184 945184 0 0.0
window-app BRD4161A (read only) 850304 850304 0 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 850296 850296 0 0.0
esp32 all-clusters-app c3devkit (read only) 950408 950408 0 0.0
(read/write) 1400290 1400290 0 0.0
.dram0.bss 67144 67144 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200088 200088 0 0.0
.flash.text 950408 950408 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999903 999903 0 0.0
(read/write) 465560 465560 0 0.0
.dram0.bss 72296 72296 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227072 227072 0 0.0
.flash.text 994519 994519 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692692 692692 0 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 606596 606596 0 0.0
lock k32w061+release (read/write) 695256 695256 0 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 608904 608904 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8781772 8781756 -16 -0.0
(read/write) 432641 432641 0 0.0
.bss 58977 58977 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 317776 317776 0 0.0
.dynamic 560 560 0 0.0
.got 50880 50880 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 454596 454580 -16 -0.0
.text 7412804 7412804 0 0.0
thermostat-no-ble arm64 (read only) 2167740 2167740 0 0.0
(read/write) 151137 151137 0 0.0
.bss 67521 67521 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75384 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134060 0 0.0
.text 1814240 1814240 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430660 2430660 0 0.0
.bss 194564 194564 0 0.0
.data 5328 5328 0 0.0
.text 1393232 1393232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392780 2392780 0 0.0
.bss 188432 188432 0 0.0
.data 5632 5632 0 0.0
.text 1355352 1355352 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328224 2328224 0 0.0
.bss 187432 187432 0 0.0
.data 5608 5608 0 0.0
.text 1290824 1290824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319124 2319124 0 0.0
.bss 185980 185980 0 0.0
.data 5440 5440 0 0.0
.text 1281696 1281696 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023579 1023579 0 0.0
bss 123528 123528 0 0.0
rodata 120984 120984 0 0.0
text 700044 700044 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 992891 992891 0 0.0
bss 120716 120716 0 0.0
rodata 112528 112528 0 0.0
text 679948 679948 0 0.0
nrf52840dongle_nrf52840 (read/write) 1038335 1038335 0 0.0
bss 124748 124748 0 0.0
rodata 119816 119816 0 0.0
text 703856 703856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 930190 930190 0 0.0
bss 120088 120088 0 0.0
rodata 114240 114240 0 0.0
text 615072 615072 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952343 952343 0 0.0
bss 121756 121756 0 0.0
rodata 109820 109820 0 0.0
text 642160 642160 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859822 859822 0 0.0
bss 118348 118348 0 0.0
rodata 102992 102992 0 0.0
text 557964 557964 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950919 950919 0 0.0
bss 121476 121476 0 0.0
rodata 108772 108772 0 0.0
text 641980 641980 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946867 946867 0 0.0
bss 121480 121480 0 0.0
rodata 108472 108472 0 0.0
text 638220 638220 0 0.0
shell nrf52840dk_nrf52840 (read/write) 811543 811543 0 0.0
bss 113324 113324 0 0.0
rodata 79756 79756 0 0.0
text 540812 540812 0 0.0
p6 all-clusters-app default (read/write) 2489048 2489048 0 0.0
.bss 122872 122872 0 0.0
.data 2672 2672 0 0.0
.text 1447312 1447312 0 0.0
light-app default (read/write) 2394600 2394600 0 0.0
.bss 113896 113896 0 0.0
.data 2528 2528 0 0.0
.text 1352864 1352864 0 0.0
lock-app default (read/write) 2358176 2358176 0 0.0
.bss 113648 113648 0 0.0
.data 2488 2488 0 0.0
.text 1316440 1316440 0 0.0
qpg lighting-app qpg6105+debug (read only) 600348 600348 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90944 90944 0 0.0
.data 1112 1112 0 0.0
.text 595028 595028 0 0.0
lock-app qpg6105+debug (read only) 566108 566108 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90952 0 0.0
.data 1064 1064 0 0.0
.text 560788 560788 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878766 878766 0 0.0
bss 87500 87500 0 0.0
noinit 37160 37160 0 0.0
text 618928 618928 0 0.0

@lazarkov lazarkov added review - pending tv TV-related features labels Feb 21, 2022
@lazarkov lazarkov self-assigned this Feb 21, 2022
@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR #15382: Size comparison from e71be1c to 7e9d6a6

Increases above 0.2%:

platform target config section e71be1c3 7e9d6a6 change % change
linux chip-tool-ipv6only arm64 (read only) 8781772 8828412 46640 0.5
.got 50880 51184 304 0.6
.text 7412804 7456308 43504 0.6
Increases (1 build for linux)
platform target config section e71be1c3 7e9d6a6 change % change
linux chip-tool-ipv6only arm64 (read only) 8781772 8828412 46640 0.5
(read/write) 432641 433521 880 0.2
.data.rel.ro 317776 318352 576 0.2
.got 50880 51184 304 0.6
.rodata 454596 455668 1072 0.2
.text 7412804 7456308 43504 0.6
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e71be1c3 7e9d6a6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599502 599502 0 0.0
.app_xip_area 503436 503436 0 0.0
.bss 78764 78764 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557538 557538 0 0.0
.app_xip_area 463016 463016 0 0.0
.bss 77260 77260 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578774 578774 0 0.0
.app_xip_area 474828 474828 0 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916484 916484 0 0.0
(read/write) 129500 129500 0 0.0
.bss 127464 127464 0 0.0
.data 2036 2036 0 0.0
.text 916476 916476 0 0.0
BRD4161A+rpc (read only) 945192 945192 0 0.0
(read/write) 146416 146416 0 0.0
.bss 144240 144240 0 0.0
.data 2176 2176 0 0.0
.text 945184 945184 0 0.0
window-app BRD4161A (read only) 850304 850304 0 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 850296 850296 0 0.0
esp32 all-clusters-app c3devkit (read only) 950408 950408 0 0.0
(read/write) 1400290 1400290 0 0.0
.dram0.bss 67144 67144 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200088 200088 0 0.0
.flash.text 950408 950408 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999903 999903 0 0.0
(read/write) 465560 465560 0 0.0
.dram0.bss 72296 72296 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227072 227072 0 0.0
.flash.text 994519 994519 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692692 692692 0 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 606596 606596 0 0.0
lock k32w061+release (read/write) 695256 695256 0 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 608904 608904 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8781772 8828412 46640 0.5
(read/write) 432641 433521 880 0.2
.bss 58977 58977 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 317776 318352 576 0.2
.dynamic 560 560 0 0.0
.got 50880 51184 304 0.6
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 454596 455668 1072 0.2
.text 7412804 7456308 43504 0.6
thermostat-no-ble arm64 (read only) 2167740 2167740 0 0.0
(read/write) 151137 151137 0 0.0
.bss 67521 67521 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75384 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134060 0 0.0
.text 1814240 1814240 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430660 2430660 0 0.0
.bss 194564 194564 0 0.0
.data 5328 5328 0 0.0
.text 1393232 1393232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392780 2392780 0 0.0
.bss 188432 188432 0 0.0
.data 5632 5632 0 0.0
.text 1355352 1355352 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328224 2328224 0 0.0
.bss 187432 187432 0 0.0
.data 5608 5608 0 0.0
.text 1290824 1290824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319124 2319124 0 0.0
.bss 185980 185980 0 0.0
.data 5440 5440 0 0.0
.text 1281696 1281696 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023579 1023579 0 0.0
bss 123528 123528 0 0.0
rodata 120984 120984 0 0.0
text 700044 700044 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 992891 992891 0 0.0
bss 120716 120716 0 0.0
rodata 112528 112528 0 0.0
text 679948 679948 0 0.0
nrf52840dongle_nrf52840 (read/write) 1038335 1038335 0 0.0
bss 124748 124748 0 0.0
rodata 119816 119816 0 0.0
text 703856 703856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 930190 930190 0 0.0
bss 120088 120088 0 0.0
rodata 114240 114240 0 0.0
text 615072 615072 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952343 952343 0 0.0
bss 121756 121756 0 0.0
rodata 109820 109820 0 0.0
text 642160 642160 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859822 859822 0 0.0
bss 118348 118348 0 0.0
rodata 102992 102992 0 0.0
text 557964 557964 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950919 950919 0 0.0
bss 121476 121476 0 0.0
rodata 108772 108772 0 0.0
text 641980 641980 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946867 946867 0 0.0
bss 121480 121480 0 0.0
rodata 108472 108472 0 0.0
text 638220 638220 0 0.0
shell nrf52840dk_nrf52840 (read/write) 811543 811543 0 0.0
bss 113324 113324 0 0.0
rodata 79756 79756 0 0.0
text 540812 540812 0 0.0
p6 all-clusters-app default (read/write) 2489048 2489048 0 0.0
.bss 122872 122872 0 0.0
.data 2672 2672 0 0.0
.text 1447312 1447312 0 0.0
light-app default (read/write) 2394600 2394600 0 0.0
.bss 113896 113896 0 0.0
.data 2528 2528 0 0.0
.text 1352864 1352864 0 0.0
lock-app default (read/write) 2358176 2358176 0 0.0
.bss 113648 113648 0 0.0
.data 2488 2488 0 0.0
.text 1316440 1316440 0 0.0
qpg lighting-app qpg6105+debug (read only) 600348 600348 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90944 90944 0 0.0
.data 1112 1112 0 0.0
.text 595028 595028 0 0.0
lock-app qpg6105+debug (read only) 566108 566108 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90952 0 0.0
.data 1064 1064 0 0.0
.text 560788 560788 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878766 878766 0 0.0
bss 87500 87500 0 0.0
noinit 37160 37160 0 0.0
text 618928 618928 0 0.0

@lazarkov lazarkov added the TE8 label Feb 21, 2022
@woody-apple woody-apple merged commit 292e148 into project-chip:master Feb 21, 2022
@lazarkov lazarkov deleted the feature/update-channel-cluster branch February 21, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@lazarkov lazarkov

Labels
app controller darwin examples review - approved tv TV-related features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazarkov @woody-apple @Damian-Nordic