Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples/chip-tool/README.md about the correct arguments to used … #1537

Conversation

vivien-apple
Copy link
Contributor

…for CHIP commands

Problem

Readme seems out of date.

Summary of Changes

  • Change the Readme
  • I have also use the #define for the min/max values.

command to send. Right now the "off", "on", and "toggle" commands are supported,
from the On/Off cluster.
the IP address and port of the server to talk to, the name of the command to
send, as well as and enpoint id. Right now the "off", "on", and "toggle"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "as well as an endpoint id"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@BroderickCarlin BroderickCarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling nit, otherwise LGTM

@vivien-apple vivien-apple force-pushed the Docs_FixTheChipDocForChipCommands branch from eac7ff7 to c7cfb9e Compare July 9, 2020 22:29
@woody-apple woody-apple merged commit 034e631 into project-chip:master Jul 9, 2020
jmartinez-silabs added a commit to SiliconLabs/matter that referenced this pull request Feb 15, 2024
…isisoning command on apps that had the featuremap to AdministratoreCommissioning cluster (project-chip#31877)

Merge in WMN_TOOLS/matter from cp/disable_bcw to RC_2.3.0-1.3

Squashed commit of the following:

commit a3c7ae8fb451fde73a898621ee726081eb15de59
Author: Junior Martinez <[email protected]>
Date:   Fri Feb 2 14:45:37 2024 -0500

    Disable open basic commisisoning command on apps that had the featuremap to AdministratoreCommissioning cluster (project-chip#31877)
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
…isisoning command on apps that had the featuremap to AdministratoreCommissioning cluster (project-chip#31877)

Merge in WMN_TOOLS/matter from cp/disable_bcw to RC_2.3.0-1.3

Squashed commit of the following:

commit a3c7ae8fb451fde73a898621ee726081eb15de59
Author: Junior Martinez <[email protected]>
Date:   Fri Feb 2 14:45:37 2024 -0500

    Disable open basic commisisoning command on apps that had the featuremap to AdministratoreCommissioning cluster (project-chip#31877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants