Fix exchange delegate for post-subscription #15339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google and
mrjerryjohns
pullapprove
bot
requested review from
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
bzbarsky-apple
approved these changes
Feb 18, 2022
|
PR #15339: Size comparison from 90e379e to 67d9baa Increases (16 builds for cyw30739, esp32, linux, nrfconnect, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Feb 18, 2022
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Feb 19, 2022
-- Add automatic test where initial chunked report has been received by read client during post-subscription, and exchange context and delegate has been passed from interaction model engine to read client, we expire the session so that the further chunked report cannot be receive by client so that onResponseTimeout is triggered from readClient.
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Feb 19, 2022
-- Add automatic test where initial chunked report has been received by read client during post-subscription, and exchange context and delegate has been passed from interaction model engine to read client, we expire the session so that the further chunked report cannot be receive by client so that onResponseTimeout is triggered from readClient.
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Feb 19, 2022
--SetResponseTimeout when it is subscribe or in chunked procedure --Call OnReportConfirm in MoveToState when state is IsAwaitingReportResponsee add missing test from PR #project-chip#15339 -- Add automatic test where initial chunked report has been received by read client during post-subscription, and exchange context and delegate has been passed from interaction model engine to read client, we expire the session so that the further chunked report cannot be receive by client so that onResponseTimeout is triggered from readClient.
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Feb 19, 2022
--SetResponseTimeout when it is subscribe or in chunked procedure --Call OnReportConfirm in MoveToState when state is IsAwaitingReportResponsee add missing test from PR #project-chip#15339 -- Add automatic test where initial chunked report has been received by read client during post-subscription, and exchange context and delegate has been passed from interaction model engine to read client, we expire the session so that the further chunked report cannot be receive by client so that onResponseTimeout is triggered from readClient.
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Feb 22, 2022
--SetResponseTimeout when it is subscribe or in chunked procedure --Call OnReportConfirm in MoveToState when state is IsAwaitingReportResponsee add missing test from PR #project-chip#15339 -- Add automatic test where initial chunked report has been received by read client during post-subscription, and exchange context and delegate has been passed from interaction model engine to read client, we expire the session so that the further chunked report cannot be receive by client so that onResponseTimeout is triggered from readClient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, after unsolicited report is received by InteractionModelEngine and further readClient during post-subscription , the delegate is still from InteractionModelEngine, when response is timeout, the InteractionModelEngine's delegate take effective, we expect read client's exchange delegate takes effective.
Change overview
Fix exchange delegate when processing unsolicted report in read client
Testing
Still working on automatic test