Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mdns leak on android #15292

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Conversation

xylophone21
Copy link
Collaborator

Problem

  • sometimes, mdns service may not be found on Android TV
    • it is because we forget to clear the listeners list in removeServices
    • so next time when we call removeServices again, we will get unregisterService exception, and all other listeners are not unregistered
    • and then we will get listeners leak, until we can not register more and failed to register

Change overview

  • add registrationListeners.clear(); and catch unregister exception

Testing

  • chip-tool pairing

@github-actions
Copy link

github-actions bot commented Feb 17, 2022

PR #15292: Size comparison from 18a6458 to 700dd5a

Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 18a6458 700dd5a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 597578 597578 0 0.0
.app_xip_area 501496 501496 0 0.0
.bss 78780 78780 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555526 555526 0 0.0
.app_xip_area 461012 461012 0 0.0
.bss 77252 77252 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576630 576630 0 0.0
.app_xip_area 472684 472684 0 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914580 914580 0 0.0
(read/write) 129524 129524 0 0.0
.bss 127488 127488 0 0.0
.data 2036 2036 0 0.0
.text 914572 914572 0 0.0
BRD4161A+rpc (read only) 943272 943272 0 0.0
(read/write) 146440 146440 0 0.0
.bss 144264 144264 0 0.0
.data 2176 2176 0 0.0
.text 943264 943264 0 0.0
window-app BRD4161A (read only) 848440 848440 0 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 848432 848432 0 0.0
esp32 all-clusters-app c3devkit (read only) 948530 948530 0 0.0
(read/write) 1401266 1401266 0 0.0
.dram0.bss 68504 68504 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 199704 199704 0 0.0
.flash.text 948530 948530 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 998091 998091 0 0.0
(read/write) 466512 466512 0 0.0
.dram0.bss 73640 73640 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226680 226680 0 0.0
.flash.text 992707 992707 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691596 691596 0 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 605500 605500 0 0.0
lock k32w061+release (read/write) 694228 694228 0 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 607876 607876 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8333332 8333332 0 0.0
(read/write) 362609 362609 0 0.0
.bss 58961 58961 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249368 249368 0 0.0
.dynamic 560 560 0 0.0
.got 49272 49272 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435820 435820 0 0.0
.text 7134820 7134820 0 0.0
thermostat-no-ble arm64 (read only) 2163132 2163132 0 0.0
(read/write) 150737 150737 0 0.0
.bss 67489 67489 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 133596 133596 0 0.0
.text 1810912 1810912 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2428756 2428756 0 0.0
.bss 195916 195916 0 0.0
.data 5328 5328 0 0.0
.text 1391328 1391328 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391956 2391956 0 0.0
.bss 188448 188448 0 0.0
.data 5632 5632 0 0.0
.text 1354528 1354528 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327408 2327408 0 0.0
.bss 187424 187424 0 0.0
.data 5608 5608 0 0.0
.text 1290008 1290008 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2318172 2318172 0 0.0
.bss 185972 185972 0 0.0
.data 5440 5440 0 0.0
.text 1280744 1280744 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022539 1022539 0 0.0
bss 123548 123548 0 0.0
rodata 120664 120664 0 0.0
text 699328 699328 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 991835 991835 0 0.0
bss 120736 120736 0 0.0
rodata 112192 112192 0 0.0
text 679228 679228 0 0.0
nrf52840dongle_nrf52840 (read/write) 1037359 1037359 0 0.0
bss 124768 124768 0 0.0
rodata 119480 119480 0 0.0
text 703216 703216 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929154 929154 0 0.0
bss 120112 120112 0 0.0
rodata 113908 113908 0 0.0
text 614340 614340 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 951243 951243 0 0.0
bss 121752 121752 0 0.0
rodata 109360 109360 0 0.0
text 641516 641516 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858706 858706 0 0.0
bss 118344 118344 0 0.0
rodata 102532 102532 0 0.0
text 557308 557308 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949695 949695 0 0.0
bss 121472 121472 0 0.0
rodata 108316 108316 0 0.0
text 641336 641336 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945767 945767 0 0.0
bss 121476 121476 0 0.0
rodata 108012 108012 0 0.0
text 637576 637576 0 0.0
shell nrf52840dk_nrf52840 (read/write) 810767 810767 0 0.0
bss 113324 113324 0 0.0
rodata 79348 79348 0 0.0
text 540444 540444 0 0.0
p6 all-clusters-app default (read/write) 2486304 2486304 0 0.0
.bss 124232 124232 0 0.0
.data 2672 2672 0 0.0
.text 1444568 1444568 0 0.0
light-app default (read/write) 2393192 2393192 0 0.0
.bss 113912 113912 0 0.0
.data 2528 2528 0 0.0
.text 1351456 1351456 0 0.0
lock-app default (read/write) 2356656 2356656 0 0.0
.bss 113640 113640 0 0.0
.data 2488 2488 0 0.0
.text 1314920 1314920 0 0.0
qpg lighting-app qpg6105+debug (read only) 599068 599068 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90744 90744 0 0.0
.data 1112 1112 0 0.0
.text 593748 593748 0 0.0
lock-app qpg6105+debug (read only) 564700 564700 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90728 90728 0 0.0
.data 1064 1064 0 0.0
.text 559380 559380 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877890 877890 0 0.0
bss 87520 87520 0 0.0
noinit 37160 37160 0 0.0
text 618302 618302 0 0.0

@lazarkov lazarkov merged commit f2b344c into project-chip:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants