-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send OnSessionEstablishmentError if pairing in progress during shutdown #15282
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
s-mcclain:abort-pairing-during-shutdown
Feb 18, 2022
Merged
Send OnSessionEstablishmentError if pairing in progress during shutdown #15282
bzbarsky-apple
merged 2 commits into
project-chip:master
from
s-mcclain:abort-pairing-during-shutdown
Feb 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
lzgrablic02,
mrjerryjohns and
msandstedt
February 16, 2022 22:50
pullapprove
bot
requested review from
mspang,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 16, 2022 22:50
woody-apple
approved these changes
Feb 16, 2022
PR #15282: Size comparison from 72896fc to ed5d3b0 Increases (1 build for linux)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 17, 2022
chrisdecenzo
approved these changes
Feb 17, 2022
LuDuda
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed?
Change overview
During Commissioner's Shutdown, if session setup is in-progress, call an OnSessionEstablishmentError to clean up the ContextExchange prior to continuing shutdown. Otherwise, the pairing exchange will remain inside ExchangeMgr's mContextPool and signal SIGABRT.
Testing
How was this tested? (at least one bullet point required)