-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZAP helper for detecting fabric-scoped structs. #15281
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fabric-scoped-type-helper
Feb 17, 2022
Merged
Add ZAP helper for detecting fabric-scoped structs. #15281
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fabric-scoped-type-helper
Feb 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to condition some codegen on whether a type is a fabric-scoped struct.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
msandstedt
February 16, 2022 22:19
pullapprove
bot
requested review from
mspang,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
February 16, 2022 22:19
mrjerryjohns
approved these changes
Feb 16, 2022
PR #15281: Size comparison from 72896fc to 89ec203 Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
We want to condition some codegen on whether a type is a fabric-scoped struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to condition some codegen on whether a type is a fabric-scoped
struct.
Problem
Can't do special fabric-y things for fabric-scoped stuff easily in codegen.
Change overview
Add a way to do it ... if not easily, then at least somewhat.
Testing
Checked that if I do this for event fields it catches just the ACL event bits that use fabric-scoped structs.