-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdns] Show interface on mDns failures. #15266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - this will be quite helpful.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
/rebase |
PR #15266: Size comparison from 1ccc2af to cdbdbaf Increases above 0.2%:
Increases (18 builds for efr32, esp32, linux, mbed, nrfconnect, p6)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #15266: Size comparison from 1f458a5 to cc0659e Increases (3 builds for linux, mbed)
Full report (10 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
PR #15266: Size comparison from 1f458a5 to c09ed6a Full report (7 builds for cyw30739, k32w, nrfconnect, telink)
|
PR #15266: Size comparison from 1f458a5 to 8f7a563 Increases (8 builds for esp32, linux, mbed, p6)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #15266: Size comparison from 645b03b to 758eb75 Increases (17 builds for esp32, linux, mbed, p6)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
* [mdns] Show interface on mDns failures. * [log] Deescalate bad interface log from error to detail. * [mdns] Comment resolution. * [mdns] Handle interface name error. * [restyle]
Problem
chip-tool can fail to contact a node with the primary error log looking to blame mdns:
Change overview
Extend the log to display the interface name, so it is easier to see that the error is on a non-essential interface for reachability and can be ignored.
Testing
Manually on local environment and CI