Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for turning off fabric-filtering to YAML. #15162

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Add support for turning off fabric-filtering to YAML. #15162

merged 1 commit into from
Feb 15, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Allows listing "fabricFiltered: false" on a read or subscribe to get a
non-fabric-filtered read/subscribe.

Defaults to fabric-filtered if not otherwise specified.

Supported in chip-tool YAML, not yet in Darwin YAML pending the Darwin
framework growing APIs to support non-fabric-filtered reads.

Problem

Can't do a non-fabric-filtered read in YAML.

Change overview

Add a way to do it.

Testing

Added some reads without fabricFiltered, with fabricFiltered: true, and with fabricFiltered: false and verified that the server sees isFabricFiltered = true, isFabricFiltered = true, isFabricFiltered = false respectively.

Once we have working multi-fabric bits in YAML, we can add an automatic test that exercises this.

@github-actions
Copy link

github-actions bot commented Feb 14, 2022 •
edited
Loading

PR #15162: Size comparison from f32685f to ddcde72

Increases above 0.2%:

platform target config section f32685f ddcde72 change % change
linux chip-tool debug (read only) 8443341 8466477 23136 0.3
.text 7468437 7491573 23136 0.3
Increases (2 builds for linux)
platform target config section f32685f ddcde72 change % change
linux chip-tool debug (read only) 8443341 8466477 23136 0.3
.text 7468437 7491573 23136 0.3
chip-tool-ipv6only arm64 (read only) 8245572 8261348 15776 0.2
.text 7049028 7064804 15776 0.2
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f32685f ddcde72 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 592462 592462 0 0.0
.app_xip_area 498164 498164 0 0.0
.bss 76996 76996 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 550522 550522 0 0.0
.app_xip_area 457792 457792 0 0.0
.bss 75468 75468 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569034 569034 0 0.0
.app_xip_area 467048 467048 0 0.0
.bss 84396 84396 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909056 909056 0 0.0
(read/write) 127160 127160 0 0.0
.bss 125128 125128 0 0.0
.data 2032 2032 0 0.0
.text 909048 909048 0 0.0
BRD4161A+rpc (read only) 937752 937752 0 0.0
(read/write) 144080 144080 0 0.0
.bss 141904 141904 0 0.0
.data 2172 2172 0 0.0
.text 937744 937744 0 0.0
window-app BRD4161A (read only) 844244 844244 0 0.0
(read/write) 125220 125220 0 0.0
.bss 123320 123320 0 0.0
.data 1900 1900 0 0.0
.text 844236 844236 0 0.0
esp32 all-clusters-app c3devkit (read only) 944980 944980 0 0.0
(read/write) 1398370 1398370 0 0.0
.dram0.bss 66168 66168 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199032 199032 0 0.0
.flash.text 944980 944980 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 994991 994991 0 0.0
(read/write) 463656 463656 0 0.0
.dram0.bss 71312 71312 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226152 226152 0 0.0
.flash.text 989607 989607 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 682980 682980 0 0.0
.bss 76432 76432 0 0.0
.data 1904 1904 0 0.0
.text 598844 598844 0 0.0
lock k32w061+release (read/write) 688532 688532 0 0.0
.bss 76824 76824 0 0.0
.data 1948 1948 0 0.0
.text 603960 603960 0 0.0
linux all-clusters-app debug (read only) 2357297 2357297 0 0.0
(read/write) 140128 140128 0 0.0
.bss 54656 54656 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205637 205637 0 0.0
.text 1989314 1989314 0 0.0
bridge-app debug+rpc (read only) 1726381 1726381 0 0.0
(read/write) 84200 84200 0 0.0
.bss 38928 38928 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141676 141676 0 0.0
.text 1468085 1468085 0 0.0
chip-tool debug (read only) 8443341 8466477 23136 0.3
(read/write) 245376 245376 0 0.0
.bss 31816 31816 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206352 206352 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 459317 459317 0 0.0
.text 7468437 7491573 23136 0.3
chip-tool-ipv6only arm64 (read only) 8245572 8261348 15776 0.2
(read/write) 352993 352993 0 0.0
.bss 50113 50113 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 248800 248800 0 0.0
.dynamic 560 560 0 0.0
.got 49064 49064 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 435276 435276 0 0.0
.text 7049028 7064804 15776 0.2
door-lock-app debug (read only) 1931633 1931633 0 0.0
(read/write) 110104 110104 0 0.0
.bss 41616 41616 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62080 62080 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173074 173074 0 0.0
.text 1609970 1609970 0 0.0
lighting-app debug+rpc (read only) 2055281 2055281 0 0.0
(read/write) 115448 115448 0 0.0
.bss 42720 42720 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165393 165393 0 0.0
.text 1735074 1735074 0 0.0
ota-provider-app debug (read only) 1864433 1864433 0 0.0
(read/write) 105848 105848 0 0.0
.bss 41504 41504 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157643 157643 0 0.0
.text 1556130 1556130 0 0.0
ota-requestor-app debug (read only) 1859857 1859857 0 0.0
(read/write) 106904 106904 0 0.0
.bss 41760 41760 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58536 58536 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151196 151196 0 0.0
.text 1559746 1559746 0 0.0
shell debug (read only) 2341545 2341545 0 0.0
(read/write) 141616 141616 0 0.0
.bss 61920 61920 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73192 73192 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206482 206482 0 0.0
.text 1978210 1978210 0 0.0
thermostat-no-ble arm64 (read only) 2151148 2151148 0 0.0
(read/write) 140337 140337 0 0.0
.bss 57169 57169 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132908 132908 0 0.0
.text 1799984 1799984 0 0.0
tv-app debug (read only) 2529193 2529193 0 0.0
(read/write) 140960 140960 0 0.0
.bss 58720 58720 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197477 197477 0 0.0
.text 2158674 2158674 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2398112 2398112 0 0.0
.bss 188252 188252 0 0.0
.data 5320 5320 0 0.0
.text 1360712 1360712 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360344 2360344 0 0.0
.bss 180864 180864 0 0.0
.data 5624 5624 0 0.0
.text 1322944 1322944 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323872 2323872 0 0.0
.bss 180752 180752 0 0.0
.data 5600 5600 0 0.0
.text 1286472 1286472 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308900 2308900 0 0.0
.bss 178004 178004 0 0.0
.data 5424 5424 0 0.0
.text 1271472 1271472 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015827 1015827 0 0.0
bss 121188 121188 0 0.0
rodata 120096 120096 0 0.0
text 695616 695616 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 985103 985103 0 0.0
bss 118376 118376 0 0.0
rodata 111620 111620 0 0.0
text 675508 675508 0 0.0
nrf52840dongle_nrf52840 (read/write) 1031687 1031687 0 0.0
bss 122576 122576 0 0.0
rodata 118976 118976 0 0.0
text 700236 700236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 922502 922502 0 0.0
bss 117752 117752 0 0.0
rodata 113336 113336 0 0.0
text 610636 610636 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 945683 945683 0 0.0
bss 119560 119560 0 0.0
rodata 108856 108856 0 0.0
text 638652 638652 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853114 853114 0 0.0
bss 116152 116152 0 0.0
rodata 102028 102028 0 0.0
text 554444 554444 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 944375 944375 0 0.0
bss 119280 119280 0 0.0
rodata 107812 107812 0 0.0
text 638708 638708 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 940335 940335 0 0.0
bss 119284 119284 0 0.0
rodata 107508 107508 0 0.0
text 634948 634948 0 0.0
shell nrf52840dk_nrf52840 (read/write) 807147 807147 0 0.0
bss 111216 111216 0 0.0
rodata 79104 79104 0 0.0
text 539244 539244 0 0.0
p6 all-clusters-app default (read/write) 2483200 2483200 0 0.0
.bss 117520 117520 0 0.0
.data 2672 2672 0 0.0
.text 1441464 1441464 0 0.0
light-app default (read/write) 2390016 2390016 0 0.0
.bss 107168 107168 0 0.0
.data 2520 2520 0 0.0
.text 1348280 1348280 0 0.0
lock-app default (read/write) 2353480 2353480 0 0.0
.bss 106888 106888 0 0.0
.data 2480 2480 0 0.0
.text 1311744 1311744 0 0.0
qpg lighting-app qpg6105+debug (read only) 594996 594996 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88824 88824 0 0.0
.data 1108 1108 0 0.0
.text 589676 589676 0 0.0
lock-app qpg6105+debug (read only) 560732 560732 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88808 88808 0 0.0
.data 1060 1060 0 0.0
.text 555412 555412 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874782 874782 0 0.0
bss 88496 88496 0 0.0
noinit 37160 37160 0 0.0
text 614746 614746 0 0.0

@bzbarsky-apple
Add support for turning off fabric-filtering to YAML.
47e2151 
Allows listing "fabricFiltered: false" on a read or subscribe to get a
non-fabric-filtered read/subscribe.

Defaults to fabric-filtered if not otherwise specified.

Supported in chip-tool YAML, not yet in Darwin YAML pending the Darwin
framework growing APIs to support non-fabric-filtered reads.
@github-actions
Copy link

github-actions bot commented Feb 15, 2022 •
edited
Loading

PR #15162: Size comparison from 6ad78e2 to 47e2151

Increases above 0.2%:

platform target config section 6ad78e2 47e2151 change % change
linux chip-tool debug (read only) 8550773 8575237 24464 0.3
.text 7574869 7599237 24368 0.3
Increases (2 builds for linux)
platform target config section 6ad78e2 47e2151 change % change
linux chip-tool debug (read only) 8550773 8575237 24464 0.3
(read/write) 245888 245952 64 0.0
.data.rel.ro 206832 206896 64 0.0
.text 7574869 7599237 24368 0.3
chip-tool-ipv6only arm64 (read only) 8311060 8328164 17104 0.2
(read/write) 353649 353729 80 0.0
.data.rel.ro 249304 249368 64 0.0
.got 49224 49240 16 0.0
.text 7113076 7130036 16960 0.2
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6ad78e2 47e2151 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 593150 593150 0 0.0
.app_xip_area 498772 498772 0 0.0
.bss 77076 77076 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 551210 551210 0 0.0
.app_xip_area 458400 458400 0 0.0
.bss 75548 75548 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569726 569726 0 0.0
.app_xip_area 467660 467660 0 0.0
.bss 84476 84476 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909912 909912 0 0.0
(read/write) 127240 127240 0 0.0
.bss 125208 125208 0 0.0
.data 2032 2032 0 0.0
.text 909904 909904 0 0.0
BRD4161A+rpc (read only) 938632 938632 0 0.0
(read/write) 144160 144160 0 0.0
.bss 141984 141984 0 0.0
.data 2172 2172 0 0.0
.text 938624 938624 0 0.0
window-app BRD4161A (read only) 845156 845156 0 0.0
(read/write) 125300 125300 0 0.0
.bss 123400 123400 0 0.0
.data 1900 1900 0 0.0
.text 845148 845148 0 0.0
esp32 all-clusters-app c3devkit (read only) 945792 945792 0 0.0
(read/write) 1398562 1398562 0 0.0
.dram0.bss 66248 66248 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199144 199144 0 0.0
.flash.text 945792 945792 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 995651 995651 0 0.0
(read/write) 463840 463840 0 0.0
.dram0.bss 71392 71392 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226256 226256 0 0.0
.flash.text 990267 990267 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683848 683848 0 0.0
.bss 76512 76512 0 0.0
.data 1904 1904 0 0.0
.text 599632 599632 0 0.0
lock k32w061+release (read/write) 689396 689396 0 0.0
.bss 76904 76904 0 0.0
.data 1948 1948 0 0.0
.text 604744 604744 0 0.0
linux all-clusters-app debug (read only) 2361649 2361649 0 0.0
(read/write) 140288 140288 0 0.0
.bss 54816 54816 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205861 205861 0 0.0
.text 1993442 1993442 0 0.0
bridge-app debug+rpc (read only) 1727965 1727965 0 0.0
(read/write) 84200 84200 0 0.0
.bss 38928 38928 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141836 141836 0 0.0
.text 1469509 1469509 0 0.0
chip-tool debug (read only) 8550773 8575237 24464 0.3
(read/write) 245888 245952 64 0.0
.bss 31816 31816 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206832 206896 64 0.0
.dynamic 608 608 0 0.0
.got 4792 4792 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 459509 459509 0 0.0
.text 7574869 7599237 24368 0.3
chip-tool-ipv6only arm64 (read only) 8311060 8328164 17104 0.2
(read/write) 353649 353729 80 0.0
.bss 50113 50113 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249304 249368 64 0.0
.dynamic 560 560 0 0.0
.got 49224 49240 16 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 435500 435500 0 0.0
.text 7113076 7130036 16960 0.2
door-lock-app debug (read only) 1933265 1933265 0 0.0
(read/write) 110104 110104 0 0.0
.bss 41616 41616 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62080 62080 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173298 173298 0 0.0
.text 1611378 1611378 0 0.0
lighting-app debug+rpc (read only) 2056945 2056945 0 0.0
(read/write) 115448 115448 0 0.0
.bss 42720 42720 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165649 165649 0 0.0
.text 1736482 1736482 0 0.0
ota-provider-app debug (read only) 1866049 1866049 0 0.0
(read/write) 105848 105848 0 0.0
.bss 41504 41504 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157835 157835 0 0.0
.text 1557554 1557554 0 0.0
ota-requestor-app debug (read only) 1861489 1861489 0 0.0
(read/write) 106904 106904 0 0.0
.bss 41760 41760 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58536 58536 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151420 151420 0 0.0
.text 1561154 1561154 0 0.0
shell debug (read only) 2343209 2343209 0 0.0
(read/write) 141616 141616 0 0.0
.bss 61920 61920 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73192 73192 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206738 206738 0 0.0
.text 1979618 1979618 0 0.0
thermostat-no-ble arm64 (read only) 2152684 2152684 0 0.0
(read/write) 140337 140337 0 0.0
.bss 57169 57169 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 133020 133020 0 0.0
.text 1801408 1801408 0 0.0
tv-app debug (read only) 2530809 2530809 0 0.0
(read/write) 140960 140960 0 0.0
.bss 58720 58720 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197669 197669 0 0.0
.text 2160098 2160098 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2398544 2398544 0 0.0
.bss 188252 188252 0 0.0
.data 5320 5320 0 0.0
.text 1361144 1361144 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360768 2360768 0 0.0
.bss 180864 180864 0 0.0
.data 5624 5624 0 0.0
.text 1323368 1323368 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324368 2324368 0 0.0
.bss 180752 180752 0 0.0
.data 5600 5600 0 0.0
.text 1286968 1286968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309324 2309324 0 0.0
.bss 178004 178004 0 0.0
.data 5424 5424 0 0.0
.text 1271896 1271896 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1016735 1016735 0 0.0
bss 121272 121272 0 0.0
rodata 120204 120204 0 0.0
text 696284 696284 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 986011 986011 0 0.0
bss 118460 118460 0 0.0
rodata 111728 111728 0 0.0
text 676172 676172 0 0.0
nrf52840dongle_nrf52840 (read/write) 1032595 1032595 0 0.0
bss 122660 122660 0 0.0
rodata 119084 119084 0 0.0
text 700904 700904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 923378 923378 0 0.0
bss 117836 117836 0 0.0
rodata 113444 113444 0 0.0
text 611300 611300 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 946463 946463 0 0.0
bss 119644 119644 0 0.0
rodata 108964 108964 0 0.0
text 639316 639316 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853990 853990 0 0.0
bss 116236 116236 0 0.0
rodata 102136 102136 0 0.0
text 555108 555108 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 945279 945279 0 0.0
bss 119364 119364 0 0.0
rodata 107916 107916 0 0.0
text 639372 639372 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 941227 941227 0 0.0
bss 119368 119368 0 0.0
rodata 107616 107616 0 0.0
text 635612 635612 0 0.0
shell nrf52840dk_nrf52840 (read/write) 807147 807147 0 0.0
bss 111216 111216 0 0.0
rodata 79104 79104 0 0.0
text 539244 539244 0 0.0
p6 all-clusters-app default (read/write) 2484072 2484072 0 0.0
.bss 117608 117608 0 0.0
.data 2672 2672 0 0.0
.text 1442336 1442336 0 0.0
light-app default (read/write) 2390920 2390920 0 0.0
.bss 107248 107248 0 0.0
.data 2520 2520 0 0.0
.text 1349184 1349184 0 0.0
lock-app default (read/write) 2354384 2354384 0 0.0
.bss 106976 106976 0 0.0
.data 2480 2480 0 0.0
.text 1312648 1312648 0 0.0
qpg lighting-app qpg6105+debug (read only) 595624 595624 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88904 88904 0 0.0
.data 1108 1108 0 0.0
.text 590304 590304 0 0.0
lock-app qpg6105+debug (read only) 561360 561360 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88888 88888 0 0.0
.data 1060 1060 0 0.0
.text 556040 556040 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 875938 875938 0 0.0
bss 88580 88580 0 0.0
noinit 37160 37160 0 0.0
text 615704 615704 0 0.0

@mrjerryjohns mrjerryjohns merged commit 1a1f4cd into project-chip:master Feb 15, 2022
@bzbarsky-apple bzbarsky-apple deleted the fabric-filtered-yaml branch February 16, 2022 00:00
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@bzbarsky-apple @fuxingguo16
Add support for turning off fabric-filtering to YAML. (project-chip#1…
5619d9f 
…5162)

Allows listing "fabricFiltered: false" on a read or subscribe to get a
non-fabric-filtered read/subscribe.

Defaults to fabric-filtered if not otherwise specified.

Supported in chip-tool YAML, not yet in Darwin YAML pending the Darwin
framework growing APIs to support non-fabric-filtered reads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@carol-apple carol-apple carol-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @mrjerryjohns @carol-apple @jmeg-sfy