-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chip-cert to build_examples.py #15147
Merged
bzbarsky-apple
merged 4 commits into
project-chip:master
from
andy31415:chip-cert-build-examples
Feb 15, 2022
Merged
Add chip-cert to build_examples.py #15147
bzbarsky-apple
merged 4 commits into
project-chip:master
from
andy31415:chip-cert-build-examples
Feb 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
kghost
February 14, 2022 15:24
pullapprove
bot
requested review from
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 14, 2022 15:24
PR #15147: Size comparison from e439cb0 to 39ba28b Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
tcarmelveilleux
approved these changes
Feb 14, 2022
Should we do the same with the spake2p tool? |
emargolis
approved these changes
Feb 14, 2022
I think yes, did not know about that tool. I needed cert-tool since I wanted to do some updates for the dacs.py script. |
bzbarsky-apple
approved these changes
Feb 15, 2022
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
* Add chip cert tool to build_examples * Add chip-cert to the example build CI * Fix build tests unittest * Restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip-cert tool does not seem to be built by any CI. Also local path seemed to be assumed out/standalone/debug in our python scripts, however that let me to try to use gn_build.sh to generate it and got k32w errors.
Change overview
Make build_examples.py be capable to build the chip-cert tool. Added CI step for this.
Testing
Manually compiled with
./scripts/build/build_examples.py --target-glob '*-chip-cert' build
on my linux machine.CI will also validate.