-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Get the StartUp event to work #15103
[Darwin] Get the StartUp event to work #15103
Conversation
PR #15103: Size comparison from dabb721 to efdd03c Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
hmm. I noticed that locally Tsan is eating my signal handlers, so I sort of scared that |
5057bd1
to
4897445
Compare
PR #15103: Size comparison from 5cb8800 to 4897445 Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
4897445
to
d51ab5e
Compare
That's interesting, the Darwin task was failing because multiple tests (in different processes) were trying to access the KVS at the same time. |
PR #15103: Size comparison from 5cb8800 to d51ab5e Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
Darwin does not fire the
StartUp
event.I have also started some work to get the
Shutdown
event to work by handling signals. But at the moment I have written the code in such a way that the event loop is stopped before the event has been fired since it will just result into an Asanuse-after-free
error since the event is dispatched to the queue viaScheduleWork
but the platform has been turned off already.It all happens in
connectedhomeip/src/include/platform/internal/GenericPlatformManagerImpl.cpp
Line 136 in 695b616
Change overview
src/platform/Darwin
so it doesTesting
It has been manually verified using:
./out/debug/standalone/chip-tool basic read-event start-up 0x12345 0