-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error out if large (not-exactly-representable) integers are used in YAML #15102
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:yaml-large-integers
Feb 14, 2022
Merged
Error out if large (not-exactly-representable) integers are used in YAML #15102
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:yaml-large-integers
Feb 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AML. Otherwise we get silent value corruption.
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02 and
mrjerryjohns
February 11, 2022 20:43
pullapprove
bot
requested review from
msandstedt,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 11, 2022 20:43
tcarmelveilleux
approved these changes
Feb 11, 2022
mlepage-google
approved these changes
Feb 11, 2022
PR #15102: Size comparison from d344a98 to 1de91cf Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
…AML. (project-chip#15102) Otherwise we get silent value corruption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we get silent value corruption.
Problem
64-bit ints do not go through JS very well.
Change overview
Make sure people use strings for them.
Testing
Tried putting large int values in various places in yaml and made sure they all failed.