-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Use the KVS for the underlying store for the configuration m… #15080
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Darwin_KVS_ConfigurationManager
Feb 11, 2022
Merged
[Darwin] Use the KVS for the underlying store for the configuration m… #15080
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Darwin_KVS_ConfigurationManager
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel and
lazarkov
February 11, 2022 13:00
pullapprove
bot
requested review from
lzgrablic02,
mlepage-google,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
February 11, 2022 13:00
PR #15080: Size comparison from 0edb9f9 to b309338 Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
vivien-apple
force-pushed
the
Darwin_KVS_ConfigurationManager
branch
from
February 11, 2022 14:20
b309338
to
a4c7f37
Compare
andy31415
reviewed
Feb 11, 2022
andy31415
approved these changes
Feb 11, 2022
PR #15080: Size comparison from 5c57973 to a4c7f37 Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
vivien-apple
force-pushed
the
Darwin_KVS_ConfigurationManager
branch
2 times, most recently
from
February 11, 2022 15:57
745b366
to
80883ec
Compare
vivien-apple
force-pushed
the
Darwin_KVS_ConfigurationManager
branch
from
February 11, 2022 16:24
80883ec
to
ed4791d
Compare
PR #15080: Size comparison from 0bd4b85 to ed4791d Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 11, 2022
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…anager
Problem
The current storage for the configuration manager under Darwin is a sort of in-memory storage for some keys only.
This is basically some parts of #14660 that I'm trying to break down in order to not keep it stalled.
Change overview
Testing
I have built chip-tool on darwin as well as the ChipTool app on iOS.