Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] Fix SSID being printed as garbage #15069

Merged
merged 3 commits into from
Feb 11, 2022
Merged

[ESP32] Fix SSID being printed as garbage #15069

merged 3 commits into from
Feb 11, 2022

Conversation

shubhamdp
Copy link
Contributor

Problem

SSID is printed as garbage.
uint8_t data is being logged with %s specifier.

Change overview

Using length for printing SSID along with %.*s format specifier.

Testing

SSID is printing correctly on the console.

@github-actions
Copy link

github-actions bot commented Feb 11, 2022 •
edited
Loading

PR #15069: Size comparison from 70f8af2 to 7de2f30

Increases (2 builds for esp32)
platform target config section 70f8af2 7de2f30 change % change
esp32 all-clusters-app c3devkit (read only) 943728 943730 2 0.0
.flash.text 943728 943730 2 0.0
m5stack (read only) 993551 993555 4 0.0
(read/write) 464992 465000 8 0.0
.flash.rodata 225656 225664 8 0.0
.flash.text 988167 988171 4 0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 70f8af2 7de2f30 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 607074 607074 0 0.0
.app_xip_area 508552 508552 0 0.0
.bss 81220 81220 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563778 563778 0 0.0
.app_xip_area 466824 466824 0 0.0
.bss 79692 79692 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584586 584586 0 0.0
.app_xip_area 478376 478376 0 0.0
.bss 88620 88620 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907632 907632 0 0.0
(read/write) 128976 128976 0 0.0
.bss 126944 126944 0 0.0
.data 2032 2032 0 0.0
.text 907624 907624 0 0.0
BRD4161A+rpc (read only) 895092 895092 0 0.0
(read/write) 145636 145636 0 0.0
.bss 143504 143504 0 0.0
.data 2132 2132 0 0.0
.text 895084 895084 0 0.0
window-app BRD4161A (read only) 842712 842712 0 0.0
(read/write) 127040 127040 0 0.0
.bss 125136 125136 0 0.0
.data 1900 1900 0 0.0
.text 842704 842704 0 0.0
esp32 all-clusters-app c3devkit (read only) 943728 943730 2 0.0
(read/write) 1399722 1399722 0 0.0
.dram0.bss 68000 68000 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 198560 198560 0 0.0
.flash.text 943728 943730 2 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 993551 993555 4 0.0
(read/write) 464992 465000 8 0.0
.dram0.bss 73144 73144 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 225656 225664 8 0.0
.flash.text 988167 988171 4 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 684248 684248 0 0.0
.bss 78248 78248 0 0.0
.data 1904 1904 0 0.0
.text 598296 598296 0 0.0
lock k32w061+release (read/write) 689088 689088 0 0.0
.bss 78640 78640 0 0.0
.data 1948 1948 0 0.0
.text 602700 602700 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8064028 8064028 0 0.0
(read/write) 341185 341185 0 0.0
.bss 51681 51681 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 235544 235544 0 0.0
.dynamic 560 560 0 0.0
.got 48944 48944 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 433684 433684 0 0.0
.text 6901044 6901044 0 0.0
thermostat-no-ble arm64 (read only) 2140076 2140076 0 0.0
(read/write) 142209 142209 0 0.0
.bss 59105 59105 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 74960 74960 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132460 132460 0 0.0
.text 1789504 1789504 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396632 2396632 0 0.0
.bss 190068 190068 0 0.0
.data 5320 5320 0 0.0
.text 1359232 1359232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358456 2358456 0 0.0
.bss 182680 182680 0 0.0
.data 5624 5624 0 0.0
.text 1321056 1321056 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321984 2321984 0 0.0
.bss 182568 182568 0 0.0
.data 5600 5600 0 0.0
.text 1284584 1284584 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308052 2308052 0 0.0
.bss 179820 179820 0 0.0
.data 5424 5424 0 0.0
.text 1270624 1270624 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015947 1015947 0 0.0
bss 123004 123004 0 0.0
rodata 119528 119528 0 0.0
text 694520 694520 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 984779 984779 0 0.0
bss 120192 120192 0 0.0
rodata 110896 110896 0 0.0
text 674132 674132 0 0.0
nrf52840dongle_nrf52840 (read/write) 1031775 1031775 0 0.0
bss 124392 124392 0 0.0
rodata 118392 118392 0 0.0
text 699108 699108 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 922690 922690 0 0.0
bss 119568 119568 0 0.0
rodata 112772 112772 0 0.0
text 609556 609556 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 945775 945775 0 0.0
bss 121376 121376 0 0.0
rodata 108276 108276 0 0.0
text 637520 637520 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853250 853250 0 0.0
bss 117968 117968 0 0.0
rodata 101444 101444 0 0.0
text 553328 553328 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 945187 945187 0 0.0
bss 121096 121096 0 0.0
rodata 107632 107632 0 0.0
text 637780 637780 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 940535 940535 0 0.0
bss 121100 121100 0 0.0
rodata 106924 106924 0 0.0
text 633816 633816 0 0.0
shell nrf52840dk_nrf52840 (read/write) 806207 806207 0 0.0
bss 112376 112376 0 0.0
rodata 78948 78948 0 0.0
text 537304 537304 0 0.0
p6 all-clusters-app default (read/write) 2482032 2482032 0 0.0
.bss 119688 119688 0 0.0
.data 2672 2672 0 0.0
.text 1440296 1440296 0 0.0
light-app default (read/write) 2388616 2388616 0 0.0
.bss 109336 109336 0 0.0
.data 2520 2520 0 0.0
.text 1346880 1346880 0 0.0
lock-app default (read/write) 2352072 2352072 0 0.0
.bss 109056 109056 0 0.0
.data 2480 2480 0 0.0
.text 1310336 1310336 0 0.0
qpg lighting-app qpg6105+debug (read only) 593688 593688 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90520 90520 0 0.0
.data 1108 1108 0 0.0
.text 588368 588368 0 0.0
lock-app qpg6105+debug (read only) 559440 559440 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90504 90504 0 0.0
.data 1060 1060 0 0.0
.text 554120 554120 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874846 874846 0 0.0
bss 90328 90328 0 0.0
noinit 37160 37160 0 0.0
text 613496 613496 0 0.0

@restyled-io restyled-io bot mentioned this pull request Feb 11, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 11, 2022 •
edited
Loading

PR #15069: Size comparison from 70f8af2 to a2709e5

Increases above 0.2%:

platform target config section 70f8af2 a2709e5 change % change
k32w lock k32w061+release (read/write) 689088 691064 1976 0.3
.text 602700 604548 1848 0.3
linux chip-tool-ipv6only arm64 (read only) 8064028 8135596 71568 0.9
.text 6901044 6972292 71248 1.0
thermostat-no-ble arm64 (read only) 2140076 2150204 10128 0.5
.rodata 132460 132876 416 0.3
.text 1789504 1799184 9680 0.5
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 119528 119984 456 0.4
nrf52840dk_nrf52840+rpc rodata 110896 111348 452 0.4
text 674132 675508 1376 0.2
nrf52840dongle_nrf52840 rodata 118392 118844 452 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 922690 924646 1956 0.2
rodata 112772 113224 452 0.4
text 609556 610932 1376 0.2
lock-app nrf52840dk_nrf52840 (read/write) 945775 947731 1956 0.2
rodata 108276 108728 452 0.4
text 637520 638900 1380 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 853250 855210 1960 0.2
rodata 101444 101900 456 0.4
text 553328 554708 1380 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 940535 942495 1960 0.2
rodata 106924 107380 456 0.4
text 633816 635196 1380 0.2
qpg lighting-app qpg6105+debug (read only) 593688 595528 1840 0.3
.text 588368 590208 1840 0.3
lock-app qpg6105+debug (read only) 559440 561280 1840 0.3
.text 554120 555960 1840 0.3
telink lighting-app tlsr9518adk80d (read/write) 874846 877134 2288 0.3
text 613496 615198 1702 0.3
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 70f8af2 a2709e5 change % change
cyw30739 light cyw930739m2evb_01 .bss 81220 81284 64 0.1
lock cyw930739m2evb_01 .bss 79692 79756 64 0.1
ota-requestor cyw930739m2evb_01 .bss 88620 88684 64 0.1
efr32 lighting-app BRD4161A (read only) 907632 909560 1928 0.2
(read/write) 128976 129104 128 0.1
.bss 126944 127072 128 0.1
.text 907624 909552 1928 0.2
BRD4161A+rpc (read only) 895092 897020 1928 0.2
(read/write) 145636 145764 128 0.1
.bss 143504 143632 128 0.1
.text 895084 897012 1928 0.2
window-app BRD4161A (read only) 842712 844640 1928 0.2
(read/write) 127040 127168 128 0.1
.bss 125136 125264 128 0.1
.text 842704 844632 1928 0.2
esp32 all-clusters-app c3devkit (read only) 943728 945432 1704 0.2
(read/write) 1399722 1400306 584 0.0
.dram0.bss 68000 68128 128 0.2
.flash.rodata 198560 199016 456 0.2
.flash.text 943728 945432 1704 0.2
m5stack (read only) 993551 995075 1524 0.2
(read/write) 464992 465584 592 0.1
.dram0.bss 73144 73272 128 0.2
.flash.rodata 225656 226120 464 0.2
.flash.text 988167 989691 1524 0.2
k32w light k32w061+release (read/write) 684248 685636 1388 0.2
.bss 78248 78376 128 0.2
.text 598296 599556 1260 0.2
lock k32w061+release (read/write) 689088 691064 1976 0.3
.bss 78640 78768 128 0.2
.text 602700 604548 1848 0.3
linux chip-tool-ipv6only arm64 (read only) 8064028 8135596 71568 0.9
(read/write) 341185 341217 32 0.0
.data.rel.ro 235544 235568 24 0.0
.got 48944 48952 8 0.0
.rodata 433684 433956 272 0.1
.text 6901044 6972292 71248 1.0
thermostat-no-ble arm64 (read only) 2140076 2150204 10128 0.5
(read/write) 142209 142225 16 0.0
.data.rel.ro 74960 74984 24 0.0
.rodata 132460 132876 416 0.3
.text 1789504 1799184 9680 0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2396632 2398264 1632 0.1
.bss 190068 190196 128 0.1
.text 1359232 1360864 1632 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2358456 2360152 1696 0.1
.bss 182680 182808 128 0.1
.text 1321056 1322752 1696 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2321984 2323680 1696 0.1
.bss 182568 182696 128 0.1
.text 1284584 1286280 1696 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2308052 2309116 1064 0.0
.bss 179820 179948 128 0.1
.text 1270624 1271688 1064 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015947 1017907 1960 0.2
bss 123004 123132 128 0.1
rodata 119528 119984 456 0.4
text 694520 695896 1376 0.2
nrf52840dk_nrf52840+rpc (read/write) 984779 986735 1956 0.2
bss 120192 120320 128 0.1
rodata 110896 111348 452 0.4
text 674132 675508 1376 0.2
nrf52840dongle_nrf52840 (read/write) 1031775 1033731 1956 0.2
bss 124392 124520 128 0.1
rodata 118392 118844 452 0.4
text 699108 700484 1376 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 922690 924646 1956 0.2
bss 119568 119696 128 0.1
rodata 112772 113224 452 0.4
text 609556 610932 1376 0.2
lock-app nrf52840dk_nrf52840 (read/write) 945775 947731 1956 0.2
bss 121376 121504 128 0.1
rodata 108276 108728 452 0.4
text 637520 638900 1380 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 853250 855210 1960 0.2
bss 117968 118096 128 0.1
rodata 101444 101900 456 0.4
text 553328 554708 1380 0.2
pump-app nrf52840dk_nrf52840 (read/write) 945187 946575 1388 0.1
bss 121096 121224 128 0.1
rodata 107632 107708 76 0.1
text 637780 638956 1176 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 940535 942495 1960 0.2
bss 121100 121228 128 0.1
rodata 106924 107380 456 0.4
text 633816 635196 1380 0.2
p6 all-clusters-app default (read/write) 2482032 2483960 1928 0.1
.bss 119688 119816 128 0.1
.text 1440296 1442224 1928 0.1
light-app default (read/write) 2388616 2390544 1928 0.1
.bss 109336 109464 128 0.1
.text 1346880 1348808 1928 0.1
lock-app default (read/write) 2352072 2354016 1944 0.1
.bss 109056 109184 128 0.1
.text 1310336 1312280 1944 0.1
qpg lighting-app qpg6105+debug (read only) 593688 595528 1840 0.3
.bss 90520 90656 136 0.2
.text 588368 590208 1840 0.3
lock-app qpg6105+debug (read only) 559440 561280 1840 0.3
.bss 90504 90640 136 0.2
.text 554120 555960 1840 0.3
telink lighting-app tlsr9518adk80d (read/write) 874846 877134 2288 0.3
bss 90328 90456 128 0.1
text 613496 615198 1702 0.3
Decreases (3 builds for cyw30739)
platform target config section 70f8af2 a2709e5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 607074 595150 -11924 -2.0
.app_xip_area 508552 496564 -11988 -2.4
lock cyw930739m2evb_01 (read/write) 563778 552954 -10824 -1.9
.app_xip_area 466824 455936 -10888 -2.3
ota-requestor cyw930739m2evb_01 (read/write) 584586 571890 -12696 -2.2
.app_xip_area 478376 465616 -12760 -2.7
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 70f8af2 a2709e5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 607074 595150 -11924 -2.0
.app_xip_area 508552 496564 -11988 -2.4
.bss 81220 81284 64 0.1
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563778 552954 -10824 -1.9
.app_xip_area 466824 455936 -10888 -2.3
.bss 79692 79756 64 0.1
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584586 571890 -12696 -2.2
.app_xip_area 478376 465616 -12760 -2.7
.bss 88620 88684 64 0.1
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907632 909560 1928 0.2
(read/write) 128976 129104 128 0.1
.bss 126944 127072 128 0.1
.data 2032 2032 0 0.0
.text 907624 909552 1928 0.2
BRD4161A+rpc (read only) 895092 897020 1928 0.2
(read/write) 145636 145764 128 0.1
.bss 143504 143632 128 0.1
.data 2132 2132 0 0.0
.text 895084 897012 1928 0.2
window-app BRD4161A (read only) 842712 844640 1928 0.2
(read/write) 127040 127168 128 0.1
.bss 125136 125264 128 0.1
.data 1900 1900 0 0.0
.text 842704 844632 1928 0.2
esp32 all-clusters-app c3devkit (read only) 943728 945432 1704 0.2
(read/write) 1399722 1400306 584 0.0
.dram0.bss 68000 68128 128 0.2
.dram0.data 14268 14268 0 0.0
.flash.rodata 198560 199016 456 0.2
.flash.text 943728 945432 1704 0.2
.iram0.text 62056 62056 0 0.0
m5stack (read only) 993551 995075 1524 0.2
(read/write) 464992 465584 592 0.1
.dram0.bss 73144 73272 128 0.2
.dram0.data 34064 34064 0 0.0
.flash.rodata 225656 226120 464 0.2
.flash.text 988167 989691 1524 0.2
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 684248 685636 1388 0.2
.bss 78248 78376 128 0.2
.data 1904 1904 0 0.0
.text 598296 599556 1260 0.2
lock k32w061+release (read/write) 689088 691064 1976 0.3
.bss 78640 78768 128 0.2
.data 1948 1948 0 0.0
.text 602700 604548 1848 0.3
linux chip-tool-ipv6only arm64 (read only) 8064028 8135596 71568 0.9
(read/write) 341185 341217 32 0.0
.bss 51681 51681 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 235544 235568 24 0.0
.dynamic 560 560 0 0.0
.got 48944 48952 8 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 433684 433956 272 0.1
.text 6901044 6972292 71248 1.0
thermostat-no-ble arm64 (read only) 2140076 2150204 10128 0.5
(read/write) 142209 142225 16 0.0
.bss 59105 59105 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 74960 74984 24 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132460 132876 416 0.3
.text 1789504 1799184 9680 0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396632 2398264 1632 0.1
.bss 190068 190196 128 0.1
.data 5320 5320 0 0.0
.text 1359232 1360864 1632 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358456 2360152 1696 0.1
.bss 182680 182808 128 0.1
.data 5624 5624 0 0.0
.text 1321056 1322752 1696 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321984 2323680 1696 0.1
.bss 182568 182696 128 0.1
.data 5600 5600 0 0.0
.text 1284584 1286280 1696 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308052 2309116 1064 0.0
.bss 179820 179948 128 0.1
.data 5424 5424 0 0.0
.text 1270624 1271688 1064 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015947 1017907 1960 0.2
bss 123004 123132 128 0.1
rodata 119528 119984 456 0.4
text 694520 695896 1376 0.2
nrf52840dk_nrf52840+rpc (read/write) 984779 986735 1956 0.2
bss 120192 120320 128 0.1
rodata 110896 111348 452 0.4
text 674132 675508 1376 0.2
nrf52840dongle_nrf52840 (read/write) 1031775 1033731 1956 0.2
bss 124392 124520 128 0.1
rodata 118392 118844 452 0.4
text 699108 700484 1376 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 922690 924646 1956 0.2
bss 119568 119696 128 0.1
rodata 112772 113224 452 0.4
text 609556 610932 1376 0.2
lock-app nrf52840dk_nrf52840 (read/write) 945775 947731 1956 0.2
bss 121376 121504 128 0.1
rodata 108276 108728 452 0.4
text 637520 638900 1380 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 853250 855210 1960 0.2
bss 117968 118096 128 0.1
rodata 101444 101900 456 0.4
text 553328 554708 1380 0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 945187 946575 1388 0.1
bss 121096 121224 128 0.1
rodata 107632 107708 76 0.1
text 637780 638956 1176 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 940535 942495 1960 0.2
bss 121100 121228 128 0.1
rodata 106924 107380 456 0.4
text 633816 635196 1380 0.2
shell nrf52840dk_nrf52840 (read/write) 806207 806207 0 0.0
bss 112376 112376 0 0.0
rodata 78948 78948 0 0.0
text 537304 537304 0 0.0
p6 all-clusters-app default (read/write) 2482032 2483960 1928 0.1
.bss 119688 119816 128 0.1
.data 2672 2672 0 0.0
.text 1440296 1442224 1928 0.1
light-app default (read/write) 2388616 2390544 1928 0.1
.bss 109336 109464 128 0.1
.data 2520 2520 0 0.0
.text 1346880 1348808 1928 0.1
lock-app default (read/write) 2352072 2354016 1944 0.1
.bss 109056 109184 128 0.1
.data 2480 2480 0 0.0
.text 1310336 1312280 1944 0.1
qpg lighting-app qpg6105+debug (read only) 593688 595528 1840 0.3
(read/write) 146936 146936 0 0.0
.bss 90520 90656 136 0.2
.data 1108 1108 0 0.0
.text 588368 590208 1840 0.3
lock-app qpg6105+debug (read only) 559440 561280 1840 0.3
(read/write) 146936 146936 0 0.0
.bss 90504 90640 136 0.2
.data 1060 1060 0 0.0
.text 554120 555960 1840 0.3
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874846 877134 2288 0.3
bss 90328 90456 128 0.1
noinit 37160 37160 0 0.0
text 613496 615198 1702 0.3

@andy31415 andy31415 merged commit 512ab16 into project-chip:master Feb 11, 2022
@shubhamdp shubhamdp deleted the esp32_fix_ssid_print branch February 11, 2022 17:03
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@shubhamdp @bzbarsky-apple
@restyled-commits @fuxingguo16
[ESP32] Fix SSID being printed as garbage (project-chip#15069)
0ae816e 
* [ESP32] Fix SSID being printed as garbage

* Apply suggestions from code review

Co-authored-by: Boris Zbarsky <[email protected]>

* Restyled by clang-format

Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@dhrishi dhrishi Awaiting requested review from dhrishi

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
esp32 platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shubhamdp @dhrishi @harsha-rajendran @bzbarsky-apple @andy31415 @restyled-commits