submodule nits #1506
Merged
submodule nits #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalker-apple
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
gerickson
reviewed
Jul 8, 2020
| @@ -41,7 +41,7 @@ | |||
| ignore = dirty | |||
| commit = 35be9760b4edf485287f78c0cf652beb19c047f0 | |||
| [submodule "pigweed"] | |||
| path = third_party/pigweed | |||
| path = third_party/pigweed/repo | |||
gerickson
approved these changes
Jul 8, 2020
woody-apple
approved these changes
Jul 8, 2020
|
I don't know how to fix the lgtm failure off hand. I think I could have a PR where pigweed is mapped in twice? hope we can land without lgtm |
Try: git mv third_party/pigweed pigweed |
saurabhst
approved these changes
Jul 8, 2020
BroderickCarlin
approved these changes
Jul 8, 2020
|
@woody-apple this is ready |
|
@rwalker-apple can we fix the conflicts here? |
added 3 commits
July 8, 2020 20:20
rwalker-apple
force-pushed
the
submodule-nit
branch
from
7e53fde to
2c093a4
Compare
Closed
added 2 commits
July 8, 2020 20:27
|
@woody-apple ready |
andy31415
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
irregular configs for submodules
Summary of Changes
make regular