Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mbed] Fix network commissioning - add network commissioning driver #15041

Merged

Conversation

ATmobica
Copy link
Contributor

@ATmobica ATmobica commented Feb 10, 2022

Problem

Mbed examples commissioning failed because of lack NetworkCommissioningDriver with Wifi driver.
We need to also create app::Clusters::NetworkCommissioning::Instance with our driver.

Fix issue: #13170

Change overview

Add Network Commissioning Driver class implementation
Add Wifi Driver class implementation
Use Mbed Wifi driver in NetworkProvisioningDelegateImpl class
Wifi interface separation from ConnectivityManagerImpl class - now ConnectivityManagerImp class is responsible only for common connectivity services.
Create ConnectivityManagerImpl_WiFi class - this class is responsible for Wifi connectivity service.
Remove deprecated functions calling

Testing

Build and run Mbed examples - WiFi commissioning node device.

Required PRs:

@github-actions
Copy link

github-actions bot commented Feb 10, 2022

PR #15041: Size comparison from 6fa8e4c to 228f382

Full report (38 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 6fa8e4c 228f382 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 607086 607086 0 0.0
.app_xip_area 508516 508516 0 0.0
.bss 81268 81268 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563790 563790 0 0.0
.app_xip_area 466788 466788 0 0.0
.bss 79740 79740 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584566 584566 0 0.0
.app_xip_area 478316 478316 0 0.0
.bss 88660 88660 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907504 907504 0 0.0
(read/write) 128992 128992 0 0.0
.bss 126960 126960 0 0.0
.data 2032 2032 0 0.0
.text 907496 907496 0 0.0
BRD4161A+rpc (read only) 894948 894948 0 0.0
(read/write) 145652 145652 0 0.0
.bss 143520 143520 0 0.0
.data 2132 2132 0 0.0
.text 894940 894940 0 0.0
window-app BRD4161A (read only) 842632 842632 0 0.0
(read/write) 127064 127064 0 0.0
.bss 125160 125160 0 0.0
.data 1900 1900 0 0.0
.text 842624 842624 0 0.0
esp32 all-clusters-app c3devkit (read only) 943822 943822 0 0.0
(read/write) 1399770 1399770 0 0.0
.dram0.bss 68024 68024 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 198576 198576 0 0.0
.flash.text 943822 943822 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 991127 991127 0 0.0
(read/write) 464608 464608 0 0.0
.dram0.bss 73168 73168 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 225248 225248 0 0.0
.flash.text 985743 985743 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 684200 684200 0 0.0
.bss 78264 78264 0 0.0
.data 1904 1904 0 0.0
.text 598232 598232 0 0.0
lock k32w061+release (read/write) 689080 689080 0 0.0
.bss 78664 78664 0 0.0
.data 1948 1948 0 0.0
.text 602668 602668 0 0.0
linux all-clusters-app debug (read only) 2346201 2346201 0 0.0
(read/write) 141696 141696 0 0.0
.bss 56224 56224 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 78488 78488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205253 205253 0 0.0
.text 1978722 1978722 0 0.0
bridge-app debug+rpc (read only) 1713845 1713845 0 0.0
(read/write) 85864 85864 0 0.0
.bss 40624 40624 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141036 141036 0 0.0
.text 1456309 1456309 0 0.0
chip-tool debug (read only) 8229405 8229405 0 0.0
(read/write) 232248 232248 0 0.0
.bss 33512 33512 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 191528 191528 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 456309 456309 0 0.0
.text 7292453 7292453 0 0.0
chip-tool-ipv6only arm64 (read only) 8052988 8052988 0 0.0
(read/write) 339473 339473 0 0.0
.bss 51777 51777 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 233784 233784 0 0.0
.dynamic 560 560 0 0.0
.got 48904 48904 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 433156 433156 0 0.0
.text 6894260 6894260 0 0.0
door-lock-app debug (read only) 1919001 1919001 0 0.0
(read/write) 112184 112184 0 0.0
.bss 43696 43696 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62064 62064 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172434 172434 0 0.0
.text 1598098 1598098 0 0.0
lighting-app debug+rpc (read only) 2043305 2043305 0 0.0
(read/write) 117464 117464 0 0.0
.bss 44672 44672 0 0.0
.data 1464 1464 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165937 165937 0 0.0
.text 1722578 1722578 0 0.0
ota-provider-app debug (read only) 1858657 1858657 0 0.0
(read/write) 107928 107928 0 0.0
.bss 43648 43648 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 57448 57448 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157982 157982 0 0.0
.text 1550130 1550130 0 0.0
ota-requestor-app debug (read only) 1853385 1853385 0 0.0
(read/write) 109048 109048 0 0.0
.bss 43936 43936 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58504 58504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151407 151407 0 0.0
.text 1553154 1553154 0 0.0
shell debug (read only) 2319945 2319945 0 0.0
(read/write) 144688 144688 0 0.0
.bss 65120 65120 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73040 73040 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206258 206258 0 0.0
.text 1957266 1957266 0 0.0
thermostat-no-ble arm64 (read only) 2139996 2139996 0 0.0
(read/write) 142305 142305 0 0.0
.bss 59201 59201 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 74960 74960 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132460 132460 0 0.0
.text 1789424 1789424 0 0.0
tv-app debug (read only) 2515857 2515857 0 0.0
(read/write) 141056 141056 0 0.0
.bss 58848 58848 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197292 197292 0 0.0
.text 2145650 2145650 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1016027 1016027 0 0.0
bss 123020 123020 0 0.0
rodata 119528 119528 0 0.0
text 694472 694472 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 984859 984859 0 0.0
bss 120208 120208 0 0.0
rodata 110896 110896 0 0.0
text 674084 674084 0 0.0
nrf52840dongle_nrf52840 (read/write) 1031743 1031743 0 0.0
bss 124416 124416 0 0.0
rodata 118392 118392 0 0.0
text 699088 699088 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 922642 922642 0 0.0
bss 119584 119584 0 0.0
rodata 112772 112772 0 0.0
text 609508 609508 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 945743 945743 0 0.0
bss 121400 121400 0 0.0
rodata 108276 108276 0 0.0
text 637500 637500 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853250 853250 0 0.0
bss 117992 117992 0 0.0
rodata 101444 101444 0 0.0
text 553308 553308 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 945171 945171 0 0.0
bss 121120 121120 0 0.0
rodata 107632 107632 0 0.0
text 637760 637760 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 940519 940519 0 0.0
bss 121124 121124 0 0.0
rodata 106924 106924 0 0.0
text 633796 633796 0 0.0
shell nrf52840dk_nrf52840 (read/write) 806319 806319 0 0.0
bss 112400 112400 0 0.0
rodata 78948 78948 0 0.0
text 537296 537296 0 0.0
p6 all-clusters-app default (read/write) 2482288 2482288 0 0.0
.bss 119704 119704 0 0.0
.data 2672 2672 0 0.0
.text 1440552 1440552 0 0.0
light-app default (read/write) 2388616 2388616 0 0.0
.bss 109352 109352 0 0.0
.data 2520 2520 0 0.0
.text 1346880 1346880 0 0.0
lock-app default (read/write) 2352072 2352072 0 0.0
.bss 109072 109072 0 0.0
.data 2480 2480 0 0.0
.text 1310336 1310336 0 0.0
qpg lighting-app qpg6105+debug (read only) 593616 593616 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90536 90536 0 0.0
.data 1108 1108 0 0.0
.text 588296 588296 0 0.0
lock-app qpg6105+debug (read only) 559368 559368 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90520 90520 0 0.0
.data 1060 1060 0 0.0
.text 554048 554048 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874814 874814 0 0.0
bss 90352 90352 0 0.0
noinit 37160 37160 0 0.0
text 613448 613448 0 0.0

@boring-cyborg boring-cyborg bot added the config label Feb 11, 2022
@ATmobica ATmobica force-pushed the mbed-network-commissioning-driver branch from 91d2902 to be7e0cc Compare February 11, 2022 11:00
@github-actions
Copy link

github-actions bot commented Feb 11, 2022

PR #15041: Size comparison from 0edb9f9 to be7e0cc

Full report (29 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 0edb9f9 be7e0cc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595150 595150 0 0.0
.app_xip_area 496564 496564 0 0.0
.bss 81284 81284 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552954 552954 0 0.0
.app_xip_area 455936 455936 0 0.0
.bss 79756 79756 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571890 571890 0 0.0
.app_xip_area 465616 465616 0 0.0
.bss 88684 88684 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909560 909560 0 0.0
(read/write) 129104 129104 0 0.0
.bss 127072 127072 0 0.0
.data 2032 2032 0 0.0
.text 909552 909552 0 0.0
BRD4161A+rpc (read only) 897020 897020 0 0.0
(read/write) 145764 145764 0 0.0
.bss 143632 143632 0 0.0
.data 2132 2132 0 0.0
.text 897012 897012 0 0.0
window-app BRD4161A (read only) 844640 844640 0 0.0
(read/write) 127168 127168 0 0.0
.bss 125264 125264 0 0.0
.data 1900 1900 0 0.0
.text 844632 844632 0 0.0
esp32 all-clusters-app c3devkit (read only) 945430 945430 0 0.0
(read/write) 1400306 1400306 0 0.0
.dram0.bss 68128 68128 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199016 199016 0 0.0
.flash.text 945430 945430 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 995071 995071 0 0.0
(read/write) 465576 465576 0 0.0
.dram0.bss 73272 73272 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226112 226112 0 0.0
.flash.text 989687 989687 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 685636 685636 0 0.0
.bss 78376 78376 0 0.0
.data 1904 1904 0 0.0
.text 599556 599556 0 0.0
lock k32w061+release (read/write) 691064 691064 0 0.0
.bss 78768 78768 0 0.0
.data 1948 1948 0 0.0
.text 604548 604548 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8135596 8135596 0 0.0
(read/write) 341217 341217 0 0.0
.bss 51681 51681 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 235568 235568 0 0.0
.dynamic 560 560 0 0.0
.got 48952 48952 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 433956 433956 0 0.0
.text 6972292 6972292 0 0.0
thermostat-no-ble arm64 (read only) 2150204 2150204 0 0.0
(read/write) 142225 142225 0 0.0
.bss 59105 59105 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 74984 74984 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132876 132876 0 0.0
.text 1799184 1799184 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1017907 1017907 0 0.0
bss 123132 123132 0 0.0
rodata 119984 119984 0 0.0
text 695896 695896 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 986735 986735 0 0.0
bss 120320 120320 0 0.0
rodata 111348 111348 0 0.0
text 675508 675508 0 0.0
nrf52840dongle_nrf52840 (read/write) 1033731 1033731 0 0.0
bss 124520 124520 0 0.0
rodata 118844 118844 0 0.0
text 700484 700484 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 924646 924646 0 0.0
bss 119696 119696 0 0.0
rodata 113224 113224 0 0.0
text 610932 610932 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 947731 947731 0 0.0
bss 121504 121504 0 0.0
rodata 108728 108728 0 0.0
text 638900 638900 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 855210 855210 0 0.0
bss 118096 118096 0 0.0
rodata 101900 101900 0 0.0
text 554708 554708 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 946575 946575 0 0.0
bss 121224 121224 0 0.0
rodata 107708 107708 0 0.0
text 638956 638956 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 942495 942495 0 0.0
bss 121228 121228 0 0.0
rodata 107380 107380 0 0.0
text 635196 635196 0 0.0
shell nrf52840dk_nrf52840 (read/write) 806207 806207 0 0.0
bss 112376 112376 0 0.0
rodata 78948 78948 0 0.0
text 537304 537304 0 0.0
p6 all-clusters-app default (read/write) 2483960 2483960 0 0.0
.bss 119816 119816 0 0.0
.data 2672 2672 0 0.0
.text 1442224 1442224 0 0.0
light-app default (read/write) 2390544 2390544 0 0.0
.bss 109464 109464 0 0.0
.data 2520 2520 0 0.0
.text 1348808 1348808 0 0.0
lock-app default (read/write) 2354016 2354016 0 0.0
.bss 109184 109184 0 0.0
.data 2480 2480 0 0.0
.text 1312280 1312280 0 0.0
qpg lighting-app qpg6105+debug (read only) 595528 595528 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90656 90656 0 0.0
.data 1108 1108 0 0.0
.text 590208 590208 0 0.0
lock-app qpg6105+debug (read only) 561280 561280 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90640 90640 0 0.0
.data 1060 1060 0 0.0
.text 555960 555960 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877134 877134 0 0.0
bss 90456 90456 0 0.0
noinit 37160 37160 0 0.0
text 615198 615198 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 16, 2022

PR #15041: Size comparison from d671a52 to 7857815

Increases above 0.2%:

platform target config section d671a52 7857815 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2427148 2436324 9176 0.4
.data 5328 5344 16 0.3
.text 1389720 1398896 9176 0.7
lighting-app CY8CPROTO_062_4343W+release (read/write) 2390284 2399588 9304 0.4
.data 5624 5640 16 0.3
.text 1352856 1362160 9304 0.7
lock-app CY8CPROTO_062_4343W+release (read/write) 2325728 2335024 9296 0.4
.data 5600 5616 16 0.3
.text 1288328 1297624 9296 0.7
shell CY8CPROTO_062_4343W+release (read/write) 2316556 2325796 9240 0.4
.data 5432 5448 16 0.3
.text 1279128 1288368 9240 0.7
Increases (4 builds for mbed)
platform target config section d671a52 7857815 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2427148 2436324 9176 0.4
.bss 189252 189660 408 0.2
.data 5328 5344 16 0.3
.text 1389720 1398896 9176 0.7
lighting-app CY8CPROTO_062_4343W+release (read/write) 2390284 2399588 9304 0.4
.bss 181784 182192 408 0.2
.data 5624 5640 16 0.3
.text 1352856 1362160 9304 0.7
lock-app CY8CPROTO_062_4343W+release (read/write) 2325728 2335024 9296 0.4
.bss 180760 181168 408 0.2
.data 5600 5616 16 0.3
.text 1288328 1297624 9296 0.7
shell CY8CPROTO_062_4343W+release (read/write) 2316556 2325796 9240 0.4
.bss 179308 179716 408 0.2
.data 5432 5448 16 0.3
.text 1279128 1288368 9240 0.7
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d671a52 7857815 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594282 594282 0 0.0
.app_xip_area 499880 499880 0 0.0
.bss 77100 77100 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552226 552226 0 0.0
.app_xip_area 459392 459392 0 0.0
.bss 75572 75572 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573322 573322 0 0.0
.app_xip_area 471056 471056 0 0.0
.bss 84676 84676 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 912724 912724 0 0.0
(read/write) 127432 127432 0 0.0
.bss 125400 125400 0 0.0
.data 2032 2032 0 0.0
.text 912716 912716 0 0.0
BRD4161A+rpc (read only) 941448 941448 0 0.0
(read/write) 144352 144352 0 0.0
.bss 142176 142176 0 0.0
.data 2172 2172 0 0.0
.text 941440 941440 0 0.0
window-app BRD4161A (read only) 846576 846576 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123424 123424 0 0.0
.data 1900 1900 0 0.0
.text 846568 846568 0 0.0
esp32 all-clusters-app c3devkit (read only) 946454 946454 0 0.0
(read/write) 1398818 1398818 0 0.0
.dram0.bss 66208 66208 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199448 199448 0 0.0
.flash.text 946454 946454 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 996279 996279 0 0.0
(read/write) 464080 464080 0 0.0
.dram0.bss 71344 71344 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226544 226544 0 0.0
.flash.text 990895 990895 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 688312 688312 0 0.0
.bss 76712 76712 0 0.0
.data 1908 1908 0 0.0
.text 603892 603892 0 0.0
lock k32w061+release (read/write) 690928 690928 0 0.0
.bss 76928 76928 0 0.0
.data 1948 1948 0 0.0
.text 606252 606252 0 0.0
linux all-clusters-app debug (read only) 2367177 2367177 0 0.0
(read/write) 142144 142144 0 0.0
.bss 56480 56480 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78664 78664 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206245 206245 0 0.0
.text 1998274 1998274 0 0.0
bridge-app debug+rpc (read only) 1728589 1728589 0 0.0
(read/write) 85672 85672 0 0.0
.bss 40400 40400 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141964 141964 0 0.0
.text 1470005 1470005 0 0.0
chip-tool debug (read only) 8575653 8575653 0 0.0
(read/write) 245952 245952 0 0.0
.bss 31816 31816 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206896 206896 0 0.0
.dynamic 608 608 0 0.0
.got 4792 4792 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 459637 459637 0 0.0
.text 7599525 7599525 0 0.0
chip-tool-ipv6only arm64 (read only) 8328468 8328468 0 0.0
(read/write) 353745 353745 0 0.0
.bss 50113 50113 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249368 249368 0 0.0
.dynamic 560 560 0 0.0
.got 49256 49256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 435500 435500 0 0.0
.text 7130292 7130292 0 0.0
door-lock-app debug (read only) 1933889 1933889 0 0.0
(read/write) 111576 111576 0 0.0
.bss 43088 43088 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62080 62080 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173426 173426 0 0.0
.text 1611874 1611874 0 0.0
lighting-app debug+rpc (read only) 2060113 2060113 0 0.0
(read/write) 116920 116920 0 0.0
.bss 44192 44192 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166033 166033 0 0.0
.text 1739266 1739266 0 0.0
ota-provider-app debug (read only) 1867321 1867321 0 0.0
(read/write) 107320 107320 0 0.0
.bss 42976 42976 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 158283 158283 0 0.0
.text 1558354 1558354 0 0.0
ota-requestor-app debug (read only) 1880425 1880425 0 0.0
(read/write) 108736 108736 0 0.0
.bss 43392 43392 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153052 153052 0 0.0
.text 1578194 1578194 0 0.0
shell debug (read only) 2346313 2346313 0 0.0
(read/write) 144560 144560 0 0.0
.bss 64832 64832 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73224 73224 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 207090 207090 0 0.0
.text 1982418 1982418 0 0.0
thermostat-no-ble arm64 (read only) 2153276 2153276 0 0.0
(read/write) 141825 141825 0 0.0
.bss 58641 58641 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4160 4160 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 133052 133052 0 0.0
.text 1801920 1801920 0 0.0
tv-app debug (read only) 2531385 2531385 0 0.0
(read/write) 142560 142560 0 0.0
.bss 60320 60320 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197765 197765 0 0.0
.text 2160578 2160578 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427148 2436324 9176 0.4
.bss 189252 189660 408 0.2
.data 5328 5344 16 0.3
.text 1389720 1398896 9176 0.7
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2390284 2399588 9304 0.4
.bss 181784 182192 408 0.2
.data 5624 5640 16 0.3
.text 1352856 1362160 9304 0.7
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2325728 2335024 9296 0.4
.bss 180760 181168 408 0.2
.data 5600 5616 16 0.3
.text 1288328 1297624 9296 0.7
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316556 2325796 9240 0.4
.bss 179308 179716 408 0.2
.data 5432 5448 16 0.3
.text 1279128 1288368 9240 0.7
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1018755 1018755 0 0.0
bss 121460 121460 0 0.0
rodata 120368 120368 0 0.0
text 698024 698024 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 988051 988051 0 0.0
bss 118648 118648 0 0.0
rodata 111896 111896 0 0.0
text 677924 677924 0 0.0
nrf52840dongle_nrf52840 (read/write) 1033703 1033703 0 0.0
bss 122680 122680 0 0.0
rodata 119184 119184 0 0.0
text 701916 701916 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 925462 925462 0 0.0
bss 118024 118024 0 0.0
rodata 113608 113608 0 0.0
text 613040 613040 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 947459 947459 0 0.0
bss 119664 119664 0 0.0
rodata 109064 109064 0 0.0
text 640216 640216 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 854986 854986 0 0.0
bss 116256 116256 0 0.0
rodata 102236 102236 0 0.0
text 556008 556008 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 946035 946035 0 0.0
bss 119384 119384 0 0.0
rodata 108016 108016 0 0.0
text 640036 640036 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 941999 941999 0 0.0
bss 119388 119388 0 0.0
rodata 107716 107716 0 0.0
text 636276 636276 0 0.0
shell nrf52840dk_nrf52840 (read/write) 807447 807447 0 0.0
bss 111236 111236 0 0.0
rodata 79132 79132 0 0.0
text 539384 539384 0 0.0
p6 all-clusters-app default (read/write) 2484408 2484408 0 0.0
.bss 117568 117568 0 0.0
.data 2672 2672 0 0.0
.text 1442672 1442672 0 0.0
light-app default (read/write) 2391288 2391288 0 0.0
.bss 107248 107248 0 0.0
.data 2520 2520 0 0.0
.text 1349552 1349552 0 0.0
lock-app default (read/write) 2354752 2354752 0 0.0
.bss 106976 106976 0 0.0
.data 2480 2480 0 0.0
.text 1313016 1313016 0 0.0
qpg lighting-app qpg6105+debug (read only) 597492 597492 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89072 89072 0 0.0
.data 1108 1108 0 0.0
.text 592172 592172 0 0.0
lock-app qpg6105+debug (read only) 563116 563116 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89056 89056 0 0.0
.data 1060 1060 0 0.0
.text 557796 557796 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877166 877166 0 0.0
bss 88600 88600 0 0.0
noinit 37160 37160 0 0.0
text 616816 616816 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 16, 2022

PR #15041: Size comparison from 6103a69 to 026b09b

Increases above 0.2%:

platform target config section 6103a69 026b09b change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2427148 2436324 9176 0.4
.data 5328 5344 16 0.3
.text 1389720 1398896 9176 0.7
lighting-app CY8CPROTO_062_4343W+release (read/write) 2390284 2399588 9304 0.4
.data 5624 5640 16 0.3
.text 1352856 1362160 9304 0.7
lock-app CY8CPROTO_062_4343W+release (read/write) 2325728 2335024 9296 0.4
.data 5600 5616 16 0.3
.text 1288328 1297624 9296 0.7
shell CY8CPROTO_062_4343W+release (read/write) 2316556 2325796 9240 0.4
.data 5432 5448 16 0.3
.text 1279128 1288368 9240 0.7
Increases (4 builds for mbed)
platform target config section 6103a69 026b09b change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2427148 2436324 9176 0.4
.bss 189252 189660 408 0.2
.data 5328 5344 16 0.3
.text 1389720 1398896 9176 0.7
lighting-app CY8CPROTO_062_4343W+release (read/write) 2390284 2399588 9304 0.4
.bss 181784 182192 408 0.2
.data 5624 5640 16 0.3
.text 1352856 1362160 9304 0.7
lock-app CY8CPROTO_062_4343W+release (read/write) 2325728 2335024 9296 0.4
.bss 180760 181168 408 0.2
.data 5600 5616 16 0.3
.text 1288328 1297624 9296 0.7
shell CY8CPROTO_062_4343W+release (read/write) 2316556 2325796 9240 0.4
.bss 179308 179716 408 0.2
.data 5432 5448 16 0.3
.text 1279128 1288368 9240 0.7
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6103a69 026b09b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594282 594282 0 0.0
.app_xip_area 499880 499880 0 0.0
.bss 77100 77100 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552226 552226 0 0.0
.app_xip_area 459392 459392 0 0.0
.bss 75572 75572 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573322 573322 0 0.0
.app_xip_area 471056 471056 0 0.0
.bss 84676 84676 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 912724 912724 0 0.0
(read/write) 127432 127432 0 0.0
.bss 125400 125400 0 0.0
.data 2032 2032 0 0.0
.text 912716 912716 0 0.0
BRD4161A+rpc (read only) 941448 941448 0 0.0
(read/write) 144352 144352 0 0.0
.bss 142176 142176 0 0.0
.data 2172 2172 0 0.0
.text 941440 941440 0 0.0
window-app BRD4161A (read only) 846576 846576 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123424 123424 0 0.0
.data 1900 1900 0 0.0
.text 846568 846568 0 0.0
esp32 all-clusters-app c3devkit (read only) 946454 946454 0 0.0
(read/write) 1398818 1398818 0 0.0
.dram0.bss 66208 66208 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199448 199448 0 0.0
.flash.text 946454 946454 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 996279 996279 0 0.0
(read/write) 464080 464080 0 0.0
.dram0.bss 71344 71344 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226544 226544 0 0.0
.flash.text 990895 990895 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 688312 688312 0 0.0
.bss 76712 76712 0 0.0
.data 1908 1908 0 0.0
.text 603892 603892 0 0.0
lock k32w061+release (read/write) 690928 690928 0 0.0
.bss 76928 76928 0 0.0
.data 1948 1948 0 0.0
.text 606252 606252 0 0.0
linux all-clusters-app debug (read only) 2370817 2370817 0 0.0
(read/write) 142176 142176 0 0.0
.bss 56480 56480 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78664 78664 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205957 205957 0 0.0
.text 2001922 2001922 0 0.0
bridge-app debug+rpc (read only) 1725901 1725901 0 0.0
(read/write) 85640 85640 0 0.0
.bss 40400 40400 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141836 141836 0 0.0
.text 1467733 1467733 0 0.0
chip-tool debug (read only) 8574629 8574629 0 0.0
(read/write) 245920 245920 0 0.0
.bss 31816 31816 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206896 206896 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 459477 459477 0 0.0
.text 7598741 7598741 0 0.0
chip-tool-ipv6only arm64 (read only) 8327764 8327764 0 0.0
(read/write) 353713 353713 0 0.0
.bss 50113 50113 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249344 249344 0 0.0
.dynamic 560 560 0 0.0
.got 49256 49256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 435468 435468 0 0.0
.text 7129700 7129700 0 0.0
door-lock-app debug (read only) 1937569 1937569 0 0.0
(read/write) 111608 111608 0 0.0
.bss 43088 43088 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62080 62080 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173138 173138 0 0.0
.text 1615570 1615570 0 0.0
lighting-app debug+rpc (read only) 2063833 2063833 0 0.0
(read/write) 116952 116952 0 0.0
.bss 44192 44192 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165777 165777 0 0.0
.text 1742962 1742962 0 0.0
ota-provider-app debug (read only) 1870993 1870993 0 0.0
(read/write) 107352 107352 0 0.0
.bss 42976 42976 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157995 157995 0 0.0
.text 1562034 1562034 0 0.0
ota-requestor-app debug (read only) 1884129 1884129 0 0.0
(read/write) 108768 108768 0 0.0
.bss 43392 43392 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4200 4200 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 152796 152796 0 0.0
.text 1581874 1581874 0 0.0
shell debug (read only) 2345513 2345513 0 0.0
(read/write) 144560 144560 0 0.0
.bss 64832 64832 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73224 73224 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206962 206962 0 0.0
.text 1981746 1981746 0 0.0
thermostat-no-ble arm64 (read only) 2157660 2157660 0 0.0
(read/write) 141841 141841 0 0.0
.bss 58641 58641 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75000 75000 0 0.0
.dynamic 560 560 0 0.0
.got 4192 4192 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 133244 133244 0 0.0
.text 1805888 1805888 0 0.0
tv-app debug (read only) 2532761 2532761 0 0.0
(read/write) 142592 142592 0 0.0
.bss 60320 60320 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197925 197925 0 0.0
.text 2161522 2161522 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427148 2436324 9176 0.4
.bss 189252 189660 408 0.2
.data 5328 5344 16 0.3
.text 1389720 1398896 9176 0.7
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2390284 2399588 9304 0.4
.bss 181784 182192 408 0.2
.data 5624 5640 16 0.3
.text 1352856 1362160 9304 0.7
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2325728 2335024 9296 0.4
.bss 180760 181168 408 0.2
.data 5600 5616 16 0.3
.text 1288328 1297624 9296 0.7
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316556 2325796 9240 0.4
.bss 179308 179716 408 0.2
.data 5432 5448 16 0.3
.text 1279128 1288368 9240 0.7
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1018755 1018755 0 0.0
bss 121460 121460 0 0.0
rodata 120368 120368 0 0.0
text 698024 698024 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 988051 988051 0 0.0
bss 118648 118648 0 0.0
rodata 111896 111896 0 0.0
text 677924 677924 0 0.0
nrf52840dongle_nrf52840 (read/write) 1033703 1033703 0 0.0
bss 122680 122680 0 0.0
rodata 119184 119184 0 0.0
text 701916 701916 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 925462 925462 0 0.0
bss 118024 118024 0 0.0
rodata 113608 113608 0 0.0
text 613040 613040 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 947459 947459 0 0.0
bss 119664 119664 0 0.0
rodata 109064 109064 0 0.0
text 640216 640216 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 854986 854986 0 0.0
bss 116256 116256 0 0.0
rodata 102236 102236 0 0.0
text 556008 556008 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 946035 946035 0 0.0
bss 119384 119384 0 0.0
rodata 108016 108016 0 0.0
text 640036 640036 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 941999 941999 0 0.0
bss 119388 119388 0 0.0
rodata 107716 107716 0 0.0
text 636276 636276 0 0.0
shell nrf52840dk_nrf52840 (read/write) 807447 807447 0 0.0
bss 111236 111236 0 0.0
rodata 79132 79132 0 0.0
text 539384 539384 0 0.0
p6 all-clusters-app default (read/write) 2484408 2484408 0 0.0
.bss 117568 117568 0 0.0
.data 2672 2672 0 0.0
.text 1442672 1442672 0 0.0
light-app default (read/write) 2391288 2391288 0 0.0
.bss 107248 107248 0 0.0
.data 2520 2520 0 0.0
.text 1349552 1349552 0 0.0
lock-app default (read/write) 2354752 2354752 0 0.0
.bss 106976 106976 0 0.0
.data 2480 2480 0 0.0
.text 1313016 1313016 0 0.0
qpg lighting-app qpg6105+debug (read only) 597492 597492 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89072 89072 0 0.0
.data 1108 1108 0 0.0
.text 592172 592172 0 0.0
lock-app qpg6105+debug (read only) 563116 563116 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89056 89056 0 0.0
.data 1060 1060 0 0.0
.text 557796 557796 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877166 877166 0 0.0
bss 88600 88600 0 0.0
noinit 37160 37160 0 0.0
text 616816 616816 0 0.0

Copy link
Contributor

@erjiaqing erjiaqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM for the usage of ScanNetworkCallback and ConnectNetworkCallback, please check the comment above (it should block this PR from merging).

@ATmobica ATmobica force-pushed the mbed-network-commissioning-driver branch from 039eede to 6e87bed Compare February 18, 2022 12:39
@github-actions
Copy link

github-actions bot commented Feb 18, 2022

PR #15041: Size comparison from 288007d to 6e87bed

Increases above 0.2%:

platform target config section 288007d 6e87bed change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2430884 2440116 9232 0.4
.data 5328 5344 16 0.3
.text 1393456 1402688 9232 0.7
lighting-app CY8CPROTO_062_4343W+release (read/write) 2392716 2401948 9232 0.4
.data 5632 5648 16 0.3
.text 1355288 1364520 9232 0.7
lock-app CY8CPROTO_062_4343W+release (read/write) 2328224 2337464 9240 0.4
.data 5608 5624 16 0.3
.text 1290824 1300064 9240 0.7
shell CY8CPROTO_062_4343W+release (read/write) 2319124 2328356 9232 0.4
.data 5440 5456 16 0.3
.text 1281696 1290928 9232 0.7
Increases (4 builds for mbed)
platform target config section 288007d 6e87bed change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2430884 2440116 9232 0.4
.bss 195924 196332 408 0.2
.data 5328 5344 16 0.3
.text 1393456 1402688 9232 0.7
lighting-app CY8CPROTO_062_4343W+release (read/write) 2392716 2401948 9232 0.4
.bss 188432 188840 408 0.2
.data 5632 5648 16 0.3
.text 1355288 1364520 9232 0.7
lock-app CY8CPROTO_062_4343W+release (read/write) 2328224 2337464 9240 0.4
.bss 187432 187840 408 0.2
.data 5608 5624 16 0.3
.text 1290824 1300064 9240 0.7
shell CY8CPROTO_062_4343W+release (read/write) 2319124 2328356 9232 0.4
.bss 185980 186388 408 0.2
.data 5440 5456 16 0.3
.text 1281696 1290928 9232 0.7
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 288007d 6e87bed change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599270 599270 0 0.0
.app_xip_area 503196 503196 0 0.0
.bss 78772 78772 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557306 557306 0 0.0
.app_xip_area 462776 462776 0 0.0
.bss 77268 77268 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578542 578542 0 0.0
.app_xip_area 474588 474588 0 0.0
.bss 86364 86364 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916188 916188 0 0.0
(read/write) 129508 129508 0 0.0
.bss 127472 127472 0 0.0
.data 2036 2036 0 0.0
.text 916180 916180 0 0.0
BRD4161A+rpc (read only) 944880 944880 0 0.0
(read/write) 146424 146424 0 0.0
.bss 144248 144248 0 0.0
.data 2176 2176 0 0.0
.text 944872 944872 0 0.0
window-app BRD4161A (read only) 850012 850012 0 0.0
(read/write) 127424 127424 0 0.0
.bss 125520 125520 0 0.0
.data 1904 1904 0 0.0
.text 850004 850004 0 0.0
esp32 all-clusters-app c3devkit (read only) 950394 950394 0 0.0
(read/write) 1401938 1401938 0 0.0
.dram0.bss 68512 68512 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200376 200376 0 0.0
.flash.text 950394 950394 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999911 999911 0 0.0
(read/write) 467208 467208 0 0.0
.dram0.bss 73656 73656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227360 227360 0 0.0
.flash.text 994527 994527 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692444 692444 0 0.0
.bss 78392 78392 0 0.0
.data 1912 1912 0 0.0
.text 606340 606340 0 0.0
lock k32w061+release (read/write) 695008 695008 0 0.0
.bss 78608 78608 0 0.0
.data 1952 1952 0 0.0
.text 608648 608648 0 0.0
linux all-clusters-app debug (read only) 2386345 2386345 0 0.0
(read/write) 151456 151456 0 0.0
.bss 65376 65376 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206949 206949 0 0.0
.text 2015810 2015810 0 0.0
bridge-app debug+rpc (read only) 1734829 1734829 0 0.0
(read/write) 94840 94840 0 0.0
.bss 49312 49312 0 0.0
.data 2010 2010 0 0.0
.data.rel.ro 38376 38376 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 142644 142644 0 0.0
.text 1475349 1475349 0 0.0
chip-tool debug (read only) 8989165 8989165 0 0.0
(read/write) 319568 319568 0 0.0
.bss 40728 40728 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 271624 271624 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 474005 474005 0 0.0
.text 7856885 7856885 0 0.0
chip-tool-ipv6only arm64 (read only) 8714700 8714700 0 0.0
(read/write) 431361 431361 0 0.0
.bss 58977 58977 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 316816 316816 0 0.0
.dynamic 560 560 0 0.0
.got 50560 50560 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 450500 450500 0 0.0
.text 7352756 7352756 0 0.0
door-lock-app debug (read only) 1947361 1947361 0 0.0
(read/write) 120904 120904 0 0.0
.bss 52000 52000 0 0.0
.data 986 986 0 0.0
.data.rel.ro 62496 62496 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 174172 174172 0 0.0
.text 1623682 1623682 0 0.0
lighting-app debug+rpc (read only) 2073825 2073825 0 0.0
(read/write) 125880 125880 0 0.0
.bss 52992 52992 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 65984 65984 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166737 166737 0 0.0
.text 1751442 1751442 0 0.0
ota-provider-app debug (read only) 1880729 1880729 0 0.0
(read/write) 116568 116568 0 0.0
.bss 51872 51872 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159003 159003 0 0.0
.text 1570114 1570114 0 0.0
ota-requestor-app debug (read only) 1893761 1893761 0 0.0
(read/write) 117952 117952 0 0.0
.bss 52288 52288 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 59080 59080 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153388 153388 0 0.0
.text 1590434 1590434 0 0.0
shell debug (read only) 2361217 2361217 0 0.0
(read/write) 153872 153872 0 0.0
.bss 73728 73728 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73632 73632 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 207986 207986 0 0.0
.text 1995778 1995778 0 0.0
thermostat-no-ble arm64 (read only) 2167628 2167628 0 0.0
(read/write) 151121 151121 0 0.0
.bss 67505 67505 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75384 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134060 0 0.0
.text 1814128 1814128 0 0.0
tv-app debug (read only) 2543241 2543241 0 0.0
(read/write) 152064 152064 0 0.0
.bss 69248 69248 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73576 73576 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 199117 199117 0 0.0
.text 2169778 2169778 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430884 2440116 9232 0.4
.bss 195924 196332 408 0.2
.data 5328 5344 16 0.3
.text 1393456 1402688 9232 0.7
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392716 2401948 9232 0.4
.bss 188432 188840 408 0.2
.data 5632 5648 16 0.3
.text 1355288 1364520 9232 0.7
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328224 2337464 9240 0.4
.bss 187432 187840 408 0.2
.data 5608 5624 16 0.3
.text 1290824 1300064 9240 0.7
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319124 2328356 9232 0.4
.bss 185980 186388 408 0.2
.data 5440 5456 16 0.3
.text 1281696 1290928 9232 0.7
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023323 1023323 0 0.0
bss 123532 123532 0 0.0
rodata 120904 120904 0 0.0
text 699864 699864 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 992635 992635 0 0.0
bss 120720 120720 0 0.0
rodata 112448 112448 0 0.0
text 679768 679768 0 0.0
nrf52840dongle_nrf52840 (read/write) 1038063 1038063 0 0.0
bss 124752 124752 0 0.0
rodata 119736 119736 0 0.0
text 703676 703676 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929918 929918 0 0.0
bss 120092 120092 0 0.0
rodata 114160 114160 0 0.0
text 614892 614892 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952087 952087 0 0.0
bss 121760 121760 0 0.0
rodata 109740 109740 0 0.0
text 641980 641980 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859566 859566 0 0.0
bss 118352 118352 0 0.0
rodata 102912 102912 0 0.0
text 557788 557788 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950663 950663 0 0.0
bss 121480 121480 0 0.0
rodata 108692 108692 0 0.0
text 641800 641800 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946611 946611 0 0.0
bss 121484 121484 0 0.0
rodata 108392 108392 0 0.0
text 638040 638040 0 0.0
shell nrf52840dk_nrf52840 (read/write) 811335 811335 0 0.0
bss 113328 113328 0 0.0
rodata 79676 79676 0 0.0
text 540684 540684 0 0.0
p6 all-clusters-app default (read/write) 2489304 2489304 0 0.0
.bss 124240 124240 0 0.0
.data 2672 2672 0 0.0
.text 1447568 1447568 0 0.0
light-app default (read/write) 2394568 2394568 0 0.0
.bss 113896 113896 0 0.0
.data 2528 2528 0 0.0
.text 1352832 1352832 0 0.0
lock-app default (read/write) 2358144 2358144 0 0.0
.bss 113648 113648 0 0.0
.data 2488 2488 0 0.0
.text 1316408 1316408 0 0.0
qpg lighting-app qpg6105+debug (read only) 600092 600092 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90952 0 0.0
.data 1112 1112 0 0.0
.text 594772 594772 0 0.0
lock-app qpg6105+debug (read only) 565860 565860 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90960 90960 0 0.0
.data 1064 1064 0 0.0
.text 560540 560540 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878710 878710 0 0.0
bss 87504 87504 0 0.0
noinit 37160 37160 0 0.0
text 618874 618874 0 0.0

@ATmobica ATmobica force-pushed the mbed-network-commissioning-driver branch from 6e87bed to b26a72e Compare February 21, 2022 11:39
@github-actions
Copy link

github-actions bot commented Feb 21, 2022

PR #15041: Size comparison from e71be1c to b26a72e

Increases above 0.2%:

platform target config section e71be1c3 b26a72e change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2430660 2439828 9168 0.4
.bss 194564 194972 408 0.2
.data 5328 5344 16 0.3
.text 1393232 1402400 9168 0.7
lighting-app CY8CPROTO_062_4343W+release (read/write) 2392780 2402012 9232 0.4
.bss 188432 188840 408 0.2
.data 5632 5648 16 0.3
.text 1355352 1364584 9232 0.7
lock-app CY8CPROTO_062_4343W+release (read/write) 2328224 2337464 9240 0.4
.bss 187432 187840 408 0.2
.data 5608 5624 16 0.3
.text 1290824 1300064 9240 0.7
shell CY8CPROTO_062_4343W+release (read/write) 2319124 2328356 9232 0.4
.bss 185980 186388 408 0.2
.data 5440 5456 16 0.3
.text 1281696 1290928 9232 0.7
Increases (4 builds for mbed)
platform target config section e71be1c3 b26a72e change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2430660 2439828 9168 0.4
.bss 194564 194972 408 0.2
.data 5328 5344 16 0.3
.text 1393232 1402400 9168 0.7
lighting-app CY8CPROTO_062_4343W+release (read/write) 2392780 2402012 9232 0.4
.bss 188432 188840 408 0.2
.data 5632 5648 16 0.3
.text 1355352 1364584 9232 0.7
lock-app CY8CPROTO_062_4343W+release (read/write) 2328224 2337464 9240 0.4
.bss 187432 187840 408 0.2
.data 5608 5624 16 0.3
.text 1290824 1300064 9240 0.7
shell CY8CPROTO_062_4343W+release (read/write) 2319124 2328356 9232 0.4
.bss 185980 186388 408 0.2
.data 5440 5456 16 0.3
.text 1281696 1290928 9232 0.7
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e71be1c3 b26a72e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599502 599502 0 0.0
.app_xip_area 503436 503436 0 0.0
.bss 78764 78764 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557538 557538 0 0.0
.app_xip_area 463016 463016 0 0.0
.bss 77260 77260 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578774 578774 0 0.0
.app_xip_area 474828 474828 0 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916484 916484 0 0.0
(read/write) 129500 129500 0 0.0
.bss 127464 127464 0 0.0
.data 2036 2036 0 0.0
.text 916476 916476 0 0.0
BRD4161A+rpc (read only) 945192 945192 0 0.0
(read/write) 146416 146416 0 0.0
.bss 144240 144240 0 0.0
.data 2176 2176 0 0.0
.text 945184 945184 0 0.0
window-app BRD4161A (read only) 850304 850304 0 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 850296 850296 0 0.0
esp32 all-clusters-app c3devkit (read only) 950408 950408 0 0.0
(read/write) 1400290 1400290 0 0.0
.dram0.bss 67144 67144 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200088 200088 0 0.0
.flash.text 950408 950408 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999903 999903 0 0.0
(read/write) 465560 465560 0 0.0
.dram0.bss 72296 72296 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227072 227072 0 0.0
.flash.text 994519 994519 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692692 692692 0 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 606596 606596 0 0.0
lock k32w061+release (read/write) 695256 695256 0 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 608904 608904 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8781772 8781772 0 0.0
(read/write) 432641 432641 0 0.0
.bss 58977 58977 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 317776 317776 0 0.0
.dynamic 560 560 0 0.0
.got 50880 50880 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 454596 454596 0 0.0
.text 7412804 7412804 0 0.0
thermostat-no-ble arm64 (read only) 2167740 2167740 0 0.0
(read/write) 151137 151137 0 0.0
.bss 67521 67521 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75384 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134060 0 0.0
.text 1814240 1814240 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430660 2439828 9168 0.4
.bss 194564 194972 408 0.2
.data 5328 5344 16 0.3
.text 1393232 1402400 9168 0.7
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392780 2402012 9232 0.4
.bss 188432 188840 408 0.2
.data 5632 5648 16 0.3
.text 1355352 1364584 9232 0.7
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328224 2337464 9240 0.4
.bss 187432 187840 408 0.2
.data 5608 5624 16 0.3
.text 1290824 1300064 9240 0.7
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319124 2328356 9232 0.4
.bss 185980 186388 408 0.2
.data 5440 5456 16 0.3
.text 1281696 1290928 9232 0.7
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023579 1023579 0 0.0
bss 123528 123528 0 0.0
rodata 120984 120984 0 0.0
text 700044 700044 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 992891 992891 0 0.0
bss 120716 120716 0 0.0
rodata 112528 112528 0 0.0
text 679948 679948 0 0.0
nrf52840dongle_nrf52840 (read/write) 1038335 1038335 0 0.0
bss 124748 124748 0 0.0
rodata 119816 119816 0 0.0
text 703856 703856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 930190 930190 0 0.0
bss 120088 120088 0 0.0
rodata 114240 114240 0 0.0
text 615072 615072 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952343 952343 0 0.0
bss 121756 121756 0 0.0
rodata 109820 109820 0 0.0
text 642160 642160 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859822 859822 0 0.0
bss 118348 118348 0 0.0
rodata 102992 102992 0 0.0
text 557964 557964 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950919 950919 0 0.0
bss 121476 121476 0 0.0
rodata 108772 108772 0 0.0
text 641980 641980 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946867 946867 0 0.0
bss 121480 121480 0 0.0
rodata 108472 108472 0 0.0
text 638220 638220 0 0.0
shell nrf52840dk_nrf52840 (read/write) 811543 811543 0 0.0
bss 113324 113324 0 0.0
rodata 79756 79756 0 0.0
text 540812 540812 0 0.0
p6 all-clusters-app default (read/write) 2489048 2489048 0 0.0
.bss 122872 122872 0 0.0
.data 2672 2672 0 0.0
.text 1447312 1447312 0 0.0
light-app default (read/write) 2394600 2394600 0 0.0
.bss 113896 113896 0 0.0
.data 2528 2528 0 0.0
.text 1352864 1352864 0 0.0
lock-app default (read/write) 2358176 2358176 0 0.0
.bss 113648 113648 0 0.0
.data 2488 2488 0 0.0
.text 1316440 1316440 0 0.0
qpg lighting-app qpg6105+debug (read only) 600348 600348 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90944 90944 0 0.0
.data 1112 1112 0 0.0
.text 595028 595028 0 0.0
lock-app qpg6105+debug (read only) 566108 566108 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90952 0 0.0
.data 1064 1064 0 0.0
.text 560788 560788 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878766 878766 0 0.0
bss 87500 87500 0 0.0
noinit 37160 37160 0 0.0
text 618928 618928 0 0.0

@woody-apple woody-apple merged commit b4921fc into project-chip:master Feb 21, 2022
@ATmobica ATmobica deleted the mbed-network-commissioning-driver branch May 11, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants