-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mbed] Fix network commissioning - add network commissioning driver #15041
[Mbed] Fix network commissioning - add network commissioning driver #15041
Conversation
PR #15041: Size comparison from 6fa8e4c to 228f382 Full report (38 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
|
91d2902
to
be7e0cc
Compare
PR #15041: Size comparison from 0edb9f9 to be7e0cc Full report (29 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
|
be7e0cc
to
7857815
Compare
PR #15041: Size comparison from d671a52 to 7857815 Increases above 0.2%:
Increases (4 builds for mbed)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
7857815
to
026b09b
Compare
PR #15041: Size comparison from 6103a69 to 026b09b Increases above 0.2%:
Increases (4 builds for mbed)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM for the usage of ScanNetworkCallback and ConnectNetworkCallback, please check the comment above (it should block this PR from merging).
039eede
to
6e87bed
Compare
PR #15041: Size comparison from 288007d to 6e87bed Increases above 0.2%:
Increases (4 builds for mbed)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Add WiFi Driver
Create ConnectivityManagerImpl_WiFi class Remove deprecated functions calling
Passing config data model flag to gn build Fix Wifi driver initialization for no data model examples
6e87bed
to
b26a72e
Compare
PR #15041: Size comparison from e71be1c to b26a72e Increases above 0.2%:
Increases (4 builds for mbed)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
Mbed examples commissioning failed because of lack NetworkCommissioningDriver with Wifi driver.
We need to also create app::Clusters::NetworkCommissioning::Instance with our driver.
Fix issue: #13170
Change overview
Add Network Commissioning Driver class implementation
Add Wifi Driver class implementation
Use Mbed Wifi driver in NetworkProvisioningDelegateImpl class
Wifi interface separation from ConnectivityManagerImpl class - now ConnectivityManagerImp class is responsible only for common connectivity services.
Create ConnectivityManagerImpl_WiFi class - this class is responsible for Wifi connectivity service.
Remove deprecated functions calling
Testing
Build and run Mbed examples - WiFi commissioning node device.
Required PRs: