-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all-clusters-app] Allow more subscriptions opened at the same time #15029
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:CI_Darwin_TestMoreSubscriptionsOnTheServerSide
Feb 10, 2022
Merged
[all-clusters-app] Allow more subscriptions opened at the same time #15029
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:CI_Darwin_TestMoreSubscriptionsOnTheServerSide
Feb 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov and
LuDuda
February 10, 2022 13:21
pullapprove
bot
requested review from
lzgrablic02,
mlepage-google,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
February 10, 2022 13:21
jmeg-sfy
approved these changes
Feb 10, 2022
PR #15029: Size comparison from f0baba8 to f01b7f9 Full report (17 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
vivien-apple
force-pushed
the
CI_Darwin_TestMoreSubscriptionsOnTheServerSide
branch
from
February 10, 2022 14:06
f01b7f9
to
b097269
Compare
msandstedt
approved these changes
Feb 10, 2022
PR #15029: Size comparison from a08613b to b097269 Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
vivien-apple
force-pushed
the
CI_Darwin_TestMoreSubscriptionsOnTheServerSide
branch
from
February 10, 2022 16:06
b097269
to
93bdae4
Compare
PR #15029: Size comparison from a08613b to 93bdae4 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking, given this should help CI not randomly fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ToT is randomly red with the Darwin CI because #14606 has added more subscriptions and the accessory can not keep up.
Change overview
CHIP_IM_MAX_NUM_READ_CLIENT
macroTesting
I have tried by running
xcodebuild test -target "CHIP" -scheme "CHIP Framework Tests" -sdk macosx
3 times in a row without failure.