Prevent the DUT from getting killed with the signal to trigger the event #15004

yufengwangca · 2022-02-10T02:14:23Z

Problem

What is being fixed? Examples:

From CSG
"We launched the DUT and commissioned with TH and later killed the DUT by passing "kill -SIGTRAP pid "command, then we again reprovisioned the app, read and subscribed the software-fault event its passing with success code but didnt get expected outcome."

Currently, the event is not preserved over the power cycle, the subscribers of those events might not be able to receive those events before the app get killed.

Change overview

Prevent the DUT from getting killed with the signal to trigger the event

Testing

How was this tested? (at least one bullet point required)

Confirm the event are logged and DUT is not rebooted.

client:
yufengw@yufengw-SEi:~$ kill -SIGUSR1 182021
yufengw@yufengw-SEi:~$ 
yufengw@yufengw-SEi:~$ kill -SIGUSR2 182021
yufengw@yufengw-SEi:~$ 
yufengw@yufengw-SEi:~$ kill -SIGHUP 182021
yufengw@yufengw-SEi:~$ 
yufengw@yufengw-SEi:~$ kill -SIGTERM 182021
yufengw@yufengw-SEi:~$ 
yufengw@yufengw-SEi:~$ kill -SIGTSTP 182021

server:
[1644458674.224290][182021:182021] CHIP:DL: Caught signal 10
[1644458674.224325][182021:182021] CHIP:ZCL: SoftwareDiagnosticsDelegate: OnSoftwareFaultDetected
[1644458674.224360][182021:182021] CHIP:EVL: LogEvent event number: 0x0000000000020001 priority: 1, endpoint id:  0x0 cluster id: 0x0000_0034 event id: 0x0 Sys timestamp: 0x000000000A789693
[1644458674.224380][182021:182021] CHIP:DL: select failed: ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/system/SystemLayerImplSelect.cpp:378: OS Error 0x02000004: Interrupted system call

[1644458678.394146][182021:182021] CHIP:DL: Caught signal 12
[1644458678.394241][182021:182021] CHIP:ZCL: GeneralDiagnosticsDelegate: OnHardwareFaultsDetected
[1644458678.394283][182021:182021] CHIP:DMG: Endpoint 0, Cluster 0x0000_0033 update version to b22c0522
[1644458678.394430][182021:182021] CHIP:EVL: LogEvent event number: 0x0000000000020002 priority: 2, endpoint id:  0x0 cluster id: 0x0000_0033 event id: 0x0 Sys timestamp: 0x000000000A78A6DD
[1644458678.394529][182021:182021] CHIP:DL: select failed: ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/system/SystemLayerImplSelect.cpp:378: OS Error 0x02000004: Interrupted system call

[1644458695.649630][182021:182021] CHIP:DL: Caught signal 1
[1644458695.649715][182021:182021] CHIP:ZCL: GeneralDiagnosticsDelegate: OnHardwareFaultsDetected
[1644458695.649748][182021:182021] CHIP:DMG: Endpoint 0, Cluster 0x0000_0033 update version to b22c0523
[1644458695.649902][182021:182021] CHIP:EVL: LogEvent event number: 0x0000000000020003 priority: 2, endpoint id:  0x0 cluster id: 0x0000_0033 event id: 0x1 Sys timestamp: 0x000000000A78EA44
[1644458695.649993][182021:182021] CHIP:DL: select failed: ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/system/SystemLayerImplSelect.cpp:378: OS Error 0x02000004: Interrupted system call

[1644458720.416125][182021:182021] CHIP:DL: Caught signal 15
[1644458720.416207][182021:182021] CHIP:ZCL: GeneralDiagnosticsDelegate: OnHardwareFaultsDetected
[1644458720.416244][182021:182021] CHIP:DMG: Endpoint 0, Cluster 0x0000_0033 update version to b22c0524
[1644458720.416436][182021:182021] CHIP:EVL: LogEvent event number: 0x0000000000020004 priority: 2, endpoint id:  0x0 cluster id: 0x0000_0033 event id: 0x2 Sys timestamp: 0x000000000A794B03
[1644458720.416517][182021:182021] CHIP:DL: select failed: ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/system/SystemLayerImplSelect.cpp:378: OS Error 0x02000004: Interrupted system call

[1644458767.246083][182021:182021] CHIP:DL: Caught signal 20
[1644458767.246166][182021:182021] CHIP:ZCL: SwitchDelegate: OnSwitchLatched
[1644458767.246283][182021:182021] CHIP:EVL: LogEvent event number: 0x0000000000020005 priority: 1, endpoint id:  0x0 cluster id: 0x0000_003B event id: 0x0 Sys timestamp: 0x000000000A7A01F0
[1644458767.246372][182021:182021] CHIP:DL: select failed: ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/system/SystemLayerImplSelect.cpp:378: OS Error 0x02000004: Interrupted system call

github-actions · 2022-02-10T02:40:56Z

PR #15004: Size comparison from 56634bf to d1be6e4

Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`56634bf`	`d1be6e4`
cyw30739	light	cyw930739m2evb_01	(read/write)	606682	606682
			.app_xip_area	508112	508112
			.bss	81268	81268
			.data	648	648
			.rodata	0	0
			.text	0	0
	lock	cyw930739m2evb_01	(read/write)	563158	563158
			.app_xip_area	466148	466148
			.bss	79740	79740
			.data	612	612
			.rodata	0	0
			.text	0	0
	ota-requestor	cyw930739m2evb_01	(read/write)	584170	584170
			.app_xip_area	477912	477912
			.bss	88660	88660
			.data	556	556
			.rodata	0	0
			.text	112	112
efr32	lighting-app	BRD4161A	(read only)	906792	906792
			(read/write)	129000	129000
			.bss	126960	126960
			.data	2036	2036
			.text	906784	906784
		BRD4161A+rpc	(read only)	894236	894236
			(read/write)	145656	145656
			.bss	143520	143520
			.data	2136	2136
			.text	894228	894228
	window-app	BRD4161A	(read only)	841920	841920
			(read/write)	127064	127064
			.bss	125160	125160
			.data	1904	1904
			.text	841912	841912
esp32	all-clusters-app	c3devkit	(read only)	943304	943304
			(read/write)	1400250	1400250
			.dram0.bss	68024	68024
			.dram0.data	14276	14276
			.flash.rodata	199040	199040
			.flash.text	943304	943304
			.iram0.text	62056	62056
		m5stack	(read only)	990967	990967
			(read/write)	465080	465080
			.dram0.bss	73168	73168
			.dram0.data	34072	34072
			.flash.rodata	225712	225712
			.flash.text	985583	985583
			.iram0.text	123399	123399
k32w	light	k32w061+release	(read/write)	683544	683544
			.bss	78264	78264
			.data	1908	1908
			.text	597572	597572
	lock	k32w061+release	(read/write)	688408	688408
			.bss	78664	78664
			.data	1952	1952
			.text	601992	601992
linux	chip-tool-ipv6only	arm64	(read only)	`7478116`	`7478116`
			(read/write)	303409	303409
			.bss	51777	51777
			.data	1224	1224
			.data.rel.ro	199520	199520
			.dynamic	560	560
			.got	47088	47088
			.init	24	24
			.init_array	192	192
			.rodata	403020	403020
			.text	6435220	6435220
	thermostat-no-ble	arm64	(read only)	`2139804`	`2139804`
			(read/write)	142273	142273
			.bss	59201	59201
			.data	1040	1040
			.data.rel.ro	74912	74912
			.dynamic	560	560
			.got	4152	4152
			.init	24	24
			.init_array	328	328
			.rodata	132956	132956
			.text	1788736	1788736
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2396072	2396072
			.bss	190092	190092
			.data	5320	5320
			.text	1358672	1358672
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2357760`	`2357760`
			.bss	182704	182704
			.data	5632	5632
			.text	1320360	1320360
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2321288	2321288
			.bss	182592	182592
			.data	5608	5608
			.text	1283888	1283888
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139648	1139648
			.bss	11756	11756
			.data	4368	4368
			.text	103032	103032
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2307292`	`2307292`
			.bss	179844	179844
			.data	5424	5424
			.text	1269864	1269864
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	`1015363`	`1015363`
			bss	123020	123020
			rodata	119416	119416
			text	693908	693908
		nrf52840dk_nrf52840+rpc	(read/write)	984183	984183
			bss	120208	120208
			rodata	110780	110780
			text	673520	673520
		nrf52840dongle_nrf52840	(read/write)	1031067	1031067
			bss	124416	124416
			rodata	118276	118276
			text	698528	698528
		nrf5340dk_nrf5340_cpuapp	(read/write)	921958	921958
			bss	119584	119584
			rodata	112656	112656
			text	608944	608944
	lock-app	nrf52840dk_nrf52840	(read/write)	945083	945083
			bss	121400	121400
			rodata	108160	108160
			text	636948	636948
		nrf5340dk_nrf5340_cpuapp	(read/write)	852594	852594
			bss	117992	117992
			rodata	101332	101332
			text	552756	552756
	pigweed-app	nrf52840dk_nrf52840	(read/write)	527595	527595
			bss	53632	53632
			rodata	49976	49976
			text	361016	361016
	pump-app	nrf52840dk_nrf52840	(read/write)	944507	944507
			bss	121120	121120
			rodata	107520	107520
			text	637208	637208
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	939847	939847
			bss	121124	121124
			rodata	106812	106812
			text	633244	633244
	shell	nrf52840dk_nrf52840	(read/write)	805927	805927
			bss	112400	112400
			rodata	78812	78812
			text	537036	537036
p6	all-clusters-app	default	(read/write)	2482304	2482304
			.bss	119704	119704
			.data	2672	2672
			.text	1440568	1440568
	light-app	default	(read/write)	2388648	2388648
			.bss	109352	109352
			.data	2528	2528
			.text	1346912	1346912
	lock-app	default	(read/write)	`2352104`	`2352104`
			.bss	109072	109072
			.data	2488	2488
			.text	1310368	1310368
qpg	lighting-app	qpg6105+debug	(read only)	592956	592956
			(read/write)	146940	146940
			.bss	90536	90536
			.data	1112	1112
			.text	587636	587636
	lock-app	qpg6105+debug	(read only)	558708	558708
			(read/write)	146940	146940
			.bss	90520	90520
			.data	1064	1064
			.text	553388	553388
	persistent-storage-app	qpg6105+debug	(read only)	99520	99520
			(read/write)	146940	146940
			.bss	24004	24004
			.data	176	176
			.text	94200	94200
telink	lighting-app	tlsr9518adk80d	(read/write)	874334	874334
			bss	90352	90352
			noinit	37160	37160
			text	613082	613082

Prevent the DUT from getting killed with the signal to trigger the event

d1be6e4

boring-cyborg bot added linux platform labels Feb 10, 2022

pullapprove bot requested review from mrjerryjohns, msandstedt, sagar-apple, saurabhst, selissia, tcarmelveilleux, tecimovic, turon, vijs, vivien-apple, wbschiller, woody-apple, xylophone21 and yunhanw-google February 10, 2022 02:14

pullapprove bot added the review - pending label Feb 10, 2022

bzbarsky-apple approved these changes Feb 10, 2022

View reviewed changes

jmartinez-silabs approved these changes Feb 10, 2022

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Feb 10, 2022

woody-apple merged commit cfab82d into project-chip:master Feb 10, 2022

yufengwangca deleted the pr/event/signals branch February 11, 2022 08:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent the DUT from getting killed with the signal to trigger the event #15004

Prevent the DUT from getting killed with the signal to trigger the event #15004

yufengwangca commented Feb 10, 2022

github-actions bot commented Feb 10, 2022 •

edited

Loading

Prevent the DUT from getting killed with the signal to trigger the event #15004

Prevent the DUT from getting killed with the signal to trigger the event #15004

Conversation

yufengwangca commented Feb 10, 2022

Problem

Change overview

Testing

github-actions bot commented Feb 10, 2022 • edited Loading

github-actions bot commented Feb 10, 2022 •

edited

Loading