Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable server interactions on Controllers #14998

Merged
merged 9 commits into from
Mar 1, 2022
Merged

Enable server interactions on Controllers #14998

merged 9 commits into from
Mar 1, 2022

Conversation

mrjerryjohns
Copy link
Contributor

@mrjerryjohns mrjerryjohns commented Feb 10, 2022 •
edited
Loading

Problem

For controllers that happen to also provide server functionality, there is no way today to even initiate CASE to a controller from another device. This is key for an OTA provider to function correctly.

Change overview

Adds a new enableServerInteractions parameter that can be used when creating DeviceController/DeviceCommissioner AND initializing the DeviceControllerFactory to:

  1. Instantiate a CASEServer and enable listening for session establishment.
  2. Initialize the DNS-SD server
  3. Anytime a DeviceController is created and an identity bestowed upon it, advertise that identity over mDNS.

WARNING: This will not work over IPv4, and will only work over IPv6.

Testing

Creates two Python REPL instances with matching fabric credentials in persistent storage.

On the first REPL instance, ran:

devCtrl2 = fabricAdmins[0].NewController(nodeId=22)

On the second REPL instance, ran:

devCtrl.ResolveNode(22)

Confirmed that ResolveNode returned 'true' and that the logs showed that CASE was established.

@mrjerryjohns mrjerryjohns force-pushed the case-server-on-controller branch from 14c4eb0 to 20d5f21 Compare February 10, 2022 01:01
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #14998: Size comparison from 14eb3f5 to 20d5f21

Increases (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg)
platform target config section 14eb3f5 20d5f21 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605970 606058 88 0.0
.app_xip_area 507480 507572 92 0.0
.bss 81188 81216 28 0.0
lock cyw930739m2evb_01 (read/write) 562590 562698 108 0.0
.app_xip_area 465660 465764 104 0.0
.bss 79660 79696 36 0.0
ota-requestor cyw930739m2evb_01 (read/write) 583606 583706 100 0.0
.app_xip_area 477428 477528 100 0.0
.bss 88580 88612 32 0.0
efr32 lighting-app BRD4161A (read only) 906088 906648 560 0.1
.bss 126880 126904 24 0.0
.text 906080 906640 560 0.1
BRD4161A+rpc (read only) 893532 894104 572 0.1
(read/write) 145576 145584 8 0.0
.bss 143440 143472 32 0.0
.text 893524 894096 572 0.1
window-app BRD4161A (read only) 841344 841924 580 0.1
(read/write) 126984 126992 8 0.0
.bss 125080 125112 32 0.0
.text 841336 841916 580 0.1
esp32 all-clusters-app c3devkit (read only) 942230 942398 168 0.0
(read/write) 1400058 1400074 16 0.0
.dram0.bss 67944 67976 32 0.0
.flash.text 942230 942398 168 0.0
m5stack (read only) 990019 990183 164 0.0
(read/write) 464896 464912 16 0.0
.dram0.bss 73088 73120 32 0.0
.flash.text 984635 984799 164 0.0
k32w light k32w061+release (read/write) 682956 683088 132 0.0
.bss 78184 78224 40 0.1
.text 597064 597180 116 0.0
lock k32w061+release (read/write) 687836 687960 124 0.0
.bss 78584 78624 40 0.1
.text 601500 601612 112 0.0
linux chip-tool-ipv6only arm64 (read only) 7438276 7439972 1696 0.0
(read/write) 302977 303025 48 0.0
.bss 51681 51729 48 0.1
.got 47040 47048 8 0.0
.rodata 402108 402236 128 0.0
.text 6396996 6398532 1536 0.0
thermostat-no-ble arm64 (read only) 2136556 2136764 208 0.0
(read/write) 142097 142129 32 0.0
.bss 59105 59137 32 0.1
.got 4152 4160 8 0.2
.text 1785616 1785808 192 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2394992 2395120 128 0.0
.bss 190012 190036 24 0.0
.text 1357592 1357720 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2357136 2357264 128 0.0
.bss 182624 182648 24 0.0
.text 1319736 1319864 128 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2320856 2320984 128 0.0
.bss 182512 182536 24 0.0
.text 1283456 1283584 128 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2306852 2306980 128 0.0
.bss 179764 179796 32 0.0
.text 1269424 1269552 128 0.0
p6 all-clusters-app default (read/write) 2481072 2481624 552 0.0
.bss 119624 119656 32 0.0
.text 1439336 1439888 552 0.0
light-app default (read/write) 2387944 2388512 568 0.0
.bss 109272 109296 24 0.0
.text 1346208 1346776 568 0.0
lock-app default (read/write) 2351544 2352120 576 0.0
.bss 108992 109016 24 0.0
.text 1309808 1310384 576 0.0
qpg lighting-app qpg6105+debug (read only) 592292 592428 136 0.0
.bss 90496 90536 40 0.0
.text 586972 587108 136 0.0
lock-app qpg6105+debug (read only) 558188 558304 116 0.0
.bss 90480 90520 40 0.0
.text 552868 552984 116 0.0
Decreases (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg)
platform target config section 14eb3f5 20d5f21 change % change
cyw30739 light cyw930739m2evb_01 .data 648 620 -28 -4.3
lock cyw930739m2evb_01 .data 612 584 -28 -4.6
ota-requestor cyw930739m2evb_01 .data 556 528 -28 -5.0
efr32 lighting-app BRD4161A (read/write) 128920 128912 -8 -0.0
.data 2036 2008 -28 -1.4
BRD4161A+rpc .data 2136 2108 -28 -1.3
window-app BRD4161A .data 1904 1880 -24 -1.3
esp32 all-clusters-app c3devkit .dram0.data 14252 14236 -16 -0.1
m5stack .dram0.data 34048 34032 -16 -0.0
k32w light k32w061+release .data 1908 1884 -24 -1.3
lock k32w061+release .data 1952 1924 -28 -1.4
linux chip-tool-ipv6only arm64 .data 1224 1208 -16 -1.3
thermostat-no-ble arm64 .data 1040 1024 -16 -1.5
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5304 5280 -24 -0.5
lighting-app CY8CPROTO_062_4343W+release .data 5632 5608 -24 -0.4
lock-app CY8CPROTO_062_4343W+release .data 5608 5592 -16 -0.3
shell CY8CPROTO_062_4343W+release .data 5424 5400 -24 -0.4
p6 all-clusters-app default .data 2656 2632 -24 -0.9
light-app default .data 2528 2504 -24 -0.9
lock-app default .data 2488 2464 -24 -1.0
qpg lighting-app qpg6105+debug .data 1112 1088 -24 -2.2
lock-app qpg6105+debug .data 1064 1040 -24 -2.3
Full report (23 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg)
platform target config section 14eb3f5 20d5f21 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605970 606058 88 0.0
.app_xip_area 507480 507572 92 0.0
.bss 81188 81216 28 0.0
.data 648 620 -28 -4.3
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 562590 562698 108 0.0
.app_xip_area 465660 465764 104 0.0
.bss 79660 79696 36 0.0
.data 612 584 -28 -4.6
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 583606 583706 100 0.0
.app_xip_area 477428 477528 100 0.0
.bss 88580 88612 32 0.0
.data 556 528 -28 -5.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906088 906648 560 0.1
(read/write) 128920 128912 -8 -0.0
.bss 126880 126904 24 0.0
.data 2036 2008 -28 -1.4
.text 906080 906640 560 0.1
BRD4161A+rpc (read only) 893532 894104 572 0.1
(read/write) 145576 145584 8 0.0
.bss 143440 143472 32 0.0
.data 2136 2108 -28 -1.3
.text 893524 894096 572 0.1
window-app BRD4161A (read only) 841344 841924 580 0.1
(read/write) 126984 126992 8 0.0
.bss 125080 125112 32 0.0
.data 1904 1880 -24 -1.3
.text 841336 841916 580 0.1
esp32 all-clusters-app c3devkit (read only) 942230 942398 168 0.0
(read/write) 1400058 1400074 16 0.0
.dram0.bss 67944 67976 32 0.0
.dram0.data 14252 14236 -16 -0.1
.flash.rodata 198960 198960 0 0.0
.flash.text 942230 942398 168 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 990019 990183 164 0.0
(read/write) 464896 464912 16 0.0
.dram0.bss 73088 73120 32 0.0
.dram0.data 34048 34032 -16 -0.0
.flash.rodata 225632 225632 0 0.0
.flash.text 984635 984799 164 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 682956 683088 132 0.0
.bss 78184 78224 40 0.1
.data 1908 1884 -24 -1.3
.text 597064 597180 116 0.0
lock k32w061+release (read/write) 687836 687960 124 0.0
.bss 78584 78624 40 0.1
.data 1952 1924 -28 -1.4
.text 601500 601612 112 0.0
linux chip-tool-ipv6only arm64 (read only) 7438276 7439972 1696 0.0
(read/write) 302977 303025 48 0.0
.bss 51681 51729 48 0.1
.data 1224 1208 -16 -1.3
.data.rel.ro 199240 199240 0 0.0
.dynamic 560 560 0 0.0
.got 47040 47048 8 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 402108 402236 128 0.0
.text 6396996 6398532 1536 0.0
thermostat-no-ble arm64 (read only) 2136556 2136764 208 0.0
(read/write) 142097 142129 32 0.0
.bss 59105 59137 32 0.1
.data 1040 1024 -16 -1.5
.data.rel.ro 74840 74840 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4160 8 0.2
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132892 132892 0 0.0
.text 1785616 1785808 192 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2394992 2395120 128 0.0
.bss 190012 190036 24 0.0
.data 5304 5280 -24 -0.5
.text 1357592 1357720 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357136 2357264 128 0.0
.bss 182624 182648 24 0.0
.data 5632 5608 -24 -0.4
.text 1319736 1319864 128 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2320856 2320984 128 0.0
.bss 182512 182536 24 0.0
.data 5608 5592 -16 -0.3
.text 1283456 1283584 128 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2306852 2306980 128 0.0
.bss 179764 179796 32 0.0
.data 5424 5400 -24 -0.4
.text 1269424 1269552 128 0.0
p6 all-clusters-app default (read/write) 2481072 2481624 552 0.0
.bss 119624 119656 32 0.0
.data 2656 2632 -24 -0.9
.text 1439336 1439888 552 0.0
light-app default (read/write) 2387944 2388512 568 0.0
.bss 109272 109296 24 0.0
.data 2528 2504 -24 -0.9
.text 1346208 1346776 568 0.0
lock-app default (read/write) 2351544 2352120 576 0.0
.bss 108992 109016 24 0.0
.data 2488 2464 -24 -1.0
.text 1309808 1310384 576 0.0
qpg lighting-app qpg6105+debug (read only) 592292 592428 136 0.0
(read/write) 146940 146940 0 0.0
.bss 90496 90536 40 0.0
.data 1112 1088 -24 -2.2
.text 586972 587108 136 0.0
lock-app qpg6105+debug (read only) 558188 558304 116 0.0
(read/write) 146940 146940 0 0.0
.bss 90480 90520 40 0.0
.data 1064 1040 -24 -2.3
.text 552868 552984 116 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0

bzbarsky-apple
bzbarsky-apple requested changes Feb 10, 2022
View reviewed changes
src/controller/CHIPDeviceControllerFactory.cpp Outdated Show resolved Hide resolved
src/controller/CHIPDeviceControllerFactory.cpp Outdated Show resolved Hide resolved
src/controller/CHIPDeviceControllerFactory.cpp Outdated Show resolved Hide resolved
src/controller/CHIPDeviceControllerFactory.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 14, 2022 •
edited
Loading

PR #14998: Size comparison from 4d510a3 to fa9d6de

Increases above 0.2%:

platform target config section 4d510a3 fa9d6de change % change
cyw30739 light cyw930739m2evb_01 .data 644 652 8 1.2
lock cyw930739m2evb_01 .data 608 616 8 1.3
ota-requestor cyw930739m2evb_01 .data 552 560 8 1.4
efr32 lighting-app BRD4161A .data 2032 2040 8 0.4
BRD4161A+rpc .data 2172 2180 8 0.4
window-app BRD4161A .data 1900 1908 8 0.4
k32w light k32w061+release .data 1904 1912 8 0.4
lock k32w061+release .data 1948 1956 8 0.4
linux all-clusters-app debug .data 1296 1328 32 2.5
bridge-app debug+rpc .data 2034 2048 14 0.7
door-lock-app debug .data 1010 1024 14 1.4
ota-provider-app debug .data 1224 1256 32 2.6
ota-requestor-app debug .data 1160 1192 32 2.8
shell debug .data 832 864 32 3.8
thermostat-no-ble arm64 .data 1032 1048 16 1.6
tv-app debug .data 3200 3232 32 1.0
p6 all-clusters-app default .data 2672 2680 8 0.3
light-app default .data 2520 2528 8 0.3
lock-app default .data 2480 2488 8 0.3
qpg lighting-app qpg6105+debug .data 1108 1116 8 0.7
lock-app qpg6105+debug .data 1060 1068 8 0.8
Increases (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg)
platform target config section 4d510a3 fa9d6de change % change
cyw30739 light cyw930739m2evb_01 (read/write) 592750 592758 8 0.0
.app_xip_area 498228 498232 4 0.0
.data 644 652 8 1.2
lock cyw930739m2evb_01 (read/write) 550810 550818 8 0.0
.app_xip_area 457856 457860 4 0.0
.data 608 616 8 1.3
ota-requestor cyw930739m2evb_01 (read/write) 569322 569334 12 0.0
.app_xip_area 467112 467116 4 0.0
.data 552 560 8 1.4
efr32 lighting-app BRD4161A .data 2032 2040 8 0.4
BRD4161A+rpc .data 2172 2180 8 0.4
window-app BRD4161A .data 1900 1908 8 0.4
esp32 all-clusters-app c3devkit (read only) 944944 944992 48 0.0
(read/write) 1398610 1398626 16 0.0
.dram0.data 14268 14276 8 0.1
.flash.text 944944 944992 48 0.0
m5stack (read only) 994935 994951 16 0.0
(read/write) 463896 463904 8 0.0
.dram0.data 34064 34072 8 0.0
.flash.text 989551 989567 16 0.0
k32w light k32w061+release (read/write) 683220 683260 40 0.0
.data 1904 1912 8 0.4
.text 598860 598892 32 0.0
lock k32w061+release (read/write) 688772 688812 40 0.0
.data 1948 1956 8 0.4
.text 603976 604008 32 0.0
linux all-clusters-app debug (read only) 2357265 2357681 416 0.0
(read/write) 140000 140032 32 0.0
.data 1296 1328 32 2.5
.rodata 205797 205957 160 0.1
.text 1989122 1989378 256 0.0
bridge-app debug+rpc (read only) 1726269 1726653 384 0.0
(read/write) 84200 84208 8 0.0
.bss 38928 38936 8 0.0
.data 2034 2048 14 0.7
.rodata 141676 141804 128 0.1
.text 1467973 1468229 256 0.0
door-lock-app debug (read only) 1931425 1931841 416 0.0
(read/write) 110488 110536 48 0.0
.bss 42000 42016 16 0.0
.data 1010 1024 14 1.4
.data.rel.ro 62080 62088 8 0.0
.rodata 173074 173234 160 0.1
.text 1609762 1610018 256 0.0
lighting-app debug+rpc (read only) 2055073 2055489 416 0.0
.rodata 165393 165553 160 0.1
.text 1734866 1735122 256 0.0
ota-provider-app debug (read only) 1864241 1864625 384 0.0
(read/write) 106200 106232 32 0.0
.data 1224 1256 32 2.6
.rodata 157643 157771 128 0.1
.text 1555938 1556194 256 0.0
ota-requestor-app debug (read only) 1859665 1860049 384 0.0
(read/write) 107288 107320 32 0.0
.data 1160 1192 32 2.8
.rodata 151196 151324 128 0.1
.text 1559554 1559810 256 0.0
shell debug (read only) 2341625 2341977 352 0.0
(read/write) 141488 141520 32 0.0
.data 832 864 32 3.8
.rodata 206674 206770 96 0.0
.text 1978098 1978354 256 0.0
thermostat-no-ble arm64 (read only) 2151068 2151516 448 0.0
(read/write) 140689 140705 16 0.0
.data 1032 1048 16 1.6
.rodata 132908 133036 128 0.1
.text 1799904 1800224 320 0.0
tv-app debug (read only) 2529193 2530473 1280 0.1
(read/write) 139232 139264 32 0.0
.data 3200 3232 32 1.0
.rodata 197669 197893 224 0.1
.text 2158482 2159538 1056 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5320 5328 8 0.2
lighting-app CY8CPROTO_062_4343W+release .data 5624 5632 8 0.1
lock-app CY8CPROTO_062_4343W+release .data 5600 5608 8 0.1
shell CY8CPROTO_062_4343W+release .data 5424 5432 8 0.1
p6 all-clusters-app default (read/write) 2483136 2483152 16 0.0
.data 2672 2680 8 0.3
.text 1441400 1441416 16 0.0
light-app default (read/write) 2389936 2389952 16 0.0
.data 2520 2528 8 0.3
.text 1348200 1348216 16 0.0
lock-app default (read/write) 2353400 2353416 16 0.0
.data 2480 2488 8 0.3
.text 1311664 1311680 16 0.0
qpg lighting-app qpg6105+debug (read only) 595004 595028 24 0.0
.data 1108 1116 8 0.7
.text 589684 589708 24 0.0
lock-app qpg6105+debug (read only) 560732 560756 24 0.0
.data 1060 1068 8 0.8
.text 555412 555436 24 0.0
Decreases (8 builds for cyw30739, efr32, linux)
platform target config section 4d510a3 fa9d6de change % change
cyw30739 light cyw930739m2evb_01 .bss 77220 77216 -4 -0.0
lock cyw930739m2evb_01 .bss 75692 75688 -4 -0.0
efr32 lighting-app BRD4161A (read only) 909184 909168 -16 -0.0
.bss 125352 125344 -8 -0.0
.text 909176 909160 -16 -0.0
BRD4161A+rpc (read only) 937880 937868 -12 -0.0
(read/write) 144304 144300 -4 -0.0
.bss 142128 142120 -8 -0.0
.text 937872 937860 -12 -0.0
window-app BRD4161A (read only) 844372 844356 -16 -0.0
.bss 123544 123536 -8 -0.0
.text 844364 844348 -16 -0.0
linux chip-tool debug (read only) 8442781 8400909 -41872 -0.5
(read/write) 245760 229488 -16272 -6.6
.bss 32200 16984 -15216 -47.3
.data 1184 1152 -32 -2.7
.data.rel.ro 206352 205336 -1016 -0.5
.init_array 624 592 -32 -5.1
.rodata 460085 457045 -3040 -0.7
.text 7467109 7430677 -36432 -0.5
chip-tool-ipv6only arm64 (read only) 8245252 8210412 -34840 -0.4
(read/write) 353377 336977 -16400 -4.6
.bss 50497 35393 -15104 -29.9
.data 1216 1184 -32 -2.6
.data.rel.ro 248800 247720 -1080 -0.4
.got 49064 48912 -152 -0.3
.init_array 192 168 -24 -12.5
.rodata 436108 434996 -1112 -0.3
.text 7047876 7017156 -30720 -0.4
lighting-app debug+rpc (read/write) 115736 115704 -32 -0.0
.data 1400 1376 -24 -1.7
Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg)
platform target config section 4d510a3 fa9d6de change % change
cyw30739 light cyw930739m2evb_01 (read/write) 592750 592758 8 0.0
.app_xip_area 498228 498232 4 0.0
.bss 77220 77216 -4 -0.0
.data 644 652 8 1.2
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 550810 550818 8 0.0
.app_xip_area 457856 457860 4 0.0
.bss 75692 75688 -4 -0.0
.data 608 616 8 1.3
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569322 569334 12 0.0
.app_xip_area 467112 467116 4 0.0
.bss 84620 84620 0 0.0
.data 552 560 8 1.4
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909184 909168 -16 -0.0
(read/write) 127384 127384 0 0.0
.bss 125352 125344 -8 -0.0
.data 2032 2040 8 0.4
.text 909176 909160 -16 -0.0
BRD4161A+rpc (read only) 937880 937868 -12 -0.0
(read/write) 144304 144300 -4 -0.0
.bss 142128 142120 -8 -0.0
.data 2172 2180 8 0.4
.text 937872 937860 -12 -0.0
window-app BRD4161A (read only) 844372 844356 -16 -0.0
(read/write) 125444 125444 0 0.0
.bss 123544 123536 -8 -0.0
.data 1900 1908 8 0.4
.text 844364 844348 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 944944 944992 48 0.0
(read/write) 1398610 1398626 16 0.0
.dram0.bss 66408 66408 0 0.0
.dram0.data 14268 14276 8 0.1
.flash.rodata 199032 199032 0 0.0
.flash.text 944944 944992 48 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 994935 994951 16 0.0
(read/write) 463896 463904 8 0.0
.dram0.bss 71552 71552 0 0.0
.dram0.data 34064 34072 8 0.0
.flash.rodata 226152 226152 0 0.0
.flash.text 989551 989567 16 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683220 683260 40 0.0
.bss 76656 76656 0 0.0
.data 1904 1912 8 0.4
.text 598860 598892 32 0.0
lock k32w061+release (read/write) 688772 688812 40 0.0
.bss 77048 77048 0 0.0
.data 1948 1956 8 0.4
.text 603976 604008 32 0.0
linux all-clusters-app debug (read only) 2357265 2357681 416 0.0
(read/write) 140000 140032 32 0.0
.bss 54528 54528 0 0.0
.data 1296 1328 32 2.5
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205797 205957 160 0.1
.text 1989122 1989378 256 0.0
bridge-app debug+rpc (read only) 1726269 1726653 384 0.0
(read/write) 84200 84208 8 0.0
.bss 38928 38936 8 0.0
.data 2034 2048 14 0.7
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141676 141804 128 0.1
.text 1467973 1468229 256 0.0
chip-tool debug (read only) 8442781 8400909 -41872 -0.5
(read/write) 245760 229488 -16272 -6.6
.bss 32200 16984 -15216 -47.3
.data 1184 1152 -32 -2.7
.data.rel.ro 206352 205336 -1016 -0.5
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 592 -32 -5.1
.rodata 460085 457045 -3040 -0.7
.text 7467109 7430677 -36432 -0.5
chip-tool-ipv6only arm64 (read only) 8245252 8210412 -34840 -0.4
(read/write) 353377 336977 -16400 -4.6
.bss 50497 35393 -15104 -29.9
.data 1216 1184 -32 -2.6
.data.rel.ro 248800 247720 -1080 -0.4
.dynamic 560 560 0 0.0
.got 49064 48912 -152 -0.3
.init 24 24 0 0.0
.init_array 192 168 -24 -12.5
.rodata 436108 434996 -1112 -0.3
.text 7047876 7017156 -30720 -0.4
door-lock-app debug (read only) 1931425 1931841 416 0.0
(read/write) 110488 110536 48 0.0
.bss 42000 42016 16 0.0
.data 1010 1024 14 1.4
.data.rel.ro 62080 62088 8 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173074 173234 160 0.1
.text 1609762 1610018 256 0.0
lighting-app debug+rpc (read only) 2055073 2055489 416 0.0
(read/write) 115736 115704 -32 -0.0
.bss 43008 43008 0 0.0
.data 1400 1376 -24 -1.7
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165393 165553 160 0.1
.text 1734866 1735122 256 0.0
ota-provider-app debug (read only) 1864241 1864625 384 0.0
(read/write) 106200 106232 32 0.0
.bss 41856 41856 0 0.0
.data 1224 1256 32 2.6
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157643 157771 128 0.1
.text 1555938 1556194 256 0.0
ota-requestor-app debug (read only) 1859665 1860049 384 0.0
(read/write) 107288 107320 32 0.0
.bss 42144 42144 0 0.0
.data 1160 1192 32 2.8
.data.rel.ro 58536 58536 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151196 151324 128 0.1
.text 1559554 1559810 256 0.0
shell debug (read only) 2341625 2341977 352 0.0
(read/write) 141488 141520 32 0.0
.bss 61792 61792 0 0.0
.data 832 864 32 3.8
.data.rel.ro 73192 73192 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206674 206770 96 0.0
.text 1978098 1978354 256 0.0
thermostat-no-ble arm64 (read only) 2151068 2151516 448 0.0
(read/write) 140689 140705 16 0.0
.bss 57521 57521 0 0.0
.data 1032 1048 16 1.6
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132908 133036 128 0.1
.text 1799904 1800224 320 0.0
tv-app debug (read only) 2529193 2530473 1280 0.1
(read/write) 139232 139264 32 0.0
.bss 56992 56992 0 0.0
.data 3200 3232 32 1.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197669 197893 224 0.1
.text 2158482 2159538 1056 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2398112 2398112 0 0.0
.bss 188476 188476 0 0.0
.data 5320 5328 8 0.2
.text 1360712 1360712 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360344 2360344 0 0.0
.bss 181088 181088 0 0.0
.data 5624 5632 8 0.1
.text 1322944 1322944 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323872 2323872 0 0.0
.bss 180976 180976 0 0.0
.data 5600 5608 8 0.1
.text 1286472 1286472 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308900 2308900 0 0.0
.bss 178228 178228 0 0.0
.data 5424 5432 8 0.1
.text 1271472 1271472 0 0.0
p6 all-clusters-app default (read/write) 2483136 2483152 16 0.0
.bss 117744 117744 0 0.0
.data 2672 2680 8 0.3
.text 1441400 1441416 16 0.0
light-app default (read/write) 2389936 2389952 16 0.0
.bss 107392 107392 0 0.0
.data 2520 2528 8 0.3
.text 1348200 1348216 16 0.0
lock-app default (read/write) 2353400 2353416 16 0.0
.bss 107112 107112 0 0.0
.data 2480 2488 8 0.3
.text 1311664 1311680 16 0.0
qpg lighting-app qpg6105+debug (read only) 595004 595028 24 0.0
(read/write) 146936 146936 0 0.0
.bss 88936 88936 0 0.0
.data 1108 1116 8 0.7
.text 589684 589708 24 0.0
lock-app qpg6105+debug (read only) 560732 560756 24 0.0
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1060 1068 8 0.8
.text 555412 555436 24 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 14, 2022 •
edited
Loading

PR #14998: Size comparison from 4d510a3 to c908dac

Increases above 0.2%:

platform target config section 4d510a3 c908dac change % change
cyw30739 light cyw930739m2evb_01 .data 644 652 8 1.2
lock cyw930739m2evb_01 .data 608 616 8 1.3
ota-requestor cyw930739m2evb_01 .data 552 560 8 1.4
efr32 lighting-app BRD4161A .data 2032 2040 8 0.4
BRD4161A+rpc .data 2172 2180 8 0.4
window-app BRD4161A .data 1900 1908 8 0.4
k32w light k32w061+release .data 1904 1912 8 0.4
lock k32w061+release .data 1948 1956 8 0.4
linux all-clusters-app debug .bss 54528 54656 128 0.2
.data 1296 1328 32 2.5
bridge-app debug+rpc .data 2034 2048 14 0.7
door-lock-app debug .data 1010 1024 14 1.4
ota-provider-app debug .data 1224 1256 32 2.6
ota-requestor-app debug .data 1160 1192 32 2.8
shell debug .bss 61792 61920 128 0.2
.data 832 864 32 3.8
thermostat-no-ble arm64 .data 1032 1048 16 1.6
tv-app debug (read/write) 139232 140992 1760 1.3
.bss 56992 58720 1728 3.0
.data 3200 3232 32 1.0
p6 all-clusters-app default .data 2672 2680 8 0.3
light-app default .data 2520 2528 8 0.3
lock-app default .data 2480 2488 8 0.3
qpg lighting-app qpg6105+debug .data 1108 1116 8 0.7
lock-app qpg6105+debug .data 1060 1068 8 0.8
Increases (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg)
platform target config section 4d510a3 c908dac change % change
cyw30739 light cyw930739m2evb_01 .data 644 652 8 1.2
lock cyw930739m2evb_01 .data 608 616 8 1.3
ota-requestor cyw930739m2evb_01 .data 552 560 8 1.4
efr32 lighting-app BRD4161A .data 2032 2040 8 0.4
BRD4161A+rpc .data 2172 2180 8 0.4
window-app BRD4161A .data 1900 1908 8 0.4
esp32 all-clusters-app c3devkit (read only) 944944 945028 84 0.0
.dram0.data 14268 14276 8 0.1
.flash.text 944944 945028 84 0.0
m5stack (read only) 994935 995011 76 0.0
.dram0.data 34064 34072 8 0.0
.flash.text 989551 989627 76 0.0
k32w light k32w061+release .data 1904 1912 8 0.4
.text 598860 598876 16 0.0
lock k32w061+release .data 1948 1956 8 0.4
.text 603976 603992 16 0.0
linux all-clusters-app debug (read only) 2357265 2357729 464 0.0
(read/write) 140000 140160 160 0.1
.bss 54528 54656 128 0.2
.data 1296 1328 32 2.5
.text 1989122 1989586 464 0.0
bridge-app debug+rpc (read only) 1726269 1726765 496 0.0
(read/write) 84200 84208 8 0.0
.bss 38928 38936 8 0.0
.data 2034 2048 14 0.7
.rodata 141676 141804 128 0.1
.text 1467973 1468341 368 0.0
door-lock-app debug (read only) 1931425 1932049 624 0.0
.data 1010 1024 14 1.4
.data.rel.ro 62080 62088 8 0.0
.rodata 173074 173234 160 0.1
.text 1609762 1610226 464 0.0
lighting-app debug+rpc (read only) 2055073 2055697 624 0.0
.rodata 165393 165553 160 0.1
.text 1734866 1735330 464 0.0
ota-provider-app debug (read only) 1864241 1864833 592 0.0
.data 1224 1256 32 2.6
.rodata 157643 157771 128 0.1
.text 1555938 1556402 464 0.0
ota-requestor-app debug (read only) 1859665 1860241 576 0.0
.data 1160 1192 32 2.8
.rodata 151196 151324 128 0.1
.text 1559554 1560002 448 0.0
shell debug (read only) 2341625 2341897 272 0.0
(read/write) 141488 141648 160 0.1
.bss 61792 61920 128 0.2
.data 832 864 32 3.8
.text 1978098 1978466 368 0.0
thermostat-no-ble arm64 (read only) 2151068 2151580 512 0.0
.data 1032 1048 16 1.6
.rodata 132908 133036 128 0.1
.text 1799904 1800288 384 0.0
tv-app debug (read only) 2529193 2530473 1280 0.1
(read/write) 139232 140992 1760 1.3
.bss 56992 58720 1728 3.0
.data 3200 3232 32 1.0
.rodata 197669 197701 32 0.0
.text 2158482 2159730 1248 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5320 5328 8 0.2
lighting-app CY8CPROTO_062_4343W+release .data 5624 5632 8 0.1
lock-app CY8CPROTO_062_4343W+release .data 5600 5608 8 0.1
shell CY8CPROTO_062_4343W+release .data 5424 5432 8 0.1
p6 all-clusters-app default (read/write) 2483136 2483216 80 0.0
.data 2672 2680 8 0.3
.text 1441400 1441480 80 0.0
light-app default (read/write) 2389936 2390032 96 0.0
.data 2520 2528 8 0.3
.text 1348200 1348296 96 0.0
lock-app default (read/write) 2353400 2353496 96 0.0
.data 2480 2488 8 0.3
.text 1311664 1311760 96 0.0
qpg lighting-app qpg6105+debug (read only) 595004 595020 16 0.0
.data 1108 1116 8 0.7
.text 589684 589700 16 0.0
lock-app qpg6105+debug (read only) 560732 560756 24 0.0
.data 1060 1068 8 0.8
.text 555412 555436 24 0.0
Decreases (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 4d510a3 c908dac change % change
cyw30739 light cyw930739m2evb_01 (read/write) 592750 592470 -280 -0.0
.app_xip_area 498228 498168 -60 -0.0
.bss 77220 76992 -228 -0.3
lock cyw930739m2evb_01 (read/write) 550810 550530 -280 -0.1
.app_xip_area 457856 457796 -60 -0.0
.bss 75692 75464 -228 -0.3
ota-requestor cyw930739m2evb_01 (read/write) 569322 569046 -276 -0.0
.app_xip_area 467112 467052 -60 -0.0
.bss 84620 84396 -224 -0.3
efr32 lighting-app BRD4161A (read only) 909184 909056 -128 -0.0
(read/write) 127384 127160 -224 -0.2
.bss 125352 125120 -232 -0.2
.text 909176 909048 -128 -0.0
BRD4161A+rpc (read only) 937880 937740 -140 -0.0
(read/write) 144304 144076 -228 -0.2
.bss 142128 141896 -232 -0.2
.text 937872 937732 -140 -0.0
window-app BRD4161A (read only) 844372 844228 -144 -0.0
(read/write) 125444 125220 -224 -0.2
.bss 123544 123312 -232 -0.2
.text 844364 844220 -144 -0.0
esp32 all-clusters-app c3devkit (read/write) 1398610 1398386 -224 -0.0
.dram0.bss 66408 66168 -240 -0.4
m5stack (read/write) 463896 463664 -232 -0.1
.dram0.bss 71552 71312 -240 -0.3
k32w light k32w061+release (read/write) 683220 683020 -200 -0.0
.bss 76656 76432 -224 -0.3
lock k32w061+release (read/write) 688772 688572 -200 -0.0
.bss 77048 76824 -224 -0.3
linux chip-tool debug (read only) 8442781 8401821 -40960 -0.5
(read/write) 245760 229104 -16656 -6.8
.bss 32200 16600 -15600 -48.4
.data 1184 1152 -32 -2.7
.data.rel.ro 206352 205336 -1016 -0.5
.init_array 624 592 -32 -5.1
.rodata 460085 456277 -3808 -0.8
.text 7467109 7432357 -34752 -0.5
chip-tool-ipv6only arm64 (read only) 8245252 8211004 -34248 -0.4
(read/write) 353377 336593 -16784 -4.7
.bss 50497 35009 -15488 -30.7
.data 1216 1184 -32 -2.6
.data.rel.ro 248800 247720 -1080 -0.4
.got 49064 48912 -152 -0.3
.init_array 192 168 -24 -12.5
.rodata 436108 434196 -1912 -0.4
.text 7047876 7018548 -29328 -0.4
door-lock-app debug (read/write) 110488 110152 -336 -0.3
.bss 42000 41632 -368 -0.9
lighting-app debug+rpc (read/write) 115736 115416 -320 -0.3
.bss 43008 42720 -288 -0.7
.data 1400 1376 -24 -1.7
ota-provider-app debug (read/write) 106200 105880 -320 -0.3
.bss 41856 41504 -352 -0.8
ota-requestor-app debug (read/write) 107288 106936 -352 -0.3
.bss 42144 41760 -384 -0.9
shell debug .rodata 206674 206578 -96 -0.0
thermostat-no-ble arm64 (read/write) 140689 140353 -336 -0.2
.bss 57521 57169 -352 -0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 188476 188252 -224 -0.1
lighting-app CY8CPROTO_062_4343W+release .bss 181088 180864 -224 -0.1
lock-app CY8CPROTO_062_4343W+release .bss 180976 180752 -224 -0.1
shell CY8CPROTO_062_4343W+release .bss 178228 178004 -224 -0.1
p6 all-clusters-app default .bss 117744 117520 -224 -0.2
light-app default .bss 107392 107168 -224 -0.2
lock-app default .bss 107112 106888 -224 -0.2
qpg lighting-app qpg6105+debug .bss 88936 88824 -112 -0.1
lock-app qpg6105+debug .bss 88920 88808 -112 -0.1
telink lighting-app tlsr9518adk80d (read/write) 875102 874806 -296 -0.0
bss 88736 88496 -240 -0.3
text 614832 614762 -70 -0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 4d510a3 c908dac change % change
cyw30739 light cyw930739m2evb_01 (read/write) 592750 592470 -280 -0.0
.app_xip_area 498228 498168 -60 -0.0
.bss 77220 76992 -228 -0.3
.data 644 652 8 1.2
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 550810 550530 -280 -0.1
.app_xip_area 457856 457796 -60 -0.0
.bss 75692 75464 -228 -0.3
.data 608 616 8 1.3
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569322 569046 -276 -0.0
.app_xip_area 467112 467052 -60 -0.0
.bss 84620 84396 -224 -0.3
.data 552 560 8 1.4
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909184 909056 -128 -0.0
(read/write) 127384 127160 -224 -0.2
.bss 125352 125120 -232 -0.2
.data 2032 2040 8 0.4
.text 909176 909048 -128 -0.0
BRD4161A+rpc (read only) 937880 937740 -140 -0.0
(read/write) 144304 144076 -228 -0.2
.bss 142128 141896 -232 -0.2
.data 2172 2180 8 0.4
.text 937872 937732 -140 -0.0
window-app BRD4161A (read only) 844372 844228 -144 -0.0
(read/write) 125444 125220 -224 -0.2
.bss 123544 123312 -232 -0.2
.data 1900 1908 8 0.4
.text 844364 844220 -144 -0.0
esp32 all-clusters-app c3devkit (read only) 944944 945028 84 0.0
(read/write) 1398610 1398386 -224 -0.0
.dram0.bss 66408 66168 -240 -0.4
.dram0.data 14268 14276 8 0.1
.flash.rodata 199032 199032 0 0.0
.flash.text 944944 945028 84 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 994935 995011 76 0.0
(read/write) 463896 463664 -232 -0.1
.dram0.bss 71552 71312 -240 -0.3
.dram0.data 34064 34072 8 0.0
.flash.rodata 226152 226152 0 0.0
.flash.text 989551 989627 76 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683220 683020 -200 -0.0
.bss 76656 76432 -224 -0.3
.data 1904 1912 8 0.4
.text 598860 598876 16 0.0
lock k32w061+release (read/write) 688772 688572 -200 -0.0
.bss 77048 76824 -224 -0.3
.data 1948 1956 8 0.4
.text 603976 603992 16 0.0
linux all-clusters-app debug (read only) 2357265 2357729 464 0.0
(read/write) 140000 140160 160 0.1
.bss 54528 54656 128 0.2
.data 1296 1328 32 2.5
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205797 205797 0 0.0
.text 1989122 1989586 464 0.0
bridge-app debug+rpc (read only) 1726269 1726765 496 0.0
(read/write) 84200 84208 8 0.0
.bss 38928 38936 8 0.0
.data 2034 2048 14 0.7
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141676 141804 128 0.1
.text 1467973 1468341 368 0.0
chip-tool debug (read only) 8442781 8401821 -40960 -0.5
(read/write) 245760 229104 -16656 -6.8
.bss 32200 16600 -15600 -48.4
.data 1184 1152 -32 -2.7
.data.rel.ro 206352 205336 -1016 -0.5
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 592 -32 -5.1
.rodata 460085 456277 -3808 -0.8
.text 7467109 7432357 -34752 -0.5
chip-tool-ipv6only arm64 (read only) 8245252 8211004 -34248 -0.4
(read/write) 353377 336593 -16784 -4.7
.bss 50497 35009 -15488 -30.7
.data 1216 1184 -32 -2.6
.data.rel.ro 248800 247720 -1080 -0.4
.dynamic 560 560 0 0.0
.got 49064 48912 -152 -0.3
.init 24 24 0 0.0
.init_array 192 168 -24 -12.5
.rodata 436108 434196 -1912 -0.4
.text 7047876 7018548 -29328 -0.4
door-lock-app debug (read only) 1931425 1932049 624 0.0
(read/write) 110488 110152 -336 -0.3
.bss 42000 41632 -368 -0.9
.data 1010 1024 14 1.4
.data.rel.ro 62080 62088 8 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173074 173234 160 0.1
.text 1609762 1610226 464 0.0
lighting-app debug+rpc (read only) 2055073 2055697 624 0.0
(read/write) 115736 115416 -320 -0.3
.bss 43008 42720 -288 -0.7
.data 1400 1376 -24 -1.7
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165393 165553 160 0.1
.text 1734866 1735330 464 0.0
ota-provider-app debug (read only) 1864241 1864833 592 0.0
(read/write) 106200 105880 -320 -0.3
.bss 41856 41504 -352 -0.8
.data 1224 1256 32 2.6
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157643 157771 128 0.1
.text 1555938 1556402 464 0.0
ota-requestor-app debug (read only) 1859665 1860241 576 0.0
(read/write) 107288 106936 -352 -0.3
.bss 42144 41760 -384 -0.9
.data 1160 1192 32 2.8
.data.rel.ro 58536 58536 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151196 151324 128 0.1
.text 1559554 1560002 448 0.0
shell debug (read only) 2341625 2341897 272 0.0
(read/write) 141488 141648 160 0.1
.bss 61792 61920 128 0.2
.data 832 864 32 3.8
.data.rel.ro 73192 73192 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206674 206578 -96 -0.0
.text 1978098 1978466 368 0.0
thermostat-no-ble arm64 (read only) 2151068 2151580 512 0.0
(read/write) 140689 140353 -336 -0.2
.bss 57521 57169 -352 -0.6
.data 1032 1048 16 1.6
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132908 133036 128 0.1
.text 1799904 1800288 384 0.0
tv-app debug (read only) 2529193 2530473 1280 0.1
(read/write) 139232 140992 1760 1.3
.bss 56992 58720 1728 3.0
.data 3200 3232 32 1.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197669 197701 32 0.0
.text 2158482 2159730 1248 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2398112 2398112 0 0.0
.bss 188476 188252 -224 -0.1
.data 5320 5328 8 0.2
.text 1360712 1360712 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360344 2360344 0 0.0
.bss 181088 180864 -224 -0.1
.data 5624 5632 8 0.1
.text 1322944 1322944 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323872 2323872 0 0.0
.bss 180976 180752 -224 -0.1
.data 5600 5608 8 0.1
.text 1286472 1286472 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308900 2308900 0 0.0
.bss 178228 178004 -224 -0.1
.data 5424 5432 8 0.1
.text 1271472 1271472 0 0.0
p6 all-clusters-app default (read/write) 2483136 2483216 80 0.0
.bss 117744 117520 -224 -0.2
.data 2672 2680 8 0.3
.text 1441400 1441480 80 0.0
light-app default (read/write) 2389936 2390032 96 0.0
.bss 107392 107168 -224 -0.2
.data 2520 2528 8 0.3
.text 1348200 1348296 96 0.0
lock-app default (read/write) 2353400 2353496 96 0.0
.bss 107112 106888 -224 -0.2
.data 2480 2488 8 0.3
.text 1311664 1311760 96 0.0
qpg lighting-app qpg6105+debug (read only) 595004 595020 16 0.0
(read/write) 146936 146936 0 0.0
.bss 88936 88824 -112 -0.1
.data 1108 1116 8 0.7
.text 589684 589700 16 0.0
lock-app qpg6105+debug (read only) 560732 560756 24 0.0
(read/write) 146936 146936 0 0.0
.bss 88920 88808 -112 -0.1
.data 1060 1068 8 0.8
.text 555412 555436 24 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 875102 874806 -296 -0.0
bss 88736 88496 -240 -0.3
noinit 37160 37160 0 0.0
text 614832 614762 -70 -0.0

@github-actions
Copy link

github-actions bot commented Feb 17, 2022 •
edited
Loading

PR #14998: Size comparison from 11a5b14 to b35b072

Increases above 0.2%:

platform target config section 11a5b14 b35b072 change % change
cyw30739 light cyw930739m2evb_01 .data 644 652 8 1.2
lock cyw930739m2evb_01 .data 608 616 8 1.3
ota-requestor cyw930739m2evb_01 .data 552 560 8 1.4
efr32 lighting-app BRD4161A .data 2036 2044 8 0.4
BRD4161A+rpc .data 2176 2184 8 0.4
window-app BRD4161A .data 1904 1912 8 0.4
k32w light k32w061+release .data 1912 1920 8 0.4
lock k32w061+release .data 1952 1960 8 0.4
linux bridge-app debug+rpc .data 2034 2048 14 0.7
door-lock-app debug .data 1010 1024 14 1.4
ota-provider-app debug .data 1224 1256 32 2.6
ota-requestor-app debug .data 1128 1160 32 2.8
shell debug .data 832 864 32 3.8
thermostat-no-ble arm64 .data 1032 1048 16 1.6
tv-app debug .data 3200 3232 32 1.0
p6 all-clusters-app default .data 2672 2680 8 0.3
light-app default .data 2528 2536 8 0.3
lock-app default .data 2488 2496 8 0.3
Increases (35 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 11a5b14 b35b072 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599342 599354 12 0.0
.app_xip_area 503268 503276 8 0.0
.data 644 652 8 1.2
lock cyw930739m2evb_01 (read/write) 557374 557390 16 0.0
.app_xip_area 462844 462856 12 0.0
.data 608 616 8 1.3
ota-requestor cyw930739m2evb_01 (read/write) 578618 578626 8 0.0
.app_xip_area 474664 474668 4 0.0
.data 552 560 8 1.4
efr32 lighting-app BRD4161A (read only) 916240 916244 4 0.0
.data 2036 2044 8 0.4
.text 916232 916236 4 0.0
BRD4161A+rpc .data 2176 2184 8 0.4
window-app BRD4161A .data 1904 1912 8 0.4
esp32 all-clusters-app c3devkit (read only) 950284 950332 48 0.0
(read/write) 1402034 1402050 16 0.0
.dram0.data 14156 14164 8 0.1
.flash.text 950284 950332 48 0.0
m5stack (read only) 999851 999863 12 0.0
(read/write) 467304 467312 8 0.0
.dram0.data 34064 34072 8 0.0
.flash.text 994467 994479 12 0.0
k32w light k32w061+release (read/write) 692536 692560 24 0.0
.data 1912 1920 8 0.4
.text 606432 606448 16 0.0
lock k32w061+release (read/write) 695072 695096 24 0.0
.data 1952 1960 8 0.4
.text 608712 608728 16 0.0
linux all-clusters-app debug (read only) 2385545 2385961 416 0.0
.rodata 207013 207173 160 0.1
.text 2014946 2015202 256 0.0
bridge-app debug+rpc (read only) 1734437 1734821 384 0.0
(read/write) 94856 94864 8 0.0
.bss 49296 49304 8 0.0
.data 2034 2048 14 0.7
.rodata 142732 142860 128 0.1
.text 1474869 1475125 256 0.0
door-lock-app debug (read only) 1946537 1946953 416 0.0
(read/write) 120952 120968 16 0.0
.bss 52016 52032 16 0.0
.data 1010 1024 14 1.4
.rodata 174226 174386 160 0.1
.text 1622802 1623058 256 0.0
lighting-app debug+rpc (read only) 2072993 2073409 416 0.0
.rodata 166801 166961 160 0.1
.text 1750546 1750802 256 0.0
ota-provider-app debug (read only) 1879961 1880377 416 0.0
(read/write) 116568 116600 32 0.0
.data 1224 1256 32 2.6
.rodata 159099 159259 160 0.1
.text 1569250 1569506 256 0.0
ota-requestor-app debug (read only) 1893025 1893377 352 0.0
(read/write) 117952 117984 32 0.0
.data 1128 1160 32 2.8
.rodata 153516 153612 96 0.1
.text 1589570 1589826 256 0.0
shell debug (read only) 2360449 2360833 384 0.0
(read/write) 153872 153904 32 0.0
.data 832 864 32 3.8
.rodata 208082 208210 128 0.1
.text 1994914 1995170 256 0.0
thermostat-no-ble arm64 (read only) 2166764 2167180 416 0.0
(read/write) 151137 151153 16 0.0
.data 1032 1048 16 1.6
.rodata 134060 134172 112 0.1
.text 1813232 1813536 304 0.0
tv-app debug (read only) 2542905 2544185 1280 0.1
(read/write) 152064 152096 32 0.0
.data 3200 3232 32 1.0
.rodata 199149 199373 224 0.1
.text 2169410 2170466 1056 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5328 5336 8 0.2
lighting-app CY8CPROTO_062_4343W+release (read/write) 2392804 2392868 64 0.0
.data 5632 5640 8 0.1
.text 1355376 1355440 64 0.0
lock-app CY8CPROTO_062_4343W+release .data 5608 5616 8 0.1
shell CY8CPROTO_062_4343W+release .data 5440 5448 8 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023347 1023371 24 0.0
text 699836 699860 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 992659 992683 24 0.0
text 679736 679760 24 0.0
nrf52840dongle_nrf52840 (read/write) 1038087 1038127 40 0.0
text 703644 703668 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929942 929982 40 0.0
text 614860 614884 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952111 952135 24 0.0
text 641948 641972 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859574 859614 40 0.0
text 557748 557776 28 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950687 950711 24 0.0
text 641768 641792 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946635 946675 40 0.0
text 638008 638032 24 0.0
p6 all-clusters-app default (read/write) 2489384 2489408 24 0.0
.data 2672 2680 8 0.3
.text 1447648 1447672 24 0.0
light-app default (read/write) 2394648 2394672 24 0.0
.data 2528 2536 8 0.3
.text 1352912 1352936 24 0.0
lock-app default (read/write) 2358216 2358232 16 0.0
.data 2488 2496 8 0.3
.text 1316480 1316496 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 878654 878678 24 0.0
text 618770 618786 16 0.0
Decreases (9 builds for cyw30739, efr32, linux)
platform target config section 11a5b14 b35b072 change % change
cyw30739 light cyw930739m2evb_01 .bss 78772 78768 -4 -0.0
lock cyw930739m2evb_01 .bss 77268 77264 -4 -0.0
ota-requestor cyw930739m2evb_01 .bss 86364 86360 -4 -0.0
efr32 lighting-app BRD4161A (read/write) 129512 129508 -4 -0.0
.bss 127472 127464 -8 -0.0
BRD4161A+rpc (read only) 944964 944932 -32 -0.0
.bss 144248 144240 -8 -0.0
.text 944956 944924 -32 -0.0
window-app BRD4161A (read only) 850080 850060 -20 -0.0
.bss 125520 125512 -8 -0.0
.text 850072 850052 -20 -0.0
linux chip-tool debug (read only) 8988237 8946213 -42024 -0.5
(read/write) 319568 303216 -16352 -5.1
.bss 40728 25464 -15264 -37.5
.data 1184 1152 -32 -2.7
.data.rel.ro 271624 270600 -1024 -0.4
.init_array 624 592 -32 -5.1
.rodata 474037 470869 -3168 -0.7
.text 7855925 7819493 -36432 -0.5
chip-tool-ipv6only arm64 (read only) 8713636 8678780 -34856 -0.4
(read/write) 431377 414945 -16432 -3.8
.bss 58977 43841 -15136 -25.7
.data 1216 1184 -32 -2.6
.data.rel.ro 316816 315728 -1088 -0.3
.got 50568 50416 -152 -0.3
.init_array 200 176 -24 -12.0
.rodata 450444 449348 -1096 -0.2
.text 7351732 7320996 -30736 -0.4
lighting-app debug+rpc (read/write) 125944 125880 -64 -0.1
.data 1400 1376 -24 -1.7
.data.rel.ro 65984 65976 -8 -0.0
Full report (40 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 11a5b14 b35b072 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599342 599354 12 0.0
.app_xip_area 503268 503276 8 0.0
.bss 78772 78768 -4 -0.0
.data 644 652 8 1.2
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557374 557390 16 0.0
.app_xip_area 462844 462856 12 0.0
.bss 77268 77264 -4 -0.0
.data 608 616 8 1.3
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578618 578626 8 0.0
.app_xip_area 474664 474668 4 0.0
.bss 86364 86360 -4 -0.0
.data 552 560 8 1.4
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916240 916244 4 0.0
(read/write) 129512 129508 -4 -0.0
.bss 127472 127464 -8 -0.0
.data 2036 2044 8 0.4
.text 916232 916236 4 0.0
BRD4161A+rpc (read only) 944964 944932 -32 -0.0
(read/write) 146424 146424 0 0.0
.bss 144248 144240 -8 -0.0
.data 2176 2184 8 0.4
.text 944956 944924 -32 -0.0
window-app BRD4161A (read only) 850080 850060 -20 -0.0
(read/write) 127424 127424 0 0.0
.bss 125520 125512 -8 -0.0
.data 1904 1912 8 0.4
.text 850072 850052 -20 -0.0
esp32 all-clusters-app c3devkit (read only) 950284 950332 48 0.0
(read/write) 1402034 1402050 16 0.0
.dram0.bss 68512 68512 0 0.0
.dram0.data 14156 14164 8 0.1
.flash.rodata 200472 200472 0 0.0
.flash.text 950284 950332 48 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999851 999863 12 0.0
(read/write) 467304 467312 8 0.0
.dram0.bss 73656 73656 0 0.0
.dram0.data 34064 34072 8 0.0
.flash.rodata 227456 227456 0 0.0
.flash.text 994467 994479 12 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692536 692560 24 0.0
.bss 78392 78392 0 0.0
.data 1912 1920 8 0.4
.text 606432 606448 16 0.0
lock k32w061+release (read/write) 695072 695096 24 0.0
.bss 78608 78608 0 0.0
.data 1952 1960 8 0.4
.text 608712 608728 16 0.0
linux all-clusters-app debug (read only) 2385545 2385961 416 0.0
(read/write) 151456 151456 0 0.0
.bss 65376 65376 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207013 207173 160 0.1
.text 2014946 2015202 256 0.0
bridge-app debug+rpc (read only) 1734437 1734821 384 0.0
(read/write) 94856 94864 8 0.0
.bss 49296 49304 8 0.0
.data 2034 2048 14 0.7
.data.rel.ro 38376 38376 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 142732 142860 128 0.1
.text 1474869 1475125 256 0.0
chip-tool debug (read only) 8988237 8946213 -42024 -0.5
(read/write) 319568 303216 -16352 -5.1
.bss 40728 25464 -15264 -37.5
.data 1184 1152 -32 -2.7
.data.rel.ro 271624 270600 -1024 -0.4
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 592 -32 -5.1
.rodata 474037 470869 -3168 -0.7
.text 7855925 7819493 -36432 -0.5
chip-tool-ipv6only arm64 (read only) 8713636 8678780 -34856 -0.4
(read/write) 431377 414945 -16432 -3.8
.bss 58977 43841 -15136 -25.7
.data 1216 1184 -32 -2.6
.data.rel.ro 316816 315728 -1088 -0.3
.dynamic 560 560 0 0.0
.got 50568 50416 -152 -0.3
.init 24 24 0 0.0
.init_array 200 176 -24 -12.0
.rodata 450444 449348 -1096 -0.2
.text 7351732 7320996 -30736 -0.4
door-lock-app debug (read only) 1946537 1946953 416 0.0
(read/write) 120952 120968 16 0.0
.bss 52016 52032 16 0.0
.data 1010 1024 14 1.4
.data.rel.ro 62488 62488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 174226 174386 160 0.1
.text 1622802 1623058 256 0.0
lighting-app debug+rpc (read only) 2072993 2073409 416 0.0
(read/write) 125944 125880 -64 -0.1
.bss 53024 53024 0 0.0
.data 1400 1376 -24 -1.7
.data.rel.ro 65984 65976 -8 -0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166801 166961 160 0.1
.text 1750546 1750802 256 0.0
ota-provider-app debug (read only) 1879961 1880377 416 0.0
(read/write) 116568 116600 32 0.0
.bss 51872 51872 0 0.0
.data 1224 1256 32 2.6
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159099 159259 160 0.1
.text 1569250 1569506 256 0.0
ota-requestor-app debug (read only) 1893025 1893377 352 0.0
(read/write) 117952 117984 32 0.0
.bss 52288 52288 0 0.0
.data 1128 1160 32 2.8
.data.rel.ro 59080 59080 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153516 153612 96 0.1
.text 1589570 1589826 256 0.0
shell debug (read only) 2360449 2360833 384 0.0
(read/write) 153872 153904 32 0.0
.bss 73728 73728 0 0.0
.data 832 864 32 3.8
.data.rel.ro 73632 73632 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 208082 208210 128 0.1
.text 1994914 1995170 256 0.0
thermostat-no-ble arm64 (read only) 2166764 2167180 416 0.0
(read/write) 151137 151153 16 0.0
.bss 67505 67505 0 0.0
.data 1032 1048 16 1.6
.data.rel.ro 75384 75384 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134172 112 0.1
.text 1813232 1813536 304 0.0
tv-app debug (read only) 2542905 2544185 1280 0.1
(read/write) 152064 152096 32 0.0
.bss 69248 69248 0 0.0
.data 3200 3232 32 1.0
.data.rel.ro 73576 73576 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 199149 199373 224 0.1
.text 2169410 2170466 1056 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2431028 2431028 0 0.0
.bss 195924 195924 0 0.0
.data 5328 5336 8 0.2
.text 1393600 1393600 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392804 2392868 64 0.0
.bss 188432 188432 0 0.0
.data 5632 5640 8 0.1
.text 1355376 1355440 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328312 2328312 0 0.0
.bss 187432 187432 0 0.0
.data 5608 5616 8 0.1
.text 1290912 1290912 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319204 2319204 0 0.0
.bss 185980 185980 0 0.0
.data 5440 5448 8 0.1
.text 1281776 1281776 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023347 1023371 24 0.0
bss 123532 123532 0 0.0
rodata 120960 120960 0 0.0
text 699836 699860 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 992659 992683 24 0.0
bss 120720 120720 0 0.0
rodata 112504 112504 0 0.0
text 679736 679760 24 0.0
nrf52840dongle_nrf52840 (read/write) 1038087 1038127 40 0.0
bss 124752 124752 0 0.0
rodata 119792 119792 0 0.0
text 703644 703668 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929942 929982 40 0.0
bss 120092 120092 0 0.0
rodata 114216 114216 0 0.0
text 614860 614884 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952111 952135 24 0.0
bss 121760 121760 0 0.0
rodata 109796 109796 0 0.0
text 641948 641972 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859574 859614 40 0.0
bss 118352 118352 0 0.0
rodata 102968 102968 0 0.0
text 557748 557776 28 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950687 950711 24 0.0
bss 121480 121480 0 0.0
rodata 108748 108748 0 0.0
text 641768 641792 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946635 946675 40 0.0
bss 121484 121484 0 0.0
rodata 108448 108448 0 0.0
text 638008 638032 24 0.0
shell nrf52840dk_nrf52840 (read/write) 811335 811335 0 0.0
bss 113328 113328 0 0.0
rodata 79676 79676 0 0.0
text 540684 540684 0 0.0
p6 all-clusters-app default (read/write) 2489384 2489408 24 0.0
.bss 124240 124240 0 0.0
.data 2672 2680 8 0.3
.text 1447648 1447672 24 0.0
light-app default (read/write) 2394648 2394672 24 0.0
.bss 113896 113896 0 0.0
.data 2528 2536 8 0.3
.text 1352912 1352936 24 0.0
lock-app default (read/write) 2358216 2358232 16 0.0
.bss 113648 113648 0 0.0
.data 2488 2496 8 0.3
.text 1316480 1316496 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 878654 878678 24 0.0
bss 87504 87504 0 0.0
noinit 37160 37160 0 0.0
text 618770 618786 16 0.0

@carol-apple carol-apple mentioned this pull request Feb 18, 2022
Closed
@stale
Copy link

stale bot commented Feb 25, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Feb 25, 2022
@mrjerryjohns
Copy link
Contributor Author

/rebase

@stale stale bot removed the stale Stale issue or PR label Feb 25, 2022
@github-actions
Copy link

github-actions bot commented Feb 25, 2022 •
edited
Loading

PR #14998: Size comparison from c1d14cc to ffe5dbb

Increases above 0.2%:

platform target config section c1d14cc ffe5dbb change % change
cyw30739 light cyw930739m2evb_01 .data 652 660 8 1.2
lock cyw930739m2evb_01 .data 616 624 8 1.3
ota-requestor cyw930739m2evb_01 .data 560 568 8 1.4
efr32 lighting-app BRD4161A .data 2048 2056 8 0.4
BRD4161A+rpc .data 2212 2220 8 0.4
lock-app BRD4161A+wf200 .data 1924 1932 8 0.4
window-app BRD4161A .data 1916 1924 8 0.4
k32w light k32w061+release .data 1924 1932 8 0.4
lock k32w061+release .data 1964 1972 8 0.4
linux all-clusters-app debug .data 1360 1392 32 2.4
bridge-app debug+rpc .data 2042 2048 6 0.3
door-lock-app debug .data 1050 1056 6 0.6
ota-provider-app debug .data 1320 1352 32 2.4
ota-requestor-app debug .data 1192 1224 32 2.7
thermostat-no-ble arm64 .data 1056 1072 16 1.5
tv-app debug .data 3168 3200 32 1.0
p6 all-clusters-app default .data 2688 2696 8 0.3
light-app default .data 2536 2544 8 0.3
lock-app default .data 2496 2504 8 0.3
Increases (37 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c1d14cc ffe5dbb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599614 599638 24 0.0
.app_xip_area 504460 504476 16 0.0
.data 652 660 8 1.2
lock cyw930739m2evb_01 (read/write) 557686 557714 28 0.0
.app_xip_area 464068 464088 20 0.0
.data 616 624 8 1.3
ota-requestor cyw930739m2evb_01 (read/write) 578210 578230 20 0.0
.app_xip_area 475160 475172 12 0.0
.data 560 568 8 1.4
efr32 lighting-app BRD4161A (read only) 916556 916560 4 0.0
.data 2048 2056 8 0.4
.text 916548 916552 4 0.0
BRD4161A+rpc .data 2212 2220 8 0.4
lock-app BRD4161A+wf200 (read/write) 120360 120372 12 0.0
.data 1924 1932 8 0.4
window-app BRD4161A (read only) 850620 850648 28 0.0
(read/write) 126844 126848 4 0.0
.data 1916 1924 8 0.4
.text 850612 850640 28 0.0
esp32 all-clusters-app c3devkit (read only) 956550 956598 48 0.0
.dram0.data 14228 14236 8 0.1
.flash.text 956550 956598 48 0.0
m5stack (read only) 1004691 1004719 28 0.0
(read/write) 458288 458296 8 0.0
.dram0.data 34072 34080 8 0.0
.flash.text 999307 999335 28 0.0
k32w light k32w061+release (read/write) 691972 692016 44 0.0
.data 1924 1932 8 0.4
.text 606768 606804 36 0.0
lock k32w061+release (read/write) 695244 695264 20 0.0
.data 1964 1972 8 0.4
.text 609792 609812 20 0.0
linux all-clusters-app debug (read only) 2394729 2395113 384 0.0
(read/write) 144696 144728 32 0.0
.data 1360 1392 32 2.4
.rodata 204709 204837 128 0.1
.text 2027250 2027506 256 0.0
bridge-app debug+rpc (read only) 1720805 1721189 384 0.0
(read/write) 92744 92752 8 0.0
.bss 47552 47560 8 0.0
.data 2042 2048 6 0.3
.rodata 141492 141620 128 0.1
.text 1463509 1463765 256 0.0
door-lock-app debug (read only) 1936273 1936657 384 0.0
(read/write) 119136 119200 64 0.1
.bss 50496 50560 64 0.1
.data 1050 1056 6 0.6
.rodata 173532 173660 128 0.1
.text 1614258 1614514 256 0.0
lighting-app debug+rpc (read only) 2071137 2071561 424 0.0
(read/write) 124496 124560 64 0.1
.bss 51424 51488 64 0.1
.rodata 166129 166300 171 0.1
.text 1749554 1749810 256 0.0
ota-provider-app debug (read only) 1868393 1868745 352 0.0
(read/write) 114800 114832 32 0.0
.data 1320 1352 32 2.4
.rodata 158739 158835 96 0.1
.text 1559090 1559346 256 0.0
ota-requestor-app debug (read only) 1879385 1879801 416 0.0
(read/write) 116568 116600 32 0.0
.data 1192 1224 32 2.7
.rodata 152452 152612 160 0.1
.text 1578098 1578354 256 0.0
shell debug (read only) 2362961 2363345 384 0.0
.rodata 204658 204786 128 0.1
.text 2001746 2002002 256 0.0
thermostat-no-ble arm64 (read only) 2162948 2163380 432 0.0
(read/write) 148577 148593 16 0.0
.data 1056 1072 16 1.5
.rodata 132980 133108 128 0.1
.text 1811664 1811968 304 0.0
tv-app debug (read only) 2589489 2590769 1280 0.0
(read/write) 148632 148664 32 0.0
.data 3168 3200 32 1.0
.rodata 198653 198877 224 0.1
.text 2217074 2218130 1056 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5512 5520 8 0.1
lighting-app CY8CPROTO_062_4343W+release .data 5800 5808 8 0.1
lock-app CY8CPROTO_062_4343W+release .data 5776 5784 8 0.1
shell CY8CPROTO_062_4343W+release .data 5608 5616 8 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038947 1038987 40 0.0
text 700060 700080 20 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1002171 1002195 24 0.0
text 686440 686460 20 0.0
nrf52840dk_nrf52840+rpc (read/write) 968503 968527 24 0.0
text 663668 663684 16 0.0
nrf52840dongle_nrf52840 (read/write) 1018263 1018287 24 0.0
text 691148 691164 16 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904986 905010 24 0.0
text 596152 596172 20 0.0
lock-app nrf52840dk_nrf52840 (read/write) 931259 931283 24 0.0
text 628928 628944 16 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834886 834910 24 0.0
text 539404 539420 16 0.0
pump-app nrf52840dk_nrf52840 (read/write) 929519 929543 24 0.0
text 628356 628372 16 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 925479 925503 24 0.0
text 624612 624628 16 0.0
p6 all-clusters-app default .data 2688 2696 8 0.3
light-app default .data 2536 2544 8 0.3
lock-app default .data 2496 2504 8 0.3
telink lighting-app tlsr9518adk80d (read/write) 883158 883182 24 0.0
text 623996 624012 16 0.0
Decreases (11 builds for efr32, k32w, linux, p6)
platform target config section c1d14cc ffe5dbb change % change
efr32 lighting-app BRD4161A .bss 126560 126552 -8 -0.0
BRD4161A+rpc .bss 143336 143328 -8 -0.0
lock-app BRD4161A+wf200 (read only) 986476 986424 -52 -0.0
.text 986468 986416 -52 -0.0
window-app BRD4161A .bss 124928 124920 -8 -0.0
k32w lock k32w061+release .bss 77688 77680 -8 -0.0
linux chip-tool debug (read only) 9002309 8960461 -41848 -0.5
(read/write) 298816 282464 -16352 -5.5
.bss 40448 25184 -15264 -37.7
.data 1164 1136 -28 -2.4
.data.rel.ro 251144 250120 -1024 -0.4
.init_array 632 600 -32 -5.1
.rodata 481109 478133 -2976 -0.6
.text 7912293 7875845 -36448 -0.5
chip-tool-ipv6only arm64 (read only) 8756588 8721700 -34888 -0.4
(read/write) 412033 395633 -16400 -4.0
.bss 58673 43553 -15120 -25.8
.data 1216 1192 -24 -2.0
.data.rel.ro 296840 295752 -1088 -0.4
.got 51496 51352 -144 -0.3
.init_array 208 184 -24 -11.5
.rodata 456964 455852 -1112 -0.2
.text 7434388 7403604 -30784 -0.4
lighting-app debug+rpc .data.rel.ro 66144 66136 -8 -0.0
p6 all-clusters-app default (read/write) 2488128 2488096 -32 -0.0
.text 1446392 1446360 -32 -0.0
light-app default (read/write) 2395344 2395320 -24 -0.0
.text 1353608 1353584 -24 -0.0
lock-app default (read/write) 2358920 2358880 -40 -0.0
.text 1317184 1317144 -40 -0.0
Full report (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c1d14cc ffe5dbb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599614 599638 24 0.0
.app_xip_area 504460 504476 16 0.0
.bss 77844 77844 0 0.0
.data 652 660 8 1.2
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557686 557714 28 0.0
.app_xip_area 464068 464088 20 0.0
.bss 76348 76348 0 0.0
.data 616 624 8 1.3
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578210 578230 20 0.0
.app_xip_area 475160 475172 12 0.0
.bss 85452 85452 0 0.0
.data 560 568 8 1.4
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916556 916560 4 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126552 -8 -0.0
.data 2048 2056 8 0.4
.text 916548 916552 4 0.0
BRD4161A+rpc (read only) 946644 946644 0 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143328 -8 -0.0
.data 2212 2220 8 0.4
.text 946636 946636 0 0.0
lock-app BRD4161A+wf200 (read only) 986476 986424 -52 -0.0
(read/write) 120360 120372 12 0.0
.bss 118436 118436 0 0.0
.data 1924 1932 8 0.4
.text 986468 986416 -52 -0.0
window-app BRD4161A (read only) 850620 850648 28 0.0
(read/write) 126844 126848 4 0.0
.bss 124928 124920 -8 -0.0
.data 1916 1924 8 0.4
.text 850612 850640 28 0.0
esp32 all-clusters-app c3devkit (read only) 956550 956598 48 0.0
(read/write) 1393010 1393010 0 0.0
.dram0.bss 62592 62592 0 0.0
.dram0.data 14228 14236 8 0.1
.flash.rodata 197272 197272 0 0.0
.flash.text 956550 956598 48 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1004691 1004719 28 0.0
(read/write) 458288 458296 8 0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34080 8 0.0
.flash.rodata 224624 224624 0 0.0
.flash.text 999307 999335 28 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691972 692016 44 0.0
.bss 77480 77480 0 0.0
.data 1924 1932 8 0.4
.text 606768 606804 36 0.0
lock k32w061+release (read/write) 695244 695264 20 0.0
.bss 77688 77680 -8 -0.0
.data 1964 1972 8 0.4
.text 609792 609812 20 0.0
linux all-clusters-app debug (read only) 2394729 2395113 384 0.0
(read/write) 144696 144728 32 0.0
.bss 59232 59232 0 0.0
.data 1360 1392 32 2.4
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 204709 204837 128 0.1
.text 2027250 2027506 256 0.0
bridge-app debug+rpc (read only) 1720805 1721189 384 0.0
(read/write) 92744 92752 8 0.0
.bss 47552 47560 8 0.0
.data 2042 2048 6 0.3
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141492 141620 128 0.1
.text 1463509 1463765 256 0.0
chip-tool debug (read only) 9002309 8960461 -41848 -0.5
(read/write) 298816 282464 -16352 -5.5
.bss 40448 25184 -15264 -37.7
.data 1164 1136 -28 -2.4
.data.rel.ro 251144 250120 -1024 -0.4
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 600 -32 -5.1
.rodata 481109 478133 -2976 -0.6
.text 7912293 7875845 -36448 -0.5
chip-tool-ipv6only arm64 (read only) 8756588 8721700 -34888 -0.4
(read/write) 412033 395633 -16400 -4.0
.bss 58673 43553 -15120 -25.8
.data 1216 1192 -24 -2.0
.data.rel.ro 296840 295752 -1088 -0.4
.dynamic 560 560 0 0.0
.got 51496 51352 -144 -0.3
.init 24 24 0 0.0
.init_array 208 184 -24 -11.5
.rodata 456964 455852 -1112 -0.2
.text 7434388 7403604 -30784 -0.4
door-lock-app debug (read only) 1936273 1936657 384 0.0
(read/write) 119136 119200 64 0.1
.bss 50496 50560 64 0.1
.data 1050 1056 6 0.6
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173532 173660 128 0.1
.text 1614258 1614514 256 0.0
lighting-app debug+rpc (read only) 2071137 2071561 424 0.0
(read/write) 124496 124560 64 0.1
.bss 51424 51488 64 0.1
.data 1472 1472 0 0.0
.data.rel.ro 66144 66136 -8 -0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166129 166300 171 0.1
.text 1749554 1749810 256 0.0
ota-provider-app debug (read only) 1868393 1868745 352 0.0
(read/write) 114800 114832 32 0.0
.bss 50368 50368 0 0.0
.data 1320 1352 32 2.4
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158739 158835 96 0.1
.text 1559090 1559346 256 0.0
ota-requestor-app debug (read only) 1879385 1879801 416 0.0
(read/write) 116568 116600 32 0.0
.bss 51232 51232 0 0.0
.data 1192 1224 32 2.7
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152452 152612 160 0.1
.text 1578098 1578354 256 0.0
shell debug (read only) 2362961 2363345 384 0.0
(read/write) 147176 147176 0 0.0
.bss 67552 67552 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204658 204786 128 0.1
.text 2001746 2002002 256 0.0
thermostat-no-ble arm64 (read only) 2162948 2163380 432 0.0
(read/write) 148577 148593 16 0.0
.bss 65265 65265 0 0.0
.data 1056 1072 16 1.5
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132980 133108 128 0.1
.text 1811664 1811968 304 0.0
tv-app debug (read only) 2589489 2590769 1280 0.0
(read/write) 148632 148664 32 0.0
.bss 65824 65824 0 0.0
.data 3168 3200 32 1.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 198653 198877 224 0.1
.text 2217074 2218130 1056 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449728 2449728 0 0.0
.bss 191016 191016 0 0.0
.data 5512 5520 8 0.1
.text 1412300 1412300 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2414424 2414424 0 0.0
.bss 188188 188188 0 0.0
.data 5800 5808 8 0.1
.text 1376996 1376996 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350244 2350244 0 0.0
.bss 187092 187092 0 0.0
.data 5776 5784 8 0.1
.text 1312844 1312844 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1155428 1155428 0 0.0
.bss 11952 11952 0 0.0
.data 4512 4512 0 0.0
.text 118812 118812 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340240 2340240 0 0.0
.bss 185736 185736 0 0.0
.data 5608 5616 8 0.1
.text 1302812 1302812 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038947 1038987 40 0.0
bss 125756 125756 0 0.0
rodata 135924 135924 0 0.0
text 700060 700080 20 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1002171 1002195 24 0.0
bss 122064 122064 0 0.0
rodata 116164 116164 0 0.0
text 686440 686460 20 0.0
nrf52840dk_nrf52840+rpc (read/write) 968503 968527 24 0.0
bss 119148 119148 0 0.0
rodata 107544 107544 0 0.0
text 663668 663684 16 0.0
nrf52840dongle_nrf52840 (read/write) 1018263 1018287 24 0.0
bss 123112 123112 0 0.0
rodata 115852 115852 0 0.0
text 691148 691164 16 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904986 905010 24 0.0
bss 119352 119352 0 0.0
rodata 108280 108280 0 0.0
text 596152 596172 20 0.0
lock-app nrf52840dk_nrf52840 (read/write) 931259 931283 24 0.0
bss 120280 120280 0 0.0
rodata 104996 104996 0 0.0
text 628928 628944 16 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834886 834910 24 0.0
bss 117600 117600 0 0.0
rodata 97028 97028 0 0.0
text 539404 539420 16 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 501603 501603 0 0.0
bss 52584 52584 0 0.0
rodata 44500 44500 0 0.0
text 342712 342712 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 929519 929543 24 0.0
bss 120012 120012 0 0.0
rodata 103976 103976 0 0.0
text 628356 628372 16 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 925479 925503 24 0.0
bss 120016 120016 0 0.0
rodata 103672 103672 0 0.0
text 624612 624628 16 0.0
shell nrf52840dk_nrf52840 (read/write) 788811 788811 0 0.0
bss 112360 112360 0 0.0
rodata 74836 74836 0 0.0
text 525504 525504 0 0.0
p6 all-clusters-app default (read/write) 2488128 2488096 -32 -0.0
.bss 118664 118664 0 0.0
.data 2688 2696 8 0.3
.text 1446392 1446360 -32 -0.0
light-app default (read/write) 2395344 2395320 -24 -0.0
.bss 112984 112984 0 0.0
.data 2536 2544 8 0.3
.text 1353608 1353584 -24 -0.0
lock-app default (read/write) 2358920 2358880 -40 -0.0
.bss 112728 112728 0 0.0
.data 2496 2504 8 0.3
.text 1317184 1317144 -40 -0.0
telink lighting-app tlsr9518adk80d (read/write) 883158 883182 24 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623996 624012 16 0.0

@mrjerryjohns
Fixed persistent app on QPG to not set chip_system_config_use_open_th…
2767eb6 
…read_udp to false to fix compilation issues with Server.cpp
@mrjerryjohns
Copy link
Contributor Author

/rebase

@andy31415 andy31415 merged commit 75372d8 into project-chip:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt left review comments

@robszewczyk robszewczyk robszewczyk left review comments

@Abhayakara Abhayakara Abhayakara left review comments

@turon turon turon left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@gjc13 gjc13 gjc13 approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mrjerryjohns @turon @tcarmelveilleux @Abhayakara @robszewczyk @msandstedt @gjc13 @bzbarsky-apple @andy31415