Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cirque flask log display when error happens #14988

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Improve cirque flask log display when error happens #14988

merged 2 commits into from
Feb 11, 2022

Conversation

yunhanw-google
Copy link
Contributor

Problem

#14691

Change overview

Make cirque flask log readable

Testing

Manually validate it via injecting the error, and check the log display

@boring-cyborg boring-cyborg bot added the scripts label Feb 9, 2022
@restyled-io restyled-io bot mentioned this pull request Feb 9, 2022
Closed
@yunhanw-google yunhanw-google changed the title Improve flash log display when error happens Improve cirque flask log display when error happens Feb 9, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14988: Size comparison from d42c084 to e6045e1

Full report (41 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d42c084 e6045e1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600590 600590 0 0.0
.app_xip_area 506172 506172 0 0.0
.bss 77116 77116 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557278 557278 0 0.0
.app_xip_area 464420 464420 0 0.0
.bss 75588 75588 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578178 578178 0 0.0
.app_xip_area 476072 476072 0 0.0
.bss 84508 84508 0 0.0
.data 556 556 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 904648 904648 0 0.0
(read/write) 127224 127224 0 0.0
.bss 125184 125184 0 0.0
.data 2036 2036 0 0.0
.text 904640 904640 0 0.0
BRD4161A+rpc (read only) 892108 892108 0 0.0
(read/write) 143880 143880 0 0.0
.bss 141744 141744 0 0.0
.data 2136 2136 0 0.0
.text 892100 892100 0 0.0
window-app BRD4161A (read only) 840048 840048 0 0.0
(read/write) 125288 125288 0 0.0
.bss 123384 123384 0 0.0
.data 1904 1904 0 0.0
.text 840040 840040 0 0.0
k32w light k32w061+release (read/write) 680060 680060 0 0.0
.bss 76488 76488 0 0.0
.data 1908 1908 0 0.0
.text 595864 595864 0 0.0
lock k32w061+release (read/write) 684940 684940 0 0.0
.bss 76888 76888 0 0.0
.data 1952 1952 0 0.0
.text 600300 600300 0 0.0
linux all-clusters-app debug (read only) 2337473 2337473 0 0.0
(read/write) 139968 139968 0 0.0
.bss 54560 54560 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 78488 78488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205413 205413 0 0.0
.text 1969810 1969810 0 0.0
bridge-app debug+rpc (read only) 1708205 1708205 0 0.0
(read/write) 84200 84200 0 0.0
.bss 38960 38960 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141132 141132 0 0.0
.text 1450549 1450549 0 0.0
chip-tool debug (read only) 7517237 7517237 0 0.0
(read/write) 197048 197048 0 0.0
.bss 32232 32232 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 157560 157560 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 419829 419829 0 0.0
.text 6696997 6696997 0 0.0
chip-tool-ipv6only arm64 (read only) 7435820 7435820 0 0.0
(read/write) 301809 301809 0 0.0
.bss 50513 50513 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 199240 199240 0 0.0
.dynamic 560 560 0 0.0
.got 47040 47040 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 402004 402004 0 0.0
.text 6394644 6394644 0 0.0
door-lock-app debug (read only) 1913041 1913041 0 0.0
(read/write) 110520 110520 0 0.0
.bss 42032 42032 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62064 62064 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172626 172626 0 0.0
.text 1591922 1591922 0 0.0
lighting-app debug+rpc (read only) 2035281 2035281 0 0.0
(read/write) 115800 115800 0 0.0
.bss 43008 43008 0 0.0
.data 1464 1464 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 164945 164945 0 0.0
.text 1715522 1715522 0 0.0
ota-provider-app debug (read only) 1852665 1852665 0 0.0
(read/write) 106264 106264 0 0.0
.bss 41984 41984 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 57448 57448 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 158142 158142 0 0.0
.text 1543954 1543954 0 0.0
ota-requestor-app debug (read only) 1847393 1847393 0 0.0
(read/write) 107384 107384 0 0.0
.bss 42272 42272 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58504 58504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151535 151535 0 0.0
.text 1547010 1547010 0 0.0
shell debug (read only) 2310769 2310769 0 0.0
(read/write) 141392 141392 0 0.0
.bss 61824 61824 0 0.0
.data 816 816 0 0.0
.data.rel.ro 73040 73040 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206130 206130 0 0.0
.text 1948194 1948194 0 0.0
thermostat-no-ble arm64 (read only) 2133804 2133804 0 0.0
(read/write) 140529 140529 0 0.0
.bss 57537 57537 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 74840 74840 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132668 132668 0 0.0
.text 1783088 1783088 0 0.0
tv-app debug (read only) 2508889 2508889 0 0.0
(read/write) 139392 139392 0 0.0
.bss 57184 57184 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197132 197132 0 0.0
.text 2138818 2138818 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2394032 2394032 0 0.0
.bss 188316 188316 0 0.0
.data 5304 5304 0 0.0
.text 1356632 1356632 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2356176 2356176 0 0.0
.bss 180928 180928 0 0.0
.data 5632 5632 0 0.0
.text 1318776 1318776 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319896 2319896 0 0.0
.bss 180816 180816 0 0.0
.data 5608 5608 0 0.0
.text 1282496 1282496 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305836 2305836 0 0.0
.bss 178068 178068 0 0.0
.data 5424 5424 0 0.0
.text 1268408 1268408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1011763 1011763 0 0.0
bss 121244 121244 0 0.0
rodata 119336 119336 0 0.0
text 692176 692176 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 980591 980591 0 0.0
bss 118432 118432 0 0.0
rodata 110708 110708 0 0.0
text 671788 671788 0 0.0
nrf52840dongle_nrf52840 (read/write) 1027651 1027651 0 0.0
bss 122640 122640 0 0.0
rodata 118204 118204 0 0.0
text 696844 696844 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 918374 918374 0 0.0
bss 117808 117808 0 0.0
rodata 112576 112576 0 0.0
text 607200 607200 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 941675 941675 0 0.0
bss 119624 119624 0 0.0
rodata 108080 108080 0 0.0
text 635408 635408 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849170 849170 0 0.0
bss 116216 116216 0 0.0
rodata 101252 101252 0 0.0
text 551208 551208 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 941099 941099 0 0.0
bss 119344 119344 0 0.0
rodata 107440 107440 0 0.0
text 635672 635672 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 936439 936439 0 0.0
bss 119348 119348 0 0.0
rodata 106732 106732 0 0.0
text 631704 631704 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803903 803903 0 0.0
bss 111208 111208 0 0.0
rodata 78820 78820 0 0.0
text 536280 536280 0 0.0
p6 all-clusters-app default (read/write) 2479568 2479568 0 0.0
.bss 117576 117576 0 0.0
.data 2656 2656 0 0.0
.text 1437832 1437832 0 0.0
light-app default (read/write) 2386520 2386520 0 0.0
.bss 107224 107224 0 0.0
.data 2528 2528 0 0.0
.text 1344784 1344784 0 0.0
lock-app default (read/write) 2350136 2350136 0 0.0
.bss 106944 106944 0 0.0
.data 2488 2488 0 0.0
.text 1308400 1308400 0 0.0
qpg lighting-app qpg6105+debug (read only) 591164 591164 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88800 88800 0 0.0
.data 1112 1112 0 0.0
.text 585844 585844 0 0.0
lock-app qpg6105+debug (read only) 557056 557056 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88784 88784 0 0.0
.data 1064 1064 0 0.0
.text 551736 551736 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 870530 870530 0 0.0
bss 88576 88576 0 0.0
noinit 37160 37160 0 0.0
text 611140 611140 0 0.0

@andy31415 andy31415 merged commit c899d1f into project-chip:master Feb 11, 2022
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@yunhanw-google @restyled-commits @fuxingguo16
Improve cirque flask log display when error happens (project-chip#14988)
ca63506 
* Improve flash log display when error happens

* Restyled by shfmt

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yunhanw-google @yufengwangca @bzbarsky-apple @andy31415 @restyled-commits