Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log for decryption failure #14970

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Add log for decryption failure #14970

merged 1 commit into from
Feb 9, 2022

Conversation

jepenven-silabs
Copy link
Contributor

Problem

Upon key decryption failure, no log are outputted, only a silent failure

Change overview

Add log to help with debugging

Testing

Unit test

@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14970: Size comparison from f4901af to 54bb374

Increases (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section f4901af 54bb374 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599634 599754 120 0.0
.app_xip_area 505144 505264 120 0.0
lock cyw930739m2evb_01 (read/write) 556334 556454 120 0.0
.app_xip_area 463404 463524 120 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577234 577354 120 0.0
.app_xip_area 475056 475176 120 0.0
efr32 lighting-app BRD4161A (read only) 903664 903800 136 0.0
.text 903656 903792 136 0.0
BRD4161A+rpc (read only) 891108 891244 136 0.0
.text 891100 891236 136 0.0
window-app BRD4161A (read only) 839048 839184 136 0.0
.text 839040 839176 136 0.0
esp32 all-clusters-app c3devkit (read only) 940834 940854 20 0.0
(read/write) 1397866 1397970 104 0.0
.flash.rodata 198352 198456 104 0.1
.flash.text 940834 940854 20 0.0
m5stack (read only) 988767 988779 12 0.0
(read/write) 462880 462984 104 0.0
.flash.rodata 225240 225344 104 0.0
.flash.text 983383 983395 12 0.0
k32w light k32w061+release (read/write) 679132 679252 120 0.0
.text 594864 594984 120 0.0
lock k32w061+release (read/write) 684012 684132 120 0.0
.text 599300 599420 120 0.0
linux all-clusters-app debug (read only) 2334953 2335129 176 0.0
.rodata 204613 204741 128 0.1
.text 1968066 1968114 48 0.0
bridge-app debug+rpc (read only) 1705845 1706021 176 0.0
.rodata 140332 140460 128 0.1
.text 1448965 1449013 48 0.0
chip-tool debug (read only) 7514813 7514973 160 0.0
.rodata 418901 418997 96 0.0
.text 6695477 6695541 64 0.0
chip-tool-ipv6only arm64 (read only) 7433596 7433724 128 0.0
.rodata 401300 401412 112 0.0
.text 6393092 6393108 16 0.0
door-lock-app debug (read only) 1910553 1910697 144 0.0
.rodata 171858 171954 96 0.1
.text 1590178 1590226 48 0.0
lighting-app debug+rpc (read only) 2032825 2033001 176 0.0
.rodata 164209 164337 128 0.1
.text 1713778 1713826 48 0.0
ota-provider-app debug (read only) 1714521 1714713 192 0.0
.rodata 151910 152038 128 0.1
.text 1443906 1443970 64 0.0
ota-requestor-app debug (read only) 1709161 1709305 144 0.0
.rodata 145495 145591 96 0.1
.text 1446770 1446818 48 0.0
shell debug (read only) 2308393 2308553 160 0.0
.rodata 205330 205426 96 0.0
.text 1946594 1946658 64 0.0
thermostat-no-ble arm64 (read only) 2131068 2131180 112 0.0
.rodata 132108 132204 96 0.1
.text 1780896 1780912 16 0.0
tv-app debug (read only) 2503209 2503353 144 0.0
.rodata 196140 196236 96 0.0
.text 2134130 2134178 48 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2391536 2391640 104 0.0
.text 1354136 1354240 104 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2353688 2353856 168 0.0
.text 1316288 1316456 168 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2317408 2317512 104 0.0
.text 1280008 1280112 104 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2303508 168 0.0
.text 1265912 1266080 168 0.0
p6 all-clusters-app default (read/write) 2478576 2478712 136 0.0
.text 1436840 1436976 136 0.0
light-app default (read/write) 2385536 2385672 136 0.0
.text 1343800 1343936 136 0.0
lock-app default (read/write) 2349136 2349280 144 0.0
.text 1307400 1307544 144 0.0
qpg lighting-app qpg6105+debug (read only) 590172 590292 120 0.0
.text 584852 584972 120 0.0
lock-app qpg6105+debug (read only) 556064 556184 120 0.0
.text 550744 550864 120 0.0
telink lighting-app tlsr9518adk80d (read/write) 869602 869734 132 0.0
text 610720 610740 20 0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section f4901af 54bb374 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599634 599754 120 0.0
.app_xip_area 505144 505264 120 0.0
.bss 77212 77212 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556334 556454 120 0.0
.app_xip_area 463404 463524 120 0.0
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577234 577354 120 0.0
.app_xip_area 475056 475176 120 0.0
.bss 84604 84604 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 903664 903800 136 0.0
(read/write) 127296 127296 0 0.0
.bss 125280 125280 0 0.0
.data 2012 2012 0 0.0
.text 903656 903792 136 0.0
BRD4161A+rpc (read only) 891108 891244 136 0.0
(read/write) 143952 143952 0 0.0
.bss 141840 141840 0 0.0
.data 2112 2112 0 0.0
.text 891100 891236 136 0.0
window-app BRD4161A (read only) 839048 839184 136 0.0
(read/write) 125360 125360 0 0.0
.bss 123480 123480 0 0.0
.data 1880 1880 0 0.0
.text 839040 839176 136 0.0
esp32 all-clusters-app c3devkit (read only) 940834 940854 20 0.0
(read/write) 1397866 1397970 104 0.0
.dram0.bss 66344 66344 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198352 198456 104 0.1
.flash.text 940834 940854 20 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 988767 988779 12 0.0
(read/write) 462880 462984 104 0.0
.dram0.bss 71488 71488 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 225240 225344 104 0.0
.flash.text 983383 983395 12 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679132 679252 120 0.0
.bss 76584 76584 0 0.0
.data 1884 1884 0 0.0
.text 594864 594984 120 0.0
lock k32w061+release (read/write) 684012 684132 120 0.0
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599300 599420 120 0.0
linux all-clusters-app debug (read only) 2334953 2335129 176 0.0
(read/write) 140096 140096 0 0.0
.bss 54688 54688 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 78552 78552 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204613 204741 128 0.1
.text 1968066 1968114 48 0.0
bridge-app debug+rpc (read only) 1705845 1706021 176 0.0
(read/write) 84328 84328 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140460 128 0.1
.text 1448965 1449013 48 0.0
chip-tool debug (read only) 7514813 7514973 160 0.0
(read/write) 197176 197176 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 157624 157624 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 418901 418997 96 0.0
.text 6695477 6695541 64 0.0
chip-tool-ipv6only arm64 (read only) 7433596 7433724 128 0.0
(read/write) 301953 301953 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 199304 199304 0 0.0
.dynamic 560 560 0 0.0
.got 47040 47040 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 401300 401412 112 0.0
.text 6393092 6393108 16 0.0
door-lock-app debug (read only) 1910553 1910697 144 0.0
(read/write) 110680 110680 0 0.0
.bss 42160 42160 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62160 62160 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171858 171954 96 0.1
.text 1590178 1590226 48 0.0
lighting-app debug+rpc (read only) 2032825 2033001 176 0.0
(read/write) 115928 115928 0 0.0
.bss 43136 43136 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65928 65928 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 164209 164337 128 0.1
.text 1713778 1713826 48 0.0
ota-provider-app debug (read only) 1714521 1714713 192 0.0
(read/write) 81368 81368 0 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33560 33560 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 152038 128 0.1
.text 1443906 1443970 64 0.0
ota-requestor-app debug (read only) 1709161 1709305 144 0.0
(read/write) 83288 83288 0 0.0
.bss 42240 42240 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34616 34616 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145495 145591 96 0.1
.text 1446770 1446818 48 0.0
shell debug (read only) 2308393 2308553 160 0.0
(read/write) 141648 141648 0 0.0
.bss 62080 62080 0 0.0
.data 768 768 0 0.0
.data.rel.ro 73104 73104 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205330 205426 96 0.0
.text 1946594 1946658 64 0.0
thermostat-no-ble arm64 (read only) 2131068 2131180 112 0.0
(read/write) 140673 140673 0 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132204 96 0.1
.text 1780896 1780912 16 0.0
tv-app debug (read only) 2503209 2503353 144 0.0
(read/write) 139512 139512 0 0.0
.bss 57280 57280 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73048 73048 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 196140 196236 96 0.0
.text 2134130 2134178 48 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391536 2391640 104 0.0
.bss 188412 188412 0 0.0
.data 5280 5280 0 0.0
.text 1354136 1354240 104 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353688 2353856 168 0.0
.bss 181024 181024 0 0.0
.data 5608 5608 0 0.0
.text 1316288 1316456 168 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2317512 104 0.0
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1280112 104 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2303508 168 0.0
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265912 1266080 168 0.0
p6 all-clusters-app default (read/write) 2478576 2478712 136 0.0
.bss 117672 117672 0 0.0
.data 2632 2632 0 0.0
.text 1436840 1436976 136 0.0
light-app default (read/write) 2385536 2385672 136 0.0
.bss 107320 107320 0 0.0
.data 2504 2504 0 0.0
.text 1343800 1343936 136 0.0
lock-app default (read/write) 2349136 2349280 144 0.0
.bss 107040 107040 0 0.0
.data 2464 2464 0 0.0
.text 1307400 1307544 144 0.0
qpg lighting-app qpg6105+debug (read only) 590172 590292 120 0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 1088 1088 0 0.0
.text 584852 584972 120 0.0
lock-app qpg6105+debug (read only) 556064 556184 120 0.0
(read/write) 146940 146940 0 0.0
.bss 88880 88880 0 0.0
.data 1040 1040 0 0.0
.text 550744 550864 120 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 869602 869734 132 0.0
bss 88672 88672 0 0.0
noinit 37160 37160 0 0.0
text 610720 610740 20 0.0

@andy31415 andy31415 merged commit 98d1e33 into project-chip:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jepenven-silabs @tcarmelveilleux @woody-apple @andy31415