-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Implement OTA to all EFR32 examples #14924
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:ota_lighting-app
Feb 9, 2022
Merged
[OTA] Implement OTA to all EFR32 examples #14924
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:ota_lighting-app
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast track since EFR32 only. |
jepenven-silabs
force-pushed
the
ota_lighting-app
branch
from
February 9, 2022 02:02
e30ef4a
to
c8d2716
Compare
PR #14924: Size comparison from 3ef9ec3 to c8d2716 Full report (31 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple and
jelderton
February 9, 2022 05:43
pullapprove
bot
requested review from
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
February 9, 2022 05:43
woody-apple
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking platform changes.
PR #14924: Size comparison from 3ef9ec3 to 93499fa Increases above 0.2%:
Increases (7 builds for efr32, linux, p6)
Decreases (30 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Feb 9, 2022
andy31415
approved these changes
Feb 9, 2022
selissia
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
OTA isn't enabled on all efr32 examples
Change overview
Add OTA support to lock-app and lighting-app
Testing
Lighting-app logic was tested by @selissia