-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TV SDK, minor changes, mostly syncing the xml files per spec. #14910
Merged
woody-apple
merged 5 commits into
project-chip:master
from
lazarkov:feature/sync-tv-sdk-with-spec-february-2022
Feb 9, 2022
Merged
Update TV SDK, minor changes, mostly syncing the xml files per spec. #14910
woody-apple
merged 5 commits into
project-chip:master
from
lazarkov:feature/sync-tv-sdk-with-spec-february-2022
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda and
lzgrablic02
February 8, 2022 20:58
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
February 8, 2022 20:58
PR #14910: Size comparison from 8d0fd6b to a9424d2 Increases (1 build for linux)
Decreases (5 builds for esp32, linux, mbed, p6)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 8, 2022
lazarkov
force-pushed
the
feature/sync-tv-sdk-with-spec-february-2022
branch
from
February 8, 2022 22:19
a9424d2
to
c7d44ea
Compare
chrisdecenzo
approved these changes
Feb 8, 2022
PR #14910: Size comparison from 41b2347 to c7d44ea Increases above 0.2%:
Increases (4 builds for linux)
Decreases (6 builds for esp32, linux, mbed, p6)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issues reported
This PR will resolve these reported issues:
#13214
#13606
Change overview
see above
Testing
Run
./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "