-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CHIP_CONFIG_MAX_DEVICE_ADMINS to CHIP_CONFIG_MAX_FABRICS. #14851
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:better-naming-for-max-fabrics
Feb 8, 2022
Merged
Rename CHIP_CONFIG_MAX_DEVICE_ADMINS to CHIP_CONFIG_MAX_FABRICS. #14851
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:better-naming-for-max-fabrics
Feb 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost and
LuDuda
February 7, 2022 19:14
mrjerryjohns
approved these changes
Feb 7, 2022
emargolis
approved these changes
Feb 7, 2022
selissia
approved these changes
Feb 7, 2022
bzbarsky-apple
force-pushed
the
better-naming-for-max-fabrics
branch
from
February 7, 2022 19:20
ee3790e
to
b94b346
Compare
bzbarsky-apple
force-pushed
the
better-naming-for-max-fabrics
branch
from
February 7, 2022 19:20
b94b346
to
26b895a
Compare
PR #14851: Size comparison from a92d1a8 to 26b895a Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
msandstedt
approved these changes
Feb 7, 2022
carol-apple
approved these changes
Feb 7, 2022
andy31415
approved these changes
Feb 7, 2022
/rebase |
woody-apple
force-pushed
the
better-naming-for-max-fabrics
branch
from
February 8, 2022 03:22
26b895a
to
be8c42e
Compare
PR #14851: Size comparison from 88032ed to be8c42e Full report (17 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
/rebase |
bzbarsky-apple
force-pushed
the
better-naming-for-max-fabrics
branch
from
February 8, 2022 04:37
be8c42e
to
5c5d075
Compare
PR #14851: Size comparison from 97cf4ff to 5c5d075 Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
That's what it really means. There can be multiple "admins" per fabric.
woody-apple
force-pushed
the
better-naming-for-max-fabrics
branch
from
February 8, 2022 08:38
5c5d075
to
6709006
Compare
PR #14851: Size comparison from b4901db to 6709006 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's what it really means. There can be multiple "admins" per fabric.
Problem
Confusing naming.
Change overview
Say what we mean, and mean what we say.
Testing
No behavior changes expected.