Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Media Struct Atributes on chip tool #14841

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Enable Media Struct Atributes on chip tool #14841

merged 2 commits into from
Feb 8, 2022

Conversation

lazarkov
Copy link
Contributor

@lazarkov lazarkov commented Feb 7, 2022 •
edited
Loading

Problem

The list of attributes haven't been enabled on chip tool. Meaning, you were not able to test them on test events.
ApplicationBasic#ApplicationAttribute
ApplicationLauncher#CurrentAppAttribute
ChannelCluster#LineupAttribute
ChannelCluster#CurrentChannel
MediaPlaybackCluster#SampledPositionAttribute

Issues reported

This PR will resolve these reported issues:
#12204
#14744

Important

I've also updated the zap template file as it caused the Android fail build.

Change overview

see above

Testing

Run ./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "

@lazarkov lazarkov added the tv TV-related features label Feb 7, 2022
@lazarkov lazarkov self-assigned this Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14841: Size comparison from d7af12d to b9fc18b

Increases above 0.2%:

platform target config section d7af12d b9fc18b change % change
linux chip-tool-ipv6only arm64 (read only) 7239492 7263396 23904 0.3
(read/write) 287921 288849 928 0.3
.data.rel.ro 186528 187392 864 0.5
.rodata 392812 393836 1024 0.3
.text 6241844 6262708 20864 0.3
Increases (1 build for linux)
platform target config section d7af12d b9fc18b change % change
linux chip-tool-ipv6only arm64 (read only) 7239492 7263396 23904 0.3
(read/write) 287921 288849 928 0.3
.data.rel.ro 186528 187392 864 0.5
.got 45784 45848 64 0.1
.rodata 392812 393836 1024 0.3
.text 6241844 6262708 20864 0.3
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d7af12d b9fc18b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587734 587734 0 0.0
.app_xip_area 494468 494468 0 0.0
.bss 75988 75988 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545646 545646 0 0.0
.app_xip_area 453940 453940 0 0.0
.bss 74460 74460 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570090 570090 0 0.0
.app_xip_area 469064 469064 0 0.0
.bss 83452 83452 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857524 857524 0 0.0
(read/write) 125740 125740 0 0.0
.bss 123816 123816 0 0.0
.data 1924 1924 0 0.0
.text 857516 857516 0 0.0
BRD4161A+rpc (read only) 844900 844900 0 0.0
(read/write) 142400 142400 0 0.0
.bss 140376 140376 0 0.0
.data 2024 2024 0 0.0
.text 844892 844892 0 0.0
window-app BRD4161A (read only) 829776 829776 0 0.0
(read/write) 124384 124384 0 0.0
.bss 122504 122504 0 0.0
.data 1880 1880 0 0.0
.text 829768 829768 0 0.0
esp32 all-clusters-app c3devkit (read only) 937038 937038 0 0.0
(read/write) 1401242 1401242 0 0.0
.dram0.bss 70064 70064 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198000 198000 0 0.0
.flash.text 937038 937038 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 985011 985011 0 0.0
(read/write) 465592 465592 0 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224608 224608 0 0.0
.flash.text 979627 979627 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672292 672292 0 0.0
.bss 75688 75688 0 0.0
.data 1884 1884 0 0.0
.text 588920 588920 0 0.0
lock k32w061+release (read/write) 673760 673760 0 0.0
.bss 76016 76016 0 0.0
.data 1924 1924 0 0.0
.text 590020 590020 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7239492 7263396 23904 0.3
(read/write) 287921 288849 928 0.3
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 187392 864 0.5
.dynamic 560 560 0 0.0
.got 45784 45848 64 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392812 393836 1024 0.3
.text 6241844 6262708 20864 0.3
thermostat-no-ble arm64 (read only) 2127652 2127652 0 0.0
(read/write) 140561 140561 0 0.0
.bss 57601 57601 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131412 0 0.0
.text 1778288 1778288 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389200 2389200 0 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351800 1351800 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348464 2348464 0 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311064 1311064 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312384 2312384 0 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1274984 1274984 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302836 2302836 0 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265408 1265408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998143 998143 0 0.0
bss 120404 120404 0 0.0
rodata 117308 117308 0 0.0
text 681508 681508 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 969571 969571 0 0.0
bss 116260 116260 0 0.0
rodata 108768 108768 0 0.0
text 666072 666072 0 0.0
nrf52840dongle_nrf52840 (read/write) 1014831 1014831 0 0.0
bss 121768 121768 0 0.0
rodata 116144 116144 0 0.0
text 687000 687000 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904818 904818 0 0.0
bss 116964 116964 0 0.0
rodata 110564 110564 0 0.0
text 596516 596516 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930283 930283 0 0.0
bss 118740 118740 0 0.0
rodata 105656 105656 0 0.0
text 627368 627368 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837794 837794 0 0.0
bss 115336 115336 0 0.0
rodata 98828 98828 0 0.0
text 543152 543152 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932899 932899 0 0.0
bss 118492 118492 0 0.0
rodata 106128 106128 0 0.0
text 629704 629704 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927855 927855 0 0.0
bss 118496 118496 0 0.0
rodata 105132 105132 0 0.0
text 625644 625644 0 0.0
shell nrf52840dk_nrf52840 (read/write) 802811 802811 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535792 535792 0 0.0
p6 all-clusters-app default (read/write) 2450352 2450352 0 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408616 1408616 0 0.0
light-app default (read/write) 2353784 2353784 0 0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312048 1312048 0 0.0
lock-app default (read/write) 2318984 2318984 0 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277248 1277248 0 0.0
qpg lighting-app qpg6105+debug (read only) 580504 580504 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87976 87976 0 0.0
.data 1088 1088 0 0.0
.text 575184 575184 0 0.0
lock-app qpg6105+debug (read only) 526572 526572 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87424 87424 0 0.0
.data 1024 1024 0 0.0
.text 521252 521252 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859166 859166 0 0.0
bss 88332 88332 0 0.0
noinit 37160 37160 0 0.0
text 602234 602234 0 0.0

@lazarkov lazarkov force-pushed the feature/enable-struct-atributes-for-chip-tool branch from b9fc18b to 41bec69 Compare February 7, 2022 18:17
@bzbarsky-apple
Copy link
Contributor

Is this relevant once #14794 merges?

bzbarsky-apple
bzbarsky-apple approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is relevant for other controllers, so is a good change to make no matter what chip-tool is doing.

@lazarkov lazarkov force-pushed the feature/enable-struct-atributes-for-chip-tool branch 2 times, most recently from cf3e81f to 3ef665b Compare February 7, 2022 20:42
@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14841: Size comparison from 566402a to 3ef665b

Increases above 0.2%:

platform target config section 566402a 3ef665b change % change
linux chip-tool-ipv6only arm64 (read only) 7263300 7287220 23920 0.3
(read/write) 288385 289313 928 0.3
.data.rel.ro 186872 187736 864 0.5
.rodata 393132 394172 1040 0.3
.text 6264276 6285140 20864 0.3
Increases (1 build for linux)
platform target config section 566402a 3ef665b change % change
linux chip-tool-ipv6only arm64 (read only) 7263300 7287220 23920 0.3
(read/write) 288385 289313 928 0.3
.data.rel.ro 186872 187736 864 0.5
.got 45904 45968 64 0.1
.rodata 393132 394172 1040 0.3
.text 6264276 6285140 20864 0.3
Full report (11 builds for cyw30739, k32w, linux, qpg, telink)
platform target config section 566402a 3ef665b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594518 594518 0 0.0
.app_xip_area 500372 500372 0 0.0
.bss 76868 76868 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552422 552422 0 0.0
.app_xip_area 459836 459836 0 0.0
.bss 75340 75340 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576462 576462 0 0.0
.app_xip_area 474556 474556 0 0.0
.bss 84332 84332 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 678648 678648 0 0.0
.bss 76568 76568 0 0.0
.data 1884 1884 0 0.0
.text 594396 594396 0 0.0
lock k32w061+release (read/write) 680532 680532 0 0.0
.bss 76896 76896 0 0.0
.data 1924 1924 0 0.0
.text 595912 595912 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7263300 7287220 23920 0.3
(read/write) 288385 289313 928 0.3
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186872 187736 864 0.5
.dynamic 560 560 0 0.0
.got 45904 45968 64 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 393132 394172 1040 0.3
.text 6264276 6285140 20864 0.3
thermostat-no-ble arm64 (read only) 2130244 2130244 0 0.0
(read/write) 140561 140561 0 0.0
.bss 57601 57601 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131716 131716 0 0.0
.text 1780576 1780576 0 0.0
qpg lighting-app qpg6105+debug (read only) 585960 585960 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88856 88856 0 0.0
.data 1088 1088 0 0.0
.text 580640 580640 0 0.0
lock-app qpg6105+debug (read only) 532028 532028 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88304 88304 0 0.0
.data 1024 1024 0 0.0
.text 526708 526708 0 0.0
persistent-storage-app qpg6105+debug (read only) 99548 99548 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94228 94228 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 866398 866398 0 0.0
bss 89208 89208 0 0.0
noinit 37160 37160 0 0.0
text 607696 607696 0 0.0

@lazarkov lazarkov force-pushed the feature/enable-struct-atributes-for-chip-tool branch from 3ef665b to b68d7ef Compare February 7, 2022 21:15
@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14841: Size comparison from 6f9fa8e to b68d7ef

Increases above 0.2%:

platform target config section 6f9fa8e b68d7ef change % change
linux chip-tool-ipv6only arm64 (read only) 7263300 7287220 23920 0.3
(read/write) 288385 289313 928 0.3
.data.rel.ro 186872 187736 864 0.5
.rodata 393132 394172 1040 0.3
.text 6264276 6285140 20864 0.3
Increases (1 build for linux)
platform target config section 6f9fa8e b68d7ef change % change
linux chip-tool-ipv6only arm64 (read only) 7263300 7287220 23920 0.3
(read/write) 288385 289313 928 0.3
.data.rel.ro 186872 187736 864 0.5
.got 45904 45968 64 0.1
.rodata 393132 394172 1040 0.3
.text 6264276 6285140 20864 0.3
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6f9fa8e b68d7ef change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594518 594518 0 0.0
.app_xip_area 500372 500372 0 0.0
.bss 76868 76868 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552422 552422 0 0.0
.app_xip_area 459836 459836 0 0.0
.bss 75340 75340 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576462 576462 0 0.0
.app_xip_area 474556 474556 0 0.0
.bss 84332 84332 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 865884 865884 0 0.0
(read/write) 126620 126620 0 0.0
.bss 124696 124696 0 0.0
.data 1924 1924 0 0.0
.text 865876 865876 0 0.0
BRD4161A+rpc (read only) 853356 853356 0 0.0
(read/write) 143280 143280 0 0.0
.bss 141256 141256 0 0.0
.data 2024 2024 0 0.0
.text 853348 853348 0 0.0
window-app BRD4161A (read only) 838104 838104 0 0.0
(read/write) 125264 125264 0 0.0
.bss 123384 123384 0 0.0
.data 1880 1880 0 0.0
.text 838096 838096 0 0.0
esp32 all-clusters-app c3devkit (read only) 937480 937480 0 0.0
(read/write) 1400986 1400986 0 0.0
.dram0.bss 69448 69448 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198352 198352 0 0.0
.flash.text 937480 937480 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 985307 985307 0 0.0
(read/write) 465320 465320 0 0.0
.dram0.bss 74200 74200 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224952 224952 0 0.0
.flash.text 979923 979923 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 678648 678648 0 0.0
.bss 76568 76568 0 0.0
.data 1884 1884 0 0.0
.text 594396 594396 0 0.0
lock k32w061+release (read/write) 680532 680532 0 0.0
.bss 76896 76896 0 0.0
.data 1924 1924 0 0.0
.text 595912 595912 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7263300 7287220 23920 0.3
(read/write) 288385 289313 928 0.3
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186872 187736 864 0.5
.dynamic 560 560 0 0.0
.got 45904 45968 64 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 393132 394172 1040 0.3
.text 6264276 6285140 20864 0.3
thermostat-no-ble arm64 (read only) 2129316 2129316 0 0.0
(read/write) 140625 140625 0 0.0
.bss 57665 57665 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131860 131860 0 0.0
.text 1779504 1779504 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389760 2389760 0 0.0
.bss 188356 188356 0 0.0
.data 5296 5296 0 0.0
.text 1352360 1352360 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348928 2348928 0 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311528 1311528 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312848 2312848 0 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1275448 1275448 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302884 2302884 0 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265456 1265456 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004827 1004827 0 0.0
bss 121280 121280 0 0.0
rodata 118072 118072 0 0.0
text 686540 686540 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 976319 976319 0 0.0
bss 117136 117136 0 0.0
rodata 109532 109532 0 0.0
text 671188 671188 0 0.0
nrf52840dongle_nrf52840 (read/write) 1021647 1021647 0 0.0
bss 122644 122644 0 0.0
rodata 116960 116960 0 0.0
text 692112 692112 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911506 911506 0 0.0
bss 117840 117840 0 0.0
rodata 111332 111332 0 0.0
text 601568 601568 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 937083 937083 0 0.0
bss 119616 119616 0 0.0
rodata 106472 106472 0 0.0
text 632460 632460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844594 844594 0 0.0
bss 116212 116212 0 0.0
rodata 99644 99644 0 0.0
text 548260 548260 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939331 939331 0 0.0
bss 119368 119368 0 0.0
rodata 106656 106656 0 0.0
text 634704 634704 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934671 934671 0 0.0
bss 119372 119372 0 0.0
rodata 105948 105948 0 0.0
text 630740 630740 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803343 803343 0 0.0
bss 111232 111232 0 0.0
rodata 78532 78532 0 0.0
text 536004 536004 0 0.0
p6 all-clusters-app default (read/write) 2450984 2450984 0 0.0
.bss 116512 116512 0 0.0
.data 2584 2584 0 0.0
.text 1409248 1409248 0 0.0
light-app default (read/write) 2354432 2354432 0 0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312696 1312696 0 0.0
lock-app default (read/write) 2319616 2319616 0 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277880 1277880 0 0.0
qpg lighting-app qpg6105+debug (read only) 585960 585960 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88856 88856 0 0.0
.data 1088 1088 0 0.0
.text 580640 580640 0 0.0
lock-app qpg6105+debug (read only) 532028 532028 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88304 88304 0 0.0
.data 1024 1024 0 0.0
.text 526708 526708 0 0.0
persistent-storage-app qpg6105+debug (read only) 99548 99548 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94228 94228 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 865822 865822 0 0.0
bss 88592 88592 0 0.0
noinit 37160 37160 0 0.0
text 607738 607738 0 0.0

@lazarkov
Copy link
Contributor Author

lazarkov commented Feb 7, 2022

I guess this is relevant for other controllers, so is a good change to make no matter what chip-tool is doing.

@bzbarsky-apple yes it definitely won't harm.

@lazarkov lazarkov mentioned this pull request Feb 7, 2022
Closed
@chrisdecenzo chrisdecenzo merged commit b5776df into project-chip:master Feb 8, 2022
@lazarkov lazarkov deleted the feature/enable-struct-atributes-for-chip-tool branch February 8, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@lazarkov lazarkov

Labels
controller darwin review - approved tv TV-related features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazarkov @bzbarsky-apple @chrisdecenzo