Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] Automatically build OTA image based on config option #14835

Merged
merged 1 commit into from
Feb 8, 2022
Merged

[ESP32] Automatically build OTA image based on config option #14835

merged 1 commit into from
Feb 8, 2022

Conversation

shubhamdp
Copy link
Contributor

Problem

  • Building OTA image during build process is missing

Change overview

  • Build OTA image during build process which depends on config option

Testing

  • Tested using all-clusters-app/esp32, OTA image is generated in build/ directory and ota_image_tool.py show shows the correct parameters which were provided using config options.

@boring-cyborg boring-cyborg bot added the config label Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14835: Size comparison from 0f7be8b to 696a0a6

Full report (32 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0f7be8b 696a0a6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587670 587670 0 0.0
.app_xip_area 494404 494404 0 0.0
.bss 75988 75988 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545586 545586 0 0.0
.app_xip_area 453880 453880 0 0.0
.bss 74460 74460 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570010 570010 0 0.0
.app_xip_area 468984 468984 0 0.0
.bss 83452 83452 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857496 857496 0 0.0
(read/write) 125744 125744 0 0.0
.bss 123816 123816 0 0.0
.data 1924 1924 0 0.0
.text 857488 857488 0 0.0
BRD4161A+rpc (read only) 844848 844848 0 0.0
(read/write) 142400 142400 0 0.0
.bss 140376 140376 0 0.0
.data 2024 2024 0 0.0
.text 844840 844840 0 0.0
window-app BRD4161A (read only) 829732 829732 0 0.0
(read/write) 124384 124384 0 0.0
.bss 122504 122504 0 0.0
.data 1880 1880 0 0.0
.text 829724 829724 0 0.0
k32w light k32w061+release (read/write) 672212 672212 0 0.0
.bss 75688 75688 0 0.0
.data 1884 1884 0 0.0
.text 588840 588840 0 0.0
lock k32w061+release (read/write) 673744 673744 0 0.0
.bss 76016 76016 0 0.0
.data 1924 1924 0 0.0
.text 590004 590004 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7238916 7238916 0 0.0
(read/write) 287921 287921 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186528 0 0.0
.dynamic 560 560 0 0.0
.got 45784 45784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392812 392812 0 0.0
.text 6241268 6241268 0 0.0
thermostat-no-ble arm64 (read only) 2127300 2127300 0 0.0
(read/write) 140561 140561 0 0.0
.bss 57601 57601 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131412 0 0.0
.text 1777936 1777936 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389192 2389192 0 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351792 1351792 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348448 2348448 0 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311048 1311048 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312368 2312368 0 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1274968 1274968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302708 2302708 0 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265280 1265280 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998095 998095 0 0.0
bss 120404 120404 0 0.0
rodata 117308 117308 0 0.0
text 681464 681464 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 969451 969451 0 0.0
bss 116260 116260 0 0.0
rodata 108696 108696 0 0.0
text 666020 666020 0 0.0
nrf52840dongle_nrf52840 (read/write) 1014783 1014783 0 0.0
bss 121768 121768 0 0.0
rodata 116144 116144 0 0.0
text 686956 686956 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904786 904786 0 0.0
bss 116964 116964 0 0.0
rodata 110564 110564 0 0.0
text 596472 596472 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930235 930235 0 0.0
bss 118740 118740 0 0.0
rodata 105656 105656 0 0.0
text 627324 627324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837762 837762 0 0.0
bss 115336 115336 0 0.0
rodata 98828 98828 0 0.0
text 543108 543108 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932867 932867 0 0.0
bss 118492 118492 0 0.0
rodata 106128 106128 0 0.0
text 629660 629660 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927807 927807 0 0.0
bss 118496 118496 0 0.0
rodata 105132 105132 0 0.0
text 625600 625600 0 0.0
shell nrf52840dk_nrf52840 (read/write) 802811 802811 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535792 535792 0 0.0
p6 all-clusters-app default (read/write) 2450304 2450304 0 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408568 1408568 0 0.0
light-app default (read/write) 2353736 2353736 0 0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312000 1312000 0 0.0
lock-app default (read/write) 2318944 2318944 0 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277208 1277208 0 0.0
qpg lighting-app qpg6105+debug (read only) 580468 580468 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87976 87976 0 0.0
.data 1088 1088 0 0.0
.text 575148 575148 0 0.0
lock-app qpg6105+debug (read only) 526548 526548 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87424 87424 0 0.0
.data 1024 1024 0 0.0
.text 521228 521228 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859102 859102 0 0.0
bss 88332 88332 0 0.0
noinit 37160 37160 0 0.0
text 602176 602176 0 0.0

@shubhamdp shubhamdp changed the title [ESP32] Automatically build OTA image based on config option WIP: [ESP32] Automatically build OTA image based on config option Feb 7, 2022
@shubhamdp shubhamdp force-pushed the esp32_build_ota_image branch from 696a0a6 to dab30f9 Compare February 7, 2022 14:43
@shubhamdp shubhamdp changed the title WIP: [ESP32] Automatically build OTA image based on config option [ESP32] Automatically build OTA image based on config option Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14835: Size comparison from a8ff1d9 to dab30f9

Increases (2 builds for esp32)
platform target config section a8ff1d9 dab30f9 change % change
esp32 all-clusters-app c3devkit (read only) 937038 937042 4 0.0
(read/write) 1401242 1401250 8 0.0
.flash.rodata 198000 198008 8 0.0
.flash.text 937038 937042 4 0.0
m5stack (read only) 985011 985015 4 0.0
(read/write) 465592 465600 8 0.0
.flash.rodata 224608 224616 8 0.0
.flash.text 979627 979631 4 0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a8ff1d9 dab30f9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587734 587734 0 0.0
.app_xip_area 494468 494468 0 0.0
.bss 75988 75988 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545646 545646 0 0.0
.app_xip_area 453940 453940 0 0.0
.bss 74460 74460 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570090 570090 0 0.0
.app_xip_area 469064 469064 0 0.0
.bss 83452 83452 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857524 857524 0 0.0
(read/write) 125740 125740 0 0.0
.bss 123816 123816 0 0.0
.data 1924 1924 0 0.0
.text 857516 857516 0 0.0
BRD4161A+rpc (read only) 844900 844900 0 0.0
(read/write) 142400 142400 0 0.0
.bss 140376 140376 0 0.0
.data 2024 2024 0 0.0
.text 844892 844892 0 0.0
window-app BRD4161A (read only) 829776 829776 0 0.0
(read/write) 124384 124384 0 0.0
.bss 122504 122504 0 0.0
.data 1880 1880 0 0.0
.text 829768 829768 0 0.0
esp32 all-clusters-app c3devkit (read only) 937038 937042 4 0.0
(read/write) 1401242 1401250 8 0.0
.dram0.bss 70064 70064 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198000 198008 8 0.0
.flash.text 937038 937042 4 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 985011 985015 4 0.0
(read/write) 465592 465600 8 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224608 224616 8 0.0
.flash.text 979627 979631 4 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672292 672292 0 0.0
.bss 75688 75688 0 0.0
.data 1884 1884 0 0.0
.text 588920 588920 0 0.0
lock k32w061+release (read/write) 673760 673760 0 0.0
.bss 76016 76016 0 0.0
.data 1924 1924 0 0.0
.text 590020 590020 0 0.0
linux all-clusters-app debug (read only) 2324625 2324625 0 0.0
(read/write) 140032 140032 0 0.0
.bss 54656 54656 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204421 204421 0 0.0
.text 1958002 1958002 0 0.0
bridge-app debug+rpc (read only) 1701165 1701165 0 0.0
(read/write) 84296 84296 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 139692 139692 0 0.0
.text 1445045 1445045 0 0.0
chip-tool debug (read only) 7299213 7299213 0 0.0
(read/write) 184592 184592 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 145072 145072 0 0.0
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 410389 410389 0 0.0
.text 6518885 6518885 0 0.0
chip-tool-ipv6only arm64 (read only) 7239492 7239492 0 0.0
(read/write) 287921 287921 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186528 0 0.0
.dynamic 560 560 0 0.0
.got 45784 45784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392812 392812 0 0.0
.text 6241844 6241844 0 0.0
door-lock-app debug (read only) 1905249 1905249 0 0.0
(read/write) 110584 110584 0 0.0
.bss 42128 42128 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62096 62096 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172242 172242 0 0.0
.text 1584610 1584610 0 0.0
lighting-app debug+rpc (read only) 2000065 2000065 0 0.0
(read/write) 115624 115624 0 0.0
.bss 43128 43128 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65640 65640 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 162353 162353 0 0.0
.text 1683186 1683186 0 0.0
ota-provider-app debug (read only) 1711353 1711353 0 0.0
(read/write) 81336 81336 0 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33528 33528 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151142 151142 0 0.0
.text 1441650 1441650 0 0.0
ota-requestor-app debug (read only) 1700769 1700769 0 0.0
(read/write) 83288 83288 0 0.0
.bss 42272 42272 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34584 34584 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 144759 144759 0 0.0
.text 1439234 1439234 0 0.0
shell debug (read only) 2298681 2298681 0 0.0
(read/write) 141552 141552 0 0.0
.bss 62016 62016 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73040 73040 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205298 205298 0 0.0
.text 1936962 1936962 0 0.0
thermostat-no-ble arm64 (read only) 2127652 2127652 0 0.0
(read/write) 140561 140561 0 0.0
.bss 57601 57601 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131412 0 0.0
.text 1778288 1778288 0 0.0
tv-app debug (read only) 2519361 2519361 0 0.0
(read/write) 139544 139544 0 0.0
.bss 57120 57120 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73224 73224 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 193780 193780 0 0.0
.text 2152546 2152546 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389200 2389200 0 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351800 1351800 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348464 2348464 0 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311064 1311064 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312384 2312384 0 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1274984 1274984 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302836 2302836 0 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265408 1265408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998143 998143 0 0.0
bss 120404 120404 0 0.0
rodata 117308 117308 0 0.0
text 681508 681508 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 969571 969571 0 0.0
bss 116260 116260 0 0.0
rodata 108768 108768 0 0.0
text 666072 666072 0 0.0
nrf52840dongle_nrf52840 (read/write) 1014831 1014831 0 0.0
bss 121768 121768 0 0.0
rodata 116144 116144 0 0.0
text 687000 687000 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904818 904818 0 0.0
bss 116964 116964 0 0.0
rodata 110564 110564 0 0.0
text 596516 596516 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930283 930283 0 0.0
bss 118740 118740 0 0.0
rodata 105656 105656 0 0.0
text 627368 627368 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837794 837794 0 0.0
bss 115336 115336 0 0.0
rodata 98828 98828 0 0.0
text 543152 543152 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932899 932899 0 0.0
bss 118492 118492 0 0.0
rodata 106128 106128 0 0.0
text 629704 629704 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927855 927855 0 0.0
bss 118496 118496 0 0.0
rodata 105132 105132 0 0.0
text 625644 625644 0 0.0
shell nrf52840dk_nrf52840 (read/write) 802811 802811 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535792 535792 0 0.0
p6 all-clusters-app default (read/write) 2450352 2450352 0 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408616 1408616 0 0.0
light-app default (read/write) 2353784 2353784 0 0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312048 1312048 0 0.0
lock-app default (read/write) 2318984 2318984 0 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277248 1277248 0 0.0
qpg lighting-app qpg6105+debug (read only) 580504 580504 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87976 87976 0 0.0
.data 1088 1088 0 0.0
.text 575184 575184 0 0.0
lock-app qpg6105+debug (read only) 526572 526572 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87424 87424 0 0.0
.data 1024 1024 0 0.0
.text 521252 521252 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859166 859166 0 0.0
bss 88332 88332 0 0.0
noinit 37160 37160 0 0.0
text 602234 602234 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking platform changes by a platform maintainer.

@woody-apple woody-apple merged commit b4901db into project-chip:master Feb 8, 2022
@shubhamdp shubhamdp deleted the esp32_build_ota_image branch February 8, 2022 07:31
@shubhamdp shubhamdp mentioned this pull request Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@dhrishi dhrishi Awaiting requested review from dhrishi

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
config fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamdp @woody-apple @dhrishi