Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32: Add MAX_FABRICS config option #14834

Merged

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Feb 7, 2022

Problem

The CHIP_CONFIG_MAX_FABRICS config option should be added for ESP32 platform.

Change overview

Add MAX_FABRICS config option in chip component

Testing

compiling success for all-clusters-app

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

PR #14834: Size comparison from 0f7be8b to 0a7940d

Increases (1 build for esp32)
platform target config section 0f7be8b 0a7940d change % change
esp32 all-clusters-app m5stack (read only) 984975 984995 20 0.0
.flash.text 979591 979611 20 0.0
Decreases (2 builds for esp32)
platform target config section 0f7be8b 0a7940d change % change
esp32 all-clusters-app c3devkit (read only) 936986 936966 -20 -0.0
(read/write) 1401242 1398074 -3168 -0.2
.dram0.bss 70064 66896 -3168 -4.5
.flash.text 936986 936966 -20 -0.0
m5stack (read/write) 465592 462424 -3168 -0.7
.dram0.bss 74816 71648 -3168 -4.2
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0f7be8b 0a7940d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587670 587670 0 0.0
.app_xip_area 494404 494404 0 0.0
.bss 75988 75988 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545586 545586 0 0.0
.app_xip_area 453880 453880 0 0.0
.bss 74460 74460 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570010 570010 0 0.0
.app_xip_area 468984 468984 0 0.0
.bss 83452 83452 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857496 857496 0 0.0
(read/write) 125744 125744 0 0.0
.bss 123816 123816 0 0.0
.data 1924 1924 0 0.0
.text 857488 857488 0 0.0
BRD4161A+rpc (read only) 844848 844848 0 0.0
(read/write) 142400 142400 0 0.0
.bss 140376 140376 0 0.0
.data 2024 2024 0 0.0
.text 844840 844840 0 0.0
window-app BRD4161A (read only) 829732 829732 0 0.0
(read/write) 124384 124384 0 0.0
.bss 122504 122504 0 0.0
.data 1880 1880 0 0.0
.text 829724 829724 0 0.0
esp32 all-clusters-app c3devkit (read only) 936986 936966 -20 -0.0
(read/write) 1401242 1398074 -3168 -0.2
.dram0.bss 70064 66896 -3168 -4.5
.dram0.data 14276 14276 0 0.0
.flash.rodata 198000 198000 0 0.0
.flash.text 936986 936966 -20 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 984975 984995 20 0.0
(read/write) 465592 462424 -3168 -0.7
.dram0.bss 74816 71648 -3168 -4.2
.dram0.data 34040 34040 0 0.0
.flash.rodata 224608 224608 0 0.0
.flash.text 979591 979611 20 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672212 672212 0 0.0
.bss 75688 75688 0 0.0
.data 1884 1884 0 0.0
.text 588840 588840 0 0.0
lock k32w061+release (read/write) 673744 673744 0 0.0
.bss 76016 76016 0 0.0
.data 1924 1924 0 0.0
.text 590004 590004 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7238916 7238916 0 0.0
(read/write) 287921 287921 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186528 0 0.0
.dynamic 560 560 0 0.0
.got 45784 45784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392812 392812 0 0.0
.text 6241268 6241268 0 0.0
thermostat-no-ble arm64 (read only) 2127300 2127300 0 0.0
(read/write) 140561 140561 0 0.0
.bss 57601 57601 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131412 0 0.0
.text 1777936 1777936 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389192 2389192 0 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351792 1351792 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348448 2348448 0 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311048 1311048 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312368 2312368 0 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1274968 1274968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302708 2302708 0 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265280 1265280 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998095 998095 0 0.0
bss 120404 120404 0 0.0
rodata 117308 117308 0 0.0
text 681464 681464 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 969451 969451 0 0.0
bss 116260 116260 0 0.0
rodata 108696 108696 0 0.0
text 666020 666020 0 0.0
nrf52840dongle_nrf52840 (read/write) 1014783 1014783 0 0.0
bss 121768 121768 0 0.0
rodata 116144 116144 0 0.0
text 686956 686956 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904786 904786 0 0.0
bss 116964 116964 0 0.0
rodata 110564 110564 0 0.0
text 596472 596472 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930235 930235 0 0.0
bss 118740 118740 0 0.0
rodata 105656 105656 0 0.0
text 627324 627324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837762 837762 0 0.0
bss 115336 115336 0 0.0
rodata 98828 98828 0 0.0
text 543108 543108 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932867 932867 0 0.0
bss 118492 118492 0 0.0
rodata 106128 106128 0 0.0
text 629660 629660 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927807 927807 0 0.0
bss 118496 118496 0 0.0
rodata 105132 105132 0 0.0
text 625600 625600 0 0.0
shell nrf52840dk_nrf52840 (read/write) 802811 802811 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535792 535792 0 0.0
p6 all-clusters-app default (read/write) 2450304 2450304 0 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408568 1408568 0 0.0
light-app default (read/write) 2353736 2353736 0 0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312000 1312000 0 0.0
lock-app default (read/write) 2318944 2318944 0 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277208 1277208 0 0.0
qpg lighting-app qpg6105+debug (read only) 580468 580468 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87976 87976 0 0.0
.data 1088 1088 0 0.0
.text 575148 575148 0 0.0
lock-app qpg6105+debug (read only) 526548 526548 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87424 87424 0 0.0
.data 1024 1024 0 0.0
.text 521228 521228 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859102 859102 0 0.0
bss 88332 88332 0 0.0
noinit 37160 37160 0 0.0
text 602176 602176 0 0.0

config/esp32/components/chip/Kconfig Outdated Show resolved Hide resolved
config/esp32/components/chip/Kconfig Outdated Show resolved Hide resolved
@wqx6 wqx6 force-pushed the add_max_device_admins_config_esp32 branch from 0a7940d to 463afb2 Compare February 8, 2022 04:05
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

PR #14834: Size comparison from 1c1eca4 to 463afb2

Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1c1eca4 463afb2 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594502 594502 0 0.0
.app_xip_area 500356 500356 0 0.0
.bss 76868 76868 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552406 552406 0 0.0
.app_xip_area 459820 459820 0 0.0
.bss 75340 75340 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576446 576446 0 0.0
.app_xip_area 474540 474540 0 0.0
.bss 84332 84332 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 865884 865884 0 0.0
(read/write) 126620 126620 0 0.0
.bss 124696 124696 0 0.0
.data 1924 1924 0 0.0
.text 865876 865876 0 0.0
BRD4161A+rpc (read only) 853340 853340 0 0.0
(read/write) 143280 143280 0 0.0
.bss 141256 141256 0 0.0
.data 2024 2024 0 0.0
.text 853332 853332 0 0.0
window-app BRD4161A (read only) 838104 838104 0 0.0
(read/write) 125264 125264 0 0.0
.bss 123384 123384 0 0.0
.data 1880 1880 0 0.0
.text 838096 838096 0 0.0
esp32 all-clusters-app c3devkit (read only) 937452 937452 0 0.0
(read/write) 1400986 1400986 0 0.0
.dram0.bss 69448 69448 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198352 198352 0 0.0
.flash.text 937452 937452 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 985291 985291 0 0.0
(read/write) 465320 465320 0 0.0
.dram0.bss 74200 74200 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224952 224952 0 0.0
.flash.text 979907 979907 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 678616 678616 0 0.0
.bss 76568 76568 0 0.0
.data 1884 1884 0 0.0
.text 594364 594364 0 0.0
lock k32w061+release (read/write) 680500 680500 0 0.0
.bss 76896 76896 0 0.0
.data 1924 1924 0 0.0
.text 595880 595880 0 0.0
linux all-clusters-app debug (read only) 2327369 2327369 0 0.0
(read/write) 140064 140064 0 0.0
.bss 54688 54688 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205029 205029 0 0.0
.text 1960114 1960114 0 0.0
bridge-app debug+rpc (read only) 1704053 1704053 0 0.0
(read/write) 84296 84296 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140172 140172 0 0.0
.text 1447429 1447429 0 0.0
chip-tool debug (read only) 7383957 7383957 0 0.0
(read/write) 185392 185392 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 145888 145888 0 0.0
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 413077 413077 0 0.0
.text 6599045 6599045 0 0.0
chip-tool-ipv6only arm64 (read only) 7315140 7315140 0 0.0
(read/write) 289681 289681 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 187544 187544 0 0.0
.dynamic 560 560 0 0.0
.got 46528 46528 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 396380 396380 0 0.0
.text 6309604 6309604 0 0.0
door-lock-app debug (read only) 1908441 1908441 0 0.0
(read/write) 110552 110552 0 0.0
.bss 42096 42096 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62096 62096 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172786 172786 0 0.0
.text 1587234 1587234 0 0.0
lighting-app debug+rpc (read only) 2003289 2003289 0 0.0
(read/write) 115600 115600 0 0.0
.bss 43104 43104 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65640 65640 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 162865 162865 0 0.0
.text 1685874 1685874 0 0.0
ota-provider-app debug (read only) 1711793 1711793 0 0.0
(read/write) 81336 81336 0 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33528 33528 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151206 151206 0 0.0
.text 1442002 1442002 0 0.0
ota-requestor-app debug (read only) 1701209 1701209 0 0.0
(read/write) 83288 83288 0 0.0
.bss 42272 42272 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34584 34584 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 144823 144823 0 0.0
.text 1439586 1439586 0 0.0
shell debug (read only) 2300777 2300777 0 0.0
(read/write) 141616 141616 0 0.0
.bss 62080 62080 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73040 73040 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205778 205778 0 0.0
.text 1938578 1938578 0 0.0
thermostat-no-ble arm64 (read only) 2129548 2129548 0 0.0
(read/write) 140641 140641 0 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131932 131932 0 0.0
.text 1779648 1779648 0 0.0
tv-app debug (read only) 2525577 2525577 0 0.0
(read/write) 139800 139800 0 0.0
.bss 57280 57280 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73336 73336 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 195532 195532 0 0.0
.text 2156434 2156434 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389696 2389696 0 0.0
.bss 188356 188356 0 0.0
.data 5296 5296 0 0.0
.text 1352296 1352296 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348928 2348928 0 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311528 1311528 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312848 2312848 0 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1275448 1275448 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302820 2302820 0 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265392 1265392 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004811 1004811 0 0.0
bss 121280 121280 0 0.0
rodata 118072 118072 0 0.0
text 686524 686524 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 976303 976303 0 0.0
bss 117136 117136 0 0.0
rodata 109532 109532 0 0.0
text 671168 671168 0 0.0
nrf52840dongle_nrf52840 (read/write) 1021631 1021631 0 0.0
bss 122644 122644 0 0.0
rodata 116960 116960 0 0.0
text 692096 692096 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911490 911490 0 0.0
bss 117840 117840 0 0.0
rodata 111332 111332 0 0.0
text 601552 601552 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 937067 937067 0 0.0
bss 119616 119616 0 0.0
rodata 106472 106472 0 0.0
text 632444 632444 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844578 844578 0 0.0
bss 116212 116212 0 0.0
rodata 99644 99644 0 0.0
text 548244 548244 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541747 541747 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376920 376920 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939315 939315 0 0.0
bss 119368 119368 0 0.0
rodata 106656 106656 0 0.0
text 634688 634688 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934655 934655 0 0.0
bss 119372 119372 0 0.0
rodata 105948 105948 0 0.0
text 630724 630724 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803327 803327 0 0.0
bss 111232 111232 0 0.0
rodata 78532 78532 0 0.0
text 535988 535988 0 0.0
p6 all-clusters-app default (read/write) 2463856 2463856 0 0.0
.bss 117976 117976 0 0.0
.data 2584 2584 0 0.0
.text 1422120 1422120 0 0.0
light-app default (read/write) 2367304 2367304 0 0.0
.bss 107600 107600 0 0.0
.data 2432 2432 0 0.0
.text 1325568 1325568 0 0.0
lock-app default (read/write) 2332488 2332488 0 0.0
.bss 107304 107304 0 0.0
.data 2392 2392 0 0.0
.text 1290752 1290752 0 0.0
qpg lighting-app qpg6105+debug (read only) 585872 585872 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88856 88856 0 0.0
.data 1084 1084 0 0.0
.text 580552 580552 0 0.0
lock-app qpg6105+debug (read only) 531956 531956 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88304 88304 0 0.0
.data 1024 1024 0 0.0
.text 526636 526636 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 865790 865790 0 0.0
bss 88592 88592 0 0.0
noinit 37160 37160 0 0.0
text 607706 607706 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the add_max_device_admins_config_esp32 branch from 463afb2 to afef6a5 Compare February 8, 2022 15:08
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

PR #14834: Size comparison from 2f785f4 to afef6a5

Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2f785f4 afef6a5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594490 594490 0 0.0
.app_xip_area 500344 500344 0 0.0
.bss 76868 76868 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552390 552390 0 0.0
.app_xip_area 459804 459804 0 0.0
.bss 75340 75340 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576398 576398 0 0.0
.app_xip_area 474492 474492 0 0.0
.bss 84332 84332 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 865876 865876 0 0.0
(read/write) 126620 126620 0 0.0
.bss 124696 124696 0 0.0
.data 1924 1924 0 0.0
.text 865868 865868 0 0.0
BRD4161A+rpc (read only) 853332 853332 0 0.0
(read/write) 143280 143280 0 0.0
.bss 141256 141256 0 0.0
.data 2024 2024 0 0.0
.text 853324 853324 0 0.0
window-app BRD4161A (read only) 838080 838080 0 0.0
(read/write) 125264 125264 0 0.0
.bss 123384 123384 0 0.0
.data 1880 1880 0 0.0
.text 838072 838072 0 0.0
esp32 all-clusters-app c3devkit (read only) 937984 937984 0 0.0
(read/write) 1401162 1401162 0 0.0
.dram0.bss 69448 69448 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198528 198528 0 0.0
.flash.text 937984 937984 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 986303 986303 0 0.0
(read/write) 466200 466200 0 0.0
.dram0.bss 74592 74592 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 225440 225440 0 0.0
.flash.text 980919 980919 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 678572 678572 0 0.0
.bss 76568 76568 0 0.0
.data 1884 1884 0 0.0
.text 594320 594320 0 0.0
lock k32w061+release (read/write) 680488 680488 0 0.0
.bss 76896 76896 0 0.0
.data 1924 1924 0 0.0
.text 595868 595868 0 0.0
linux all-clusters-app debug (read only) 2327673 2327673 0 0.0
(read/write) 140096 140096 0 0.0
.bss 54688 54688 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 78536 78536 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205061 205061 0 0.0
.text 1960290 1960290 0 0.0
bridge-app debug+rpc (read only) 1704373 1704373 0 0.0
(read/write) 84328 84328 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140204 140204 0 0.0
.text 1447621 1447621 0 0.0
chip-tool debug (read only) 7481925 7481925 0 0.0
(read/write) 198072 198072 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 158536 158536 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 416437 416437 0 0.0
.text 6663061 6663061 0 0.0
chip-tool-ipv6only arm64 (read only) 7402804 7402804 0 0.0
(read/write) 302401 302401 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 200208 200208 0 0.0
.dynamic 560 560 0 0.0
.got 46584 46584 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 399148 399148 0 0.0
.text 6363828 6363828 0 0.0
door-lock-app debug (read only) 1908777 1908777 0 0.0
(read/write) 110584 110584 0 0.0
.bss 42096 42096 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62128 62128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172818 172818 0 0.0
.text 1587442 1587442 0 0.0
lighting-app debug+rpc (read only) 2003609 2003609 0 0.0
(read/write) 115632 115632 0 0.0
.bss 43104 43104 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65672 65672 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 162897 162897 0 0.0
.text 1686066 1686066 0 0.0
ota-provider-app debug (read only) 1712241 1712241 0 0.0
(read/write) 81368 81368 0 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33560 33560 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151238 151238 0 0.0
.text 1442322 1442322 0 0.0
ota-requestor-app debug (read only) 1701673 1701673 0 0.0
(read/write) 83320 83320 0 0.0
.bss 42272 42272 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34616 34616 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 144887 144887 0 0.0
.text 1439890 1439890 0 0.0
shell debug (read only) 2301113 2301113 0 0.0
(read/write) 141648 141648 0 0.0
.bss 62080 62080 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73072 73072 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205810 205810 0 0.0
.text 1938786 1938786 0 0.0
thermostat-no-ble arm64 (read only) 2129932 2129932 0 0.0
(read/write) 140673 140673 0 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131964 131964 0 0.0
.text 1779904 1779904 0 0.0
tv-app debug (read only) 2525897 2525897 0 0.0
(read/write) 139832 139832 0 0.0
.bss 57280 57280 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73368 73368 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 195564 195564 0 0.0
.text 2156626 2156626 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389752 2389752 0 0.0
.bss 188356 188356 0 0.0
.data 5296 5296 0 0.0
.text 1352352 1352352 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348920 2348920 0 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311520 1311520 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312840 2312840 0 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1275440 1275440 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302812 2302812 0 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265384 1265384 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004835 1004835 0 0.0
bss 121280 121280 0 0.0
rodata 118128 118128 0 0.0
text 686484 686484 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 976311 976311 0 0.0
bss 117136 117136 0 0.0
rodata 109588 109588 0 0.0
text 671124 671124 0 0.0
nrf52840dongle_nrf52840 (read/write) 1021639 1021639 0 0.0
bss 122644 122644 0 0.0
rodata 117016 117016 0 0.0
text 692052 692052 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911494 911494 0 0.0
bss 117840 117840 0 0.0
rodata 111384 111384 0 0.0
text 601508 601508 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 937091 937091 0 0.0
bss 119616 119616 0 0.0
rodata 106528 106528 0 0.0
text 632404 632404 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844586 844586 0 0.0
bss 116212 116212 0 0.0
rodata 99700 99700 0 0.0
text 548204 548204 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541747 541747 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376920 376920 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939323 939323 0 0.0
bss 119368 119368 0 0.0
rodata 106712 106712 0 0.0
text 634648 634648 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934663 934663 0 0.0
bss 119372 119372 0 0.0
rodata 106004 106004 0 0.0
text 630680 630680 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803151 803151 0 0.0
bss 111232 111232 0 0.0
rodata 78532 78532 0 0.0
text 535824 535824 0 0.0
p6 all-clusters-app default (read/write) 2463848 2463848 0 0.0
.bss 117976 117976 0 0.0
.data 2584 2584 0 0.0
.text 1422112 1422112 0 0.0
light-app default (read/write) 2367296 2367296 0 0.0
.bss 107600 107600 0 0.0
.data 2432 2432 0 0.0
.text 1325560 1325560 0 0.0
lock-app default (read/write) 2332480 2332480 0 0.0
.bss 107304 107304 0 0.0
.data 2392 2392 0 0.0
.text 1290744 1290744 0 0.0
qpg lighting-app qpg6105+debug (read only) 585808 585808 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88856 88856 0 0.0
.data 1084 1084 0 0.0
.text 580488 580488 0 0.0
lock-app qpg6105+debug (read only) 531884 531884 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88304 88304 0 0.0
.data 1024 1024 0 0.0
.text 526564 526564 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 865822 865822 0 0.0
bss 88592 88592 0 0.0
noinit 37160 37160 0 0.0
text 607684 607684 0 0.0

@wqx6 wqx6 changed the title ESP32: Add MAX_DEVICE_ADMINS config option ESP32: Add MAX_FABRICS config option Feb 9, 2022
@wqx6
Copy link
Contributor Author

wqx6 commented Feb 9, 2022

/rebase

@woody-apple woody-apple force-pushed the add_max_device_admins_config_esp32 branch from afef6a5 to 1865a19 Compare February 9, 2022 02:36
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

PR #14834: Size comparison from 5ace0cd to 1865a19

Increases (1 build for esp32)
platform target config section 5ace0cd 1865a19 change % change
esp32 all-clusters-app m5stack (read only) 987511 987527 16 0.0
.flash.text 982127 982143 16 0.0
Decreases (2 builds for esp32)
platform target config section 5ace0cd 1865a19 change % change
esp32 all-clusters-app c3devkit (read only) 939372 939352 -20 -0.0
(read/write) 1401882 1398714 -3168 -0.2
.dram0.bss 70024 66856 -3168 -4.5
.flash.text 939372 939352 -20 -0.0
m5stack (read/write) 466892 463724 -3168 -0.7
.dram0.bss 75160 71992 -3168 -4.2
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5ace0cd 1865a19 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595382 595382 0 0.0
.app_xip_area 500916 500916 0 0.0
.bss 77188 77188 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556334 556334 0 0.0
.app_xip_area 463404 463404 0 0.0
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577314 577314 0 0.0
.app_xip_area 475088 475088 0 0.0
.bss 84652 84652 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866340 866340 0 0.0
(read/write) 126684 126684 0 0.0
.bss 124760 124760 0 0.0
.data 1924 1924 0 0.0
.text 866332 866332 0 0.0
BRD4161A+rpc (read only) 853788 853788 0 0.0
(read/write) 143344 143344 0 0.0
.bss 141320 141320 0 0.0
.data 2024 2024 0 0.0
.text 853780 853780 0 0.0
window-app BRD4161A (read only) 838544 838544 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123448 123448 0 0.0
.data 1880 1880 0 0.0
.text 838536 838536 0 0.0
esp32 all-clusters-app c3devkit (read only) 939372 939352 -20 -0.0
(read/write) 1401882 1398714 -3168 -0.2
.dram0.bss 70024 66856 -3168 -4.5
.dram0.data 14260 14260 0 0.0
.flash.rodata 198688 198688 0 0.0
.flash.text 939372 939352 -20 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987511 987527 16 0.0
(read/write) 466892 463724 -3168 -0.7
.dram0.bss 75160 71992 -3168 -4.2
.dram0.data 34024 34024 0 0.0
.flash.rodata 225580 225580 0 0.0
.flash.text 982127 982143 16 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679212 679212 0 0.0
.bss 76632 76632 0 0.0
.data 1884 1884 0 0.0
.text 594896 594896 0 0.0
lock k32w061+release (read/write) 684012 684012 0 0.0
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599300 599300 0 0.0
linux all-clusters-app debug (read only) 2334969 2334969 0 0.0
(read/write) 140640 140640 0 0.0
.bss 55200 55200 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205285 205285 0 0.0
.text 1967362 1967362 0 0.0
bridge-app debug+rpc (read only) 1705909 1705909 0 0.0
(read/write) 84328 84328 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140332 0 0.0
.text 1449029 1449029 0 0.0
chip-tool debug (read only) 7472205 7472205 0 0.0
(read/write) 197048 197048 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 157512 157512 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 414773 414773 0 0.0
.text 6657285 6657285 0 0.0
chip-tool-ipv6only arm64 (read only) 7394508 7394508 0 0.0
(read/write) 301233 301233 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 199216 199216 0 0.0
.dynamic 560 560 0 0.0
.got 46400 46400 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 397316 397316 0 0.0
.text 6360180 6360180 0 0.0
door-lock-app debug (read only) 1910633 1910633 0 0.0
(read/write) 110680 110680 0 0.0
.bss 42160 42160 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62160 62160 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171858 171858 0 0.0
.text 1590258 1590258 0 0.0
lighting-app debug+rpc (read only) 2005193 2005193 0 0.0
(read/write) 115632 115632 0 0.0
.bss 43104 43104 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65672 65672 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 163057 163057 0 0.0
.text 1687490 1687490 0 0.0
ota-provider-app debug (read only) 1714521 1714521 0 0.0
(read/write) 81368 81368 0 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33560 33560 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 151910 0 0.0
.text 1443906 1443906 0 0.0
ota-requestor-app debug (read only) 1703177 1703177 0 0.0
(read/write) 83320 83320 0 0.0
.bss 42272 42272 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34616 34616 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145047 145047 0 0.0
.text 1441234 1441234 0 0.0
shell debug (read only) 2308409 2308409 0 0.0
(read/write) 142224 142224 0 0.0
.bss 62592 62592 0 0.0
.data 768 768 0 0.0
.data.rel.ro 73168 73168 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206002 206002 0 0.0
.text 1945890 1945890 0 0.0
thermostat-no-ble arm64 (read only) 2134876 2134876 0 0.0
(read/write) 141009 141009 0 0.0
.bss 57953 57953 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74952 74952 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 132316 132316 0 0.0
.text 1784400 1784400 0 0.0
tv-app debug (read only) 2525753 2525753 0 0.0
(read/write) 140056 140056 0 0.0
.bss 57568 57568 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73288 73288 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 197196 197196 0 0.0
.text 2155186 2155186 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2390920 2390920 0 0.0
.bss 188932 188932 0 0.0
.data 5288 5288 0 0.0
.text 1353520 1353520 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349448 0 0.0
.bss 181000 181000 0 0.0
.data 5600 5600 0 0.0
.text 1312048 1312048 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2317408 0 0.0
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1280008 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303404 2303404 0 0.0
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265976 1265976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005707 1005707 0 0.0
bss 121352 121352 0 0.0
rodata 118312 118312 0 0.0
text 687048 687048 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 974551 974551 0 0.0
bss 118540 118540 0 0.0
rodata 109700 109700 0 0.0
text 666664 666664 0 0.0
nrf52840dongle_nrf52840 (read/write) 1022399 1022399 0 0.0
bss 122716 122716 0 0.0
rodata 117200 117200 0 0.0
text 692620 692620 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912322 912322 0 0.0
bss 117912 117912 0 0.0
rodata 111572 111572 0 0.0
text 602076 602076 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 940775 940775 0 0.0
bss 119720 119720 0 0.0
rodata 107540 107540 0 0.0
text 634956 634956 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848250 848250 0 0.0
bss 116312 116312 0 0.0
rodata 100708 100708 0 0.0
text 550752 550752 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940211 940211 0 0.0
bss 119440 119440 0 0.0
rodata 106896 106896 0 0.0
text 635212 635212 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935535 935535 0 0.0
bss 119444 119444 0 0.0
rodata 106188 106188 0 0.0
text 631244 631244 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803911 803911 0 0.0
bss 111304 111304 0 0.0
rodata 78716 78716 0 0.0
text 536272 536272 0 0.0
p6 all-clusters-app default (read/write) 2465432 2465432 0 0.0
.bss 118544 118544 0 0.0
.data 2568 2568 0 0.0
.text 1423696 1423696 0 0.0
light-app default (read/write) 2367776 2367776 0 0.0
.bss 107664 107664 0 0.0
.data 2432 2432 0 0.0
.text 1326040 1326040 0 0.0
lock-app default (read/write) 2336584 2336584 0 0.0
.bss 107400 107400 0 0.0
.data 2400 2400 0 0.0
.text 1294848 1294848 0 0.0
qpg lighting-app qpg6105+debug (read only) 586368 586368 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1084 1084 0 0.0
.text 581048 581048 0 0.0
lock-app qpg6105+debug (read only) 535332 535332 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1028 0 0.0
.text 530012 530012 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 870166 870166 0 0.0
bss 88680 88680 0 0.0
noinit 37160 37160 0 0.0
text 611502 611502 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 9eaedf3 into project-chip:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants