-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Add MAX_FABRICS config option #14834
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
wqx6:add_max_device_admins_config_esp32
Feb 9, 2022
Merged
ESP32: Add MAX_FABRICS config option #14834
bzbarsky-apple
merged 1 commit into
project-chip:master
from
wqx6:add_max_device_admins_config_esp32
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda and
lzgrablic02
February 7, 2022 11:44
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
February 7, 2022 11:44
PR #14834: Size comparison from 0f7be8b to 0a7940d Increases (1 build for esp32)
Decreases (2 builds for esp32)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
previously requested changes
Feb 7, 2022
woody-apple
approved these changes
Feb 8, 2022
wqx6
force-pushed
the
add_max_device_admins_config_esp32
branch
from
February 8, 2022 04:05
0a7940d
to
463afb2
Compare
woody-apple
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking platform changes
PR #14834: Size comparison from 1c1eca4 to 463afb2 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
woody-apple
force-pushed
the
add_max_device_admins_config_esp32
branch
from
February 8, 2022 15:08
463afb2
to
afef6a5
Compare
PR #14834: Size comparison from 2f785f4 to afef6a5 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
dhrishi
approved these changes
Feb 8, 2022
wqx6
changed the title
ESP32: Add MAX_DEVICE_ADMINS config option
ESP32: Add MAX_FABRICS config option
Feb 9, 2022
/rebase |
woody-apple
force-pushed
the
add_max_device_admins_config_esp32
branch
from
February 9, 2022 02:36
afef6a5
to
1865a19
Compare
PR #14834: Size comparison from 5ace0cd to 1865a19 Increases (1 build for esp32)
Decreases (2 builds for esp32)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
CHIP_CONFIG_MAX_FABRICS
config option should be added for ESP32 platform.Change overview
Add
MAX_FABRICS
config option in chip componentTesting
compiling success for all-clusters-app