Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACL validation #14756

Merged
merged 16 commits into from
Feb 9, 2022
Merged

Add ACL validation #14756

merged 16 commits into from
Feb 9, 2022

Conversation

mlepage-google
Copy link
Contributor

@mlepage-google mlepage-google commented Feb 3, 2022 •
edited
Loading

Problem

Need more ACL validation. #14460

Change overview

  • There was some before, but this is more stringent.
  • Also refactor some of the "IsValid"-like functions.
  • Remove more operational PASE support.
  • Update unit tests.

Testing

  • Unit tests
  • Ran all-clusters-app with REPL on Linux, wrote ACLs

@mlepage-google
Add ACL validation
73c444d 
- There was some before, but this is more stringent.
- Also refactor some of the "IsValid"-like functions.
- Update unit tests.
- Remove more operational PASE support.

Part of project-chip#14460
@boring-cyborg boring-cyborg bot added the lib label Feb 3, 2022
@mlepage-google mlepage-google marked this pull request as draft February 3, 2022 19:18
@mlepage-google
Copy link
Contributor Author

I was hoping to get this done today but still a couple things to wrap up tomorrow morning before I flip the draft/review switch. Thank you for your patience.

@mlepage-google
Final touches
0336c12 
- More test cases
- Move some of the IsValid functions into access control
- Slight simplification to AccessControl::IsValid
@mlepage-google mlepage-google marked this pull request as ready for review February 8, 2022 16:55
@mlepage-google
Copy link
Contributor Author

Alright, lots of test code now, validity should be solid.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR #14756: Size comparison from b080024 to 24f4bec

Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b080024 24f4bec change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 596094 716 0.1
.app_xip_area 500912 501628 716 0.1
lock cyw930739m2evb_01 (read/write) 556330 557046 716 0.1
.app_xip_area 463400 464116 716 0.2
ota-requestor cyw930739m2evb_01 (read/write) 577294 578010 716 0.1
.app_xip_area 475068 475784 716 0.2
efr32 lighting-app BRD4161A (read only) 866356 867148 792 0.1
.text 866348 867140 792 0.1
BRD4161A+rpc (read only) 853804 854596 792 0.1
.text 853796 854588 792 0.1
window-app BRD4161A (read only) 838560 839352 792 0.1
.text 838552 839344 792 0.1
esp32 all-clusters-app c3devkit (read only) 938950 939516 566 0.1
(read/write) 1402434 1402634 200 0.0
.flash.rodata 199208 199408 200 0.1
.flash.text 938950 939516 566 0.1
m5stack (read only) 987139 987643 504 0.1
(read/write) 467444 467620 176 0.0
.flash.rodata 226100 226276 176 0.1
.flash.text 981755 982259 504 0.1
k32w light k32w061+release (read/write) 679180 679892 712 0.1
.text 594864 595576 712 0.1
lock k32w061+release (read/write) 683996 684708 712 0.1
.text 599284 599996 712 0.1
linux thermostat-no-ble arm64 (read only) 2134876 2137260 2384 0.1
.rodata 132316 132492 176 0.1
.text 1784400 1786608 2208 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2391184 2393376 2192 0.1
.text 1353784 1355976 2192 0.2
lighting-app CY8CPROTO_062_4343W+release (read/write) 2349448 2351632 2184 0.1
.text 1312048 1314232 2184 0.2
lock-app CY8CPROTO_062_4343W+release (read/write) 2317408 2319592 2184 0.1
.text 1280008 1282192 2184 0.2
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2305532 2192 0.1
.text 1265912 1268104 2192 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1006131 708 0.1
rodata 118268 118448 180 0.2
text 686928 687460 532 0.1
nrf52840dk_nrf52840+rpc (read/write) 974379 975103 724 0.1
rodata 109656 109836 180 0.2
text 666540 667072 532 0.1
nrf52840dongle_nrf52840 (read/write) 1022227 1022931 704 0.1
rodata 117156 117332 176 0.2
text 692496 693028 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 912146 912858 712 0.1
rodata 111524 111708 184 0.2
text 601952 602484 532 0.1
lock-app nrf52840dk_nrf52840 (read/write) 940615 941323 708 0.1
rodata 107492 107672 180 0.2
text 634832 635364 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 848078 848782 704 0.1
rodata 100664 100840 176 0.2
text 550632 551164 532 0.1
pump-app nrf52840dk_nrf52840 (read/write) 940035 940743 708 0.1
rodata 106848 107028 180 0.2
text 635088 635620 532 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 936083 708 0.1
rodata 106140 106320 180 0.2
text 631124 631656 532 0.1
p6 all-clusters-app default (read/write) 2465624 2466416 792 0.0
.text 1423888 1424680 792 0.1
light-app default (read/write) 2367760 2368552 792 0.0
.text 1326024 1326816 792 0.1
lock-app default (read/write) 2336584 2337376 792 0.0
.text 1294848 1295640 792 0.1
qpg lighting-app qpg6105+debug (read only) 586368 587076 708 0.1
.text 581048 581756 708 0.1
lock-app qpg6105+debug (read only) 535316 536032 716 0.1
.text 529996 530712 716 0.1
telink lighting-app tlsr9518adk80d (read/write) 869974 870734 760 0.1
text 611380 611940 560 0.1
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b080024 24f4bec change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 596094 716 0.1
.app_xip_area 500912 501628 716 0.1
.bss 77188 77188 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556330 557046 716 0.1
.app_xip_area 463400 464116 716 0.2
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577294 578010 716 0.1
.app_xip_area 475068 475784 716 0.2
.bss 84652 84652 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866356 867148 792 0.1
(read/write) 126684 126684 0 0.0
.bss 124760 124760 0 0.0
.data 1924 1924 0 0.0
.text 866348 867140 792 0.1
BRD4161A+rpc (read only) 853804 854596 792 0.1
(read/write) 143344 143344 0 0.0
.bss 141320 141320 0 0.0
.data 2024 2024 0 0.0
.text 853796 854588 792 0.1
window-app BRD4161A (read only) 838560 839352 792 0.1
(read/write) 125328 125328 0 0.0
.bss 123448 123448 0 0.0
.data 1880 1880 0 0.0
.text 838552 839344 792 0.1
esp32 all-clusters-app c3devkit (read only) 938950 939516 566 0.1
(read/write) 1402434 1402634 200 0.0
.dram0.bss 70040 70040 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 199208 199408 200 0.1
.flash.text 938950 939516 566 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987139 987643 504 0.1
(read/write) 467444 467620 176 0.0
.dram0.bss 75176 75176 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 226100 226276 176 0.1
.flash.text 981755 982259 504 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679180 679892 712 0.1
.bss 76632 76632 0 0.0
.data 1884 1884 0 0.0
.text 594864 595576 712 0.1
lock k32w061+release (read/write) 683996 684708 712 0.1
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599284 599996 712 0.1
linux chip-tool-ipv6only arm64 (read only) 7409244 7409244 0 0.0
(read/write) 302305 302305 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 200144 200144 0 0.0
.dynamic 560 560 0 0.0
.got 46552 46552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 399300 399300 0 0.0
.text 6370452 6370452 0 0.0
thermostat-no-ble arm64 (read only) 2134876 2137260 2384 0.1
(read/write) 141009 141009 0 0.0
.bss 57953 57953 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74952 74952 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 132316 132492 176 0.1
.text 1784400 1786608 2208 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391184 2393376 2192 0.1
.bss 188948 188948 0 0.0
.data 5304 5304 0 0.0
.text 1353784 1355976 2192 0.2
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2351632 2184 0.1
.bss 181000 181000 0 0.0
.data 5600 5600 0 0.0
.text 1312048 1314232 2184 0.2
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2319592 2184 0.1
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1282192 2184 0.2
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2305532 2192 0.1
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265912 1268104 2192 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1006131 708 0.1
bss 121344 121344 0 0.0
rodata 118268 118448 180 0.2
text 686928 687460 532 0.1
nrf52840dk_nrf52840+rpc (read/write) 974379 975103 724 0.1
bss 118532 118532 0 0.0
rodata 109656 109836 180 0.2
text 666540 667072 532 0.1
nrf52840dongle_nrf52840 (read/write) 1022227 1022931 704 0.1
bss 122708 122708 0 0.0
rodata 117156 117332 176 0.2
text 692496 693028 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 912146 912858 712 0.1
bss 117904 117904 0 0.0
rodata 111524 111708 184 0.2
text 601952 602484 532 0.1
lock-app nrf52840dk_nrf52840 (read/write) 940615 941323 708 0.1
bss 119712 119712 0 0.0
rodata 107492 107672 180 0.2
text 634832 635364 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 848078 848782 704 0.1
bss 116304 116304 0 0.0
rodata 100664 100840 176 0.2
text 550632 551164 532 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940035 940743 708 0.1
bss 119432 119432 0 0.0
rodata 106848 107028 180 0.2
text 635088 635620 532 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 936083 708 0.1
bss 119436 119436 0 0.0
rodata 106140 106320 180 0.2
text 631124 631656 532 0.1
shell nrf52840dk_nrf52840 (read/write) 803719 803719 0 0.0
bss 111296 111296 0 0.0
rodata 78668 78668 0 0.0
text 536128 536128 0 0.0
p6 all-clusters-app default (read/write) 2465624 2466416 792 0.0
.bss 118560 118560 0 0.0
.data 2584 2584 0 0.0
.text 1423888 1424680 792 0.1
light-app default (read/write) 2367760 2368552 792 0.0
.bss 107664 107664 0 0.0
.data 2432 2432 0 0.0
.text 1326024 1326816 792 0.1
lock-app default (read/write) 2336584 2337376 792 0.0
.bss 107400 107400 0 0.0
.data 2400 2400 0 0.0
.text 1294848 1295640 792 0.1
qpg lighting-app qpg6105+debug (read only) 586368 587076 708 0.1
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1084 1084 0 0.0
.text 581048 581756 708 0.1
lock-app qpg6105+debug (read only) 535316 536032 716 0.1
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1028 0 0.0
.text 529996 530712 716 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 869974 870734 760 0.1
bss 88672 88672 0 0.0
noinit 37160 37160 0 0.0
text 611380 611940 560 0.1

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR #14756: Size comparison from b080024 to fdc0a51

Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b080024 fdc0a51 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 596094 716 0.1
.app_xip_area 500912 501628 716 0.1
lock cyw930739m2evb_01 (read/write) 556330 557046 716 0.1
.app_xip_area 463400 464116 716 0.2
ota-requestor cyw930739m2evb_01 (read/write) 577294 578010 716 0.1
.app_xip_area 475068 475784 716 0.2
efr32 lighting-app BRD4161A (read only) 866356 867148 792 0.1
.text 866348 867140 792 0.1
BRD4161A+rpc (read only) 853804 854596 792 0.1
.text 853796 854588 792 0.1
window-app BRD4161A (read only) 838560 839352 792 0.1
.text 838552 839344 792 0.1
esp32 all-clusters-app c3devkit (read only) 938950 939516 566 0.1
(read/write) 1402434 1402634 200 0.0
.flash.rodata 199208 199408 200 0.1
.flash.text 938950 939516 566 0.1
m5stack (read only) 987139 987643 504 0.1
(read/write) 467444 467620 176 0.0
.flash.rodata 226100 226276 176 0.1
.flash.text 981755 982259 504 0.1
k32w light k32w061+release (read/write) 679180 679892 712 0.1
.text 594864 595576 712 0.1
lock k32w061+release (read/write) 683996 684708 712 0.1
.text 599284 599996 712 0.1
linux chip-tool-ipv6only arm64 .data.rel.ro 200144 200200 56 0.0
.rodata 399300 399412 112 0.0
thermostat-no-ble arm64 (read only) 2134876 2137260 2384 0.1
.rodata 132316 132492 176 0.1
.text 1784400 1786608 2208 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2391184 2393376 2192 0.1
.text 1353784 1355976 2192 0.2
lighting-app CY8CPROTO_062_4343W+release (read/write) 2349448 2351632 2184 0.1
.text 1312048 1314232 2184 0.2
lock-app CY8CPROTO_062_4343W+release (read/write) 2317408 2319592 2184 0.1
.text 1280008 1282192 2184 0.2
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2305532 2192 0.1
.text 1265912 1268104 2192 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1006131 708 0.1
rodata 118268 118448 180 0.2
text 686928 687460 532 0.1
nrf52840dk_nrf52840+rpc (read/write) 974379 975103 724 0.1
rodata 109656 109836 180 0.2
text 666540 667072 532 0.1
nrf52840dongle_nrf52840 (read/write) 1022227 1022931 704 0.1
rodata 117156 117332 176 0.2
text 692496 693028 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 912146 912858 712 0.1
rodata 111524 111708 184 0.2
text 601952 602484 532 0.1
lock-app nrf52840dk_nrf52840 (read/write) 940615 941323 708 0.1
rodata 107492 107672 180 0.2
text 634832 635364 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 848078 848782 704 0.1
rodata 100664 100840 176 0.2
text 550632 551164 532 0.1
pump-app nrf52840dk_nrf52840 (read/write) 940035 940743 708 0.1
rodata 106848 107028 180 0.2
text 635088 635620 532 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 936083 708 0.1
rodata 106140 106320 180 0.2
text 631124 631656 532 0.1
p6 all-clusters-app default (read/write) 2465624 2466416 792 0.0
.text 1423888 1424680 792 0.1
light-app default (read/write) 2367760 2368552 792 0.0
.text 1326024 1326816 792 0.1
lock-app default (read/write) 2336584 2337376 792 0.0
.text 1294848 1295640 792 0.1
qpg lighting-app qpg6105+debug (read only) 586368 587076 708 0.1
.text 581048 581756 708 0.1
lock-app qpg6105+debug (read only) 535316 536032 716 0.1
.text 529996 530712 716 0.1
telink lighting-app tlsr9518adk80d (read/write) 869974 870734 760 0.1
text 611380 611940 560 0.1
Decreases (1 build for linux)
platform target config section b080024 fdc0a51 change % change
linux chip-tool-ipv6only arm64 (read only) 7409244 7408828 -416 -0.0
.got 46552 46496 -56 -0.1
.text 6370452 6369972 -480 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b080024 fdc0a51 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 596094 716 0.1
.app_xip_area 500912 501628 716 0.1
.bss 77188 77188 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556330 557046 716 0.1
.app_xip_area 463400 464116 716 0.2
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577294 578010 716 0.1
.app_xip_area 475068 475784 716 0.2
.bss 84652 84652 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866356 867148 792 0.1
(read/write) 126684 126684 0 0.0
.bss 124760 124760 0 0.0
.data 1924 1924 0 0.0
.text 866348 867140 792 0.1
BRD4161A+rpc (read only) 853804 854596 792 0.1
(read/write) 143344 143344 0 0.0
.bss 141320 141320 0 0.0
.data 2024 2024 0 0.0
.text 853796 854588 792 0.1
window-app BRD4161A (read only) 838560 839352 792 0.1
(read/write) 125328 125328 0 0.0
.bss 123448 123448 0 0.0
.data 1880 1880 0 0.0
.text 838552 839344 792 0.1
esp32 all-clusters-app c3devkit (read only) 938950 939516 566 0.1
(read/write) 1402434 1402634 200 0.0
.dram0.bss 70040 70040 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 199208 199408 200 0.1
.flash.text 938950 939516 566 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987139 987643 504 0.1
(read/write) 467444 467620 176 0.0
.dram0.bss 75176 75176 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 226100 226276 176 0.1
.flash.text 981755 982259 504 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679180 679892 712 0.1
.bss 76632 76632 0 0.0
.data 1884 1884 0 0.0
.text 594864 595576 712 0.1
lock k32w061+release (read/write) 683996 684708 712 0.1
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599284 599996 712 0.1
linux chip-tool-ipv6only arm64 (read only) 7409244 7408828 -416 -0.0
(read/write) 302305 302305 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 200144 200200 56 0.0
.dynamic 560 560 0 0.0
.got 46552 46496 -56 -0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 399300 399412 112 0.0
.text 6370452 6369972 -480 -0.0
thermostat-no-ble arm64 (read only) 2134876 2137260 2384 0.1
(read/write) 141009 141009 0 0.0
.bss 57953 57953 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74952 74952 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 132316 132492 176 0.1
.text 1784400 1786608 2208 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391184 2393376 2192 0.1
.bss 188948 188948 0 0.0
.data 5304 5304 0 0.0
.text 1353784 1355976 2192 0.2
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2351632 2184 0.1
.bss 181000 181000 0 0.0
.data 5600 5600 0 0.0
.text 1312048 1314232 2184 0.2
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2319592 2184 0.1
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1282192 2184 0.2
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2305532 2192 0.1
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265912 1268104 2192 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1006131 708 0.1
bss 121344 121344 0 0.0
rodata 118268 118448 180 0.2
text 686928 687460 532 0.1
nrf52840dk_nrf52840+rpc (read/write) 974379 975103 724 0.1
bss 118532 118532 0 0.0
rodata 109656 109836 180 0.2
text 666540 667072 532 0.1
nrf52840dongle_nrf52840 (read/write) 1022227 1022931 704 0.1
bss 122708 122708 0 0.0
rodata 117156 117332 176 0.2
text 692496 693028 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 912146 912858 712 0.1
bss 117904 117904 0 0.0
rodata 111524 111708 184 0.2
text 601952 602484 532 0.1
lock-app nrf52840dk_nrf52840 (read/write) 940615 941323 708 0.1
bss 119712 119712 0 0.0
rodata 107492 107672 180 0.2
text 634832 635364 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 848078 848782 704 0.1
bss 116304 116304 0 0.0
rodata 100664 100840 176 0.2
text 550632 551164 532 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940035 940743 708 0.1
bss 119432 119432 0 0.0
rodata 106848 107028 180 0.2
text 635088 635620 532 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 936083 708 0.1
bss 119436 119436 0 0.0
rodata 106140 106320 180 0.2
text 631124 631656 532 0.1
shell nrf52840dk_nrf52840 (read/write) 803719 803719 0 0.0
bss 111296 111296 0 0.0
rodata 78668 78668 0 0.0
text 536128 536128 0 0.0
p6 all-clusters-app default (read/write) 2465624 2466416 792 0.0
.bss 118560 118560 0 0.0
.data 2584 2584 0 0.0
.text 1423888 1424680 792 0.1
light-app default (read/write) 2367760 2368552 792 0.0
.bss 107664 107664 0 0.0
.data 2432 2432 0 0.0
.text 1326024 1326816 792 0.1
lock-app default (read/write) 2336584 2337376 792 0.0
.bss 107400 107400 0 0.0
.data 2400 2400 0 0.0
.text 1294848 1295640 792 0.1
qpg lighting-app qpg6105+debug (read only) 586368 587076 708 0.1
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1084 1084 0 0.0
.text 581048 581756 708 0.1
lock-app qpg6105+debug (read only) 535316 536032 716 0.1
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1028 0 0.0
.text 529996 530712 716 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 869974 870734 760 0.1
bss 88672 88672 0 0.0
noinit 37160 37160 0 0.0
text 611380 611940 560 0.1

@mlepage-google
Fix destruction order in test code
0b85bae 
Delegate must outlive the thing holding it.
@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR #14756: Size comparison from b080024 to 0b85bae

Increases above 0.2%:

platform target config section b080024 0b85bae change % change
linux bridge-app debug+rpc .rodata 140332 140716 384 0.3
lighting-app debug+rpc .rodata 163057 163441 384 0.2
ota-provider-app debug .rodata 151910 152294 384 0.3
ota-requestor-app debug .rodata 145047 145431 384 0.3
Increases (38 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b080024 0b85bae change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 596078 700 0.1
.app_xip_area 500912 501612 700 0.1
lock cyw930739m2evb_01 (read/write) 556330 557030 700 0.1
.app_xip_area 463400 464100 700 0.2
ota-requestor cyw930739m2evb_01 (read/write) 577294 577994 700 0.1
.app_xip_area 475068 475768 700 0.1
efr32 lighting-app BRD4161A (read only) 866356 867132 776 0.1
.text 866348 867124 776 0.1
BRD4161A+rpc (read only) 853804 854580 776 0.1
.text 853796 854572 776 0.1
window-app BRD4161A (read only) 838560 839336 776 0.1
.text 838552 839328 776 0.1
esp32 all-clusters-app c3devkit (read only) 938950 939764 814 0.1
.flash.text 938950 939764 814 0.1
m5stack (read only) 987139 987855 716 0.1
.flash.text 981755 982471 716 0.1
k32w light k32w061+release (read/write) 679180 679876 696 0.1
.text 594864 595560 696 0.1
lock k32w061+release (read/write) 683996 684708 712 0.1
.text 599284 599996 712 0.1
linux all-clusters-app debug (read only) 2334841 2336585 1744 0.1
.text 1966370 1968978 2608 0.1
bridge-app debug+rpc (read only) 1705909 1708037 2128 0.1
.rodata 140332 140716 384 0.3
.text 1449029 1450773 1744 0.1
door-lock-app debug (read only) 1910377 1912713 2336 0.1
(read/write) 110584 110680 96 0.1
.bss 42096 42160 64 0.2
.data.rel.ro 62128 62160 32 0.1
.text 1588850 1591986 3136 0.2
lighting-app debug+rpc (read only) 2005177 2007305 2128 0.1
.rodata 163057 163441 384 0.2
.text 1687474 1689218 1744 0.1
ota-provider-app debug (read only) 1714505 1716633 2128 0.1
.rodata 151910 152294 384 0.3
.text 1443890 1445634 1744 0.1
ota-requestor-app debug (read only) 1703161 1705289 2128 0.1
.rodata 145047 145431 384 0.3
.text 1441218 1442962 1744 0.1
shell debug (read only) 2308313 2310025 1712 0.1
.text 1944898 1947506 2608 0.1
thermostat-no-ble arm64 (read only) 2134876 2137228 2352 0.1
.rodata 132316 132492 176 0.1
.text 1784400 1786576 2176 0.1
tv-app debug (read only) 2521097 2523145 2048 0.1
.rodata 196908 197228 320 0.2
.text 2150818 2152546 1728 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2391184 2393152 1968 0.1
.text 1353784 1355752 1968 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2349448 2351632 2184 0.1
.text 1312048 1314232 2184 0.2
lock-app CY8CPROTO_062_4343W+release (read/write) 2317408 2319592 2184 0.1
.text 1280008 1282192 2184 0.2
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2305532 2192 0.1
.text 1265912 1268104 2192 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1006403 980 0.1
bss 121344 121352 8 0.0
rodata 118268 118496 228 0.2
text 686928 687560 632 0.1
nrf52840dk_nrf52840+rpc (read/write) 974379 975247 868 0.1
bss 118532 118540 8 0.0
rodata 109656 109884 228 0.2
text 666540 667176 636 0.1
nrf52840dongle_nrf52840 (read/write) 1022227 1023091 864 0.1
bss 122708 122716 8 0.0
rodata 117156 117380 224 0.2
text 692496 693132 636 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 912146 913014 868 0.1
bss 117904 117912 8 0.0
rodata 111524 111752 228 0.2
text 601952 602588 636 0.1
lock-app nrf52840dk_nrf52840 (read/write) 940615 941463 848 0.1
bss 119712 119720 8 0.0
rodata 107492 107716 224 0.2
text 634832 635468 636 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 848078 848942 864 0.1
bss 116304 116312 8 0.0
rodata 100664 100888 224 0.2
text 550632 551264 632 0.1
pump-app nrf52840dk_nrf52840 (read/write) 940035 940899 864 0.1
bss 119432 119440 8 0.0
rodata 106848 107072 224 0.2
text 635088 635724 636 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 936223 848 0.1
bss 119436 119444 8 0.0
rodata 106140 106364 224 0.2
text 631124 631756 632 0.1
shell nrf52840dk_nrf52840 (read/write) 803719 803911 192 0.0
bss 111296 111304 8 0.0
rodata 78668 78716 48 0.1
text 536128 536272 144 0.0
p6 all-clusters-app default (read/write) 2465624 2466296 672 0.0
.text 1423888 1424560 672 0.0
light-app default (read/write) 2367760 2368552 792 0.0
.text 1326024 1326816 792 0.1
lock-app default (read/write) 2336584 2337376 792 0.0
.text 1294848 1295640 792 0.1
qpg lighting-app qpg6105+debug (read only) 586368 587068 700 0.1
.text 581048 581748 700 0.1
lock-app qpg6105+debug (read only) 535316 536016 700 0.1
.text 529996 530696 700 0.1
telink lighting-app tlsr9518adk80d (read/write) 869974 870910 936 0.1
bss 88672 88680 8 0.0
text 611380 612052 672 0.1
Decreases (9 builds for esp32, linux, mbed, p6)
platform target config section b080024 0b85bae change % change
esp32 all-clusters-app c3devkit (read/write) 1402434 1402074 -360 -0.0
.dram0.bss 70040 70024 -16 -0.0
.dram0.data 14276 14260 -16 -0.1
.flash.rodata 199208 198880 -328 -0.2
m5stack (read/write) 467444 467068 -376 -0.1
.dram0.bss 75176 75160 -16 -0.0
.dram0.data 34040 34024 -16 -0.0
.flash.rodata 226100 225756 -344 -0.2
linux all-clusters-app debug (read/write) 140704 140640 -64 -0.0
.bss 55232 55200 -32 -0.1
.data 1200 1168 -32 -2.7
.rodata 206053 205285 -768 -0.4
chip-tool debug (read only) 7491461 7473149 -18312 -0.2
(read/write) 197976 197624 -352 -0.2
.data.rel.ro 158424 158088 -336 -0.2
.rodata 416693 414965 -1728 -0.4
.text 6672629 6656741 -15888 -0.2
chip-tool-ipv6only arm64 (read only) 7409244 7393100 -16144 -0.2
(read/write) 302305 301857 -448 -0.1
.data.rel.ro 200144 199792 -352 -0.2
.got 46552 46448 -104 -0.2
.rodata 399300 397508 -1792 -0.4
.text 6370452 6357140 -13312 -0.2
door-lock-app debug .rodata 173010 172210 -800 -0.5
shell debug (read/write) 142288 142224 -64 -0.0
.bss 62624 62592 -32 -0.1
.data 800 768 -32 -4.0
.rodata 206802 206002 -800 -0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 188948 188932 -16 -0.0
.data 5304 5288 -16 -0.3
p6 all-clusters-app default .bss 118560 118544 -16 -0.0
.data 2584 2568 -16 -0.6
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b080024 0b85bae change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 596078 700 0.1
.app_xip_area 500912 501612 700 0.1
.bss 77188 77188 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556330 557030 700 0.1
.app_xip_area 463400 464100 700 0.2
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577294 577994 700 0.1
.app_xip_area 475068 475768 700 0.1
.bss 84652 84652 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866356 867132 776 0.1
(read/write) 126684 126684 0 0.0
.bss 124760 124760 0 0.0
.data 1924 1924 0 0.0
.text 866348 867124 776 0.1
BRD4161A+rpc (read only) 853804 854580 776 0.1
(read/write) 143344 143344 0 0.0
.bss 141320 141320 0 0.0
.data 2024 2024 0 0.0
.text 853796 854572 776 0.1
window-app BRD4161A (read only) 838560 839336 776 0.1
(read/write) 125328 125328 0 0.0
.bss 123448 123448 0 0.0
.data 1880 1880 0 0.0
.text 838552 839328 776 0.1
esp32 all-clusters-app c3devkit (read only) 938950 939764 814 0.1
(read/write) 1402434 1402074 -360 -0.0
.dram0.bss 70040 70024 -16 -0.0
.dram0.data 14276 14260 -16 -0.1
.flash.rodata 199208 198880 -328 -0.2
.flash.text 938950 939764 814 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987139 987855 716 0.1
(read/write) 467444 467068 -376 -0.1
.dram0.bss 75176 75160 -16 -0.0
.dram0.data 34040 34024 -16 -0.0
.flash.rodata 226100 225756 -344 -0.2
.flash.text 981755 982471 716 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679180 679876 696 0.1
.bss 76632 76632 0 0.0
.data 1884 1884 0 0.0
.text 594864 595560 696 0.1
lock k32w061+release (read/write) 683996 684708 712 0.1
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599284 599996 712 0.1
linux all-clusters-app debug (read only) 2334841 2336585 1744 0.1
(read/write) 140704 140640 -64 -0.0
.bss 55232 55200 -32 -0.1
.data 1200 1168 -32 -2.7
.data.rel.ro 78600 78600 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206053 205285 -768 -0.4
.text 1966370 1968978 2608 0.1
bridge-app debug+rpc (read only) 1705909 1708037 2128 0.1
(read/write) 84328 84328 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140716 384 0.3
.text 1449029 1450773 1744 0.1
chip-tool debug (read only) 7491461 7473149 -18312 -0.2
(read/write) 197976 197624 -352 -0.2
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 158424 158088 -336 -0.2
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 416693 414965 -1728 -0.4
.text 6672629 6656741 -15888 -0.2
chip-tool-ipv6only arm64 (read only) 7409244 7393100 -16144 -0.2
(read/write) 302305 301857 -448 -0.1
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 200144 199792 -352 -0.2
.dynamic 560 560 0 0.0
.got 46552 46448 -104 -0.2
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 399300 397508 -1792 -0.4
.text 6370452 6357140 -13312 -0.2
door-lock-app debug (read only) 1910377 1912713 2336 0.1
(read/write) 110584 110680 96 0.1
.bss 42096 42160 64 0.2
.data 946 946 0 0.0
.data.rel.ro 62128 62160 32 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173010 172210 -800 -0.5
.text 1588850 1591986 3136 0.2
lighting-app debug+rpc (read only) 2005177 2007305 2128 0.1
(read/write) 115632 115632 0 0.0
.bss 43104 43104 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65672 65672 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 163057 163441 384 0.2
.text 1687474 1689218 1744 0.1
ota-provider-app debug (read only) 1714505 1716633 2128 0.1
(read/write) 81368 81368 0 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33560 33560 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 152294 384 0.3
.text 1443890 1445634 1744 0.1
ota-requestor-app debug (read only) 1703161 1705289 2128 0.1
(read/write) 83320 83320 0 0.0
.bss 42272 42272 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34616 34616 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145047 145431 384 0.3
.text 1441218 1442962 1744 0.1
shell debug (read only) 2308313 2310025 1712 0.1
(read/write) 142288 142224 -64 -0.0
.bss 62624 62592 -32 -0.1
.data 800 768 -32 -4.0
.data.rel.ro 73168 73168 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206802 206002 -800 -0.4
.text 1944898 1947506 2608 0.1
thermostat-no-ble arm64 (read only) 2134876 2137228 2352 0.1
(read/write) 141009 141009 0 0.0
.bss 57953 57953 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74952 74952 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 132316 132492 176 0.1
.text 1784400 1786576 2176 0.1
tv-app debug (read only) 2521097 2523145 2048 0.1
(read/write) 140056 140056 0 0.0
.bss 57568 57568 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73288 73288 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 196908 197228 320 0.2
.text 2150818 2152546 1728 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391184 2393152 1968 0.1
.bss 188948 188932 -16 -0.0
.data 5304 5288 -16 -0.3
.text 1353784 1355752 1968 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2351632 2184 0.1
.bss 181000 181000 0 0.0
.data 5600 5600 0 0.0
.text 1312048 1314232 2184 0.2
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2319592 2184 0.1
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1282192 2184 0.2
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2305532 2192 0.1
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265912 1268104 2192 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1006403 980 0.1
bss 121344 121352 8 0.0
rodata 118268 118496 228 0.2
text 686928 687560 632 0.1
nrf52840dk_nrf52840+rpc (read/write) 974379 975247 868 0.1
bss 118532 118540 8 0.0
rodata 109656 109884 228 0.2
text 666540 667176 636 0.1
nrf52840dongle_nrf52840 (read/write) 1022227 1023091 864 0.1
bss 122708 122716 8 0.0
rodata 117156 117380 224 0.2
text 692496 693132 636 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 912146 913014 868 0.1
bss 117904 117912 8 0.0
rodata 111524 111752 228 0.2
text 601952 602588 636 0.1
lock-app nrf52840dk_nrf52840 (read/write) 940615 941463 848 0.1
bss 119712 119720 8 0.0
rodata 107492 107716 224 0.2
text 634832 635468 636 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 848078 848942 864 0.1
bss 116304 116312 8 0.0
rodata 100664 100888 224 0.2
text 550632 551264 632 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940035 940899 864 0.1
bss 119432 119440 8 0.0
rodata 106848 107072 224 0.2
text 635088 635724 636 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 936223 848 0.1
bss 119436 119444 8 0.0
rodata 106140 106364 224 0.2
text 631124 631756 632 0.1
shell nrf52840dk_nrf52840 (read/write) 803719 803911 192 0.0
bss 111296 111304 8 0.0
rodata 78668 78716 48 0.1
text 536128 536272 144 0.0
p6 all-clusters-app default (read/write) 2465624 2466296 672 0.0
.bss 118560 118544 -16 -0.0
.data 2584 2568 -16 -0.6
.text 1423888 1424560 672 0.0
light-app default (read/write) 2367760 2368552 792 0.0
.bss 107664 107664 0 0.0
.data 2432 2432 0 0.0
.text 1326024 1326816 792 0.1
lock-app default (read/write) 2336584 2337376 792 0.0
.bss 107400 107400 0 0.0
.data 2400 2400 0 0.0
.text 1294848 1295640 792 0.1
qpg lighting-app qpg6105+debug (read only) 586368 587068 700 0.1
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1084 1084 0 0.0
.text 581048 581748 700 0.1
lock-app qpg6105+debug (read only) 535316 536016 700 0.1
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1028 0 0.0
.text 529996 530696 700 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 869974 870910 936 0.1
bss 88672 88680 8 0.0
noinit 37160 37160 0 0.0
text 611380 612052 672 0.1

@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14756: Size comparison from 983fedf to 1519d3e

Increases (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 983fedf 1519d3e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 596090 716 0.1
.app_xip_area 500908 501624 716 0.1
lock cyw930739m2evb_01 (read/write) 556326 557042 716 0.1
.app_xip_area 463396 464112 716 0.2
ota-requestor cyw930739m2evb_01 (read/write) 577226 577942 716 0.1
.app_xip_area 475048 475764 716 0.2
efr32 lighting-app BRD4161A (read only) 898448 899240 792 0.1
.text 898440 899232 792 0.1
BRD4161A+rpc (read only) 885884 886676 792 0.1
.text 885876 886668 792 0.1
window-app BRD4161A (read only) 839048 839840 792 0.1
.text 839040 839832 792 0.1
esp32 all-clusters-app c3devkit (read only) 940826 941392 566 0.1
(read/write) 1397866 1398066 200 0.0
.flash.rodata 198352 198552 200 0.1
.flash.text 940826 941392 566 0.1
m5stack (read only) 988759 989303 544 0.1
(read/write) 462880 463056 176 0.0
.flash.rodata 225240 225416 176 0.1
.flash.text 983375 983919 544 0.1
k32w light k32w061+release (read/write) 679116 679844 728 0.1
.text 594848 595576 728 0.1
lock k32w061+release (read/write) 683996 684708 712 0.1
.text 599284 599996 712 0.1
linux thermostat-no-ble arm64 (read only) 2131052 2133436 2384 0.1
.rodata 132108 132284 176 0.1
.text 1780880 1783088 2208 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2391536 2393728 2192 0.1
.text 1354136 1356328 2192 0.2
lighting-app CY8CPROTO_062_4343W+release (read/write) 2349448 2351632 2184 0.1
.text 1312048 1314232 2184 0.2
lock-app CY8CPROTO_062_4343W+release (read/write) 2317408 2319592 2184 0.1
.text 1280008 1282192 2184 0.2
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2305532 2192 0.1
.text 1265912 1268104 2192 0.2
p6 all-clusters-app default (read/write) 2478560 2479352 792 0.0
.text 1436824 1437616 792 0.1
light-app default (read/write) 2380312 2381104 792 0.0
.text 1338576 1339368 792 0.1
lock-app default (read/write) 2349136 2349928 792 0.0
.text 1307400 1308192 792 0.1
qpg lighting-app qpg6105+debug (read only) 586320 587028 708 0.1
.text 581000 581708 708 0.1
lock-app qpg6105+debug (read only) 535316 536024 708 0.1
.text 529996 530704 708 0.1
telink lighting-app tlsr9518adk80d (read/write) 866774 867534 760 0.1
text 608368 608928 560 0.1
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 983fedf 1519d3e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 596090 716 0.1
.app_xip_area 500908 501624 716 0.1
.bss 77188 77188 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556326 557042 716 0.1
.app_xip_area 463396 464112 716 0.2
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577226 577942 716 0.1
.app_xip_area 475048 475764 716 0.2
.bss 84604 84604 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 898448 899240 792 0.1
(read/write) 127264 127264 0 0.0
.bss 125256 125256 0 0.0
.data 2008 2008 0 0.0
.text 898440 899232 792 0.1
BRD4161A+rpc (read only) 885884 886676 792 0.1
(read/write) 143924 143924 0 0.0
.bss 141816 141816 0 0.0
.data 2108 2108 0 0.0
.text 885876 886668 792 0.1
window-app BRD4161A (read only) 839048 839840 792 0.1
(read/write) 125360 125360 0 0.0
.bss 123480 123480 0 0.0
.data 1880 1880 0 0.0
.text 839040 839832 792 0.1
esp32 all-clusters-app c3devkit (read only) 940826 941392 566 0.1
(read/write) 1397866 1398066 200 0.0
.dram0.bss 66344 66344 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198352 198552 200 0.1
.flash.text 940826 941392 566 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 988759 989303 544 0.1
(read/write) 462880 463056 176 0.0
.dram0.bss 71488 71488 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 225240 225416 176 0.1
.flash.text 983375 983919 544 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679116 679844 728 0.1
.bss 76584 76584 0 0.0
.data 1884 1884 0 0.0
.text 594848 595576 728 0.1
lock k32w061+release (read/write) 683996 684708 712 0.1
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599284 599996 712 0.1
linux chip-tool-ipv6only arm64 (read only) 7431420 7431420 0 0.0
(read/write) 301921 301921 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 199304 199304 0 0.0
.dynamic 560 560 0 0.0
.got 47008 47008 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 401172 401172 0 0.0
.text 6391140 6391140 0 0.0
thermostat-no-ble arm64 (read only) 2131052 2133436 2384 0.1
(read/write) 140673 140673 0 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132284 176 0.1
.text 1780880 1783088 2208 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391536 2393728 2192 0.1
.bss 188412 188412 0 0.0
.data 5280 5280 0 0.0
.text 1354136 1356328 2192 0.2
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2351632 2184 0.1
.bss 181000 181000 0 0.0
.data 5600 5600 0 0.0
.text 1312048 1314232 2184 0.2
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2319592 2184 0.1
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1282192 2184 0.2
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2305532 2192 0.1
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265912 1268104 2192 0.2
p6 all-clusters-app default (read/write) 2478560 2479352 792 0.0
.bss 117672 117672 0 0.0
.data 2632 2632 0 0.0
.text 1436824 1437616 792 0.1
light-app default (read/write) 2380312 2381104 792 0.0
.bss 107296 107296 0 0.0
.data 2496 2496 0 0.0
.text 1338576 1339368 792 0.1
lock-app default (read/write) 2349136 2349928 792 0.0
.bss 107040 107040 0 0.0
.data 2464 2464 0 0.0
.text 1307400 1308192 792 0.1
qpg lighting-app qpg6105+debug (read only) 586320 587028 708 0.1
(read/write) 146936 146936 0 0.0
.bss 88872 88872 0 0.0
.data 1084 1084 0 0.0
.text 581000 581708 708 0.1
lock-app qpg6105+debug (read only) 535316 536024 708 0.1
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1028 0 0.0
.text 529996 530704 708 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 866774 867534 760 0.1
bss 88664 88664 0 0.0
noinit 37160 37160 0 0.0
text 608368 608928 560 0.1

@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14756: Size comparison from f4901af to 7db18dc

Increases above 0.2%:

platform target config section f4901af 7db18dc change % change
linux bridge-app debug+rpc .rodata 140332 140716 384 0.3
door-lock-app debug .rodata 171858 172210 352 0.2
lighting-app debug+rpc .rodata 164209 164593 384 0.2
ota-provider-app debug .rodata 151910 152294 384 0.3
ota-requestor-app debug .rodata 145495 145879 384 0.3
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section f4901af 7db18dc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599634 600350 716 0.1
.app_xip_area 505144 505860 716 0.1
lock cyw930739m2evb_01 (read/write) 556334 557050 716 0.1
.app_xip_area 463404 464120 716 0.2
ota-requestor cyw930739m2evb_01 (read/write) 577234 577950 716 0.1
.app_xip_area 475056 475772 716 0.2
efr32 lighting-app BRD4161A (read only) 903664 904456 792 0.1
.text 903656 904448 792 0.1
BRD4161A+rpc (read only) 891108 891900 792 0.1
.text 891100 891892 792 0.1
window-app BRD4161A (read only) 839048 839840 792 0.1
.text 839040 839832 792 0.1
esp32 all-clusters-app c3devkit (read only) 940834 941400 566 0.1
(read/write) 1397866 1398066 200 0.0
.flash.rodata 198352 198552 200 0.1
.flash.text 940834 941400 566 0.1
m5stack (read only) 988767 989311 544 0.1
(read/write) 462880 463056 176 0.0
.flash.rodata 225240 225416 176 0.1
.flash.text 983383 983927 544 0.1
k32w light k32w061+release (read/write) 679132 679844 712 0.1
.text 594864 595576 712 0.1
lock k32w061+release (read/write) 684012 684724 712 0.1
.text 599300 600012 712 0.1
linux all-clusters-app debug (read only) 2334953 2337097 2144 0.1
.rodata 204613 204997 384 0.2
.text 1968066 1969826 1760 0.1
bridge-app debug+rpc (read only) 1705845 1707989 2144 0.1
.rodata 140332 140716 384 0.3
.text 1448965 1450725 1760 0.1
chip-tool debug (read only) 7514813 7515005 192 0.0
.rodata 418901 419093 192 0.0
door-lock-app debug (read only) 1910553 1912665 2112 0.1
.rodata 171858 172210 352 0.2
.text 1590178 1591938 1760 0.1
lighting-app debug+rpc (read only) 2032825 2034969 2144 0.1
.rodata 164209 164593 384 0.2
.text 1713778 1715538 1760 0.1
ota-provider-app debug (read only) 1714521 1716681 2160 0.1
.rodata 151910 152294 384 0.3
.text 1443906 1445682 1776 0.1
ota-requestor-app debug (read only) 1709161 1711305 2144 0.1
.rodata 145495 145879 384 0.3
.text 1446770 1448530 1760 0.1
shell debug (read only) 2308393 2310553 2160 0.1
.rodata 205330 205714 384 0.2
.text 1946594 1948370 1776 0.1
thermostat-no-ble arm64 (read only) 2131068 2133436 2368 0.1
.rodata 132108 132284 176 0.1
.text 1780896 1783088 2192 0.1
tv-app debug (read only) 2503209 2505289 2080 0.1
.rodata 196140 196460 320 0.2
.text 2134130 2135890 1760 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2391536 2393728 2192 0.1
.text 1354136 1356328 2192 0.2
lighting-app CY8CPROTO_062_4343W+release (read/write) 2353688 2355872 2184 0.1
.text 1316288 1318472 2184 0.2
lock-app CY8CPROTO_062_4343W+release (read/write) 2317408 2319592 2184 0.1
.text 1280008 1282192 2184 0.2
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2305532 2192 0.1
.text 1265912 1268104 2192 0.2
p6 all-clusters-app default (read/write) 2478576 2479368 792 0.0
.text 1436840 1437632 792 0.1
light-app default (read/write) 2385536 2386328 792 0.0
.text 1343800 1344592 792 0.1
lock-app default (read/write) 2349136 2349928 792 0.0
.text 1307400 1308192 792 0.1
qpg lighting-app qpg6105+debug (read only) 590172 590880 708 0.1
.text 584852 585560 708 0.1
lock-app qpg6105+debug (read only) 556064 556772 708 0.1
.text 550744 551452 708 0.1
telink lighting-app tlsr9518adk80d (read/write) 869602 870362 760 0.1
text 610720 611280 560 0.1
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section f4901af 7db18dc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599634 600350 716 0.1
.app_xip_area 505144 505860 716 0.1
.bss 77212 77212 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556334 557050 716 0.1
.app_xip_area 463404 464120 716 0.2
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577234 577950 716 0.1
.app_xip_area 475056 475772 716 0.2
.bss 84604 84604 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 903664 904456 792 0.1
(read/write) 127296 127296 0 0.0
.bss 125280 125280 0 0.0
.data 2012 2012 0 0.0
.text 903656 904448 792 0.1
BRD4161A+rpc (read only) 891108 891900 792 0.1
(read/write) 143952 143952 0 0.0
.bss 141840 141840 0 0.0
.data 2112 2112 0 0.0
.text 891100 891892 792 0.1
window-app BRD4161A (read only) 839048 839840 792 0.1
(read/write) 125360 125360 0 0.0
.bss 123480 123480 0 0.0
.data 1880 1880 0 0.0
.text 839040 839832 792 0.1
esp32 all-clusters-app c3devkit (read only) 940834 941400 566 0.1
(read/write) 1397866 1398066 200 0.0
.dram0.bss 66344 66344 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198352 198552 200 0.1
.flash.text 940834 941400 566 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 988767 989311 544 0.1
(read/write) 462880 463056 176 0.0
.dram0.bss 71488 71488 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 225240 225416 176 0.1
.flash.text 983383 983927 544 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679132 679844 712 0.1
.bss 76584 76584 0 0.0
.data 1884 1884 0 0.0
.text 594864 595576 712 0.1
lock k32w061+release (read/write) 684012 684724 712 0.1
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599300 600012 712 0.1
linux all-clusters-app debug (read only) 2334953 2337097 2144 0.1
(read/write) 140096 140096 0 0.0
.bss 54688 54688 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 78552 78552 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204613 204997 384 0.2
.text 1968066 1969826 1760 0.1
bridge-app debug+rpc (read only) 1705845 1707989 2144 0.1
(read/write) 84328 84328 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140716 384 0.3
.text 1448965 1450725 1760 0.1
chip-tool debug (read only) 7514813 7515005 192 0.0
(read/write) 197176 197176 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 157624 157624 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 418901 419093 192 0.0
.text 6695477 6695477 0 0.0
chip-tool-ipv6only arm64 (read only) 7433596 7433596 0 0.0
(read/write) 301953 301953 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 199304 199304 0 0.0
.dynamic 560 560 0 0.0
.got 47040 47040 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 401300 401300 0 0.0
.text 6393092 6393092 0 0.0
door-lock-app debug (read only) 1910553 1912665 2112 0.1
(read/write) 110680 110680 0 0.0
.bss 42160 42160 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62160 62160 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171858 172210 352 0.2
.text 1590178 1591938 1760 0.1
lighting-app debug+rpc (read only) 2032825 2034969 2144 0.1
(read/write) 115928 115928 0 0.0
.bss 43136 43136 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65928 65928 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 164209 164593 384 0.2
.text 1713778 1715538 1760 0.1
ota-provider-app debug (read only) 1714521 1716681 2160 0.1
(read/write) 81368 81368 0 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33560 33560 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 152294 384 0.3
.text 1443906 1445682 1776 0.1
ota-requestor-app debug (read only) 1709161 1711305 2144 0.1
(read/write) 83288 83288 0 0.0
.bss 42240 42240 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34616 34616 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145495 145879 384 0.3
.text 1446770 1448530 1760 0.1
shell debug (read only) 2308393 2310553 2160 0.1
(read/write) 141648 141648 0 0.0
.bss 62080 62080 0 0.0
.data 768 768 0 0.0
.data.rel.ro 73104 73104 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205330 205714 384 0.2
.text 1946594 1948370 1776 0.1
thermostat-no-ble arm64 (read only) 2131068 2133436 2368 0.1
(read/write) 140673 140673 0 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132284 176 0.1
.text 1780896 1783088 2192 0.1
tv-app debug (read only) 2503209 2505289 2080 0.1
(read/write) 139512 139512 0 0.0
.bss 57280 57280 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73048 73048 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 196140 196460 320 0.2
.text 2134130 2135890 1760 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391536 2393728 2192 0.1
.bss 188412 188412 0 0.0
.data 5280 5280 0 0.0
.text 1354136 1356328 2192 0.2
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353688 2355872 2184 0.1
.bss 181024 181024 0 0.0
.data 5608 5608 0 0.0
.text 1316288 1318472 2184 0.2
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2319592 2184 0.1
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1282192 2184 0.2
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2305532 2192 0.1
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265912 1268104 2192 0.2
p6 all-clusters-app default (read/write) 2478576 2479368 792 0.0
.bss 117672 117672 0 0.0
.data 2632 2632 0 0.0
.text 1436840 1437632 792 0.1
light-app default (read/write) 2385536 2386328 792 0.0
.bss 107320 107320 0 0.0
.data 2504 2504 0 0.0
.text 1343800 1344592 792 0.1
lock-app default (read/write) 2349136 2349928 792 0.0
.bss 107040 107040 0 0.0
.data 2464 2464 0 0.0
.text 1307400 1308192 792 0.1
qpg lighting-app qpg6105+debug (read only) 590172 590880 708 0.1
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 1088 1088 0 0.0
.text 584852 585560 708 0.1
lock-app qpg6105+debug (read only) 556064 556772 708 0.1
(read/write) 146940 146940 0 0.0
.bss 88880 88880 0 0.0
.data 1040 1040 0 0.0
.text 550744 551452 708 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 869602 870362 760 0.1
bss 88672 88672 0 0.0
noinit 37160 37160 0 0.0
text 610720 611280 560 0.1

@andy31415 andy31415 merged commit b67b7b6 into project-chip:master Feb 9, 2022
@mlepage-google mlepage-google deleted the acl-validation branch February 9, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@turon turon turon approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@turon turon

Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mlepage-google @turon @andy31415 @woody-apple @bzbarsky-apple