-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger StartUp & ShutDown event on all platforms uniformly #14731
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
yufengwangca:pr/event/startup
Feb 5, 2022
Merged
Trigger StartUp & ShutDown event on all platforms uniformly #14731
yufengwangca
merged 1 commit into
project-chip:master
from
yufengwangca:pr/event/startup
Feb 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
robszewczyk and
sagar-apple
February 3, 2022 02:35
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
February 3, 2022 02:35
PR #14731: Size comparison from 8881290 to cd1c973 Increases (12 builds for cyw30739, efr32, linux, p6, telink)
Full report (12 builds for cyw30739, efr32, linux, p6, telink)
|
PR #14731: Size comparison from 8881290 to ff86b92 Increases (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 3, 2022
Damian-Nordic
approved these changes
Feb 3, 2022
PR #14731: Size comparison from 1ee9366 to 113a2cb Increases (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
approved these changes
Feb 3, 2022
PR #14731: Size comparison from 9423bb4 to eabf17d Increases (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
PR #14731: Size comparison from 4549ca8 to 292ad34 Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Currently, Startup and ShutDown event are only logged on Linux platform, this is before those event are triggered from the platform layer and only Linux platform has the implementation. Those generic events are not platform specific, we can move the logic to generic platform implementation so that those events are triggered uniformly across platforms.
Fixes Startup event is only logged on Linux platform now #14617
Change overview
Trigger StartUp & ShutDown event on all platforms uniformly
Testing
How was this tested? (at least one bullet point required)