Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typesafe network featuremaps instead of re-defining constants #14700

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Use typesafe network featuremaps instead of re-defining constants #14700

merged 2 commits into from
Feb 3, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Network commissioning class was re-defining constants for feature maps.

Change overview

Switch to using bitflags of expected types, updated logic that relies on 'wifi driver' to use the driver to check not bitflags, use typesafe bitflag comparisons.

Testing

Commissioned a ESP32 devkit-c manually after the change (this is a device that reports wifi).

@boring-cyborg boring-cyborg bot added the app label Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2022 •
edited
Loading

PR #14700: Size comparison from 3c8d272 to a3ddd2c

Decreases (2 builds for esp32)
platform target config section 3c8d272 a3ddd2c6 change % change
esp32 all-clusters-app c3devkit (read only) 933944 933930 -14 -0.0
.flash.text 933944 933930 -14 -0.0
m5stack (read only) 981987 981971 -16 -0.0
.flash.text 976603 976587 -16 -0.0
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 3c8d272 a3ddd2c6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577442 577442 0 0.0
.app_xip_area 484680 484680 0 0.0
.bss 75508 75508 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535078 535078 0 0.0
.app_xip_area 443884 443884 0 0.0
.bss 73980 73980 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559658 559658 0 0.0
.app_xip_area 459144 459144 0 0.0
.bss 82972 82972 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 843664 843664 0 0.0
(read/write) 125040 125040 0 0.0
.bss 123144 123144 0 0.0
.data 1892 1892 0 0.0
.text 843656 843656 0 0.0
BRD4161A+rpc (read only) 831032 831032 0 0.0
(read/write) 141696 141696 0 0.0
.bss 139704 139704 0 0.0
.data 1992 1992 0 0.0
.text 831024 831024 0 0.0
window-app BRD4161A (read only) 815908 815908 0 0.0
(read/write) 123668 123668 0 0.0
.bss 121820 121820 0 0.0
.data 1848 1848 0 0.0
.text 815900 815900 0 0.0
esp32 all-clusters-app c3devkit (read only) 933944 933930 -14 -0.0
(read/write) 1401466 1401466 0 0.0
.dram0.bss 70304 70304 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 198000 198000 0 0.0
.flash.text 933944 933930 -14 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981987 981971 -16 -0.0
(read/write) 465824 465824 0 0.0
.dram0.bss 75064 75064 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224608 224608 0 0.0
.flash.text 976603 976587 -16 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661652 661652 0 0.0
.bss 75204 75204 0 0.0
.data 1852 1852 0 0.0
.text 578796 578796 0 0.0
lock k32w061+release (read/write) 662820 662820 0 0.0
.bss 75524 75524 0 0.0
.data 1892 1892 0 0.0
.text 579604 579604 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7093252 7093252 0 0.0
(read/write) 290977 290977 0 0.0
.bss 54577 54577 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186256 186256 0 0.0
.dynamic 560 560 0 0.0
.got 45232 45232 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 390492 390492 0 0.0
.text 6102388 6102388 0 0.0
thermostat-no-ble arm64 (read only) 2086396 2086396 0 0.0
(read/write) 148817 148817 0 0.0
.bss 66129 66129 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74624 74624 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131004 131004 0 0.0
.text 1737664 1737664 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2385696 2385696 0 0.0
.bss 189220 189220 0 0.0
.data 5288 5288 0 0.0
.text 1348296 1348296 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338512 2338512 0 0.0
.bss 178144 178144 0 0.0
.data 5568 5568 0 0.0
.text 1301112 1301112 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302232 2302232 0 0.0
.bss 178024 178024 0 0.0
.data 5544 5544 0 0.0
.text 1264832 1264832 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292740 2292740 0 0.0
.bss 175308 175308 0 0.0
.data 5368 5368 0 0.0
.text 1255312 1255312 0 0.0
p6 all-clusters-app default (read/write) 2446768 2446768 0 0.0
.bss 117372 117372 0 0.0
.data 2576 2576 0 0.0
.text 1405032 1405032 0 0.0
light-app default (read/write) 2340368 2340368 0 0.0
.bss 103340 103340 0 0.0
.data 2400 2400 0 0.0
.text 1298632 1298632 0 0.0
lock-app default (read/write) 2305400 2305400 0 0.0
.bss 103060 103060 0 0.0
.data 2360 2360 0 0.0
.text 1263664 1263664 0 0.0
qpg lighting-app qpg6105+debug (read only) 571040 571040 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87488 87488 0 0.0
.data 1056 1056 0 0.0
.text 565720 565720 0 0.0
lock-app qpg6105+debug (read only) 516776 516776 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86928 86928 0 0.0
.data 992 992 0 0.0
.text 511456 511456 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845406 845406 0 0.0
bss 85540 85540 0 0.0
noinit 37160 37160 0 0.0
text 592178 592178 0 0.0

@andy31415
Copy link
Contributor Author

/rebase

@github-actions
Copy link

github-actions bot commented Feb 2, 2022 •
edited
Loading

PR #14700: Size comparison from 4f391f1 to 37c6226

Decreases (2 builds for esp32)
platform target config section 4f391f1 37c6226 change % change
esp32 all-clusters-app c3devkit (read only) 933934 933920 -14 -0.0
.flash.text 933934 933920 -14 -0.0
m5stack (read only) 981987 981971 -16 -0.0
.flash.text 976603 976587 -16 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4f391f1 37c6226 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577442 577442 0 0.0
.app_xip_area 484680 484680 0 0.0
.bss 75508 75508 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535078 535078 0 0.0
.app_xip_area 443884 443884 0 0.0
.bss 73980 73980 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559658 559658 0 0.0
.app_xip_area 459144 459144 0 0.0
.bss 82972 82972 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 843664 843664 0 0.0
(read/write) 125040 125040 0 0.0
.bss 123144 123144 0 0.0
.data 1892 1892 0 0.0
.text 843656 843656 0 0.0
BRD4161A+rpc (read only) 831032 831032 0 0.0
(read/write) 141696 141696 0 0.0
.bss 139704 139704 0 0.0
.data 1992 1992 0 0.0
.text 831024 831024 0 0.0
window-app BRD4161A (read only) 815908 815908 0 0.0
(read/write) 123668 123668 0 0.0
.bss 121820 121820 0 0.0
.data 1848 1848 0 0.0
.text 815900 815900 0 0.0
esp32 all-clusters-app c3devkit (read only) 933934 933920 -14 -0.0
(read/write) 1401466 1401466 0 0.0
.dram0.bss 70304 70304 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 198000 198000 0 0.0
.flash.text 933934 933920 -14 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981987 981971 -16 -0.0
(read/write) 465824 465824 0 0.0
.dram0.bss 75064 75064 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224608 224608 0 0.0
.flash.text 976603 976587 -16 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661652 661652 0 0.0
.bss 75204 75204 0 0.0
.data 1852 1852 0 0.0
.text 578796 578796 0 0.0
lock k32w061+release (read/write) 662820 662820 0 0.0
.bss 75524 75524 0 0.0
.data 1892 1892 0 0.0
.text 579604 579604 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7093252 7093252 0 0.0
(read/write) 290977 290977 0 0.0
.bss 54577 54577 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186256 186256 0 0.0
.dynamic 560 560 0 0.0
.got 45232 45232 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 390492 390492 0 0.0
.text 6102388 6102388 0 0.0
thermostat-no-ble arm64 (read only) 2086396 2086396 0 0.0
(read/write) 148817 148817 0 0.0
.bss 66129 66129 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74624 74624 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131004 131004 0 0.0
.text 1737664 1737664 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2385696 2385696 0 0.0
.bss 189220 189220 0 0.0
.data 5288 5288 0 0.0
.text 1348296 1348296 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338512 2338512 0 0.0
.bss 178144 178144 0 0.0
.data 5568 5568 0 0.0
.text 1301112 1301112 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302232 2302232 0 0.0
.bss 178024 178024 0 0.0
.data 5544 5544 0 0.0
.text 1264832 1264832 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292740 2292740 0 0.0
.bss 175308 175308 0 0.0
.data 5368 5368 0 0.0
.text 1255312 1255312 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980831 980831 0 0.0
bss 118512 118512 0 0.0
rodata 116532 116532 0 0.0
text 667988 667988 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 966391 966391 0 0.0
bss 115556 115556 0 0.0
rodata 108004 108004 0 0.0
text 664428 664428 0 0.0
nrf52840dongle_nrf52840 (read/write) 996915 996915 0 0.0
bss 119684 119684 0 0.0
rodata 115380 115380 0 0.0
text 673380 673380 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890046 890046 0 0.0
bss 115300 115300 0 0.0
rodata 109824 109824 0 0.0
text 584176 584176 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913079 913079 0 0.0
bss 116876 116876 0 0.0
rodata 104804 104804 0 0.0
text 614000 614000 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823114 823114 0 0.0
bss 113692 113692 0 0.0
rodata 98012 98012 0 0.0
text 530968 530968 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915863 915863 0 0.0
bss 116632 116632 0 0.0
rodata 105324 105324 0 0.0
text 616456 616456 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911039 911039 0 0.0
bss 116640 116640 0 0.0
rodata 104428 104428 0 0.0
text 612516 612516 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109772 109772 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2446768 2446768 0 0.0
.bss 117372 117372 0 0.0
.data 2576 2576 0 0.0
.text 1405032 1405032 0 0.0
light-app default (read/write) 2340368 2340368 0 0.0
.bss 103340 103340 0 0.0
.data 2400 2400 0 0.0
.text 1298632 1298632 0 0.0
lock-app default (read/write) 2305400 2305400 0 0.0
.bss 103060 103060 0 0.0
.data 2360 2360 0 0.0
.text 1263664 1263664 0 0.0
qpg lighting-app qpg6105+debug (read only) 571040 571040 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87488 87488 0 0.0
.data 1056 1056 0 0.0
.text 565720 565720 0 0.0
lock-app qpg6105+debug (read only) 516776 516776 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86928 86928 0 0.0
.data 992 992 0 0.0
.text 511456 511456 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845406 845406 0 0.0
bss 85540 85540 0 0.0
noinit 37160 37160 0 0.0
text 592178 592178 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 3, 2022 •
edited
Loading

PR #14700: Size comparison from ac410fb to 525d919

Increases (1 build for linux)
platform target config section ac410fb 525d919 change % change
linux all-clusters-app debug (read only) 2308641 2309697 1056 0.0
.text 1942626 1943682 1056 0.1
Decreases (2 builds for esp32)
platform target config section ac410fb 525d919 change % change
esp32 all-clusters-app c3devkit (read only) 934598 934584 -14 -0.0
.flash.text 934598 934584 -14 -0.0
m5stack (read only) 982723 982707 -16 -0.0
.flash.text 977339 977323 -16 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ac410fb 525d919 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577390 577390 0 0.0
.app_xip_area 484884 484884 0 0.0
.bss 75252 75252 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535134 535134 0 0.0
.app_xip_area 444196 444196 0 0.0
.bss 73724 73724 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559618 559618 0 0.0
.app_xip_area 459360 459360 0 0.0
.bss 82716 82716 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 844328 844328 0 0.0
(read/write) 124792 124792 0 0.0
.bss 122896 122896 0 0.0
.data 1892 1892 0 0.0
.text 844320 844320 0 0.0
BRD4161A+rpc (read only) 831704 831704 0 0.0
(read/write) 141448 141448 0 0.0
.bss 139456 139456 0 0.0
.data 1992 1992 0 0.0
.text 831696 831696 0 0.0
window-app BRD4161A (read only) 816404 816404 0 0.0
(read/write) 123412 123412 0 0.0
.bss 121564 121564 0 0.0
.data 1848 1848 0 0.0
.text 816396 816396 0 0.0
esp32 all-clusters-app c3devkit (read only) 934598 934584 -14 -0.0
(read/write) 1401002 1401002 0 0.0
.dram0.bss 70048 70048 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 197792 197792 0 0.0
.flash.text 934598 934584 -14 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982723 982707 -16 -0.0
(read/write) 465360 465360 0 0.0
.dram0.bss 74808 74808 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224400 224400 0 0.0
.flash.text 977339 977323 -16 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661620 661620 0 0.0
.bss 74948 74948 0 0.0
.data 1852 1852 0 0.0
.text 579020 579020 0 0.0
lock k32w061+release (read/write) 663072 663072 0 0.0
.bss 75268 75268 0 0.0
.data 1892 1892 0 0.0
.text 580112 580112 0 0.0
linux all-clusters-app debug (read only) 2308641 2309697 1056 0.0
(read/write) 139872 139872 0 0.0
.bss 54592 54592 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204037 204037 0 0.0
.text 1942626 1943682 1056 0.1
bridge-app debug+rpc (read only) 1636309 1636309 0 0.0
(read/write) 80552 80552 0 0.0
.bss 36032 36032 0 0.0
.data 1922 1922 0 0.0
.data.rel.ro 37440 37440 0 0.0
.dynamic 592 592 0 0.0
.got 3968 3968 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 137620 137620 0 0.0
.text 1383621 1383621 0 0.0
chip-tool debug (read only) 7174989 7174989 0 0.0
(read/write) 181800 181800 0 0.0
.bss 29320 29320 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 145392 145392 0 0.0
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 600 600 0 0.0
.rodata 408469 408469 0 0.0
.text 6398165 6398165 0 0.0
chip-tool-ipv6only arm64 (read only) 7120532 7120532 0 0.0
(read/write) 284545 284545 0 0.0
.bss 47585 47585 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186712 186712 0 0.0
.dynamic 560 560 0 0.0
.got 45336 45336 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 391564 391564 0 0.0
.text 6127236 6127236 0 0.0
door-lock-app debug (read only) 1857545 1857545 0 0.0
(read/write) 110432 110432 0 0.0
.bss 42208 42208 0 0.0
.data 962 962 0 0.0
.data.rel.ro 61856 61856 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170940 170940 0 0.0
.text 1538562 1538562 0 0.0
lighting-app debug+rpc (read only) 1958977 1958977 0 0.0
(read/write) 115552 115552 0 0.0
.bss 43160 43160 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 65504 65504 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 160945 160945 0 0.0
.text 1643634 1643634 0 0.0
ota-provider-app debug (read only) 1640017 1640017 0 0.0
(read/write) 80040 80040 0 0.0
.bss 41088 41088 0 0.0
.data 1064 1064 0 0.0
.data.rel.ro 32376 32376 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 148486 148486 0 0.0
.text 1374114 1374114 0 0.0
ota-requestor-app debug (read only) 1645593 1645593 0 0.0
(read/write) 83024 83024 0 0.0
.bss 42400 42400 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 34248 34248 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 143831 143831 0 0.0
.text 1385522 1385522 0 0.0
shell debug (read only) 2282913 2282913 0 0.0
(read/write) 141360 141360 0 0.0
.bss 62016 62016 0 0.0
.data 768 768 0 0.0
.data.rel.ro 72896 72896 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 204786 204786 0 0.0
.text 1922082 1922082 0 0.0
thermostat-no-ble arm64 (read only) 2091484 2091484 0 0.0
(read/write) 140401 140401 0 0.0
.bss 57713 57713 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74624 74624 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130764 130764 0 0.0
.text 1743008 1743008 0 0.0
tv-app debug (read only) 2412665 2412665 0 0.0
(read/write) 138768 138768 0 0.0
.bss 57152 57152 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 72504 72504 0 0.0
.dynamic 592 592 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 191852 191852 0 0.0
.text 2049330 2049330 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2386056 2386056 0 0.0
.bss 188964 188964 0 0.0
.data 5288 5288 0 0.0
.text 1348656 1348656 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338744 2338744 0 0.0
.bss 177888 177888 0 0.0
.data 5568 5568 0 0.0
.text 1301344 1301344 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302600 2302600 0 0.0
.bss 177776 177776 0 0.0
.data 5544 5544 0 0.0
.text 1265200 1265200 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292980 2292980 0 0.0
.bss 175052 175052 0 0.0
.data 5368 5368 0 0.0
.text 1255552 1255552 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980975 980975 0 0.0
bss 118260 118260 0 0.0
rodata 116324 116324 0 0.0
text 668596 668596 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 966535 966535 0 0.0
bss 115304 115304 0 0.0
rodata 107796 107796 0 0.0
text 665040 665040 0 0.0
nrf52840dongle_nrf52840 (read/write) 997039 997039 0 0.0
bss 119432 119432 0 0.0
rodata 115168 115168 0 0.0
text 673972 673972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890190 890190 0 0.0
bss 115044 115044 0 0.0
rodata 109616 109616 0 0.0
text 584788 584788 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913319 913319 0 0.0
bss 116620 116620 0 0.0
rodata 104596 104596 0 0.0
text 614704 614704 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823350 823350 0 0.0
bss 113440 113440 0 0.0
rodata 97800 97800 0 0.0
text 531672 531672 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915987 915987 0 0.0
bss 116380 116380 0 0.0
rodata 105112 105112 0 0.0
text 617048 617048 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911195 911195 0 0.0
bss 116388 116388 0 0.0
rodata 104216 104216 0 0.0
text 613104 613104 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798875 798875 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 534248 534248 0 0.0
p6 all-clusters-app default (read/write) 2447224 2447224 0 0.0
.bss 117116 117116 0 0.0
.data 2576 2576 0 0.0
.text 1405488 1405488 0 0.0
light-app default (read/write) 2340864 2340864 0 0.0
.bss 103084 103084 0 0.0
.data 2400 2400 0 0.0
.text 1299128 1299128 0 0.0
lock-app default (read/write) 2305896 2305896 0 0.0
.bss 102804 102804 0 0.0
.data 2360 2360 0 0.0
.text 1264160 1264160 0 0.0
qpg lighting-app qpg6105+debug (read only) 571244 571244 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 1056 1056 0 0.0
.text 565924 565924 0 0.0
lock-app qpg6105+debug (read only) 517084 517084 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86680 86680 0 0.0
.data 992 992 0 0.0
.text 511764 511764 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845594 845594 0 0.0
bss 85288 85288 0 0.0
noinit 37160 37160 0 0.0
text 592830 592830 0 0.0

@andy31415 andy31415 merged commit 9ec3d31 into project-chip:master Feb 3, 2022
@andy31415 andy31415 deleted the typesafe_flags branch June 14, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@cecille cecille cecille approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @msandstedt @cecille @bzbarsky-apple