Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FabricId to the Root Cert DN for Android and iOS. #14686

Conversation

emargolis
Copy link
Contributor

Problem

Prior #13737 merge the test root certificate included also FabricId.

Change overview

To keep consistency with the test environments that were created prior to #13737 this PR adds FabricId attribute to the root certificate DN.

Testing

existing tests

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

PR #14686: Size comparison from 8bb93af to aa640f2

Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8bb93af aa640f2 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 576670 576670 0 0.0
.app_xip_area 483892 483892 0 0.0
.bss 75524 75524 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 534666 534666 0 0.0
.app_xip_area 443456 443456 0 0.0
.bss 73996 73996 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559322 559322 0 0.0
.app_xip_area 458808 458808 0 0.0
.bss 82972 82972 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 842920 842920 0 0.0
(read/write) 125056 125056 0 0.0
.bss 123160 123160 0 0.0
.data 1892 1892 0 0.0
.text 842912 842912 0 0.0
BRD4161A+rpc (read only) 830288 830288 0 0.0
(read/write) 141712 141712 0 0.0
.bss 139720 139720 0 0.0
.data 1992 1992 0 0.0
.text 830280 830280 0 0.0
window-app BRD4161A (read only) 815468 815468 0 0.0
(read/write) 123684 123684 0 0.0
.bss 121836 121836 0 0.0
.data 1848 1848 0 0.0
.text 815460 815460 0 0.0
esp32 all-clusters-app c3devkit (read only) 933880 933880 0 0.0
(read/write) 1399794 1399794 0 0.0
.dram0.bss 70328 70328 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 196296 196296 0 0.0
.flash.text 933880 933880 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981907 981907 0 0.0
(read/write) 464136 464136 0 0.0
.dram0.bss 75080 75080 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222904 222904 0 0.0
.flash.text 976523 976523 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661320 661320 0 0.0
.bss 75212 75212 0 0.0
.data 1852 1852 0 0.0
.text 578456 578456 0 0.0
lock k32w061+release (read/write) 662396 662396 0 0.0
.bss 75532 75532 0 0.0
.data 1892 1892 0 0.0
.text 579172 579172 0 0.0
linux all-clusters-app debug (read only) 2299721 2299721 0 0.0
(read/write) 147104 147104 0 0.0
.bss 63040 63040 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 77176 77176 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 203269 203269 0 0.0
.text 1935794 1935794 0 0.0
bridge-app debug+rpc (read only) 1628989 1628989 0 0.0
(read/write) 87816 87816 0 0.0
.bss 43776 43776 0 0.0
.data 1794 1794 0 0.0
.data.rel.ro 37088 37088 0 0.0
.dynamic 592 592 0 0.0
.got 3968 3968 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 137684 137684 0 0.0
.text 1376501 1376501 0 0.0
chip-tool debug (read only) 7086365 7086365 0 0.0
(read/write) 187304 187304 0 0.0
.bss 36264 36264 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 143968 143968 0 0.0
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 600 600 0 0.0
.rodata 404597 404597 0 0.0
.text 6315717 6315717 0 0.0
chip-tool-ipv6only arm64 (read only) 7036900 7036900 0 0.0
(read/write) 289857 289857 0 0.0
.bss 54593 54593 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 185152 185152 0 0.0
.dynamic 560 560 0 0.0
.got 45200 45200 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 387804 387804 0 0.0
.text 6050212 6050212 0 0.0
door-lock-app debug (read only) 1850457 1850457 0 0.0
(read/write) 117728 117728 0 0.0
.bss 49856 49856 0 0.0
.data 962 962 0 0.0
.data.rel.ro 61504 61504 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 171036 171036 0 0.0
.text 1531618 1531618 0 0.0
lighting-app debug+rpc (read only) 1951201 1951201 0 0.0
(read/write) 122720 122720 0 0.0
.bss 50808 50808 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 65024 65024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 160785 160785 0 0.0
.text 1636594 1636594 0 0.0
ota-provider-app debug (read only) 1629865 1629865 0 0.0
(read/write) 87464 87464 0 0.0
.bss 48736 48736 0 0.0
.data 1064 1064 0 0.0
.data.rel.ro 32168 32168 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 147710 147710 0 0.0
.text 1365026 1365026 0 0.0
ota-requestor-app debug (read only) 1638577 1638577 0 0.0
(read/write) 90512 90512 0 0.0
.bss 50048 50048 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 34088 34088 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 143983 143983 0 0.0
.text 1378546 1378546 0 0.0
shell debug (read only) 2274345 2274345 0 0.0
(read/write) 148880 148880 0 0.0
.bss 70752 70752 0 0.0
.data 768 768 0 0.0
.data.rel.ro 71680 71680 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 204050 204050 0 0.0
.text 1915570 1915570 0 0.0
thermostat-no-ble arm64 (read only) 2084140 2084140 0 0.0
(read/write) 148433 148433 0 0.0
.bss 66177 66177 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74192 74192 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130588 130588 0 0.0
.text 1736400 1736400 0 0.0
tv-app debug (read only) 2404921 2404921 0 0.0
(read/write) 317904 317904 0 0.0
.bss 237312 237312 0 0.0
.data 2944 2944 0 0.0
.data.rel.ro 71656 71656 0 0.0
.dynamic 592 592 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 191436 191436 0 0.0
.text 2043154 2043154 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2384000 2384000 0 0.0
.bss 189244 189244 0 0.0
.data 5288 5288 0 0.0
.text 1346600 1346600 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337720 2337720 0 0.0
.bss 178160 178160 0 0.0
.data 5568 5568 0 0.0
.text 1300320 1300320 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2301824 2301824 0 0.0
.bss 178040 178040 0 0.0
.data 5544 5544 0 0.0
.text 1264424 1264424 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292428 2292428 0 0.0
.bss 175316 175316 0 0.0
.data 5368 5368 0 0.0
.text 1255000 1255000 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980051 980051 0 0.0
bss 118528 118528 0 0.0
rodata 115816 115816 0 0.0
text 667932 667932 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 965627 965627 0 0.0
bss 115572 115572 0 0.0
rodata 107288 107288 0 0.0
text 664376 664376 0 0.0
nrf52840dongle_nrf52840 (read/write) 996119 996119 0 0.0
bss 119700 119700 0 0.0
rodata 114648 114648 0 0.0
text 673324 673324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 889266 889266 0 0.0
bss 115316 115316 0 0.0
rodata 109092 109092 0 0.0
text 584128 584128 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912663 912663 0 0.0
bss 116888 116888 0 0.0
rodata 104452 104452 0 0.0
text 613936 613936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822730 822730 0 0.0
bss 113704 113704 0 0.0
rodata 97660 97660 0 0.0
text 530912 530912 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915419 915419 0 0.0
bss 116644 116644 0 0.0
rodata 104912 104912 0 0.0
text 616392 616392 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910595 910595 0 0.0
bss 116652 116652 0 0.0
rodata 104016 104016 0 0.0
text 612440 612440 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798395 798395 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533760 533760 0 0.0
p6 all-clusters-app default (read/write) 2445048 2445048 0 0.0
.bss 117388 117388 0 0.0
.data 2576 2576 0 0.0
.text 1403312 1403312 0 0.0
light-app default (read/write) 2339624 2339624 0 0.0
.bss 103348 103348 0 0.0
.data 2400 2400 0 0.0
.text 1297888 1297888 0 0.0
lock-app default (read/write) 2305032 2305032 0 0.0
.bss 103068 103068 0 0.0
.data 2360 2360 0 0.0
.text 1263296 1263296 0 0.0
qpg lighting-app qpg6105+debug (read only) 570244 570244 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87504 87504 0 0.0
.data 1056 1056 0 0.0
.text 564924 564924 0 0.0
lock-app qpg6105+debug (read only) 516344 516344 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86944 86944 0 0.0
.data 992 992 0 0.0
.text 511024 511024 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 844626 844626 0 0.0
bss 85552 85552 0 0.0
noinit 37160 37160 0 0.0
text 592126 592126 0 0.0

@emargolis emargolis removed the request for review from bzbarsky-apple February 3, 2022 21:00
@andy31415 andy31415 merged commit 6dd3122 into project-chip:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants