-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FabricTable memory leak in DeviceControllerSystemState #14658
Merged
andy31415
merged 1 commit into
project-chip:master
from
kianooshkarami:bugfix/ctrl-dev-fact-memleak
Feb 1, 2022
Merged
Fix FabricTable memory leak in DeviceControllerSystemState #14658
andy31415
merged 1 commit into
project-chip:master
from
kianooshkarami:bugfix/ctrl-dev-fact-memleak
Feb 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabricTable is instantiated in DeviceControllerFactory::InitSystemState as shown below ``` stateParams.fabricTable = chip::Platform::New<FabricTable>(); ``` stateParams (type: DeviceControllerSystemStateParams) is then passed onto DeviceControllerFactory::mSystemState (type: DeviceControllerSystemState), where stateParams.fabricTable is now stored in mSystemState.mFabrics. We need to ensure that the original memory allocated in the initial step is now freed in DeviceControllerSystemState::Shutdown()
Damian-Nordic
approved these changes
Feb 1, 2022
andy31415
approved these changes
Feb 1, 2022
PR #14658: Size comparison from cb9b046 to f7990f1 Increases (3 builds for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed?
Fix FabricTable memory leak in DeviceControllerSystemState
Change overview
FabricTable is instantiated in DeviceControllerFactory::InitSystemState
as shown below
stateParams (type: DeviceControllerSystemStateParams) is then passed
onto DeviceControllerFactory::mSystemState (type: DeviceControllerSystemState), where stateParams.fabricTable is now stored in mSystemState.mFabrics.
We need to ensure that the original memory allocated in the initial step
is now freed in DeviceControllerSystemState::Shutdown()
Testing
How was this tested? (at least one bullet point required)
Answer: This was validated through memory sanitizer
** No Unit test check for similar memory leaks.