-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Access-Control cluster to all example apps using ZAP #14657
Add Access-Control cluster to all example apps using ZAP #14657
Conversation
4b66059
to
c839e6f
Compare
PR #14657: Size comparison from a2f9cad to c839e6f Increases above 0.2%:
Increases (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better now, just keep an eye on the zap when rebasing etc. thanks!
c839e6f
to
38251e5
Compare
PR #14657: Size comparison from 543cc88 to 38251e5 Increases above 0.2%:
Increases (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
38251e5
to
3837caa
Compare
PR #14657: Size comparison from 2a6dc3e to 3837caa Increases above 0.2%:
Increases (17 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
3837caa
to
0fb65d7
Compare
PR #14657: Size comparison from 8ffe422 to 0fb65d7 Increases above 0.2%:
Increases (8 builds for cyw30739, k32w, qpg, telink)
Full report (9 builds for cyw30739, k32w, qpg, telink)
|
0fb65d7
to
3712fc5
Compare
PR #14657: Size comparison from 22f5d22 to 3712fc5 Increases above 0.2%:
Increases (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
3712fc5
to
a9bb84f
Compare
PR #14657: Size comparison from 22f5d22 to a9bb84f Increases above 0.2%:
Increases (14 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
Full report (17 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
a9bb84f
to
8e79895
Compare
PR #14657: Size comparison from 22f5d22 to 8e79895 Increases above 0.2%:
Increases (31 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Verified cluster is present (on Linux) and functioning in these apps:
Could not commission the bridge app for some reason, so couldn't check it. |
Looks like all directories in examples had a zap file updated, except:
all-clusters-app was already done, and the rest look like real exceptions (i.e. not apps) to me. None of them have zap files in this list, except placeholder (which seems to be some sort of template app):
|
Problem
#14461
Add Access-Control cluster to all remaining example apps
Change overview
Used ZAP GUI to add access-control cluster (server) to all example apps. Additionally, the Bridge, door-lock, lighting, and OTA-Provider apps also has the Access-control client cluster enabled.
Testing