-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Get chip-tool template to generate write commands for struct attributes now that complex types are supported #14593
Merged
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_GenerateStructWrite
Feb 1, 2022
Merged
[chip-tool] Get chip-tool template to generate write commands for struct attributes now that complex types are supported #14593
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_GenerateStructWrite
Feb 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uct attributes now that complex types are supported
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
holbrookt,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02 and
mrjerryjohns
January 31, 2022 15:34
pullapprove
bot
requested review from
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
woody-apple and
xylophone21
January 31, 2022 15:34
vivien-apple
changed the title
Chip tool generate struct write
[chip-tool] Get chip-tool template to generate write commands for struct attributes now that complex types are supported
Jan 31, 2022
PR #14593: Size comparison from 39115b9 to c782f9b Increases above 0.2%:
Increases (2 builds for linux)
Full report (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking, given this is adding tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip-tool
template does not generatewrite
commands for attributes of typestruct
. Since complex types are not supported there is no reason to not generate those.Change overview
write
commands to be generated for attribute of typestruct
Testing
I have manually validated that it works with the command: