Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query network cluster using wildcard reads #14567

Merged
merged 16 commits into from
Feb 3, 2022
Merged

Query network cluster using wildcard reads #14567

merged 16 commits into from
Feb 3, 2022

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Jan 29, 2022

Problem

#14410 proposed a solution to get network cluster information, but it is quite complex because it does not make use of wildcard reads.

Change overview

  • use wildcard read to get network feature maps in one go, remove steps to walk through endpoints and read each individually.

Testing

M5 all clusters app for wifi, cirque for thread, lighting app on linux for on-network.

cecille and others added 8 commits January 27, 2022 09:21
@cecille
Read parts list from descriptor cluster
c569a80
@cecille
Add step to read server clusters from descriptor.
9e8f49a
@cecille
Read basic cluster information during commissioning.
eb8b946
@cecille
Pass back status from iter.
8afd91b
@cecille
Merge remote-tracking branch 'upstream/master' into check_descriptor_…
69a9284 
…cluster
@cecille
sequence network cluster existance and feature checks.
9556c90 
If we check the feature map right after we check for the existance
of the networking cluster, we can just bail out once we find a
networking cluster that matches

Test: on-network with lighting app on linux
      wifi on all-clusters app on M5
      tested thread using all clusters app - saw reads of endpoints,
      found network cluster on different endpoint.
@restyled-commits @cecille
Restyled by clang-format
420142b
@cecille
Use multi-endpoint wildcard to simplify commissioning
fa799d9
@restyled-io restyled-io bot mentioned this pull request Jan 29, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jan 29, 2022 •
edited
Loading

PR #14567: Size comparison from ecf9ccd to 5d95e49

Increases above 0.2%:

platform target config section ecf9ccd 5d95e49 change % change
linux chip-tool debug (read only) 6965189 7008501 43312 0.6
.data.rel.ro 136016 136344 328 0.2
.text 6198341 6240309 41968 0.7
chip-tool-ipv6only arm64 (read only) 6931652 6978316 46664 0.7
.text 5952612 5998036 45424 0.8
tv-app debug (read only) 2343889 2406209 62320 2.7
.data.rel.ro 71408 71928 520 0.7
.rodata 199308 199884 576 0.3
.text 1974898 2035394 60496 3.1
Increases (3 builds for linux)
platform target config section ecf9ccd 5d95e49 change % change
linux chip-tool debug (read only) 6965189 7008501 43312 0.6
(read/write) 180336 180656 320 0.2
.data.rel.ro 136016 136344 328 0.2
.rodata 416321 416897 576 0.1
.text 6198341 6240309 41968 0.7
chip-tool-ipv6only arm64 (read only) 6931652 6978316 46664 0.7
(read/write) 283185 283537 352 0.1
.data.rel.ro 178216 178536 320 0.2
.got 44528 44560 32 0.1
.rodata 396844 397172 328 0.1
.text 5952612 5998036 45424 0.8
tv-app debug (read only) 2343889 2406209 62320 2.7
(read/write) 321440 321984 544 0.2
.bss 241056 241088 32 0.0
.data.rel.ro 71408 71928 520 0.7
.rodata 199308 199884 576 0.3
.text 1974898 2035394 60496 3.1
Full report (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ecf9ccd 5d95e49 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578186 578186 0 0.0
.app_xip_area 484280 484280 0 0.0
.bss 76652 76652 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536198 536198 0 0.0
.app_xip_area 443836 443836 0 0.0
.bss 75148 75148 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843080 843080 0 0.0
(read/write) 126200 126200 0 0.0
.bss 124296 124296 0 0.0
.data 1900 1900 0 0.0
.text 843072 843072 0 0.0
BRD4161A+rpc (read only) 830432 830432 0 0.0
(read/write) 142856 142856 0 0.0
.bss 140856 140856 0 0.0
.data 2000 2000 0 0.0
.text 830424 830424 0 0.0
window-app BRD4161A (read only) 815688 815688 0 0.0
(read/write) 124852 124852 0 0.0
.bss 122996 122996 0 0.0
.data 1856 1856 0 0.0
.text 815680 815680 0 0.0
esp32 all-clusters-app c3devkit (read only) 933696 933696 0 0.0
(read/write) 1398082 1398082 0 0.0
.dram0.bss 69680 69680 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 195256 195256 0 0.0
.flash.text 933696 933696 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981515 981515 0 0.0
(read/write) 462452 462452 0 0.0
.dram0.bss 74432 74432 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 221868 221868 0 0.0
.flash.text 976131 976131 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 663020 663020 0 0.0
.bss 76428 76428 0 0.0
.data 1868 1868 0 0.0
.text 578924 578924 0 0.0
lock k32w061+release (read/write) 663908 663908 0 0.0
.bss 76692 76692 0 0.0
.data 1892 1892 0 0.0
.text 579524 579524 0 0.0
linux all-clusters-app debug (read only) 2291689 2291689 0 0.0
(read/write) 146288 146288 0 0.0
.bss 62560 62560 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 76824 76824 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 204469 204469 0 0.0
.text 1926562 1926562 0 0.0
bridge-app debug+rpc (read only) 1626501 1626501 0 0.0
(read/write) 88936 88936 0 0.0
.bss 44896 44896 0 0.0
.data 1794 1794 0 0.0
.data.rel.ro 37088 37088 0 0.0
.dynamic 592 592 0 0.0
.got 3968 3968 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 137940 137940 0 0.0
.text 1373781 1373781 0 0.0
chip-tool debug (read only) 6965189 7008501 43312 0.6
(read/write) 180336 180656 320 0.2
.bss 37240 37240 0 0.0
.data 1064 1064 0 0.0
.data.rel.ro 136016 136344 328 0.2
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 416321 416897 576 0.1
.text 6198341 6240309 41968 0.7
chip-tool-ipv6only arm64 (read only) 6931652 6978316 46664 0.7
(read/write) 283185 283537 352 0.1
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178216 178536 320 0.2
.dynamic 560 560 0 0.0
.got 44528 44560 32 0.1
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 396844 397172 328 0.1
.text 5952612 5998036 45424 0.8
door-lock-app debug (read only) 1848145 1848145 0 0.0
(read/write) 119040 119040 0 0.0
.bss 51136 51136 0 0.0
.data 994 994 0 0.0
.data.rel.ro 61504 61504 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 171292 171292 0 0.0
.text 1529122 1529122 0 0.0
lighting-app debug+rpc (read only) 1948105 1948105 0 0.0
(read/write) 123968 123968 0 0.0
.bss 52056 52056 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 65040 65040 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 161329 161329 0 0.0
.text 1633026 1633026 0 0.0
ota-provider-app debug (read only) 1627321 1627321 0 0.0
(read/write) 88808 88808 0 0.0
.bss 50080 50080 0 0.0
.data 1064 1064 0 0.0
.data.rel.ro 32168 32168 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 147814 147814 0 0.0
.text 1362450 1362450 0 0.0
ota-requestor-app debug (read only) 1636017 1636017 0 0.0
(read/write) 91840 91840 0 0.0
.bss 51360 51360 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 34088 34088 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 144247 144247 0 0.0
.text 1375746 1375746 0 0.0
shell debug (read only) 2266281 2266281 0 0.0
(read/write) 148064 148064 0 0.0
.bss 70272 70272 0 0.0
.data 768 768 0 0.0
.data.rel.ro 71344 71344 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205202 205202 0 0.0
.text 1906354 1906354 0 0.0
thermostat-no-ble arm64 (read only) 2082108 2082108 0 0.0
(read/write) 149457 149457 0 0.0
.bss 67169 67169 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74216 74216 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130172 130172 0 0.0
.text 1734656 1734656 0 0.0
tv-app debug (read only) 2343889 2406209 62320 2.7
(read/write) 321440 321984 544 0.2
.bss 241056 241088 32 0.0
.data 2944 2944 0 0.0
.data.rel.ro 71408 71928 520 0.7
.dynamic 592 592 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 199308 199884 576 0.3
.text 1974898 2035394 60496 3.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2383456 2383456 0 0.0
.bss 188580 188580 0 0.0
.data 5288 5288 0 0.0
.text 1346056 1346056 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337912 2337912 0 0.0
.bss 179304 179304 0 0.0
.data 5584 5584 0 0.0
.text 1300512 1300512 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2301888 2301888 0 0.0
.bss 179208 179208 0 0.0
.data 5552 5552 0 0.0
.text 1264488 1264488 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292692 2292692 0 0.0
.bss 176532 176532 0 0.0
.data 5384 5384 0 0.0
.text 1255264 1255264 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981455 981455 0 0.0
bss 119660 119660 0 0.0
rodata 115684 115684 0 0.0
text 668300 668300 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 966987 966987 0 0.0
bss 116704 116704 0 0.0
rodata 107160 107160 0 0.0
text 664740 664740 0 0.0
nrf52840dongle_nrf52840 (read/write) 997507 997507 0 0.0
bss 120832 120832 0 0.0
rodata 114516 114516 0 0.0
text 673708 673708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890626 890626 0 0.0
bss 116448 116448 0 0.0
rodata 108964 108964 0 0.0
text 584484 584484 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 914019 914019 0 0.0
bss 118040 118040 0 0.0
rodata 104320 104320 0 0.0
text 614272 614272 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824070 824070 0 0.0
bss 114856 114856 0 0.0
rodata 97528 97528 0 0.0
text 531232 531232 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916883 916883 0 0.0
bss 117792 117792 0 0.0
rodata 104832 104832 0 0.0
text 616800 616800 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 912083 912083 0 0.0
bss 117816 117816 0 0.0
rodata 103936 103936 0 0.0
text 612856 612856 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2443168 2443168 0 0.0
.bss 116732 116732 0 0.0
.data 2584 2584 0 0.0
.text 1401432 1401432 0 0.0
light-app default (read/write) 2338664 2338664 0 0.0
.bss 104484 104484 0 0.0
.data 2408 2408 0 0.0
.text 1296928 1296928 0 0.0
lock-app default (read/write) 2304160 2304160 0 0.0
.bss 104228 104228 0 0.0
.data 2360 2360 0 0.0
.text 1262424 1262424 0 0.0
qpg lighting-app qpg6105+debug (read only) 570956 570956 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88640 88640 0 0.0
.data 1060 1060 0 0.0
.text 565636 565636 0 0.0
lock-app qpg6105+debug (read only) 517052 517052 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 992 992 0 0.0
.text 511732 511732 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845826 845826 0 0.0
bss 86440 86440 0 0.0
noinit 37160 37160 0 0.0
text 592564 592564 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jan 29, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is much nicer! Approved, with some nits.

src/controller/CHIPDeviceController.cpp Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Outdated Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Outdated Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Show resolved Hide resolved
This was referenced Feb 1, 2022
Closed
Closed
@restyled-io restyled-io bot mentioned this pull request Feb 2, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 2, 2022 •
edited
Loading

PR #14567: Size comparison from 4f391f1 to 81d9c06

Increases above 0.2%:

platform target config section 4f391f1 81d9c06 change % change
linux chip-tool-ipv6only arm64 (read only) 7093252 7140516 47264 0.7
.text 6102388 6148372 45984 0.8
Increases (1 build for linux)
platform target config section 4f391f1 81d9c06 change % change
linux chip-tool-ipv6only arm64 (read only) 7093252 7140516 47264 0.7
(read/write) 290977 291345 368 0.1
.data.rel.ro 186256 186600 344 0.2
.got 45232 45264 32 0.1
.rodata 390492 390796 304 0.1
.text 6102388 6148372 45984 0.8
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4f391f1 81d9c06 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577442 577442 0 0.0
.app_xip_area 484680 484680 0 0.0
.bss 75508 75508 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535078 535078 0 0.0
.app_xip_area 443884 443884 0 0.0
.bss 73980 73980 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559658 559658 0 0.0
.app_xip_area 459144 459144 0 0.0
.bss 82972 82972 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 843664 843664 0 0.0
(read/write) 125040 125040 0 0.0
.bss 123144 123144 0 0.0
.data 1892 1892 0 0.0
.text 843656 843656 0 0.0
BRD4161A+rpc (read only) 831032 831032 0 0.0
(read/write) 141696 141696 0 0.0
.bss 139704 139704 0 0.0
.data 1992 1992 0 0.0
.text 831024 831024 0 0.0
window-app BRD4161A (read only) 815908 815908 0 0.0
(read/write) 123668 123668 0 0.0
.bss 121820 121820 0 0.0
.data 1848 1848 0 0.0
.text 815900 815900 0 0.0
esp32 all-clusters-app c3devkit (read only) 933934 933934 0 0.0
(read/write) 1401466 1401466 0 0.0
.dram0.bss 70304 70304 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 198000 198000 0 0.0
.flash.text 933934 933934 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981987 981987 0 0.0
(read/write) 465824 465824 0 0.0
.dram0.bss 75064 75064 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224608 224608 0 0.0
.flash.text 976603 976603 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661652 661652 0 0.0
.bss 75204 75204 0 0.0
.data 1852 1852 0 0.0
.text 578796 578796 0 0.0
lock k32w061+release (read/write) 662820 662820 0 0.0
.bss 75524 75524 0 0.0
.data 1892 1892 0 0.0
.text 579604 579604 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7093252 7140516 47264 0.7
(read/write) 290977 291345 368 0.1
.bss 54577 54577 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186256 186600 344 0.2
.dynamic 560 560 0 0.0
.got 45232 45264 32 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 390492 390796 304 0.1
.text 6102388 6148372 45984 0.8
thermostat-no-ble arm64 (read only) 2086396 2086396 0 0.0
(read/write) 148817 148817 0 0.0
.bss 66129 66129 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74624 74624 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131004 131004 0 0.0
.text 1737664 1737664 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2385696 2385696 0 0.0
.bss 189220 189220 0 0.0
.data 5288 5288 0 0.0
.text 1348296 1348296 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338512 2338512 0 0.0
.bss 178144 178144 0 0.0
.data 5568 5568 0 0.0
.text 1301112 1301112 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302232 2302232 0 0.0
.bss 178024 178024 0 0.0
.data 5544 5544 0 0.0
.text 1264832 1264832 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292740 2292740 0 0.0
.bss 175308 175308 0 0.0
.data 5368 5368 0 0.0
.text 1255312 1255312 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980831 980831 0 0.0
bss 118512 118512 0 0.0
rodata 116532 116532 0 0.0
text 667988 667988 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 966391 966391 0 0.0
bss 115556 115556 0 0.0
rodata 108004 108004 0 0.0
text 664428 664428 0 0.0
nrf52840dongle_nrf52840 (read/write) 996915 996915 0 0.0
bss 119684 119684 0 0.0
rodata 115380 115380 0 0.0
text 673380 673380 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890046 890046 0 0.0
bss 115300 115300 0 0.0
rodata 109824 109824 0 0.0
text 584176 584176 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913079 913079 0 0.0
bss 116876 116876 0 0.0
rodata 104804 104804 0 0.0
text 614000 614000 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823114 823114 0 0.0
bss 113692 113692 0 0.0
rodata 98012 98012 0 0.0
text 530968 530968 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915863 915863 0 0.0
bss 116632 116632 0 0.0
rodata 105324 105324 0 0.0
text 616456 616456 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911039 911039 0 0.0
bss 116640 116640 0 0.0
rodata 104428 104428 0 0.0
text 612516 612516 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109772 109772 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2446768 2446768 0 0.0
.bss 117372 117372 0 0.0
.data 2576 2576 0 0.0
.text 1405032 1405032 0 0.0
light-app default (read/write) 2340368 2340368 0 0.0
.bss 103340 103340 0 0.0
.data 2400 2400 0 0.0
.text 1298632 1298632 0 0.0
lock-app default (read/write) 2305400 2305400 0 0.0
.bss 103060 103060 0 0.0
.data 2360 2360 0 0.0
.text 1263664 1263664 0 0.0
qpg lighting-app qpg6105+debug (read only) 571040 571040 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87488 87488 0 0.0
.data 1056 1056 0 0.0
.text 565720 565720 0 0.0
lock-app qpg6105+debug (read only) 516776 516776 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86928 86928 0 0.0
.data 992 992 0 0.0
.text 511456 511456 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845406 845406 0 0.0
bss 85540 85540 0 0.0
noinit 37160 37160 0 0.0
text 592178 592178 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 2, 2022 •
edited
Loading

PR #14567: Size comparison from 22f5d22 to 2342897

Increases above 0.2%:

platform target config section 22f5d22 2342897 change % change
linux chip-tool debug (read only) 7140509 7184517 44008 0.6
.data.rel.ro 145008 145352 344 0.2
.text 6365573 6408165 42592 0.7
chip-tool-ipv6only arm64 (read only) 7092068 7139300 47232 0.7
.text 6101124 6147060 45936 0.8
tv-app debug (read only) 2410617 2474657 64040 2.7
(read/write) 138640 139248 608 0.4
.data.rel.ro 72504 73080 576 0.8
.rodata 191788 192396 608 0.3
.text 2047346 2109410 62064 3.0
Increases (3 builds for linux)
platform target config section 22f5d22 2342897 change % change
linux chip-tool debug (read only) 7140509 7184517 44008 0.6
(read/write) 180872 181192 320 0.2
.data.rel.ro 145008 145352 344 0.2
.rodata 407445 408021 576 0.1
.text 6365573 6408165 42592 0.7
chip-tool-ipv6only arm64 (read only) 7092068 7139300 47232 0.7
(read/write) 283521 283889 368 0.1
.data.rel.ro 186304 186648 344 0.2
.got 45216 45248 32 0.1
.rodata 390476 390796 320 0.1
.text 6101124 6147060 45936 0.8
tv-app debug (read only) 2410617 2474657 64040 2.7
(read/write) 138640 139248 608 0.4
.bss 57024 57056 32 0.1
.data.rel.ro 72504 73080 576 0.8
.rodata 191788 192396 608 0.3
.text 2047346 2109410 62064 3.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 22f5d22 2342897 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 576874 576874 0 0.0
.app_xip_area 484368 484368 0 0.0
.bss 75252 75252 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 534634 534634 0 0.0
.app_xip_area 443696 443696 0 0.0
.bss 73724 73724 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559102 559102 0 0.0
.app_xip_area 458844 458844 0 0.0
.bss 82716 82716 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 843568 843568 0 0.0
(read/write) 124792 124792 0 0.0
.bss 122896 122896 0 0.0
.data 1892 1892 0 0.0
.text 843560 843560 0 0.0
BRD4161A+rpc (read only) 830920 830920 0 0.0
(read/write) 141448 141448 0 0.0
.bss 139456 139456 0 0.0
.data 1992 1992 0 0.0
.text 830912 830912 0 0.0
window-app BRD4161A (read only) 815796 815796 0 0.0
(read/write) 123412 123412 0 0.0
.bss 121564 121564 0 0.0
.data 1848 1848 0 0.0
.text 815788 815788 0 0.0
esp32 all-clusters-app c3devkit (read only) 934044 934044 0 0.0
(read/write) 1400954 1400954 0 0.0
.dram0.bss 70048 70048 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 197744 197744 0 0.0
.flash.text 934044 934044 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982083 982083 0 0.0
(read/write) 465320 465320 0 0.0
.dram0.bss 74808 74808 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224360 224360 0 0.0
.flash.text 976699 976699 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661112 661112 0 0.0
.bss 74948 74948 0 0.0
.data 1852 1852 0 0.0
.text 578512 578512 0 0.0
lock k32w061+release (read/write) 662388 662388 0 0.0
.bss 75268 75268 0 0.0
.data 1892 1892 0 0.0
.text 579428 579428 0 0.0
linux all-clusters-app debug (read only) 2306625 2306625 0 0.0
(read/write) 139744 139744 0 0.0
.bss 54464 54464 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 203973 203973 0 0.0
.text 1940674 1940674 0 0.0
bridge-app debug+rpc (read only) 1634181 1634181 0 0.0
(read/write) 80424 80424 0 0.0
.bss 35904 35904 0 0.0
.data 1922 1922 0 0.0
.data.rel.ro 37440 37440 0 0.0
.dynamic 592 592 0 0.0
.got 3968 3968 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 137556 137556 0 0.0
.text 1381557 1381557 0 0.0
chip-tool debug (read only) 7140509 7184517 44008 0.6
(read/write) 180872 181192 320 0.2
.bss 28776 28776 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 145008 145352 344 0.2
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 600 600 0 0.0
.rodata 407445 408021 576 0.1
.text 6365573 6408165 42592 0.7
chip-tool-ipv6only arm64 (read only) 7092068 7139300 47232 0.7
(read/write) 283521 283889 368 0.1
.bss 47089 47089 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186304 186648 344 0.2
.dynamic 560 560 0 0.0
.got 45216 45248 32 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 390476 390796 320 0.1
.text 6101124 6147060 45936 0.8
door-lock-app debug (read only) 1855417 1855417 0 0.0
(read/write) 110304 110304 0 0.0
.bss 42080 42080 0 0.0
.data 962 962 0 0.0
.data.rel.ro 61856 61856 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170876 170876 0 0.0
.text 1536498 1536498 0 0.0
lighting-app debug+rpc (read only) 1956801 1956801 0 0.0
(read/write) 115424 115424 0 0.0
.bss 43032 43032 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 65504 65504 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 160913 160913 0 0.0
.text 1641490 1641490 0 0.0
ota-provider-app debug (read only) 1637873 1637873 0 0.0
(read/write) 79912 79912 0 0.0
.bss 40960 40960 0 0.0
.data 1064 1064 0 0.0
.data.rel.ro 32376 32376 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 148422 148422 0 0.0
.text 1372034 1372034 0 0.0
ota-requestor-app debug (read only) 1643449 1643449 0 0.0
(read/write) 82896 82896 0 0.0
.bss 42272 42272 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 34248 34248 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 143799 143799 0 0.0
.text 1383410 1383410 0 0.0
shell debug (read only) 2280929 2280929 0 0.0
(read/write) 141104 141104 0 0.0
.bss 61760 61760 0 0.0
.data 768 768 0 0.0
.data.rel.ro 72896 72896 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 204754 204754 0 0.0
.text 1920130 1920130 0 0.0
thermostat-no-ble arm64 (read only) 2090044 2090044 0 0.0
(read/write) 140273 140273 0 0.0
.bss 57585 57585 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74624 74624 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130716 130716 0 0.0
.text 1741616 1741616 0 0.0
tv-app debug (read only) 2410617 2474657 64040 2.7
(read/write) 138640 139248 608 0.4
.bss 57024 57056 32 0.1
.data 3104 3104 0 0.0
.data.rel.ro 72504 73080 576 0.8
.dynamic 592 592 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 191788 192396 608 0.3
.text 2047346 2109410 62064 3.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2385568 2385568 0 0.0
.bss 188964 188964 0 0.0
.data 5288 5288 0 0.0
.text 1348168 1348168 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338256 2338256 0 0.0
.bss 177888 177888 0 0.0
.data 5568 5568 0 0.0
.text 1300856 1300856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302040 2302040 0 0.0
.bss 177776 177776 0 0.0
.data 5544 5544 0 0.0
.text 1264640 1264640 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292484 2292484 0 0.0
.bss 175052 175052 0 0.0
.data 5368 5368 0 0.0
.text 1255056 1255056 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980291 980291 0 0.0
bss 118260 118260 0 0.0
rodata 116280 116280 0 0.0
text 667968 667968 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 965867 965867 0 0.0
bss 115304 115304 0 0.0
rodata 107752 107752 0 0.0
text 664408 664408 0 0.0
nrf52840dongle_nrf52840 (read/write) 996387 996387 0 0.0
bss 119432 119432 0 0.0
rodata 115124 115124 0 0.0
text 673360 673360 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 889522 889522 0 0.0
bss 115044 115044 0 0.0
rodata 109572 109572 0 0.0
text 584156 584156 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912667 912667 0 0.0
bss 116620 116620 0 0.0
rodata 104552 104552 0 0.0
text 614096 614096 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822698 822698 0 0.0
bss 113440 113440 0 0.0
rodata 97756 97756 0 0.0
text 531064 531064 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915335 915335 0 0.0
bss 116380 116380 0 0.0
rodata 105068 105068 0 0.0
text 616436 616436 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910543 910543 0 0.0
bss 116388 116388 0 0.0
rodata 104172 104172 0 0.0
text 612496 612496 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798363 798363 0 0.0
bss 109772 109772 0 0.0
rodata 78352 78352 0 0.0
text 533732 533732 0 0.0
p6 all-clusters-app default (read/write) 2446672 2446672 0 0.0
.bss 117116 117116 0 0.0
.data 2576 2576 0 0.0
.text 1404936 1404936 0 0.0
light-app default (read/write) 2340256 2340256 0 0.0
.bss 103084 103084 0 0.0
.data 2400 2400 0 0.0
.text 1298520 1298520 0 0.0
lock-app default (read/write) 2305304 2305304 0 0.0
.bss 102804 102804 0 0.0
.data 2360 2360 0 0.0
.text 1263568 1263568 0 0.0
qpg lighting-app qpg6105+debug (read only) 570760 570760 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 1056 1056 0 0.0
.text 565440 565440 0 0.0
lock-app qpg6105+debug (read only) 516600 516600 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86680 86680 0 0.0
.data 992 992 0 0.0
.text 511280 511280 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 844862 844862 0 0.0
bss 85288 85288 0 0.0
noinit 37160 37160 0 0.0
text 592146 592146 0 0.0

@cecille cecille mentioned this pull request Feb 2, 2022
Open
@cecille cecille merged commit 1ee9366 into project-chip:master Feb 3, 2022
@cecille cecille deleted the descriptor_cluster_im_shenanigans branch February 3, 2022 14:51
cecille added a commit to cecille/connectedhomeip that referenced this pull request Feb 3, 2022
@cecille
Address nits from project-chip#14567
bcf0c71
bzbarsky-apple pushed a commit that referenced this pull request Feb 4, 2022
@cecille
Check VID/PID when doing device attestation (#14551)
a7d7d8d 
* Pass VID/PID to DAC.

* Address nits from #14567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cecille @msandstedt @mrjerryjohns @bzbarsky-apple @Damian-Nordic @jmeg-sfy @restyled-commits