Remove uses of "pragma message" for unsuppressable warnings #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling IPEndPointBasis.cpp generates unsuppressable output when certain lwIP options are disabled. If disabling these options is legal, then merely compiling shouldn't print out an objection to them. I disabling them is not legal, then the lwIP configs for the examples should be corrected. Fixes project-chip#1444
mspang
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
andy31415
approved these changes
Jul 6, 2020
gerickson
suggested changes
Jul 6, 2020
woody-apple
approved these changes
Jul 6, 2020
The description suggests one: enable these in the examples (and probably turn it into an #warning in that case if we really don't intend to allow this combination). If we intend to allow it and still want to give a hint we could handle it via documentation, or alternatively add another #define like CHIP_SUPPRESS_CONFIG_RECOMMENDATIONS so there's an opt out. Currently it is impossible to make the examples build clean of diagnostic messages and the goal is mainly to make it possible. |
BroderickCarlin
approved these changes
Jul 6, 2020
gerickson
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling this file generates unsuppressable output when certain lwIP
options are disabled. If these configurations are legal, then merely
compiling shouldn't print out an objection to them. If they are truly
not intended to be used, the lwIP configs for the examples should be
corrected.
Fixes #1444