Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SED] Take SED polling intervals into account in all MRP contexts #14417

Merged
merged 1 commit into from
Feb 3, 2022
Merged

[SED] Take SED polling intervals into account in all MRP contexts #14417

merged 1 commit into from
Feb 3, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

Currently, only DNS-SD code takes SED polling intervals into account when advertising CRA and CRI records. PASE and CASE sessions and other contexts, on the other hand, always use the default MRP configuration.

Change overview

Add a function for determining the current local MRP config and use it in all necessary contexts.

Testing

Tested manually using nRF Connect-based SED (AFAIK there's currently no way to test SED on Linux)

@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #14417: Size comparison from 63d0c37 to 2b942c0

Increases (23 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 63d0c37 2b942c0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580918 581062 144 0.0
.app_xip_area 485716 485860 144 0.0
lock-app CYW30739 (read/write) 538922 539078 156 0.0
.app_xip_area 445264 445412 148 0.0
.bss 76444 76452 8 0.0
efr32 window-app BRD4161A (read/write) 126148 126152 4 0.0
.bss 124292 124300 8 0.0
esp32 all-clusters-app c3devkit (read only) 934132 934150 18 0.0
.dram0.bss 70984 70992 8 0.0
.flash.text 934132 934150 18 0.0
m5stack (read only) 981551 981611 60 0.0
(read/write) 465528 465532 4 0.0
.dram0.bss 75728 75736 8 0.0
.flash.text 976167 976227 60 0.0
k32w light k32w061+release (read/write) 665716 665848 132 0.0
.text 580324 580460 136 0.0
lock k32w061+release (read/write) 666668 666824 156 0.0
.bss 77988 77996 8 0.0
.text 580988 581140 152 0.0
linux chip-tool-ipv6only arm64 (read/write) 279025 279041 16 0.0
.bss 55537 55553 16 0.0
.got 42744 42752 8 0.0
thermostat-no-ble arm64 (read only) 2084468 2084612 144 0.0
.got 4144 4152 8 0.2
.text 1735136 1735280 144 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 984183 984347 164 0.0
bss 120956 120960 4 0.0
rodata 116492 116560 68 0.1
text 668944 669040 96 0.0
nrf52840dk_nrf52840+rpc (read/write) 968047 968211 164 0.0
bss 118000 118004 4 0.0
rodata 108028 108096 68 0.1
text 663616 663712 96 0.0
nrf52840dongle_nrf52840 (read/write) 1000303 1000467 164 0.0
bss 122128 122132 4 0.0
rodata 115344 115412 68 0.1
text 674372 674468 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 893406 893554 148 0.0
bss 117744 117748 4 0.0
rodata 109792 109860 68 0.1
text 585124 585216 92 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916799 916963 164 0.0
bss 119336 119340 4 0.0
rodata 105132 105200 68 0.1
text 614928 615024 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826834 826982 148 0.0
bss 116152 116156 4 0.0
rodata 98356 98424 68 0.1
text 531880 531972 92 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919663 919827 164 0.0
bss 119088 119092 4 0.0
rodata 105644 105712 68 0.1
text 617464 617560 96 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914847 915011 164 0.0
bss 119112 119116 4 0.0
rodata 104748 104816 68 0.1
text 613500 613596 96 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798287 84 0.0
bss 109776 109780 4 0.0
rodata 78288 78324 36 0.0
text 533640 533688 48 0.0
p6 all-clusters-app default .bss 118036 118044 8 0.0
light-app default .bss 105780 105788 8 0.0
qpg lighting-app qpg6105+debug (read only) 572424 572568 144 0.0
(read/write) 146936 146940 4 0.0
.bss 89936 89944 8 0.0
.text 567104 567248 144 0.0
lock-app qpg6105+debug (read only) 518552 518688 136 0.0
.bss 89408 89416 8 0.0
.text 513232 513368 136 0.0
telink lighting-app tlsr9518adk80d (read/write) 848690 848838 148 0.0
bss 87736 87744 8 0.0
text 593356 593434 78 0.0
Decreases (13 builds for efr32, esp32, k32w, linux, p6, qpg)
platform target config section 63d0c37 2b942c0 change % change
efr32 lighting-app BRD4161A (read only) 844508 844492 -16 -0.0
(read/write) 127492 127488 -4 -0.0
.data 1900 1896 -4 -0.2
.text 844500 844484 -16 -0.0
BRD4161A+rpc (read only) 831880 831864 -16 -0.0
.data 2000 1996 -4 -0.2
.text 831872 831856 -16 -0.0
window-app BRD4161A (read only) 817124 817092 -32 -0.0
.data 1856 1852 -4 -0.2
.text 817116 817084 -32 -0.0
esp32 all-clusters-app c3devkit (read/write) 1398698 1398690 -8 -0.0
.flash.rodata 194552 194544 -8 -0.0
m5stack .flash.rodata 223648 223644 -4 -0.0
k32w light k32w061+release .data 1868 1864 -4 -0.2
lock k32w061+release .data 1892 1888 -4 -0.2
linux chip-tool-ipv6only arm64 (read only) 6744396 6744380 -16 -0.0
.init_array 200 192 -8 -4.0
.text 5785492 5785476 -16 -0.0
thermostat-no-ble arm64 .init_array 336 328 -8 -2.4
p6 all-clusters-app default .data 2584 2576 -8 -0.3
light-app default .data 2408 2400 -8 -0.3
qpg lighting-app qpg6105+debug .data 1060 1056 -4 -0.4
lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.data 992 988 -4 -0.4
Full report (28 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 63d0c37 2b942c0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580918 581062 144 0.0
.app_xip_area 485716 485860 144 0.0
.bss 77948 77948 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 538922 539078 156 0.0
.app_xip_area 445264 445412 148 0.0
.bss 76444 76452 8 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 844508 844492 -16 -0.0
(read/write) 127492 127488 -4 -0.0
.bss 125592 125592 0 0.0
.data 1900 1896 -4 -0.2
.text 844500 844484 -16 -0.0
BRD4161A+rpc (read only) 831880 831864 -16 -0.0
(read/write) 144152 144152 0 0.0
.bss 142152 142152 0 0.0
.data 2000 1996 -4 -0.2
.text 831872 831856 -16 -0.0
window-app BRD4161A (read only) 817124 817092 -32 -0.0
(read/write) 126148 126152 4 0.0
.bss 124292 124300 8 0.0
.data 1856 1852 -4 -0.2
.text 817116 817084 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 934132 934150 18 0.0
(read/write) 1398698 1398690 -8 -0.0
.dram0.bss 70984 70992 8 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 194552 194544 -8 -0.0
.flash.text 934132 934150 18 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981551 981611 60 0.0
(read/write) 465528 465532 4 0.0
.dram0.bss 75728 75736 8 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 223648 223644 -4 -0.0
.flash.text 976167 976227 60 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665716 665848 132 0.0
.bss 77724 77724 0 0.0
.data 1868 1864 -4 -0.2
.text 580324 580460 136 0.0
lock k32w061+release (read/write) 666668 666824 156 0.0
.bss 77988 77996 8 0.0
.data 1892 1888 -4 -0.2
.text 580988 581140 152 0.0
linux chip-tool-ipv6only arm64 (read only) 6744396 6744380 -16 -0.0
(read/write) 279025 279041 16 0.0
.bss 55537 55553 16 0.0
.data 1128 1128 0 0.0
.data.rel.ro 175864 175864 0 0.0
.dynamic 560 560 0 0.0
.got 42744 42752 8 0.0
.init 24 24 0 0.0
.init_array 200 192 -8 -4.0
.rodata 387684 387684 0 0.0
.text 5785492 5785476 -16 -0.0
thermostat-no-ble arm64 (read only) 2084468 2084612 144 0.0
(read/write) 152097 152097 0 0.0
.bss 69761 69761 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74256 74256 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4152 8 0.2
.init 24 24 0 0.0
.init_array 336 328 -8 -2.4
.rodata 131940 131940 0 0.0
.text 1735136 1735280 144 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 984183 984347 164 0.0
bss 120956 120960 4 0.0
rodata 116492 116560 68 0.1
text 668944 669040 96 0.0
nrf52840dk_nrf52840+rpc (read/write) 968047 968211 164 0.0
bss 118000 118004 4 0.0
rodata 108028 108096 68 0.1
text 663616 663712 96 0.0
nrf52840dongle_nrf52840 (read/write) 1000303 1000467 164 0.0
bss 122128 122132 4 0.0
rodata 115344 115412 68 0.1
text 674372 674468 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 893406 893554 148 0.0
bss 117744 117748 4 0.0
rodata 109792 109860 68 0.1
text 585124 585216 92 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916799 916963 164 0.0
bss 119336 119340 4 0.0
rodata 105132 105200 68 0.1
text 614928 615024 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826834 826982 148 0.0
bss 116152 116156 4 0.0
rodata 98356 98424 68 0.1
text 531880 531972 92 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919663 919827 164 0.0
bss 119088 119092 4 0.0
rodata 105644 105712 68 0.1
text 617464 617560 96 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914847 915011 164 0.0
bss 119112 119116 4 0.0
rodata 104748 104816 68 0.1
text 613500 613596 96 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798287 84 0.0
bss 109776 109780 4 0.0
rodata 78288 78324 36 0.0
text 533640 533688 48 0.0
p6 all-clusters-app default (read/write) 2443448 2443448 0 0.0
.bss 118036 118044 8 0.0
.data 2584 2576 -8 -0.3
.text 1401712 1401712 0 0.0
light-app default (read/write) 2340096 2340096 0 0.0
.bss 105780 105788 8 0.0
.data 2408 2400 -8 -0.3
.text 1298360 1298360 0 0.0
lock-app default (read/write) 2305600 2305600 0 0.0
.bss 105524 105524 0 0.0
.data 2360 2360 0 0.0
.text 1263864 1263864 0 0.0
qpg lighting-app qpg6105+debug (read only) 572424 572568 144 0.0
(read/write) 146936 146940 4 0.0
.bss 89936 89944 8 0.0
.data 1060 1056 -4 -0.4
.text 567104 567248 144 0.0
lock-app qpg6105+debug (read only) 518552 518688 136 0.0
(read/write) 146940 146936 -4 -0.0
.bss 89408 89416 8 0.0
.data 992 988 -4 -0.4
.text 513232 513368 136 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848690 848838 148 0.0
bss 87736 87744 8 0.0
noinit 37160 37160 0 0.0
text 593356 593434 78 0.0

@github-actions
Copy link

github-actions bot commented Feb 1, 2022 •
edited
Loading

PR #14417: Size comparison from bebbd74 to 218e866

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bebbd74 218e866 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577146 577366 220 0.0
.app_xip_area 484352 484572 220 0.0
lock-app CYW30739 (read/write) 535142 535370 228 0.0
.app_xip_area 443924 444144 220 0.0
.bss 74004 74012 8 0.0
efr32 window-app BRD4161A (read/write) 123704 123708 4 0.0
.bss 121852 121860 8 0.0
esp32 all-clusters-app c3devkit (read only) 934322 934360 38 0.0
(read/write) 1398290 1398346 56 0.0
.dram0.bss 68984 68992 8 0.0
.flash.rodata 196136 196192 56 0.0
.flash.text 934322 934360 38 0.0
m5stack (read only) 982339 982439 100 0.0
(read/write) 462636 462704 68 0.0
.dram0.bss 73744 73752 8 0.0
.flash.rodata 222740 222800 60 0.0
.flash.text 976955 977055 100 0.0
k32w light k32w061+release (read/write) 661876 662088 212 0.0
.text 578992 579208 216 0.0
lock k32w061+release (read/write) 662888 663124 236 0.0
.bss 75548 75556 8 0.0
.text 579644 579876 232 0.0
linux chip-tool-ipv6only arm64 .got 45192 45200 8 0.0
thermostat-no-ble arm64 (read only) 2087388 2087548 160 0.0
.got 4136 4144 8 0.2
.text 1739280 1739440 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2384256 2384512 256 0.0
.text 1346856 1347112 256 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338168 2338424 256 0.0
.text 1300768 1301024 256 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302208 2302472 264 0.0
.bss 178056 178064 8 0.0
.text 1264808 1265072 264 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2292876 2293140 264 0.0
.text 1255448 1255712 264 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980539 980779 240 0.0
bss 118544 118548 4 0.0
rodata 115840 115968 128 0.1
text 668364 668472 108 0.0
nrf52840dk_nrf52840+rpc (read/write) 966115 966355 240 0.0
bss 115588 115592 4 0.0
rodata 107312 107440 128 0.1
text 664808 664916 108 0.0
nrf52840dongle_nrf52840 (read/write) 996623 996847 224 0.0
bss 119716 119720 4 0.0
rodata 114672 114800 128 0.1
text 673756 673864 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 889754 889978 224 0.0
bss 115332 115336 4 0.0
rodata 109116 109244 128 0.1
text 584560 584664 104 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913151 913391 240 0.0
bss 116904 116908 4 0.0
rodata 104476 104604 128 0.1
text 614368 614476 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823186 823426 240 0.0
bss 113720 113724 4 0.0
rodata 97684 97812 128 0.1
text 531344 531448 104 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916011 916235 224 0.0
bss 116660 116664 4 0.0
rodata 104992 105120 128 0.1
text 616892 617000 108 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911171 911411 240 0.0
bss 116668 116672 4 0.0
rodata 104096 104224 128 0.1
text 612940 613048 108 0.0
shell nrf52840dk_nrf52840 (read/write) 798395 798463 68 0.0
bss 109776 109780 4 0.0
rodata 78352 78388 36 0.0
text 533760 533808 48 0.0
p6 all-clusters-app default .bss 116044 116052 8 0.0
light-app default .bss 103364 103372 8 0.0
qpg lighting-app qpg6105+debug (read only) 570700 570920 220 0.0
(read/write) 146936 146940 4 0.0
.bss 87520 87528 8 0.0
.text 565380 565600 220 0.0
lock-app qpg6105+debug (read only) 516816 517024 208 0.0
(read/write) 146936 146940 4 0.0
.bss 86960 86968 8 0.0
.text 511496 511704 208 0.0
telink lighting-app tlsr9518adk80d (read/write) 845134 845374 240 0.0
bss 85568 85576 8 0.0
text 592564 592662 98 0.0
Decreases (13 builds for efr32, k32w, linux, mbed, p6, qpg)
platform target config section bebbd74 218e866 change % change
efr32 lighting-app BRD4161A (read only) 843616 843584 -32 -0.0
.data 1896 1892 -4 -0.2
.text 843608 843576 -32 -0.0
BRD4161A+rpc (read only) 830984 830952 -32 -0.0
(read/write) 141736 141728 -8 -0.0
.data 1996 1992 -4 -0.2
.text 830976 830944 -32 -0.0
window-app BRD4161A (read only) 816164 816132 -32 -0.0
.data 1852 1848 -4 -0.2
.text 816156 816124 -32 -0.0
k32w light k32w061+release .data 1856 1852 -4 -0.2
lock k32w061+release .data 1896 1892 -4 -0.2
linux chip-tool-ipv6only arm64 .init_array 184 176 -8 -4.3
thermostat-no-ble arm64 .init_array 344 336 -8 -2.3
mbed lock-app CY8CPROTO_062_4343W+release .data 5552 5544 -8 -0.1
p6 all-clusters-app default (read/write) 2445640 2445592 -48 -0.0
.text 1403904 1403856 -48 -0.0
light-app default (read/write) 2340320 2340272 -48 -0.0
.data 2408 2400 -8 -0.3
.text 1298584 1298536 -48 -0.0
lock-app default (read/write) 2305728 2305680 -48 -0.0
.data 2368 2360 -8 -0.3
.text 1263992 1263944 -48 -0.0
qpg lighting-app qpg6105+debug .data 1060 1056 -4 -0.4
lock-app qpg6105+debug .data 996 992 -4 -0.4
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bebbd74 218e866 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577146 577366 220 0.0
.app_xip_area 484352 484572 220 0.0
.bss 75540 75540 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 535142 535370 228 0.0
.app_xip_area 443924 444144 220 0.0
.bss 74004 74012 8 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843616 843584 -32 -0.0
(read/write) 125072 125072 0 0.0
.bss 123176 123176 0 0.0
.data 1896 1892 -4 -0.2
.text 843608 843576 -32 -0.0
BRD4161A+rpc (read only) 830984 830952 -32 -0.0
(read/write) 141736 141728 -8 -0.0
.bss 139736 139736 0 0.0
.data 1996 1992 -4 -0.2
.text 830976 830944 -32 -0.0
window-app BRD4161A (read only) 816164 816132 -32 -0.0
(read/write) 123704 123708 4 0.0
.bss 121852 121860 8 0.0
.data 1852 1848 -4 -0.2
.text 816156 816124 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 934322 934360 38 0.0
(read/write) 1398290 1398346 56 0.0
.dram0.bss 68984 68992 8 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 196136 196192 56 0.0
.flash.text 934322 934360 38 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982339 982439 100 0.0
(read/write) 462636 462704 68 0.0
.dram0.bss 73744 73752 8 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222740 222800 60 0.0
.flash.text 976955 977055 100 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661876 662088 212 0.0
.bss 75228 75228 0 0.0
.data 1856 1852 -4 -0.2
.text 578992 579208 216 0.0
lock k32w061+release (read/write) 662888 663124 236 0.0
.bss 75548 75556 8 0.0
.data 1896 1892 -4 -0.2
.text 579644 579876 232 0.0
linux chip-tool-ipv6only arm64 (read only) 7031380 7031380 0 0.0
(read/write) 289697 289697 0 0.0
.bss 54593 54593 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 185000 185000 0 0.0
.dynamic 560 560 0 0.0
.got 45192 45200 8 0.0
.init 24 24 0 0.0
.init_array 184 176 -8 -4.3
.rodata 387772 387772 0 0.0
.text 6045108 6045108 0 0.0
thermostat-no-ble arm64 (read only) 2087388 2087548 160 0.0
(read/write) 148529 148529 0 0.0
.bss 66209 66209 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74248 74248 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4144 8 0.2
.init 24 24 0 0.0
.init_array 344 336 -8 -2.3
.rodata 130780 130780 0 0.0
.text 1739280 1739440 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2384256 2384512 256 0.0
.bss 187900 187900 0 0.0
.data 5288 5288 0 0.0
.text 1346856 1347112 256 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338168 2338424 256 0.0
.bss 178176 178176 0 0.0
.data 5568 5568 0 0.0
.text 1300768 1301024 256 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302208 2302472 264 0.0
.bss 178056 178064 8 0.0
.data 5552 5544 -8 -0.1
.text 1264808 1265072 264 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292876 2293140 264 0.0
.bss 175332 175332 0 0.0
.data 5368 5368 0 0.0
.text 1255448 1255712 264 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980539 980779 240 0.0
bss 118544 118548 4 0.0
rodata 115840 115968 128 0.1
text 668364 668472 108 0.0
nrf52840dk_nrf52840+rpc (read/write) 966115 966355 240 0.0
bss 115588 115592 4 0.0
rodata 107312 107440 128 0.1
text 664808 664916 108 0.0
nrf52840dongle_nrf52840 (read/write) 996623 996847 224 0.0
bss 119716 119720 4 0.0
rodata 114672 114800 128 0.1
text 673756 673864 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 889754 889978 224 0.0
bss 115332 115336 4 0.0
rodata 109116 109244 128 0.1
text 584560 584664 104 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913151 913391 240 0.0
bss 116904 116908 4 0.0
rodata 104476 104604 128 0.1
text 614368 614476 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823186 823426 240 0.0
bss 113720 113724 4 0.0
rodata 97684 97812 128 0.1
text 531344 531448 104 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916011 916235 224 0.0
bss 116660 116664 4 0.0
rodata 104992 105120 128 0.1
text 616892 617000 108 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911171 911411 240 0.0
bss 116668 116672 4 0.0
rodata 104096 104224 128 0.1
text 612940 613048 108 0.0
shell nrf52840dk_nrf52840 (read/write) 798395 798463 68 0.0
bss 109776 109780 4 0.0
rodata 78352 78388 36 0.0
text 533760 533808 48 0.0
p6 all-clusters-app default (read/write) 2445640 2445592 -48 -0.0
.bss 116044 116052 8 0.0
.data 2576 2576 0 0.0
.text 1403904 1403856 -48 -0.0
light-app default (read/write) 2340320 2340272 -48 -0.0
.bss 103364 103372 8 0.0
.data 2408 2400 -8 -0.3
.text 1298584 1298536 -48 -0.0
lock-app default (read/write) 2305728 2305680 -48 -0.0
.bss 103084 103084 0 0.0
.data 2368 2360 -8 -0.3
.text 1263992 1263944 -48 -0.0
qpg lighting-app qpg6105+debug (read only) 570700 570920 220 0.0
(read/write) 146936 146940 4 0.0
.bss 87520 87528 8 0.0
.data 1060 1056 -4 -0.4
.text 565380 565600 220 0.0
lock-app qpg6105+debug (read only) 516816 517024 208 0.0
(read/write) 146936 146940 4 0.0
.bss 86960 86968 8 0.0
.data 996 992 -4 -0.4
.text 511496 511704 208 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845134 845374 240 0.0
bss 85568 85576 8 0.0
noinit 37160 37160 0 0.0
text 592564 592662 98 0.0

@Damian-Nordic
[SED] Take SED polling intervals into account in all MRP contexts
ba9c4ca 
Currently, only DNS-SD code takes SED polling intervals
into account when advertising CRA and CRI records. PASE
and CASE sessions and other contexts, on the other hand,
always use the default MRP configuration. Add a function
for determining the current local MRP config and use it
in all necessary contexts.
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

PR #14417: Size comparison from 63a5c52 to ba9c4ca

Increases (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 63a5c52 ba9c4ca change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577526 577746 220 0.0
.app_xip_area 484756 484976 220 0.0
lock cyw930739m2evb_01 (read/write) 535150 535370 220 0.0
.app_xip_area 443948 444168 220 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559706 559930 224 0.0
.app_xip_area 459192 459416 224 0.0
efr32 window-app BRD4161A (read/write) 123684 123688 4 0.0
.bss 121836 121844 8 0.0
esp32 all-clusters-app c3devkit (read only) 934022 934060 38 0.0
(read/write) 1401482 1401554 72 0.0
.dram0.bss 70320 70328 8 0.0
.flash.rodata 198000 198056 56 0.0
.flash.text 934022 934060 38 0.0
m5stack (read only) 982071 982171 100 0.0
(read/write) 465832 465900 68 0.0
.dram0.bss 75072 75080 8 0.0
.flash.rodata 224608 224668 60 0.0
.flash.text 976687 976787 100 0.0
k32w light k32w061+release (read/write) 661708 661920 212 0.0
.text 578844 579060 216 0.0
lock k32w061+release (read/write) 662892 663128 236 0.0
.bss 75532 75540 8 0.0
.text 579668 579900 232 0.0
linux chip-tool-ipv6only arm64 (read only) 7088532 7088548 16 0.0
(read/write) 290881 290897 16 0.0
.bss 54577 54593 16 0.0
.got 45232 45240 8 0.0
.text 6097780 6097796 16 0.0
thermostat-no-ble arm64 (read only) 2086380 2086540 160 0.0
(read/write) 148865 148881 16 0.0
.bss 66177 66193 16 0.0
.got 4136 4144 8 0.2
.text 1737648 1737808 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2385832 2386024 192 0.0
.text 1348432 1348624 192 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338640 2338840 200 0.0
.text 1301240 1301440 200 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302296 2302560 264 0.0
.bss 178032 178040 8 0.0
.text 1264896 1265160 264 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2292804 2293060 256 0.0
.text 1255376 1255632 256 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980927 981151 224 0.0
bss 118524 118528 4 0.0
rodata 116548 116676 128 0.1
text 668068 668176 108 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913143 913383 240 0.0
bss 116884 116888 4 0.0
rodata 104804 104932 128 0.1
text 614068 614176 108 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915927 916199 272 0.0
bss 116640 116644 4 0.0
rodata 105324 105452 128 0.1
text 616524 616632 108 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911135 911375 240 0.0
bss 116648 116652 4 0.0
rodata 104428 104556 128 0.1
text 612576 612684 108 0.0
shell nrf52840dk_nrf52840 (read/write) 798379 798463 84 0.0
bss 109772 109776 4 0.0
rodata 78352 78388 36 0.0
text 533752 533800 48 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 966487 966727 240 0.0
bss 115568 115572 4 0.0
rodata 108020 108148 128 0.1
text 664508 664616 108 0.0
nrf52840dongle_nrf52840 (read/write) 996995 997219 224 0.0
bss 119696 119700 4 0.0
rodata 115380 115508 128 0.1
text 673460 673568 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890126 890350 224 0.0
bss 115312 115316 4 0.0
rodata 109824 109952 128 0.1
text 584256 584360 104 0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 823210 823434 224 0.0
bss 113700 113704 4 0.0
rodata 98012 98140 128 0.1
text 531040 531144 104 0.0
p6 all-clusters-app default .bss 117388 117396 8 0.0
light-app default .bss 103348 103356 8 0.0
qpg lighting-app qpg6105+debug (read only) 571104 571332 228 0.0
.bss 87496 87504 8 0.0
.text 565784 566012 228 0.0
lock-app qpg6105+debug (read only) 516840 517056 216 0.0
.bss 86936 86944 8 0.0
.text 511520 511736 216 0.0
telink lighting-app tlsr9518adk80d (read/write) 845494 845734 240 0.0
bss 85552 85560 8 0.0
text 592264 592362 98 0.0
Decreases (15 builds for efr32, k32w, linux, mbed, p6, qpg)
platform target config section 63a5c52 ba9c4ca change % change
efr32 lighting-app BRD4161A (read only) 843824 843808 -16 -0.0
(read/write) 125056 125048 -8 -0.0
.data 1892 1888 -4 -0.2
.text 843816 843800 -16 -0.0
window-app BRD4161A (read only) 816076 816044 -32 -0.0
.data 1848 1844 -4 -0.2
.text 816068 816036 -32 -0.0
lighting-app BRD4161A+rpc (read only) 831200 831184 -16 -0.0
.data 1992 1988 -4 -0.2
.text 831192 831176 -16 -0.0
k32w light k32w061+release .data 1852 1848 -4 -0.2
lock k32w061+release .data 1892 1888 -4 -0.2
linux chip-tool-ipv6only arm64 .init_array 184 176 -8 -4.3
thermostat-no-ble arm64 .init_array 336 328 -8 -2.4
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5288 5280 -8 -0.2
lighting-app CY8CPROTO_062_4343W+release .data 5568 5560 -8 -0.1
shell CY8CPROTO_062_4343W+release .data 5368 5360 -8 -0.1
p6 all-clusters-app default (read/write) 2446944 2446896 -48 -0.0
.data 2576 2568 -8 -0.3
.text 1405208 1405160 -48 -0.0
light-app default (read/write) 2340536 2340488 -48 -0.0
.text 1298800 1298752 -48 -0.0
lock-app default (read/write) 2305560 2305528 -32 -0.0
.text 1263824 1263792 -32 -0.0
qpg lighting-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.data 1056 1052 -4 -0.4
lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.data 992 988 -4 -0.4
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 63a5c52 ba9c4ca change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577526 577746 220 0.0
.app_xip_area 484756 484976 220 0.0
.bss 75516 75516 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535150 535370 220 0.0
.app_xip_area 443948 444168 220 0.0
.bss 73988 73988 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559706 559930 224 0.0
.app_xip_area 459192 459416 224 0.0
.bss 82972 82972 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 843824 843808 -16 -0.0
(read/write) 125056 125048 -8 -0.0
.bss 123160 123160 0 0.0
.data 1892 1888 -4 -0.2
.text 843816 843800 -16 -0.0
window-app BRD4161A (read only) 816076 816044 -32 -0.0
(read/write) 123684 123688 4 0.0
.bss 121836 121844 8 0.0
.data 1848 1844 -4 -0.2
.text 816068 816036 -32 -0.0
lighting-app BRD4161A+rpc (read only) 831200 831184 -16 -0.0
(read/write) 141712 141712 0 0.0
.bss 139720 139720 0 0.0
.data 1992 1988 -4 -0.2
.text 831192 831176 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 934022 934060 38 0.0
(read/write) 1401482 1401554 72 0.0
.dram0.bss 70320 70328 8 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 198000 198056 56 0.0
.flash.text 934022 934060 38 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982071 982171 100 0.0
(read/write) 465832 465900 68 0.0
.dram0.bss 75072 75080 8 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224608 224668 60 0.0
.flash.text 976687 976787 100 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661708 661920 212 0.0
.bss 75212 75212 0 0.0
.data 1852 1848 -4 -0.2
.text 578844 579060 216 0.0
lock k32w061+release (read/write) 662892 663128 236 0.0
.bss 75532 75540 8 0.0
.data 1892 1888 -4 -0.2
.text 579668 579900 232 0.0
linux chip-tool-ipv6only arm64 (read only) 7088532 7088548 16 0.0
(read/write) 290881 290897 16 0.0
.bss 54577 54593 16 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186160 186160 0 0.0
.dynamic 560 560 0 0.0
.got 45232 45240 8 0.0
.init 24 24 0 0.0
.init_array 184 176 -8 -4.3
.rodata 390460 390460 0 0.0
.text 6097780 6097796 16 0.0
thermostat-no-ble arm64 (read only) 2086380 2086540 160 0.0
(read/write) 148865 148881 16 0.0
.bss 66177 66193 16 0.0
.data 952 952 0 0.0
.data.rel.ro 74624 74624 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4144 8 0.2
.init 24 24 0 0.0
.init_array 336 328 -8 -2.4
.rodata 131004 131004 0 0.0
.text 1737648 1737808 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2385832 2386024 192 0.0
.bss 189236 189236 0 0.0
.data 5288 5280 -8 -0.2
.text 1348432 1348624 192 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338640 2338840 200 0.0
.bss 178152 178152 0 0.0
.data 5568 5560 -8 -0.1
.text 1301240 1301440 200 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302296 2302560 264 0.0
.bss 178032 178040 8 0.0
.data 5544 5544 0 0.0
.text 1264896 1265160 264 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292804 2293060 256 0.0
.bss 175316 175316 0 0.0
.data 5368 5360 -8 -0.1
.text 1255376 1255632 256 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980927 981151 224 0.0
bss 118524 118528 4 0.0
rodata 116548 116676 128 0.1
text 668068 668176 108 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913143 913383 240 0.0
bss 116884 116888 4 0.0
rodata 104804 104932 128 0.1
text 614068 614176 108 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915927 916199 272 0.0
bss 116640 116644 4 0.0
rodata 105324 105452 128 0.1
text 616524 616632 108 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911135 911375 240 0.0
bss 116648 116652 4 0.0
rodata 104428 104556 128 0.1
text 612576 612684 108 0.0
shell nrf52840dk_nrf52840 (read/write) 798379 798463 84 0.0
bss 109772 109776 4 0.0
rodata 78352 78388 36 0.0
text 533752 533800 48 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 966487 966727 240 0.0
bss 115568 115572 4 0.0
rodata 108020 108148 128 0.1
text 664508 664616 108 0.0
nrf52840dongle_nrf52840 (read/write) 996995 997219 224 0.0
bss 119696 119700 4 0.0
rodata 115380 115508 128 0.1
text 673460 673568 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890126 890350 224 0.0
bss 115312 115316 4 0.0
rodata 109824 109952 128 0.1
text 584256 584360 104 0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 823210 823434 224 0.0
bss 113700 113704 4 0.0
rodata 98012 98140 128 0.1
text 531040 531144 104 0.0
p6 all-clusters-app default (read/write) 2446944 2446896 -48 -0.0
.bss 117388 117396 8 0.0
.data 2576 2568 -8 -0.3
.text 1405208 1405160 -48 -0.0
light-app default (read/write) 2340536 2340488 -48 -0.0
.bss 103348 103356 8 0.0
.data 2400 2400 0 0.0
.text 1298800 1298752 -48 -0.0
lock-app default (read/write) 2305560 2305528 -32 -0.0
.bss 103068 103068 0 0.0
.data 2360 2360 0 0.0
.text 1263824 1263792 -32 -0.0
qpg lighting-app qpg6105+debug (read only) 571104 571332 228 0.0
(read/write) 146940 146936 -4 -0.0
.bss 87496 87504 8 0.0
.data 1056 1052 -4 -0.4
.text 565784 566012 228 0.0
lock-app qpg6105+debug (read only) 516840 517056 216 0.0
(read/write) 146940 146936 -4 -0.0
.bss 86936 86944 8 0.0
.data 992 988 -4 -0.4
.text 511520 511736 216 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845494 845734 240 0.0
bss 85552 85560 8 0.0
noinit 37160 37160 0 0.0
text 592264 592362 98 0.0

@Damian-Nordic Damian-Nordic merged commit 0471a29 into project-chip:master Feb 3, 2022
@Damian-Nordic Damian-Nordic deleted the sed-mrp branch February 3, 2022 22:37
msandstedt added a commit to msandstedt/connectedhomeip that referenced this pull request Feb 4, 2022
@msandstedt
update for compatibility with project-chip#14417
a10482d
ghost pushed a commit that referenced this pull request Feb 14, 2022
backport: Take SED polling intervals into account in all MRP contexts #…
92f274d 
…14417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@LuDuda LuDuda Awaiting requested review from LuDuda

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@msandstedt msandstedt Awaiting requested review from msandstedt

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

Assignees
No one assigned
Labels
app controller lib review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Damian-Nordic @LuDuda @msandstedt @bzbarsky-apple @jmartinez-silabs @jmeg-sfy