-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ephemeral node IDs for unsecured sessions #14382
Add ephemeral node IDs for unsecured sessions #14382
Conversation
c64e34a
to
aa69605
Compare
PR #14382: Size comparison from c62489b to aa69605 Increases (13 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
/rebase |
aa69605
to
9d23e4b
Compare
PR #14382: Size comparison from ba45194 to 9d23e4b Increases above 0.2%:
Increases (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
Full report (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
9d23e4b
to
d62516e
Compare
PR #14382: Size comparison from 865aab9 to d62516e Increases above 0.2%:
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
95669d3
to
2854a15
Compare
PR #14382: Size comparison from c14afc5 to 2854a15 Increases above 0.2%:
Increases (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
Full report (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending on https://github.com/project-chip/connectedhomeip/pull/14382/files#r794717551 being applied
51ad5ef
to
79139b4
Compare
PR #14382: Size comparison from c14afc5 to 79139b4 Increases above 0.2%:
Increases (17 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg, telink)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg, telink)
|
79139b4
to
286134d
Compare
PR #14382: Size comparison from cb9b046 to 286134d Increases above 0.2%:
Increases (40 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Co-authored-by: Michael Sandstedt <[email protected]>
286134d
to
61fe29d
Compare
PR #14382: Size comparison from 2f785f4 to 61fe29d Increases above 0.2%:
Increases (40 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
* Add ephemeral node IDs for unsecured sessions * Resolve comments * Apply suggestions from code review Co-authored-by: Michael Sandstedt <[email protected]> Co-authored-by: Michael Sandstedt <[email protected]> (cherry picked from commit b5dae1e)
Problem
Fixes #11120 Message is sent to the wrong interface
Implement spec https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/4796
Change overview
mSessionRole
andmEphemeralInitiatorNodeId
intoUnauthenticatedSession
classTesting
Unit-tests & Cirque tets