Restyle Allow for split commissioner / admin topology #14376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![restyled-io[bot]](https://avatars.githubusercontent.com/in/5851?s=60&v=4){kind=small}
It is possible to implement Matter commissioning such that a commissioner node is not on any fabric, and delegates operational communication and invocation of the CommissioningComplete command to a different administrator node. In this configuration, the commissioner only communicates by PASE and may not ever have received operational credentials. To support such a configuration, this commit amends the commissioner to accept initialization to the kUndefinedFabricIndex. In this configuration, the commissioner does not bootstrap itself with any credentials, and is capable of conducting the commissioning procedure until these are needed. When it is found that credentials aren't available, the commissioner gracefully discontinues commissioning. Because CASESessionManager is using fabric association for operational discovery, discontinuation of the commissioning sequence occurs at attempted operational discovery. Fixes #13501
Co-authored-by: Boris Zbarsky <[email protected]>
Previously, chip-tool had reused fabric ID as fabric index, and was specifying both during commissioner initialization. This is brittle though because it is not practical for chip-tool to always know the fabric index ahead of time before initialization. This commit changes the commissioner to no longer accept a fabric index for initialization. Instead, the operational key pair and NOC chain are optionally passed. If present, these are added or merged into the fabric table. Merge works by identifying an existing, matching fabric in the table by comparing root public key and fabric ID. Once the new certificates are merged, the fabric index is extracted from the fabric table.
restyled-io
bot
deleted the
restyled/13501-allow-split-commissioner-admin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #14261 with additional commits that automatically address
incorrect style, created by Restyled.
Please review accordingly.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.