-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve chip app segmentation fault on simulated device #14355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krypton36
force-pushed
the
FixEventCrasher
branch
from
January 26, 2022 21:01
adb1c5d
to
1e6ff42
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248 and
jelderton
January 26, 2022 21:01
pullapprove
bot
requested review from
vijs,
kpschoedel,
wbschiller,
LuDuda,
woody-apple,
msandstedt,
xylophone21,
mspang,
yufengwangca,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic and
turon
January 26, 2022 21:01
@krypton36 can you re-enable the test as well? |
andy31415
approved these changes
Jan 26, 2022
PR #14355: Size comparison from 3bd289d to 1e6ff42 Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Jan 27, 2022
Been informed that this is blocking testing, fast tracking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After pairing, the simulated device will crash due to removal of event.
chip-csg#68
Change overview
ScheduleWork
to perform tasks in a operate thread so thatRemoveEventHandler
doesn't deallocate any context while running.Testing