Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Cryptography: Message encryption implemented in the Group Data … #14313

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Group Cryptography: Message encryption implemented in the Group Data … #14313

merged 3 commits into from
Jan 27, 2022

Conversation

rcasallas-silabs
Copy link
Contributor

Problem

The Group Data Provider is missing a method to obtain the key context required for encryption.

Change overview

  • Two new methods added to the Crypto::SymmetricKeyContext: GetKeyHash used to obtain the key hash, and Release used to free the allocated memory.
  • New method added to the GroupDataProvider interface to return the key context: GetKeyContext
  • GroupKeyContext updated to the new interface.
  • GetKeyContext implemented in GroupDataProviderImpl
  • Unit test update to use the new GetKeyContext with the existing trial decryption loop.

Testing

  • Unit tests ran successfully.

@boring-cyborg boring-cyborg bot added the crypto label Jan 26, 2022
@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #14313: Size comparison from 76f1a0f to fd3213a

Increases above 0.2%:

platform target config section 76f1a0f fd3213a change % change
linux chip-tool-ipv6only arm64 .bss 56241 56401 160 0.3
thermostat-no-ble arm64 .bss 65857 66033 176 0.3
Increases (25 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 76f1a0f fd3213a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 579910 580358 448 0.1
.app_xip_area 484832 485184 352 0.1
.bss 77824 77920 96 0.1
esp32 all-clusters-app c3devkit (read only) 920846 921204 358 0.0
(read/write) 1384650 1384762 112 0.0
.dram0.bss 70840 70936 96 0.1
.flash.rodata 180632 180648 16 0.0
.flash.text 920846 921204 358 0.0
m5stack (read only) 969851 970167 316 0.0
(read/write) 451664 451776 112 0.0
.dram0.bss 75584 75680 96 0.1
.flash.rodata 209920 209936 16 0.0
.flash.text 964467 964783 316 0.0
k32w light k32w061+release (read/write) 664700 665160 460 0.1
.bss 77596 77692 96 0.1
.text 579436 579800 364 0.1
lock k32w061+release (read/write) 665696 666140 444 0.1
.bss 77860 77956 96 0.1
.text 580144 580492 348 0.1
linux chip-tool-ipv6only arm64 (read only) 8729252 8730892 1640 0.0
(read/write) 392273 392481 208 0.1
.bss 56241 56401 160 0.3
.data.rel.ro 261872 261920 48 0.0
.rodata 534252 534260 8 0.0
.text 7353252 7354740 1488 0.0
thermostat-no-ble arm64 (read only) 2058404 2060028 1624 0.1
(read/write) 147457 147681 224 0.2
.bss 65857 66033 176 0.3
.data.rel.ro 73624 73672 48 0.1
.rodata 131396 131404 8 0.0
.text 1711248 1712720 1472 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2354872 2355200 328 0.0
.bss 189548 189644 96 0.1
.text 1317472 1317800 328 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2340864 2341192 328 0.0
.bss 181072 181168 96 0.1
.text 1303464 1303792 328 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2307608 2307936 328 0.0
.bss 180968 181064 96 0.1
.text 1270208 1270536 328 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2293772 2294164 392 0.0
.bss 177700 177796 96 0.1
.text 1256344 1256736 392 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983171 983615 444 0.0
bss 120828 120924 96 0.1
rodata 116408 116420 12 0.0
text 668144 668480 336 0.1
nrf52840dk_nrf52840+rpc (read/write) 967031 967475 444 0.0
bss 117872 117968 96 0.1
rodata 107940 107952 12 0.0
text 662816 663152 336 0.1
nrf52840dongle_nrf52840 (read/write) 999355 999799 444 0.0
bss 122000 122096 96 0.1
rodata 115292 115304 12 0.0
text 673604 673940 336 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892390 892834 444 0.0
bss 117616 117712 96 0.1
rodata 109704 109716 12 0.0
text 584324 584660 336 0.1
lock-app nrf52840dk_nrf52840 (read/write) 915863 916307 444 0.0
bss 119208 119304 96 0.1
rodata 105076 105088 12 0.0
text 614168 614504 336 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 825886 826330 444 0.1
bss 116024 116120 96 0.1
rodata 98304 98316 12 0.0
text 531120 531456 336 0.1
pump-app nrf52840dk_nrf52840 (read/write) 918523 918967 444 0.0
bss 118952 119048 96 0.1
rodata 105464 105476 12 0.0
text 616632 616968 336 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 913707 914151 444 0.0
bss 118980 119076 96 0.1
rodata 104568 104580 12 0.0
text 612664 613000 336 0.1
p6 all-clusters-app default (read/write) 2414704 2415712 1008 0.0
.bss 117892 117988 96 0.1
.text 1372968 1373976 1008 0.1
light-app default (read/write) 2338168 2339184 1016 0.0
.bss 105652 105748 96 0.1
.text 1296432 1297448 1016 0.1
lock-app default (read/write) 2303720 2304728 1008 0.0
.bss 105396 105492 96 0.1
.text 1261984 1262992 1008 0.1
qpg lighting-app qpg6105+debug (read only) 571540 571888 348 0.1
.bss 89808 89904 96 0.1
.text 566220 566568 348 0.1
lock-app qpg6105+debug (read only) 517724 518080 356 0.1
.bss 89280 89376 96 0.1
.text 512404 512760 356 0.1
telink lighting-app tlsr9518adk80d (read/write) 847718 848210 492 0.1
bss 87608 87704 96 0.1
text 592560 592946 386 0.1
Full report (29 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 76f1a0f fd3213a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 579910 580358 448 0.1
.app_xip_area 484832 485184 352 0.1
.bss 77824 77920 96 0.1
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
esp32 all-clusters-app c3devkit (read only) 920846 921204 358 0.0
(read/write) 1384650 1384762 112 0.0
.dram0.bss 70840 70936 96 0.1
.dram0.data 14244 14244 0 0.0
.flash.rodata 180632 180648 16 0.0
.flash.text 920846 921204 358 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 969851 970167 316 0.0
(read/write) 451664 451776 112 0.0
.dram0.bss 75584 75680 96 0.1
.dram0.data 34032 34032 0 0.0
.flash.rodata 209920 209936 16 0.0
.flash.text 964467 964783 316 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 664700 665160 460 0.1
.bss 77596 77692 96 0.1
.data 1868 1868 0 0.0
.text 579436 579800 364 0.1
lock k32w061+release (read/write) 665696 666140 444 0.1
.bss 77860 77956 96 0.1
.data 1892 1892 0 0.0
.text 580144 580492 348 0.1
linux chip-tool-ipv6only arm64 (read only) 8729252 8730892 1640 0.0
(read/write) 392273 392481 208 0.1
.bss 56241 56401 160 0.3
.data 1128 1128 0 0.0
.data.rel.ro 261872 261920 48 0.0
.dynamic 560 560 0 0.0
.got 69280 69280 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 534252 534260 8 0.0
.text 7353252 7354740 1488 0.0
thermostat-no-ble arm64 (read only) 2058404 2060028 1624 0.1
(read/write) 147457 147681 224 0.2
.bss 65857 66033 176 0.3
.data 904 904 0 0.0
.data.rel.ro 73624 73672 48 0.1
.dynamic 560 560 0 0.0
.got 4112 4112 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131396 131404 8 0.0
.text 1711248 1712720 1472 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2354872 2355200 328 0.0
.bss 189548 189644 96 0.1
.data 5296 5296 0 0.0
.text 1317472 1317800 328 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340864 2341192 328 0.0
.bss 181072 181168 96 0.1
.data 5584 5584 0 0.0
.text 1303464 1303792 328 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307608 2307936 328 0.0
.bss 180968 181064 96 0.1
.data 5568 5568 0 0.0
.text 1270208 1270536 328 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293772 2294164 392 0.0
.bss 177700 177796 96 0.1
.data 5384 5384 0 0.0
.text 1256344 1256736 392 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983171 983615 444 0.0
bss 120828 120924 96 0.1
rodata 116408 116420 12 0.0
text 668144 668480 336 0.1
nrf52840dk_nrf52840+rpc (read/write) 967031 967475 444 0.0
bss 117872 117968 96 0.1
rodata 107940 107952 12 0.0
text 662816 663152 336 0.1
nrf52840dongle_nrf52840 (read/write) 999355 999799 444 0.0
bss 122000 122096 96 0.1
rodata 115292 115304 12 0.0
text 673604 673940 336 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892390 892834 444 0.0
bss 117616 117712 96 0.1
rodata 109704 109716 12 0.0
text 584324 584660 336 0.1
lock-app nrf52840dk_nrf52840 (read/write) 915863 916307 444 0.0
bss 119208 119304 96 0.1
rodata 105076 105088 12 0.0
text 614168 614504 336 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 825886 826330 444 0.1
bss 116024 116120 96 0.1
rodata 98304 98316 12 0.0
text 531120 531456 336 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 918523 918967 444 0.0
bss 118952 119048 96 0.1
rodata 105464 105476 12 0.0
text 616632 616968 336 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 913707 914151 444 0.0
bss 118980 119076 96 0.1
rodata 104568 104580 12 0.0
text 612664 613000 336 0.1
shell nrf52840dk_nrf52840 (read/write) 798219 798219 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533648 533648 0 0.0
p6 all-clusters-app default (read/write) 2414704 2415712 1008 0.0
.bss 117892 117988 96 0.1
.data 2584 2584 0 0.0
.text 1372968 1373976 1008 0.1
light-app default (read/write) 2338168 2339184 1016 0.0
.bss 105652 105748 96 0.1
.data 2408 2408 0 0.0
.text 1296432 1297448 1016 0.1
lock-app default (read/write) 2303720 2304728 1008 0.0
.bss 105396 105492 96 0.1
.data 2360 2360 0 0.0
.text 1261984 1262992 1008 0.1
qpg lighting-app qpg6105+debug (read only) 571540 571888 348 0.1
(read/write) 146936 146936 0 0.0
.bss 89808 89904 96 0.1
.data 1060 1060 0 0.0
.text 566220 566568 348 0.1
lock-app qpg6105+debug (read only) 517724 518080 356 0.1
(read/write) 146940 146940 0 0.0
.bss 89280 89376 96 0.1
.data 992 992 0 0.0
.text 512404 512760 356 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 847718 848210 492 0.1
bss 87608 87704 96 0.1
noinit 37160 37160 0 0.0
text 592560 592946 386 0.1

@rcasallas-silabs rcasallas-silabs force-pushed the group_cryptography2 branch 2 times, most recently from c1164b4 to 680e288 Compare January 26, 2022 20:54
@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #14313: Size comparison from 3bd289d to 680e288

Increases above 0.2%:

platform target config section 3bd289d 680e288 change % change
linux chip-tool-ipv6only arm64 .bss 55377 55537 160 0.3
thermostat-no-ble arm64 .bss 66417 66593 176 0.3
Increases (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3bd289d 680e288 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580330 580798 468 0.1
.app_xip_area 485224 485596 372 0.1
.bss 77852 77948 96 0.1
efr32 lighting-app BRD4161A (read only) 843316 844340 1024 0.1
(read/write) 127396 127492 96 0.1
.bss 125496 125592 96 0.1
.text 843308 844332 1024 0.1
BRD4161A+rpc (read only) 830672 831688 1016 0.1
(read/write) 144056 144152 96 0.1
.bss 142056 142152 96 0.1
.text 830664 831680 1016 0.1
window-app BRD4161A (read only) 815948 816964 1016 0.1
(read/write) 126052 126148 96 0.1
.bss 124196 124292 96 0.1
.text 815940 816956 1016 0.1
esp32 all-clusters-app c3devkit (read only) 921116 921496 380 0.0
(read/write) 1384722 1384834 112 0.0
.dram0.bss 70872 70968 96 0.1
.flash.rodata 180672 180688 16 0.0
.flash.text 921116 921496 380 0.0
m5stack (read only) 970111 970431 320 0.0
(read/write) 451744 451848 104 0.0
.dram0.bss 75616 75712 96 0.1
.flash.rodata 209968 209976 8 0.0
.flash.text 964727 965047 320 0.0
k32w light k32w061+release (read/write) 665192 665668 476 0.1
.bss 77628 77724 96 0.1
.text 579896 580276 380 0.1
lock k32w061+release (read/write) 666080 666556 476 0.1
.bss 77892 77988 96 0.1
.text 580496 580876 380 0.1
linux chip-tool-ipv6only arm64 (read only) 8904716 8906388 1672 0.0
(read/write) 393649 393857 208 0.1
.bss 55377 55537 160 0.3
.data.rel.ro 263656 263704 48 0.0
.rodata 542916 542924 8 0.0
.text 7514868 7516388 1520 0.0
thermostat-no-ble arm64 (read only) 2061828 2063500 1672 0.1
(read/write) 148113 148337 224 0.2
.bss 66417 66593 176 0.3
.data.rel.ro 73712 73760 48 0.1
.rodata 131428 131436 8 0.0
.text 1714416 1715936 1520 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2355056 2355456 400 0.0
.bss 189580 189676 96 0.1
.text 1317656 1318056 400 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2341048 2341448 400 0.0
.bss 181104 181200 96 0.1
.text 1303648 1304048 400 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2307792 2308192 400 0.0
.bss 181000 181096 96 0.1
.text 1270392 1270792 400 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2294060 2294452 392 0.0
.bss 177732 177828 96 0.1
.text 1256632 1257024 392 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983643 984103 460 0.0
bss 120860 120956 96 0.1
rodata 116480 116492 12 0.0
text 668512 668868 356 0.1
nrf52840dk_nrf52840+rpc (read/write) 967507 967967 460 0.0
bss 117904 118000 96 0.1
rodata 108016 108028 12 0.0
text 663184 663540 356 0.1
nrf52840dongle_nrf52840 (read/write) 999731 1000191 460 0.0
bss 122032 122128 96 0.1
rodata 115332 115344 12 0.0
text 673900 674256 356 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 892866 893326 460 0.1
bss 117648 117744 96 0.1
rodata 109780 109792 12 0.0
text 584692 585048 356 0.1
lock-app nrf52840dk_nrf52840 (read/write) 916227 916687 460 0.1
bss 119240 119336 96 0.1
rodata 105120 105132 12 0.0
text 614460 614816 356 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826246 826722 476 0.1
bss 116056 116152 96 0.1
rodata 98344 98356 12 0.0
text 531412 531768 356 0.1
pump-app nrf52840dk_nrf52840 (read/write) 918883 919359 476 0.1
bss 118984 119080 96 0.1
rodata 105504 105516 12 0.0
text 616924 617280 356 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914067 914527 460 0.1
bss 119012 119108 96 0.1
rodata 104608 104620 12 0.0
text 612956 613312 356 0.1
p6 all-clusters-app default (read/write) 2415424 2416448 1024 0.0
.bss 117924 118020 96 0.1
.text 1373688 1374712 1024 0.1
light-app default (read/write) 2338904 2339920 1016 0.0
.bss 105684 105780 96 0.1
.text 1297168 1298184 1016 0.1
lock-app default (read/write) 2304440 2305464 1024 0.0
.bss 105428 105524 96 0.1
.text 1262704 1263728 1024 0.1
qpg lighting-app qpg6105+debug (read only) 571964 572336 372 0.1
.bss 89840 89936 96 0.1
.text 566644 567016 372 0.1
lock-app qpg6105+debug (read only) 518060 518432 372 0.1
.bss 89312 89408 96 0.1
.text 512740 513112 372 0.1
telink lighting-app tlsr9518adk80d (read/write) 848046 848562 516 0.1
bss 87640 87736 96 0.1
text 592818 593226 408 0.1
Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3bd289d 680e288 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580330 580798 468 0.1
.app_xip_area 485224 485596 372 0.1
.bss 77852 77948 96 0.1
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843316 844340 1024 0.1
(read/write) 127396 127492 96 0.1
.bss 125496 125592 96 0.1
.data 1900 1900 0 0.0
.text 843308 844332 1024 0.1
BRD4161A+rpc (read only) 830672 831688 1016 0.1
(read/write) 144056 144152 96 0.1
.bss 142056 142152 96 0.1
.data 2000 2000 0 0.0
.text 830664 831680 1016 0.1
window-app BRD4161A (read only) 815948 816964 1016 0.1
(read/write) 126052 126148 96 0.1
.bss 124196 124292 96 0.1
.data 1856 1856 0 0.0
.text 815940 816956 1016 0.1
esp32 all-clusters-app c3devkit (read only) 921116 921496 380 0.0
(read/write) 1384722 1384834 112 0.0
.dram0.bss 70872 70968 96 0.1
.dram0.data 14244 14244 0 0.0
.flash.rodata 180672 180688 16 0.0
.flash.text 921116 921496 380 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 970111 970431 320 0.0
(read/write) 451744 451848 104 0.0
.dram0.bss 75616 75712 96 0.1
.dram0.data 34032 34032 0 0.0
.flash.rodata 209968 209976 8 0.0
.flash.text 964727 965047 320 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665192 665668 476 0.1
.bss 77628 77724 96 0.1
.data 1868 1868 0 0.0
.text 579896 580276 380 0.1
lock k32w061+release (read/write) 666080 666556 476 0.1
.bss 77892 77988 96 0.1
.data 1892 1892 0 0.0
.text 580496 580876 380 0.1
linux chip-tool-ipv6only arm64 (read only) 8904716 8906388 1672 0.0
(read/write) 393649 393857 208 0.1
.bss 55377 55537 160 0.3
.data 1128 1128 0 0.0
.data.rel.ro 263656 263704 48 0.0
.dynamic 560 560 0 0.0
.got 69728 69728 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 542916 542924 8 0.0
.text 7514868 7516388 1520 0.0
thermostat-no-ble arm64 (read only) 2061828 2063500 1672 0.1
(read/write) 148113 148337 224 0.2
.bss 66417 66593 176 0.3
.data 904 904 0 0.0
.data.rel.ro 73712 73760 48 0.1
.dynamic 560 560 0 0.0
.got 4128 4128 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131428 131436 8 0.0
.text 1714416 1715936 1520 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355056 2355456 400 0.0
.bss 189580 189676 96 0.1
.data 5296 5296 0 0.0
.text 1317656 1318056 400 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341048 2341448 400 0.0
.bss 181104 181200 96 0.1
.data 5584 5584 0 0.0
.text 1303648 1304048 400 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307792 2308192 400 0.0
.bss 181000 181096 96 0.1
.data 5568 5568 0 0.0
.text 1270392 1270792 400 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294060 2294452 392 0.0
.bss 177732 177828 96 0.1
.data 5384 5384 0 0.0
.text 1256632 1257024 392 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983643 984103 460 0.0
bss 120860 120956 96 0.1
rodata 116480 116492 12 0.0
text 668512 668868 356 0.1
nrf52840dk_nrf52840+rpc (read/write) 967507 967967 460 0.0
bss 117904 118000 96 0.1
rodata 108016 108028 12 0.0
text 663184 663540 356 0.1
nrf52840dongle_nrf52840 (read/write) 999731 1000191 460 0.0
bss 122032 122128 96 0.1
rodata 115332 115344 12 0.0
text 673900 674256 356 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 892866 893326 460 0.1
bss 117648 117744 96 0.1
rodata 109780 109792 12 0.0
text 584692 585048 356 0.1
lock-app nrf52840dk_nrf52840 (read/write) 916227 916687 460 0.1
bss 119240 119336 96 0.1
rodata 105120 105132 12 0.0
text 614460 614816 356 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826246 826722 476 0.1
bss 116056 116152 96 0.1
rodata 98344 98356 12 0.0
text 531412 531768 356 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 918883 919359 476 0.1
bss 118984 119080 96 0.1
rodata 105504 105516 12 0.0
text 616924 617280 356 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914067 914527 460 0.1
bss 119012 119108 96 0.1
rodata 104608 104620 12 0.0
text 612956 613312 356 0.1
shell nrf52840dk_nrf52840 (read/write) 798219 798219 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533652 533652 0 0.0
p6 all-clusters-app default (read/write) 2415424 2416448 1024 0.0
.bss 117924 118020 96 0.1
.data 2584 2584 0 0.0
.text 1373688 1374712 1024 0.1
light-app default (read/write) 2338904 2339920 1016 0.0
.bss 105684 105780 96 0.1
.data 2408 2408 0 0.0
.text 1297168 1298184 1016 0.1
lock-app default (read/write) 2304440 2305464 1024 0.0
.bss 105428 105524 96 0.1
.data 2360 2360 0 0.0
.text 1262704 1263728 1024 0.1
qpg lighting-app qpg6105+debug (read only) 571964 572336 372 0.1
(read/write) 146936 146936 0 0.0
.bss 89840 89936 96 0.1
.data 1060 1060 0 0.0
.text 566644 567016 372 0.1
lock-app qpg6105+debug (read only) 518060 518432 372 0.1
(read/write) 146940 146940 0 0.0
.bss 89312 89408 96 0.1
.data 992 992 0 0.0
.text 512740 513112 372 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848046 848562 516 0.1
bss 87640 87736 96 0.1
noinit 37160 37160 0 0.0
text 592818 593226 408 0.1

bzbarsky-apple
bzbarsky-apple approved these changes Jan 26, 2022
View reviewed changes
src/credentials/GroupDataProviderImpl.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #14313: Size comparison from c62489b to 423c086

Increases above 0.2%:

platform target config section c62489b 423c086 change % change
linux chip-tool-ipv6only arm64 .bss 55377 55537 160 0.3
thermostat-no-ble arm64 .bss 68689 68865 176 0.3
Increases (15 builds for efr32, esp32, k32w, linux, p6, qpg, telink)
platform target config section c62489b 423c086 change % change
efr32 lighting-app BRD4161A (read only) 843492 844508 1016 0.1
(read/write) 127396 127492 96 0.1
.bss 125496 125592 96 0.1
.text 843484 844500 1016 0.1
BRD4161A+rpc (read only) 830864 831880 1016 0.1
(read/write) 144056 144152 96 0.1
.bss 142056 142152 96 0.1
.text 830856 831872 1016 0.1
window-app BRD4161A (read only) 816108 817124 1016 0.1
(read/write) 126052 126148 96 0.1
.bss 124196 124292 96 0.1
.text 816100 817116 1016 0.1
esp32 all-clusters-app c3devkit (read only) 923298 923678 380 0.0
(read/write) 1384986 1385098 112 0.0
.dram0.bss 70880 70976 96 0.1
.flash.rodata 180936 180952 16 0.0
.flash.text 923298 923678 380 0.0
m5stack (read only) 972395 972715 320 0.0
(read/write) 450904 451016 112 0.0
.dram0.bss 74480 74576 96 0.1
.flash.rodata 210264 210280 16 0.0
.flash.text 967011 967331 320 0.0
k32w light k32w061+release (read/write) 665224 665700 476 0.1
.bss 77628 77724 96 0.1
.text 579928 580308 380 0.1
lock k32w061+release (read/write) 666192 666652 460 0.1
.bss 77892 77988 96 0.1
.text 580608 580972 364 0.1
linux chip-tool-ipv6only arm64 (read only) 8935692 8937356 1664 0.0
(read/write) 394801 395009 208 0.1
.bss 55377 55537 160 0.3
.data.rel.ro 264512 264560 48 0.0
.text 7541700 7543220 1520 0.0
thermostat-no-ble arm64 (read only) 2082804 2084468 1664 0.1
(read/write) 150977 151201 224 0.1
.bss 68689 68865 176 0.3
.data.rel.ro 74208 74256 48 0.1
.text 1733616 1735136 1520 0.1
p6 all-clusters-app default (read/write) 2418240 2419256 1016 0.0
.bss 117932 118028 96 0.1
.text 1376504 1377520 1016 0.1
light-app default (read/write) 2339064 2340080 1016 0.0
.bss 105684 105780 96 0.1
.text 1297328 1298344 1016 0.1
lock-app default (read/write) 2304584 2305600 1016 0.0
.bss 105428 105524 96 0.1
.text 1262848 1263864 1016 0.1
qpg lighting-app qpg6105+debug (read only) 572036 572408 372 0.1
.bss 89840 89936 96 0.1
.text 566716 567088 372 0.1
lock-app qpg6105+debug (read only) 518164 518536 372 0.1
.bss 89312 89408 96 0.1
.text 512844 513216 372 0.1
telink lighting-app tlsr9518adk80d (read/write) 848810 849326 516 0.1
bss 87164 87260 96 0.1
text 594022 594430 408 0.1
Full report (16 builds for efr32, esp32, k32w, linux, p6, qpg, telink)
platform target config section c62489b 423c086 change % change
efr32 lighting-app BRD4161A (read only) 843492 844508 1016 0.1
(read/write) 127396 127492 96 0.1
.bss 125496 125592 96 0.1
.data 1900 1900 0 0.0
.text 843484 844500 1016 0.1
BRD4161A+rpc (read only) 830864 831880 1016 0.1
(read/write) 144056 144152 96 0.1
.bss 142056 142152 96 0.1
.data 2000 2000 0 0.0
.text 830856 831872 1016 0.1
window-app BRD4161A (read only) 816108 817124 1016 0.1
(read/write) 126052 126148 96 0.1
.bss 124196 124292 96 0.1
.data 1856 1856 0 0.0
.text 816100 817116 1016 0.1
esp32 all-clusters-app c3devkit (read only) 923298 923678 380 0.0
(read/write) 1384986 1385098 112 0.0
.dram0.bss 70880 70976 96 0.1
.dram0.data 14252 14252 0 0.0
.flash.rodata 180936 180952 16 0.0
.flash.text 923298 923678 380 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 972395 972715 320 0.0
(read/write) 450904 451016 112 0.0
.dram0.bss 74480 74576 96 0.1
.dram0.data 34032 34032 0 0.0
.flash.rodata 210264 210280 16 0.0
.flash.text 967011 967331 320 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665224 665700 476 0.1
.bss 77628 77724 96 0.1
.data 1868 1868 0 0.0
.text 579928 580308 380 0.1
lock k32w061+release (read/write) 666192 666652 460 0.1
.bss 77892 77988 96 0.1
.data 1892 1892 0 0.0
.text 580608 580972 364 0.1
linux chip-tool-ipv6only arm64 (read only) 8935692 8937356 1664 0.0
(read/write) 394801 395009 208 0.1
.bss 55377 55537 160 0.3
.data 1128 1128 0 0.0
.data.rel.ro 264512 264560 48 0.0
.dynamic 560 560 0 0.0
.got 70024 70024 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 544356 544356 0 0.0
.text 7541700 7543220 1520 0.0
thermostat-no-ble arm64 (read only) 2082804 2084468 1664 0.1
(read/write) 150977 151201 224 0.1
.bss 68689 68865 176 0.3
.data 960 960 0 0.0
.data.rel.ro 74208 74256 48 0.1
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 131940 0 0.0
.text 1733616 1735136 1520 0.1
p6 all-clusters-app default (read/write) 2418240 2419256 1016 0.0
.bss 117932 118028 96 0.1
.data 2592 2592 0 0.0
.text 1376504 1377520 1016 0.1
light-app default (read/write) 2339064 2340080 1016 0.0
.bss 105684 105780 96 0.1
.data 2408 2408 0 0.0
.text 1297328 1298344 1016 0.1
lock-app default (read/write) 2304584 2305600 1016 0.0
.bss 105428 105524 96 0.1
.data 2360 2360 0 0.0
.text 1262848 1263864 1016 0.1
qpg lighting-app qpg6105+debug (read only) 572036 572408 372 0.1
(read/write) 146936 146936 0 0.0
.bss 89840 89936 96 0.1
.data 1060 1060 0 0.0
.text 566716 567088 372 0.1
lock-app qpg6105+debug (read only) 518164 518536 372 0.1
(read/write) 146940 146940 0 0.0
.bss 89312 89408 96 0.1
.data 992 992 0 0.0
.text 512844 513216 372 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848810 849326 516 0.1
bss 87164 87260 96 0.1
noinit 37160 37160 0 0.0
text 594022 594430 408 0.1

@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #14313: Size comparison from 40cc421 to 65da970

Increases above 0.2%:

platform target config section 40cc421 65da970 change % change
linux chip-tool-ipv6only arm64 .bss 55377 55537 160 0.3
thermostat-no-ble arm64 .bss 69585 69761 176 0.3
Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 40cc421 65da970 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580442 580910 468 0.1
.app_xip_area 485336 485708 372 0.1
.bss 77852 77948 96 0.1
lock-app CYW30739 (read/write) 538446 538914 468 0.1
.app_xip_area 444884 445256 372 0.1
.bss 76348 76444 96 0.1
efr32 lighting-app BRD4161A (read only) 843492 844492 1000 0.1
(read/write) 127396 127492 96 0.1
.bss 125496 125592 96 0.1
.text 843484 844484 1000 0.1
BRD4161A+rpc (read only) 830864 831864 1000 0.1
(read/write) 144056 144152 96 0.1
.bss 142056 142152 96 0.1
.text 830856 831856 1000 0.1
window-app BRD4161A (read only) 816108 817108 1000 0.1
(read/write) 126052 126148 96 0.1
.bss 124196 124292 96 0.1
.text 816100 817100 1000 0.1
esp32 all-clusters-app c3devkit (read only) 923298 923676 378 0.0
(read/write) 1384986 1385098 112 0.0
.dram0.bss 70880 70976 96 0.1
.flash.rodata 180936 180952 16 0.0
.flash.text 923298 923676 378 0.0
m5stack (read only) 972227 972551 324 0.0
(read/write) 452016 452128 112 0.0
.dram0.bss 75624 75720 96 0.1
.flash.rodata 210232 210248 16 0.0
.flash.text 966843 967167 324 0.0
k32w light k32w061+release (read/write) 665224 665700 476 0.1
.bss 77628 77724 96 0.1
.text 579928 580308 380 0.1
lock k32w061+release (read/write) 666192 666652 460 0.1
.bss 77892 77988 96 0.1
.text 580608 580972 364 0.1
linux chip-tool-ipv6only arm64 (read only) 6537388 6539052 1664 0.0
(read/write) 275153 275361 208 0.1
.bss 55377 55537 160 0.3
.data.rel.ro 174424 174472 48 0.0
.text 5598724 5600244 1520 0.0
thermostat-no-ble arm64 (read only) 2082804 2084468 1664 0.1
(read/write) 151873 152097 224 0.1
.bss 69585 69761 176 0.3
.data.rel.ro 74208 74256 48 0.1
.text 1733616 1735136 1520 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2357384 2357784 400 0.0
.bss 189588 189684 96 0.1
.text 1319984 1320384 400 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2341088 2341488 400 0.0
.bss 181104 181200 96 0.1
.text 1303688 1304088 400 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2307840 2308240 400 0.0
.bss 181000 181096 96 0.1
.text 1270440 1270840 400 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2294044 2294436 392 0.0
.bss 177732 177828 96 0.1
.text 1256616 1257008 392 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983707 984167 460 0.0
bss 120860 120956 96 0.1
rodata 116480 116492 12 0.0
text 668576 668932 356 0.1
nrf52840dk_nrf52840+rpc (read/write) 967571 968031 460 0.0
bss 117904 118000 96 0.1
rodata 108016 108028 12 0.0
text 663248 663604 356 0.1
nrf52840dongle_nrf52840 (read/write) 999827 1000303 476 0.0
bss 122032 122128 96 0.1
rodata 115332 115344 12 0.0
text 674004 674360 356 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 892930 893390 460 0.1
bss 117648 117744 96 0.1
rodata 109780 109792 12 0.0
text 584756 585112 356 0.1
lock-app nrf52840dk_nrf52840 (read/write) 916323 916783 460 0.1
bss 119240 119336 96 0.1
rodata 105120 105132 12 0.0
text 614560 614916 356 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826358 826818 460 0.1
bss 116056 116152 96 0.1
rodata 98344 98356 12 0.0
text 531512 531868 356 0.1
pump-app nrf52840dk_nrf52840 (read/write) 919187 919647 460 0.1
bss 118992 119088 96 0.1
rodata 105632 105644 12 0.0
text 617096 617452 356 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914371 914831 460 0.1
bss 119016 119112 96 0.1
rodata 104736 104748 12 0.0
text 613132 613488 356 0.1
p6 all-clusters-app default (read/write) 2418240 2419240 1000 0.0
.bss 117932 118028 96 0.1
.text 1376504 1377504 1000 0.1
light-app default (read/write) 2339064 2340080 1016 0.0
.bss 105684 105780 96 0.1
.text 1297328 1298344 1016 0.1
lock-app default (read/write) 2304584 2305584 1000 0.0
.bss 105428 105524 96 0.1
.text 1262848 1263848 1000 0.1
qpg lighting-app qpg6105+debug (read only) 572036 572408 372 0.1
.bss 89840 89936 96 0.1
.text 566716 567088 372 0.1
lock-app qpg6105+debug (read only) 518164 518536 372 0.1
.bss 89312 89408 96 0.1
.text 512844 513216 372 0.1
telink lighting-app tlsr9518adk80d (read/write) 848158 848674 516 0.1
bss 87640 87736 96 0.1
text 592932 593336 404 0.1
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 40cc421 65da970 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580442 580910 468 0.1
.app_xip_area 485336 485708 372 0.1
.bss 77852 77948 96 0.1
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 538446 538914 468 0.1
.app_xip_area 444884 445256 372 0.1
.bss 76348 76444 96 0.1
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843492 844492 1000 0.1
(read/write) 127396 127492 96 0.1
.bss 125496 125592 96 0.1
.data 1900 1900 0 0.0
.text 843484 844484 1000 0.1
BRD4161A+rpc (read only) 830864 831864 1000 0.1
(read/write) 144056 144152 96 0.1
.bss 142056 142152 96 0.1
.data 2000 2000 0 0.0
.text 830856 831856 1000 0.1
window-app BRD4161A (read only) 816108 817108 1000 0.1
(read/write) 126052 126148 96 0.1
.bss 124196 124292 96 0.1
.data 1856 1856 0 0.0
.text 816100 817100 1000 0.1
esp32 all-clusters-app c3devkit (read only) 923298 923676 378 0.0
(read/write) 1384986 1385098 112 0.0
.dram0.bss 70880 70976 96 0.1
.dram0.data 14252 14252 0 0.0
.flash.rodata 180936 180952 16 0.0
.flash.text 923298 923676 378 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 972227 972551 324 0.0
(read/write) 452016 452128 112 0.0
.dram0.bss 75624 75720 96 0.1
.dram0.data 34032 34032 0 0.0
.flash.rodata 210232 210248 16 0.0
.flash.text 966843 967167 324 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665224 665700 476 0.1
.bss 77628 77724 96 0.1
.data 1868 1868 0 0.0
.text 579928 580308 380 0.1
lock k32w061+release (read/write) 666192 666652 460 0.1
.bss 77892 77988 96 0.1
.data 1892 1892 0 0.0
.text 580608 580972 364 0.1
linux chip-tool-ipv6only arm64 (read only) 6537388 6539052 1664 0.0
(read/write) 275153 275361 208 0.1
.bss 55377 55537 160 0.3
.data 1128 1128 0 0.0
.data.rel.ro 174424 174472 48 0.0
.dynamic 560 560 0 0.0
.got 40472 40472 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 377140 377140 0 0.0
.text 5598724 5600244 1520 0.0
thermostat-no-ble arm64 (read only) 2082804 2084468 1664 0.1
(read/write) 151873 152097 224 0.1
.bss 69585 69761 176 0.3
.data 960 960 0 0.0
.data.rel.ro 74208 74256 48 0.1
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 131940 0 0.0
.text 1733616 1735136 1520 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357384 2357784 400 0.0
.bss 189588 189684 96 0.1
.data 5296 5296 0 0.0
.text 1319984 1320384 400 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341088 2341488 400 0.0
.bss 181104 181200 96 0.1
.data 5584 5584 0 0.0
.text 1303688 1304088 400 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307840 2308240 400 0.0
.bss 181000 181096 96 0.1
.data 5568 5568 0 0.0
.text 1270440 1270840 400 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294044 2294436 392 0.0
.bss 177732 177828 96 0.1
.data 5384 5384 0 0.0
.text 1256616 1257008 392 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983707 984167 460 0.0
bss 120860 120956 96 0.1
rodata 116480 116492 12 0.0
text 668576 668932 356 0.1
nrf52840dk_nrf52840+rpc (read/write) 967571 968031 460 0.0
bss 117904 118000 96 0.1
rodata 108016 108028 12 0.0
text 663248 663604 356 0.1
nrf52840dongle_nrf52840 (read/write) 999827 1000303 476 0.0
bss 122032 122128 96 0.1
rodata 115332 115344 12 0.0
text 674004 674360 356 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 892930 893390 460 0.1
bss 117648 117744 96 0.1
rodata 109780 109792 12 0.0
text 584756 585112 356 0.1
lock-app nrf52840dk_nrf52840 (read/write) 916323 916783 460 0.1
bss 119240 119336 96 0.1
rodata 105120 105132 12 0.0
text 614560 614916 356 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826358 826818 460 0.1
bss 116056 116152 96 0.1
rodata 98344 98356 12 0.0
text 531512 531868 356 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919187 919647 460 0.1
bss 118992 119088 96 0.1
rodata 105632 105644 12 0.0
text 617096 617452 356 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914371 914831 460 0.1
bss 119016 119112 96 0.1
rodata 104736 104748 12 0.0
text 613132 613488 356 0.1
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2418240 2419240 1000 0.0
.bss 117932 118028 96 0.1
.data 2592 2592 0 0.0
.text 1376504 1377504 1000 0.1
light-app default (read/write) 2339064 2340080 1016 0.0
.bss 105684 105780 96 0.1
.data 2408 2408 0 0.0
.text 1297328 1298344 1016 0.1
lock-app default (read/write) 2304584 2305584 1000 0.0
.bss 105428 105524 96 0.1
.data 2360 2360 0 0.0
.text 1262848 1263848 1000 0.1
qpg lighting-app qpg6105+debug (read only) 572036 572408 372 0.1
(read/write) 146936 146936 0 0.0
.bss 89840 89936 96 0.1
.data 1060 1060 0 0.0
.text 566716 567088 372 0.1
lock-app qpg6105+debug (read only) 518164 518536 372 0.1
(read/write) 146940 146940 0 0.0
.bss 89312 89408 96 0.1
.data 992 992 0 0.0
.text 512844 513216 372 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848158 848674 516 0.1
bss 87640 87736 96 0.1
noinit 37160 37160 0 0.0
text 592932 593336 404 0.1

@bzbarsky-apple bzbarsky-apple merged commit 63d0c37 into project-chip:master Jan 27, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@rcasallas-silabs @woody-apple
@bzbarsky-apple @selissia
Group Cryptography: Message encryption implemented in the Group Data … (
2b7a400 
project-chip#14313)

* Group Cryptography: Message encryption implemented in the Group Data Provider.

* Group Cryptography: Review comments applied.

* Update src/credentials/GroupDataProviderImpl.h

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Justin Wood <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
@rcasallas-silabs rcasallas-silabs deleted the group_cryptography2 branch July 5, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
crypto review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcasallas-silabs @tcarmelveilleux @msandstedt @woody-apple @bzbarsky-apple