-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a max length to cluster-objects typeinfo for string attributes. #14256
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:string-max-length
Jan 25, 2022
Merged
Add a max length to cluster-objects typeinfo for string attributes. #14256
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:string-max-length
Jan 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets consumers size buffers based on the spec-defined max length.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
January 25, 2022 19:18
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
January 25, 2022 19:18
PR #14256: Size comparison from be9582b to 0acbb6c Full report (20 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
|
yufengwangca
approved these changes
Jan 25, 2022
saurabhst
approved these changes
Jan 25, 2022
carol-apple
approved these changes
Jan 25, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…roject-chip#14256) This lets consumers size buffers based on the spec-defined max length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets consumers size buffers based on the spec-defined max length.
Problem
Hard to know what buffer size to use for reading string attributes.
Change overview
Add the spec-defined max length to the metadata we output.
Testing
Code inspection of cluster-objects.h