Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ameba] Use common API to print QR code URL #14234

Merged
merged 1 commit into from
Jan 25, 2022
Merged

[Ameba] Use common API to print QR code URL #14234

merged 1 commit into from
Jan 25, 2022

Conversation

pankore
Copy link
Contributor

@pankore pankore commented Jan 25, 2022

Problem

  • Use common Matter API to print QR code URL

Change overview

  • Modify chipinterface.cpp to use PrintOnboardingCodes to print QR code

Testing

  • Tested with commissioning and cluster control

@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #14234: Size comparison from f1808b7 to ec48f27

Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section f1808b7 ec48f27 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573714 0 0.0
.app_xip_area 479016 479016 0 0.0
.bss 77444 77444 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835484 835484 0 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835476 835476 0 0.0
BRD4161A+rpc (read only) 822864 822864 0 0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822856 822856 0 0.0
window-app BRD4161A (read only) 806324 806324 0 0.0
(read/write) 125624 125624 0 0.0
.bss 123768 123768 0 0.0
.data 1856 1856 0 0.0
.text 806316 806316 0 0.0
esp32 all-clusters-app c3devkit (read only) 919202 919202 0 0.0
(read/write) 1376810 1376810 0 0.0
.dram0.bss 67376 67376 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176064 176064 0 0.0
.flash.text 919202 919202 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967535 967535 0 0.0
(read/write) 443240 443240 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 205224 205224 0 0.0
.flash.text 962151 962151 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660864 660864 0 0.0
.bss 77224 77224 0 0.0
.data 1868 1868 0 0.0
.text 575972 575972 0 0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77488 77488 0 0.0
.data 1892 1892 0 0.0
.text 576616 576616 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8639540 8639540 0 0.0
(read/write) 390961 390961 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260976 260976 0 0.0
.dynamic 560 560 0 0.0
.got 69056 69056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 532716 532716 0 0.0
.text 7267860 7267860 0 0.0
thermostat-no-ble arm64 (read only) 2050492 2050492 0 0.0
(read/write) 145969 145969 0 0.0
.bss 64897 64897 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73160 73160 0 0.0
.dynamic 560 560 0 0.0
.got 4056 4056 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 129948 129948 0 0.0
.text 1706144 1706144 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348784 2348784 0 0.0
.bss 186084 186084 0 0.0
.data 5296 5296 0 0.0
.text 1311360 1311360 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333984 2333984 0 0.0
.bss 180688 180688 0 0.0
.data 5576 5576 0 0.0
.text 1296584 1296584 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304568 2304568 0 0.0
.bss 180592 180592 0 0.0
.data 5568 5568 0 0.0
.text 1267168 1267168 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
p6 all-clusters-app default (read/write) 2407448 2407448 0 0.0
.bss 114428 114428 0 0.0
.data 2584 2584 0 0.0
.text 1365712 1365712 0 0.0
light-app default (read/write) 2330256 2330256 0 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288520 1288520 0 0.0
lock-app default (read/write) 2299664 2299664 0 0.0
.bss 105024 105024 0 0.0
.data 2360 2360 0 0.0
.text 1257928 1257928 0 0.0
qpg lighting-app qpg6105+debug (read only) 567092 567092 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89416 89416 0 0.0
.data 1060 1060 0 0.0
.text 561772 561772 0 0.0
lock-app qpg6105+debug (read only) 515752 515752 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 992 992 0 0.0
.text 510432 510432 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841062 841062 0 0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588184 588184 0 0.0

@pankore
Copy link
Contributor Author

pankore commented Jan 25, 2022

/rebase

@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #14234: Size comparison from 1d5c367 to 4e96149

Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1d5c367 4e96149 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573714 0 0.0
.app_xip_area 479016 479016 0 0.0
.bss 77444 77444 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835484 835484 0 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835476 835476 0 0.0
BRD4161A+rpc (read only) 822864 822864 0 0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822856 822856 0 0.0
window-app BRD4161A (read only) 806324 806324 0 0.0
(read/write) 125624 125624 0 0.0
.bss 123768 123768 0 0.0
.data 1856 1856 0 0.0
.text 806316 806316 0 0.0
esp32 all-clusters-app c3devkit (read only) 919376 919376 0 0.0
(read/write) 1376938 1376938 0 0.0
.dram0.bss 67376 67376 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176192 176192 0 0.0
.flash.text 919376 919376 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967675 967675 0 0.0
(read/write) 443360 443360 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 205344 205344 0 0.0
.flash.text 962291 962291 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661144 661144 0 0.0
.bss 77224 77224 0 0.0
.data 1868 1868 0 0.0
.text 576252 576252 0 0.0
lock k32w061+release (read/write) 662076 662076 0 0.0
.bss 77488 77488 0 0.0
.data 1892 1892 0 0.0
.text 576896 576896 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8639540 8639540 0 0.0
(read/write) 390961 390961 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260976 260976 0 0.0
.dynamic 560 560 0 0.0
.got 69056 69056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 532716 532716 0 0.0
.text 7267860 7267860 0 0.0
thermostat-no-ble arm64 (read only) 2050492 2050492 0 0.0
(read/write) 145969 145969 0 0.0
.bss 64897 64897 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73160 73160 0 0.0
.dynamic 560 560 0 0.0
.got 4056 4056 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 129948 129948 0 0.0
.text 1706144 1706144 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349032 2349032 0 0.0
.bss 186084 186084 0 0.0
.data 5296 5296 0 0.0
.text 1311608 1311608 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334296 2334296 0 0.0
.bss 180688 180688 0 0.0
.data 5576 5576 0 0.0
.text 1296896 1296896 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304816 2304816 0 0.0
.bss 180592 180592 0 0.0
.data 5568 5568 0 0.0
.text 1267416 1267416 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942439 942439 0 0.0
bss 118776 118776 0 0.0
rodata 108828 108828 0 0.0
text 637252 637252 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 927955 927955 0 0.0
bss 115820 115820 0 0.0
rodata 101280 101280 0 0.0
text 632648 632648 0 0.0
nrf52840dongle_nrf52840 (read/write) 993115 993115 0 0.0
bss 121616 121616 0 0.0
rodata 113580 113580 0 0.0
text 669452 669452 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852298 852298 0 0.0
bss 115564 115564 0 0.0
rodata 102004 102004 0 0.0
text 554172 554172 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912943 912943 0 0.0
bss 118828 118828 0 0.0
rodata 103884 103884 0 0.0
text 612828 612828 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822982 822982 0 0.0
bss 115648 115648 0 0.0
rodata 97112 97112 0 0.0
text 529784 529784 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915619 915619 0 0.0
bss 118576 118576 0 0.0
rodata 104272 104272 0 0.0
text 615296 615296 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910787 910787 0 0.0
bss 118600 118600 0 0.0
rodata 103376 103376 0 0.0
text 611324 611324 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533644 533644 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451320 451320 0 0.0
p6 all-clusters-app default (read/write) 2407784 2407784 0 0.0
.bss 114428 114428 0 0.0
.data 2584 2584 0 0.0
.text 1366048 1366048 0 0.0
light-app default (read/write) 2330608 2330608 0 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288872 1288872 0 0.0
lock-app default (read/write) 2300016 2300016 0 0.0
.bss 105024 105024 0 0.0
.data 2360 2360 0 0.0
.text 1258280 1258280 0 0.0
qpg lighting-app qpg6105+debug (read only) 567364 567364 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89416 89416 0 0.0
.data 1060 1060 0 0.0
.text 562044 562044 0 0.0
lock-app qpg6105+debug (read only) 516024 516024 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 992 992 0 0.0
.text 510704 510704 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841362 841362 0 0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588360 588360 0 0.0

@andy31415
Copy link
Contributor

fast track: platform specific change, code cleanup.

@andy31415 andy31415 merged commit d9cc25f into project-chip:master Jan 25, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@pankore @selissia
[Ameba] use common API to print QR code URL (project-chip#14234)
9193fa1
@pankore pankore deleted the qr_code branch February 9, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pankore @andy31415 @Damian-Nordic